René's URL Explorer Experiment


Title: Stop an unused import from leaving two blank lines behind by abashev · Pull Request #43 · openjavaformat/open-java-format · GitHub

Open Graph Title: Stop an unused import from leaving two blank lines behind by abashev · Pull Request #43 · openjavaformat/open-java-format

X Title: Stop an unused import from leaving two blank lines behind by abashev · Pull Request #43 · openjavaformat/open-java-format

Description: Closes #37. Upstream reports: google/google-java-format#598, google/google-java-format#1436. From upstream, with the author kept google/google-java-format#1437 by arimu1 (open upstream), ported as one commit authored by them and adapted to this codebase: RemoveUnusedImports deletes adjacent unused imports as one range (putCoalescing); a deleted range that sits between blank lines, or at the start of the file, takes one of them along. Why The command line formats first and fixes imports afterwards. An unused import between two blank lines, such as the only import between the package line and the class, left both of them behind, and only a second run collapsed them. So --replace wrote files that --dry-run --set-exit-if-changed then reported as unformatted. The Gradle and Spotless entry point fixes imports before it formats, so it was not affected, and the two entry points disagreed about these files. Checked The four RemoveUnusedImportsTest cases from the upstream PR: three fail without the change; the fourth, a partial deletion that keeps its blank line, passes either way and guards against deleting too much. MainTest.unusedImportRemovalLeavesOneBlankLine runs the file from google/google-java-format#1436 through the command line and through formatSourceAndFixImports and expects the same result from both. It fails without the change. ./gradlew :open-java-format:test on JDK 21: 1422 tests, all green. JDK 21 sources, 15,747 files: 304 format differently, with 305 blank lines fewer in all and no other change. All 304 are files the old code changed again on a second run, and the new output is stable on every one of them.

Open Graph Description: Closes #37. Upstream reports: google/google-java-format#598, google/google-java-format#1436. From upstream, with the author kept google/google-java-format#1437 by arimu1 (open upstream), ported as ...

X Description: Closes #37. Upstream reports: google/google-java-format#598, google/google-java-format#1436. From upstream, with the author kept google/google-java-format#1437 by arimu1 (open upstream), ported as ...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/43

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b30d382d-b3d9-ca9a-69d5-677b98822bd1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA16:B6082:18590D:204FAD:6AFBB1EA
html-safe-nonce4959f83dc2c1311ae4931ec5f7c8dd9e46b59f7840239f5b74d02540412fc999
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTE2OkI2MDgyOjE4NTkwRDoyMDRGQUQ6NkFGQkIxRUEiLCJ2aXNpdG9yX2lkIjoiNTI5MjIxOTkxNjA3NjQyOTgwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac73413868053d05bea099f4bf7b52a84c8e2a287082aa19145b775de56a6955bf
hovercard-subject-tagpull_request:4610960453
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/43/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altCloses #37. Upstream reports: google/google-java-format#598, google/google-java-format#1436. From upstream, with the author kept google/google-java-format#1437 by arimu1 (open upstream), ported as ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/43/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F43%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F43%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/43/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/43/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/43/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
mainhttps://github.com/openjavaformat/open-java-format/tree/main
unused-import-blank-linehttps://github.com/openjavaformat/open-java-format/tree/unused-import-blank-line
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/43
Commits 1 https://github.com/openjavaformat/open-java-format/pull/43/commits
Checks 10 https://github.com/openjavaformat/open-java-format/pull/43/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/43/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/43/files
Stop an unused import from leaving two blank lines behind https://github.com/openjavaformat/open-java-format/pull/43/files#top
Show all changes 1 commit https://github.com/openjavaformat/open-java-format/pull/43/files
3632838 Stop an unused import from leaving two blank lines behind arimu1 Sep 23, 2026 https://github.com/openjavaformat/open-java-format/pull/43/commits/3632838042f990a085769ecae0f1a5ade49fbebd
Clear filters https://github.com/openjavaformat/open-java-format/pull/43/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/43/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/43/files
RemoveUnusedImports.java https://github.com/openjavaformat/open-java-format/pull/43/files#diff-5299716450ca7354169f28803b5295a125ab25fdfbd3257eba438d4ff4f91768
MainTest.java https://github.com/openjavaformat/open-java-format/pull/43/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
RemoveUnusedImportsTest.java https://github.com/openjavaformat/open-java-format/pull/43/files#diff-e560a53ebc61bb106744b2431ebabab2a17823a75d2611eafd5acfd54b25a035
open-java-format/src/main/java/com/palantir/javaformat/java/RemoveUnusedImports.javahttps://github.com/openjavaformat/open-java-format/pull/43/files#diff-5299716450ca7354169f28803b5295a125ab25fdfbd3257eba438d4ff4f91768
View file https://github.com/openjavaformat/open-java-format/blob/3632838042f990a085769ecae0f1a5ade49fbebd/open-java-format/src/main/java/com/palantir/javaformat/java/RemoveUnusedImports.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/43/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/43/files#diff-5299716450ca7354169f28803b5295a125ab25fdfbd3257eba438d4ff4f91768
https://github.com/openjavaformat/open-java-format/pull/43/files#diff-5299716450ca7354169f28803b5295a125ab25fdfbd3257eba438d4ff4f91768
https://github.com/openjavaformat/open-java-format/pull/43/files#diff-5299716450ca7354169f28803b5295a125ab25fdfbd3257eba438d4ff4f91768
open-java-format/src/test/java/com/palantir/javaformat/java/MainTest.javahttps://github.com/openjavaformat/open-java-format/pull/43/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
View file https://github.com/openjavaformat/open-java-format/blob/3632838042f990a085769ecae0f1a5ade49fbebd/open-java-format/src/test/java/com/palantir/javaformat/java/MainTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/43/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/43/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
https://github.com/openjavaformat/open-java-format/pull/43/files#diff-378d7ba99b2237239522ae86ccba60a29d80eb6365d074a0b3fb460d6b3aab7b
open-java-format/src/test/java/com/palantir/javaformat/java/RemoveUnusedImportsTest.javahttps://github.com/openjavaformat/open-java-format/pull/43/files#diff-e560a53ebc61bb106744b2431ebabab2a17823a75d2611eafd5acfd54b25a035
View file https://github.com/openjavaformat/open-java-format/blob/3632838042f990a085769ecae0f1a5ade49fbebd/open-java-format/src/test/java/com/palantir/javaformat/java/RemoveUnusedImportsTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/43/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/43/files#diff-e560a53ebc61bb106744b2431ebabab2a17823a75d2611eafd5acfd54b25a035
https://github.com/openjavaformat/open-java-format/pull/43/files#diff-e560a53ebc61bb106744b2431ebabab2a17823a75d2611eafd5acfd54b25a035
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/43/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.