René's URL Explorer Experiment


Title: Stop comments that share a line from doubling each other's indent by abashev · Pull Request #42 · openjavaformat/open-java-format · GitHub

Open Graph Title: Stop comments that share a line from doubling each other's indent by abashev · Pull Request #42 · openjavaformat/open-java-format

X Title: Stop comments that share a line from doubling each other's indent by abashev · Pull Request #42 · openjavaformat/open-java-format

Description: Closes #36. Upstream report: google/google-java-format#413. What changes Comment.computeBreaks set the column after a comment to the column it started at plus the length of its last line. For a comment that spans lines, JavaCommentsHelper.rewrite has already indented that last line to the start column, so the column was counted twice, and every further comment on the same line started twice as far right as the one before. Commented-out code with javadoc in it, where each *//** javadoc *//* puts several multi-line comments on one line, grew exponentially: comments on the line before after 16 4.3 MB 5.2 kB 26 OutOfMemoryError with a 2 GB heap 12.5 kB in 0.33 s After a comment that spans lines the column is now the length of its last line; after a one-line comment it is still the start column plus the comment. Checked The new golden ojf-issue-36-multiline-comments-on-one-line (the file from google/google-java-format#413) and FormatterTest.indentsCommentsThatShareALineLinearly fail without the change: the golden's format and its three idempotence checks, and the size test. All pass with it. ./gradlew :open-java-format:test on JDK 21: 1422 tests, all green. The 15,747 files of the JDK 21 sources format byte for byte as before.

Open Graph Description: Closes #36. Upstream report: google/google-java-format#413. What changes Comment.computeBreaks set the column after a comment to the column it started at plus the length of its last line. For a com...

X Description: Closes #36. Upstream report: google/google-java-format#413. What changes Comment.computeBreaks set the column after a comment to the column it started at plus the length of its last line. For a com...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/42

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c4aca7e7-0d44-adb0-cb72-3b3934d1f81e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8D8:343214:5E1083:7D2FBA:6AFBC76A
html-safe-noncef2d23b3c0d8c03f8f73ebb7da77eaabce084258861169d1935bfa26eef7dbea8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEQ4OjM0MzIxNDo1RTEwODM6N0QyRkJBOjZBRkJDNzZBIiwidmlzaXRvcl9pZCI6IjU0NTUxMTEwODE5Njc3MzI1ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace480e0258562a72aa88a9bce47b00575c43b69e19a794c14660c3ec21f3a5878
hovercard-subject-tagpull_request:4610912865
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/42/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altCloses #36. Upstream report: google/google-java-format#413. What changes Comment.computeBreaks set the column after a comment to the column it started at plus the length of its last line. For a com...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/42/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F42%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F42%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/42/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/42/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/42/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
mainhttps://github.com/openjavaformat/open-java-format/tree/main
multiline-comment-columnhttps://github.com/openjavaformat/open-java-format/tree/multiline-comment-column
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/42
Commits 1 https://github.com/openjavaformat/open-java-format/pull/42/commits
Checks 10 https://github.com/openjavaformat/open-java-format/pull/42/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/42/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/42/files
Stop comments that share a line from doubling each other's indent https://github.com/openjavaformat/open-java-format/pull/42/files#top
Show all changes 1 commit https://github.com/openjavaformat/open-java-format/pull/42/files
30b63ba Stop comments that share a line from doubling each other's indent abashev Sep 23, 2026 https://github.com/openjavaformat/open-java-format/pull/42/commits/30b63ba8b287bcb9a13f8e330156238ad51d9bab
Clear filters https://github.com/openjavaformat/open-java-format/pull/42/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/42/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/42/files
Comment.java https://github.com/openjavaformat/open-java-format/pull/42/files#diff-e5edd350ffddfcafc80bdd6ecdc1c4886762bbe5cbe46051ef998085326d4252
FormatterTest.java https://github.com/openjavaformat/open-java-format/pull/42/files#diff-f85983c1d6fc968e83e9d38af248a62d00ebe6502ee2e268ed00928ed0439180
ojf-issue-36-multiline-comments-on-one-line.input https://github.com/openjavaformat/open-java-format/pull/42/files#diff-5f1fc1e83802182d51b6c00b29456e375e2f88a89a4e7431e397fc9a56f7ecd9
ojf-issue-36-multiline-comments-on-one-line.output https://github.com/openjavaformat/open-java-format/pull/42/files#diff-7d85e588ee7ba96fb31352cf735459481e35489685e2649e4801e728e054c2c9
open-java-format/src/main/java/com/palantir/javaformat/doc/Comment.javahttps://github.com/openjavaformat/open-java-format/pull/42/files#diff-e5edd350ffddfcafc80bdd6ecdc1c4886762bbe5cbe46051ef998085326d4252
View file https://github.com/openjavaformat/open-java-format/blob/30b63ba8b287bcb9a13f8e330156238ad51d9bab/open-java-format/src/main/java/com/palantir/javaformat/doc/Comment.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/42/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/42/files#diff-e5edd350ffddfcafc80bdd6ecdc1c4886762bbe5cbe46051ef998085326d4252
https://github.com/openjavaformat/open-java-format/pull/42/files#diff-e5edd350ffddfcafc80bdd6ecdc1c4886762bbe5cbe46051ef998085326d4252
open-java-format/src/test/java/com/palantir/javaformat/java/FormatterTest.javahttps://github.com/openjavaformat/open-java-format/pull/42/files#diff-f85983c1d6fc968e83e9d38af248a62d00ebe6502ee2e268ed00928ed0439180
View file https://github.com/openjavaformat/open-java-format/blob/30b63ba8b287bcb9a13f8e330156238ad51d9bab/open-java-format/src/test/java/com/palantir/javaformat/java/FormatterTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/42/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/42/files#diff-f85983c1d6fc968e83e9d38af248a62d00ebe6502ee2e268ed00928ed0439180
...s/com/palantir/javaformat/java/testdata/ojf-issue-36-multiline-comments-on-one-line.inputhttps://github.com/openjavaformat/open-java-format/pull/42/files#diff-5f1fc1e83802182d51b6c00b29456e375e2f88a89a4e7431e397fc9a56f7ecd9
View file https://github.com/openjavaformat/open-java-format/blob/30b63ba8b287bcb9a13f8e330156238ad51d9bab/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/ojf-issue-36-multiline-comments-on-one-line.input
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/42/{{ revealButtonHref }}
.../com/palantir/javaformat/java/testdata/ojf-issue-36-multiline-comments-on-one-line.outputhttps://github.com/openjavaformat/open-java-format/pull/42/files#diff-7d85e588ee7ba96fb31352cf735459481e35489685e2649e4801e728e054c2c9
View file https://github.com/openjavaformat/open-java-format/blob/30b63ba8b287bcb9a13f8e330156238ad51d9bab/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/ojf-issue-36-multiline-comments-on-one-line.output
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/42/{{ revealButtonHref }}
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/42/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.