René's URL Explorer Experiment


Title: Make Main easier to read by abashev · Pull Request #226 · openjavaformat/open-java-format · GitHub

Open Graph Title: Make Main easier to read by abashev · Pull Request #226 · openjavaformat/open-java-format

X Title: Make Main easier to read by abashev · Pull Request #226 · openjavaformat/open-java-format

Description: Readability changes to Main, and two changes that come with them, each in a commit of its own so that either can be dropped. Easier to read. Blank lines between the steps of format() and processArgs(), var for the entry of the result loop and the cause of a failed format, a static import of ofNullable, a pattern-matching instanceof for the FormatterException, and Files.writeString, which writes the same bytes as getBytes(UTF_8). The continue after a failed write goes: it was the last statement of the loop body (Error Prone's RedundantControlFlow). A file that is not UTF-8 is refused, not rewritten. Files.readString replaces new String(Files.readAllBytes(path), UTF_8), which turned each byte that is not UTF-8 into U+FFFD. Main.format and Main.processArgs become package-private. Only Main.main and the tests of the package call them. What changes for users --replace on a file saved as Latin-1, with é in a comment: 21.0.2 writes the file back with EF BF BD in place of the é and exits with 0. Now Main prints : could not read file: Input length = 3, leaves the file as it is and exits with 2. Standard input still decodes with replacement. Code outside the package that runs the command line through new Main(out, err, in).format(args) no longer compiles. Nothing in this repository, the Maven plugin or the GitHub Action does. Tests On JDK 21, :open-java-format:check passes on each of the three commits, with no new warning in Main; 1,422 tests.

Open Graph Description: Readability changes to Main, and two changes that come with them, each in a commit of its own so that either can be dropped. Easier to read. Blank lines between the steps of format() and processAr...

X Description: Readability changes to Main, and two changes that come with them, each in a commit of its own so that either can be dropped. Easier to read. Blank lines between the steps of format() and processAr...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/226

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3ab71158-77f6-a748-baab-09468ac3b122
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD43E:1D8DF0:62112E:81F4B7:6AFBC783
html-safe-nonce7b2f5c96810fcf2f3597cbe42c7de07190c73a657fef4ac120e745114ce0efa8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDNFOjFEOERGMDo2MjExMkU6ODFGNEI3OjZBRkJDNzgzIiwidmlzaXRvcl9pZCI6Ijc4OTkxODYxODMzNzkwNzY5OTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac098ed7f67815b5c709ce4edd51c8ffa627263cc28dd150ad17c2d5c60504c7dd
hovercard-subject-tagpull_request:5303227260
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/226/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altReadability changes to Main, and two changes that come with them, each in a commit of its own so that either can be dropped. Easier to read. Blank lines between the steps of format() and processAr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/226/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F226%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F226%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/226/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/226/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/226/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
21.X.Xhttps://github.com/openjavaformat/open-java-format/tree/21.X.X
abashev/Make-Main-easier-to-readhttps://github.com/openjavaformat/open-java-format/tree/abashev/Make-Main-easier-to-read
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/226
Commits 3 https://github.com/openjavaformat/open-java-format/pull/226/commits
Checks 33 https://github.com/openjavaformat/open-java-format/pull/226/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/226/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/226/files
Make Main easier to read https://github.com/openjavaformat/open-java-format/pull/226/files#top
Show all changes 3 commits https://github.com/openjavaformat/open-java-format/pull/226/files
dbd0dd7 Make Main easier to read abashev Nov 13, 2026 https://github.com/openjavaformat/open-java-format/pull/226/commits/dbd0dd7e2a21360f1f777756a82714c1ef9bea14
9620991 Refuse a Java file that is not UTF-8 instead of rewriting it abashev Nov 13, 2026 https://github.com/openjavaformat/open-java-format/pull/226/commits/9620991707a169331f48f2725392baff8d9bbe6c
5f28292 Make Main.format and processArgs package-private abashev Nov 13, 2026 https://github.com/openjavaformat/open-java-format/pull/226/commits/5f28292cd3c77b769942897ea3dfbc56b129d0f6
Clear filters https://github.com/openjavaformat/open-java-format/pull/226/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/226/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/226/files
open-java-format/src/main/java/com/palantir/javaformat/java/Main.javahttps://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
View file https://github.com/openjavaformat/open-java-format/blob/5f28292cd3c77b769942897ea3dfbc56b129d0f6/open-java-format/src/main/java/com/palantir/javaformat/java/Main.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/226/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
https://github.com/openjavaformat/open-java-format/pull/226/files#diff-9a9cdce660126c0f16b8d22c0d7c141dd11d0eedc8123b458171cc090d9e70b5
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/226/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.