René's URL Explorer Experiment


Title: Send the IDE plugin's errors to the JetBrains Marketplace by abashev · Pull Request #199 · openjavaformat/open-java-format · GitHub

Open Graph Title: Send the IDE plugin's errors to the JetBrains Marketplace by abashev · Pull Request #199 · openjavaformat/open-java-format

X Title: Send the IDE plugin's errors to the JetBrains Marketplace by abashev · Pull Request #199 · openjavaformat/open-java-format

Description: Before this PR When the IDE plugin failed, nobody could tell us. The IDE puts an error down to a plugin when its stack trace runs through the plugin's classes, and offers Report only for a plugin that names an error handler. This one named none, so the IDE Internal Errors dialog showed the plugin's errors with Report switched off. The error that mattered most did not reach that dialog at all: the formatter failing to run, its process not starting or exiting with an error, was logged as a warning. After this PR ==COMMIT_MSG== The IDE plugin sends its errors to the Exceptions tab of its page on the JetBrains Marketplace, with the OS, the IDE's and the plugin's versions and the full stack trace. A release IDE sends them only when the user lets it send error reports automatically, and no longer shows them to the user; EAP builds show them with Report. ==COMMIT_MSG== plugin.xml registers com.intellij.diagnostic.JetBrainsMarketplaceErrorReportSubmitter as the plugin's errorHandler, as the Marketplace docs describe. The class has been in the platform since 2023.3, so 2024.2, the oldest IDE the plugin supports, has it. What a release IDE does with it, read from the bytecode of IC-242.26775.15 and IU-263.7307.200. A release IDE sets idea.fatal.error.notification=disabled. With that setting, the error indicator shows a plugin's error only when the plugin's submitter is not an ITNReporter, or when the reporter's showErrorInRelease returns true. JetBrainsMarketplaceErrorReportSubmitter extends ITNReporter and does not override showErrorInRelease, which returns false. A report from a release IDE is sent automatically, without a dialog. The automatic sending (ExceptionAutoReportUtil) checks for this exact class, so a subclass that showed the errors would not get it, and IC-242 has no automatic sending at all. Logging: the formatter failing to run, the RuntimeException branch of PalantirJavaFormatFormattingService, is now logger.error, so it goes into a report. The user still gets the plugin's own notification, which points to idea.log. A FormatterException, a syntax error in the user's file, is now logger.warn, so it does not fill the reports. Neither formatter the plugin runs throws it today: both return no replacements on a syntax error. How it was checked ./gradlew :open-java-format-idea-plugin:test: 64 tests, all pass. ./gradlew :open-java-format-idea-plugin:verifyPlugin: compatible with IC-242 and IU-263. The deprecated and experimental TrustedProjects usages it reports were there before this PR. A throwaway test, not committed, ran in the plugin's test IDE (IC-242). It confirmed that IdeErrorsDialog.getSubmitter(throwable, PluginId.getId("open-java-format")) returns JetBrainsMarketplaceErrorReportSubmitter with this plugin's descriptor, that its action is "Report to the Third-Party Plugin", and that showErrorInRelease is false. Possible downsides? In a release IDE users no longer see the red indicator for this plugin's errors, which they saw before, Report switched off. When the formatter fails to run, they still get the plugin's notification. Reports arrive only from users who let the IDE send error reports automatically, and from EAP builds; none arrive from release 2024.2. A user cannot attach a comment or a way to reach them, since the dialog does not open in a release IDE. A formatter that fails on every Reformat, such as a build classpath the formatter cannot run, now logs an error each time. The Marketplace groups them as one issue.

Open Graph Description: Before this PR When the IDE plugin failed, nobody could tell us. The IDE puts an error down to a plugin when its stack trace runs through the plugin's classes, and offers Report only for a plug...

X Description: Before this PR When the IDE plugin failed, nobody could tell us. The IDE puts an error down to a plugin when its stack trace runs through the plugin's classes, and offers Report only for a ...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/199

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f0733510-679f-df2f-944e-167f8edded46
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9956:1D8DF0:61B7A0:818001:6AFBC76A
html-safe-nonce063d781b110df1ef375451535417857a0b580190588dbc56310ce473f4c94ae1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTU2OjFEOERGMDo2MUI3QTA6ODE4MDAxOjZBRkJDNzZBIiwidmlzaXRvcl9pZCI6IjU3OTgzNTQxMDA3ODEwNDE1MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccb2ea7b2693334562491276d70e81384c8d4766d6be66f77e8b62545620fdd42
hovercard-subject-tagpull_request:5210788377
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/199/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altBefore this PR When the IDE plugin failed, nobody could tell us. The IDE puts an error down to a plugin when its stack trace runs through the plugin's classes, and offers Report only for a plug...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/199/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F199%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F199%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/199/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/199/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/199/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
21.X.Xhttps://github.com/openjavaformat/open-java-format/tree/21.X.X
abashev/Report-for-exceptionshttps://github.com/openjavaformat/open-java-format/tree/abashev/Report-for-exceptions
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/199
Commits 1 https://github.com/openjavaformat/open-java-format/pull/199/commits
Checks 17 https://github.com/openjavaformat/open-java-format/pull/199/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/199/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/199/files
Send the IDE plugin's errors to the JetBrains Marketplace https://github.com/openjavaformat/open-java-format/pull/199/files#top
Show all changes 1 commit https://github.com/openjavaformat/open-java-format/pull/199/files
0e8164c Send the IDE plugin's errors to the JetBrains Marketplace abashev Nov 8, 2026 https://github.com/openjavaformat/open-java-format/pull/199/commits/0e8164cfcf68978a01a5d8e7b8c1b8aff908a093
Clear filters https://github.com/openjavaformat/open-java-format/pull/199/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/199/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/199/files
PalantirJavaFormatFormattingService.java https://github.com/openjavaformat/open-java-format/pull/199/files#diff-9ccbca341d7f8c4b0f667baecc747dec39da2ca2bf4d281f5a984cd6f49e7e63
plugin.xml https://github.com/openjavaformat/open-java-format/pull/199/files#diff-79bed27e49047a8da3113cb2811d3abd7abae06ef7070143cb8efd4d74479743
...n/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.javahttps://github.com/openjavaformat/open-java-format/pull/199/files#diff-9ccbca341d7f8c4b0f667baecc747dec39da2ca2bf4d281f5a984cd6f49e7e63
View file https://github.com/openjavaformat/open-java-format/blob/0e8164cfcf68978a01a5d8e7b8c1b8aff908a093/open-java-format-idea-plugin/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/199/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/199/files#diff-9ccbca341d7f8c4b0f667baecc747dec39da2ca2bf4d281f5a984cd6f49e7e63
https://github.com/openjavaformat/open-java-format/pull/199/files#diff-9ccbca341d7f8c4b0f667baecc747dec39da2ca2bf4d281f5a984cd6f49e7e63
https://github.com/openjavaformat/open-java-format/pull/199/files#diff-9ccbca341d7f8c4b0f667baecc747dec39da2ca2bf4d281f5a984cd6f49e7e63
open-java-format-idea-plugin/src/main/resources/META-INF/plugin.xmlhttps://github.com/openjavaformat/open-java-format/pull/199/files#diff-79bed27e49047a8da3113cb2811d3abd7abae06ef7070143cb8efd4d74479743
View file https://github.com/openjavaformat/open-java-format/blob/0e8164cfcf68978a01a5d8e7b8c1b8aff908a093/open-java-format-idea-plugin/src/main/resources/META-INF/plugin.xml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/199/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/199/files#diff-79bed27e49047a8da3113cb2811d3abd7abae06ef7070143cb8efd4d74479743
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/199/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.