René's URL Explorer Experiment


Title: Format MOE strip markers in javadoc like any other HTML comment by abashev · Pull Request #155 · openjavaformat/open-java-format · GitHub

Open Graph Title: Format MOE strip markers in javadoc like any other HTML comment by abashev · Pull Request #155 · openjavaformat/open-java-format

X Title: Format MOE strip markers in javadoc like any other HTML comment by abashev · Pull Request #155 · openjavaformat/open-java-format

Description: google/MOE, the tool whose and markers the javadoc formatter recognised, has been dead for years; #150 drops the line-comment rule for // MOE:. This removes the javadoc side: the two token types, the lexer patterns, the formatter cases and the writer state that queued a begin marker until the next token and remembered its indent for the end marker. Both markers now take the ordinary HTML comment path: a line of their own, at the indent of the text around them. Once #150 is in as well, no MOE reference is left in src/main. What changes for a javadoc that still carries the markers: A blank line that the tag after a begin marker asks for comes after the marker, not before it. A marker inside or between footer tags is a continuation line of the tag it follows, so it is indented four columns; the old code wrote the begin marker at the indent of the next token and gave the end marker that same indent. A begin marker that closes the comment without an end marker is kept; the old code queued it and never flushed it, so /** Foo. */ came out as /** Foo. */. Before, for the footer tags of the test: * @param user the person to teleport. * * Users must sign go/deatomize-waiver ahead of time. * * * @deprecated Sometimes turns the user into a goat. * After: * @param user the person to teleport. * * Users must sign go/deatomize-waiver ahead of time. * * * @deprecated Sometimes turns the user into a goat. * Tests Written first: moeStripMarkersAreOrdinaryHtmlComments failed before the change, with the old layout as its actual output. The three cases that only guarded the begin/end pairing against exploding (moeCommentBeginOnlyInMiddleOfDoc, moeCommentBeginOnlyAtEndOfDoc, moeCommentEndOnly) are gone. Verification ./gradlew test over all modules is green; ./gradlew formatDiff changes nothing; a full recompile gives the same 119 javac warnings before and after. JDK 21 corpus, 15,747 files, formatted with javadoc formatting on: no file differs between 21.X.X and this branch, and the JDK carries no MOE marker. The CLI never enables javadoc formatting (JavaFormatterOptions defaults it off and Main has no flag for it), so the usual -i run cannot see a javadoc change; the comparison ran through Formatter with formatJavadoc(true) plus the CLI's import and reflow passes.

Open Graph Description: google/MOE, the tool whose <!-- MOE:begin_intracomment_strip --> and <!-- MOE:end_intracomment_strip --> markers the javadoc formatter recognised, has been dead for years; #150 drops th...

X Description: google/MOE, the tool whose &lt;!-- MOE:begin_intracomment_strip --&gt; and &lt;!-- MOE:end_intracomment_strip --&gt; markers the javadoc formatter recognised, has been dead for year...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/155

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cdc561ea-59b5-1b7f-b6fc-659f2ed5bece
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id869A:2668B6:6BE980:933E22:6AFBC69A
html-safe-nonce1838ffef747a274130fc85a109927ed0222a58117333ca423ca47a1de0ac9eea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjlBOjI2NjhCNjo2QkU5ODA6OTMzRTIyOjZBRkJDNjlBIiwidmlzaXRvcl9pZCI6IjI2OTg0MjUyMTgyNTM5NjQ5NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac858a02b91303c70c788281591668e78d52b176c5b14320b2ba9a6014a176a4b5
hovercard-subject-tagpull_request:5006028587
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/155/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altgoogle/MOE, the tool whose <!-- MOE:begin_intracomment_strip --> and <!-- MOE:end_intracomment_strip --> markers the javadoc formatter recognised, has been dead for years; #150 drops th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/155/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F155%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F155%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/155/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/155/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/155/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
21.X.Xhttps://github.com/openjavaformat/open-java-format/tree/21.X.X
remove-moe-javadoc-markershttps://github.com/openjavaformat/open-java-format/tree/remove-moe-javadoc-markers
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/155
Commits 1 https://github.com/openjavaformat/open-java-format/pull/155/commits
Checks 17 https://github.com/openjavaformat/open-java-format/pull/155/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/155/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/155/files
Format MOE strip markers in javadoc like any other HTML comment https://github.com/openjavaformat/open-java-format/pull/155/files#top
Show all changes 1 commit https://github.com/openjavaformat/open-java-format/pull/155/files
cd40a92 Format MOE strip markers in javadoc like any other HTML comment abashev Oct 25, 2026 https://github.com/openjavaformat/open-java-format/pull/155/commits/cd40a92a828a071b00838b94071e8a46359044d2
Clear filters https://github.com/openjavaformat/open-java-format/pull/155/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/155/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/155/files
JavadocFormatter.java https://github.com/openjavaformat/open-java-format/pull/155/files#diff-3fed08a12d2193e142ba3ffade9f7874fb27a933e7a1e040e33c95ad6102122b
JavadocLexer.java https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4c525c8e93024d87ee499da472179e93fffbacc0075473d0ae40b09d959d1c40
JavadocWriter.java https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
Token.java https://github.com/openjavaformat/open-java-format/pull/155/files#diff-78c5c0f693a71e3510d1b59522348bb41bfdcecd66dd47d753e64f10453e433f
JavadocFormattingTest.java https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4874ab5903495ab1f5c86d1252ac208a672e524d979f7a6f5337a773b49b54f6
open-java-format/src/main/java/com/palantir/javaformat/java/javadoc/JavadocFormatter.javahttps://github.com/openjavaformat/open-java-format/pull/155/files#diff-3fed08a12d2193e142ba3ffade9f7874fb27a933e7a1e040e33c95ad6102122b
View file https://github.com/openjavaformat/open-java-format/blob/cd40a92a828a071b00838b94071e8a46359044d2/open-java-format/src/main/java/com/palantir/javaformat/java/javadoc/JavadocFormatter.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/155/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-3fed08a12d2193e142ba3ffade9f7874fb27a933e7a1e040e33c95ad6102122b
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-3fed08a12d2193e142ba3ffade9f7874fb27a933e7a1e040e33c95ad6102122b
open-java-format/src/main/java/com/palantir/javaformat/java/javadoc/JavadocLexer.javahttps://github.com/openjavaformat/open-java-format/pull/155/files#diff-4c525c8e93024d87ee499da472179e93fffbacc0075473d0ae40b09d959d1c40
View file https://github.com/openjavaformat/open-java-format/blob/cd40a92a828a071b00838b94071e8a46359044d2/open-java-format/src/main/java/com/palantir/javaformat/java/javadoc/JavadocLexer.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/155/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4c525c8e93024d87ee499da472179e93fffbacc0075473d0ae40b09d959d1c40
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4c525c8e93024d87ee499da472179e93fffbacc0075473d0ae40b09d959d1c40
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4c525c8e93024d87ee499da472179e93fffbacc0075473d0ae40b09d959d1c40
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4c525c8e93024d87ee499da472179e93fffbacc0075473d0ae40b09d959d1c40
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4c525c8e93024d87ee499da472179e93fffbacc0075473d0ae40b09d959d1c40
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4c525c8e93024d87ee499da472179e93fffbacc0075473d0ae40b09d959d1c40
open-java-format/src/main/java/com/palantir/javaformat/java/javadoc/JavadocWriter.javahttps://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
View file https://github.com/openjavaformat/open-java-format/blob/cd40a92a828a071b00838b94071e8a46359044d2/open-java-format/src/main/java/com/palantir/javaformat/java/javadoc/JavadocWriter.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/155/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-de4a419665098250349ae1bf84b759c76ddafdc46bb5bc7b23f2e89fafcebab1
open-java-format/src/main/java/com/palantir/javaformat/java/javadoc/Token.javahttps://github.com/openjavaformat/open-java-format/pull/155/files#diff-78c5c0f693a71e3510d1b59522348bb41bfdcecd66dd47d753e64f10453e433f
View file https://github.com/openjavaformat/open-java-format/blob/cd40a92a828a071b00838b94071e8a46359044d2/open-java-format/src/main/java/com/palantir/javaformat/java/javadoc/Token.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/155/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-78c5c0f693a71e3510d1b59522348bb41bfdcecd66dd47d753e64f10453e433f
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-78c5c0f693a71e3510d1b59522348bb41bfdcecd66dd47d753e64f10453e433f
open-java-format/src/test/java/com/palantir/javaformat/java/JavadocFormattingTest.javahttps://github.com/openjavaformat/open-java-format/pull/155/files#diff-4874ab5903495ab1f5c86d1252ac208a672e524d979f7a6f5337a773b49b54f6
View file https://github.com/openjavaformat/open-java-format/blob/cd40a92a828a071b00838b94071e8a46359044d2/open-java-format/src/test/java/com/palantir/javaformat/java/JavadocFormattingTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/155/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4874ab5903495ab1f5c86d1252ac208a672e524d979f7a6f5337a773b49b54f6
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4874ab5903495ab1f5c86d1252ac208a672e524d979f7a6f5337a773b49b54f6
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4874ab5903495ab1f5c86d1252ac208a672e524d979f7a6f5337a773b49b54f6
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4874ab5903495ab1f5c86d1252ac208a672e524d979f7a6f5337a773b49b54f6
https://github.com/openjavaformat/open-java-format/pull/155/files#diff-4874ab5903495ab1f5c86d1252ac208a672e524d979f7a6f5337a773b49b54f6
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/155/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.