René's URL Explorer Experiment


Title: Indent a block comment that trails `{` like the statements after it by abashev · Pull Request #143 · openjavaformat/open-java-format · GitHub

Open Graph Title: Indent a block comment that trails `{` like the statements after it by abashev · Pull Request #143 · openjavaformat/open-java-format

X Title: Indent a block comment that trails `{` like the statements after it by abashev · Pull Request #143 · openjavaformat/open-java-format

Description: Port of google/google-java-format#1464 (Tanvir Alam, still open upstream; author kept on the commit). Fixes #129, upstream's google/google-java-format#1260. A /* ... */ comment left on the line of an opening brace is moved onto its own line and landed one indent deeper than the statements of the block, or the elements of the array initializer, after it. A second run moved it back, so a check-style gate failed on files the formatter had just written. A lambda body such as () -> { /* c */ f(); } and a block after default: had the same defect, and all three styles reproduced it. visitBlock and the non-empty branch of visitArrayInitializer open a plusTwo level and then asked for another plusTwo on the break before the comment. OpsBuilder.build puts that comment right after the token, inside the level, so the two indents stacked. The break now gets ZERO there. An empty block keeps plusTwo, as upstream does: it closes the level right after {, and build moves the comment past that close, so without the indent the comment would sit at the column of the braces. The same mechanism is why the other tokenBreakTrailingComment("{", plusTwo) sites the issue lists (class, enum, interface, record, switch and module bodies) are fine: they emit the comment before opening their level, and a probe confirmed they were already stable. Done test-first: the I1260 fixture (upstream's input plus a lambda body) and trailingCommentAfterOpenBraceIsIdempotent in GOOGLE style failed on the first pass before the change. The I1260EmptyBlocks fixture pins the empty-block shapes (plain, try, catch, finally, if, while, case, array, method body) that the change leaves as they were. Full ./gradlew test passes, checkstyle and formatDiff are clean. Every style is affected, so the CLI and the plugins change output: a comment trailing { now ends up where a second run used to put it.

Open Graph Description: Port of google/google-java-format#1464 (Tanvir Alam, still open upstream; author kept on the commit). Fixes #129, upstream's google/google-java-format#1260. A /* ... */ comment left on the line...

X Description: Port of google/google-java-format#1464 (Tanvir Alam, still open upstream; author kept on the commit). Fixes #129, upstream's google/google-java-format#1260. A /* ... */ comment left on the ...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/143

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d513491a-feae-3876-4ef1-391ca7775264
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC62C:1460E5:6C315:93F55:6AFBC780
html-safe-nonce1cc1d8c60410ef9fd6f86b3240c20111a44371b08edfc45aad3dc0dbc669717e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjJDOjE0NjBFNTo2QzMxNTo5M0Y1NTo2QUZCQzc4MCIsInZpc2l0b3JfaWQiOiIzNjEyNzM2MTQyNTM0NDk0MDgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac63766870ed9d313607a77b9482cb5f7d2fdfbd177fa00f1cc23838104fbbb7fe
hovercard-subject-tagpull_request:4942633224
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/143/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altPort of google/google-java-format#1464 (Tanvir Alam, still open upstream; author kept on the commit). Fixes #129, upstream's google/google-java-format#1260. A /* ... */ comment left on the line...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/143/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F143%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F143%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/143/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/143/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/143/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
21.X.Xhttps://github.com/openjavaformat/open-java-format/tree/21.X.X
fix/trailing-comment-after-open-bracehttps://github.com/openjavaformat/open-java-format/tree/fix/trailing-comment-after-open-brace
Conversation 0 https://github.com/openjavaformat/open-java-format/pull/143
Commits 1 https://github.com/openjavaformat/open-java-format/pull/143/commits
Checks 17 https://github.com/openjavaformat/open-java-format/pull/143/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/143/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/143/files
Indent a block comment that trails { like the statements after it https://github.com/openjavaformat/open-java-format/pull/143/files#top
Show all changes 1 commit https://github.com/openjavaformat/open-java-format/pull/143/files
7f98ec8 Indent a block comment that trails `{` like the statements after it tanvir-ux Oct 20, 2026 https://github.com/openjavaformat/open-java-format/pull/143/commits/7f98ec805d1fd7150c391ec605247b71edc5d922
Clear filters https://github.com/openjavaformat/open-java-format/pull/143/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/143/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/143/files
JavaInputAstVisitor.java https://github.com/openjavaformat/open-java-format/pull/143/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
FormatterTest.java https://github.com/openjavaformat/open-java-format/pull/143/files#diff-f85983c1d6fc968e83e9d38af248a62d00ebe6502ee2e268ed00928ed0439180
I1260.input https://github.com/openjavaformat/open-java-format/pull/143/files#diff-b53adaaafff94ee8e70bdef91bde144167c53e133e81c39d96ce654bfda0a605
I1260.output https://github.com/openjavaformat/open-java-format/pull/143/files#diff-726bcfe24d1dd72451a5cff3b0dd9c15b386407b44f048353fb427fcaf79cd1e
I1260EmptyBlocks.input https://github.com/openjavaformat/open-java-format/pull/143/files#diff-ee88b152b9711af3409eed465f0c4b7a2600147ee846413d3bd74116510210a2
I1260EmptyBlocks.output https://github.com/openjavaformat/open-java-format/pull/143/files#diff-e7c375ed457ab4463341c3da74422ae861bf0a8d8991ff06616ba76a1ff1884b
open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.javahttps://github.com/openjavaformat/open-java-format/pull/143/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
View file https://github.com/openjavaformat/open-java-format/blob/7f98ec805d1fd7150c391ec605247b71edc5d922/open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/143/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/143/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
https://github.com/openjavaformat/open-java-format/pull/143/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
https://github.com/openjavaformat/open-java-format/pull/143/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
https://github.com/openjavaformat/open-java-format/pull/143/files#diff-4c56c3f402a5387ffa98b467fa35d91986b454b87e4a1b47b11da48e30272fc3
open-java-format/src/test/java/com/palantir/javaformat/java/FormatterTest.javahttps://github.com/openjavaformat/open-java-format/pull/143/files#diff-f85983c1d6fc968e83e9d38af248a62d00ebe6502ee2e268ed00928ed0439180
View file https://github.com/openjavaformat/open-java-format/blob/7f98ec805d1fd7150c391ec605247b71edc5d922/open-java-format/src/test/java/com/palantir/javaformat/java/FormatterTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/143/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/143/files#diff-f85983c1d6fc968e83e9d38af248a62d00ebe6502ee2e268ed00928ed0439180
open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I1260.inputhttps://github.com/openjavaformat/open-java-format/pull/143/files#diff-b53adaaafff94ee8e70bdef91bde144167c53e133e81c39d96ce654bfda0a605
View file https://github.com/openjavaformat/open-java-format/blob/7f98ec805d1fd7150c391ec605247b71edc5d922/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I1260.input
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/143/{{ revealButtonHref }}
open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I1260.outputhttps://github.com/openjavaformat/open-java-format/pull/143/files#diff-726bcfe24d1dd72451a5cff3b0dd9c15b386407b44f048353fb427fcaf79cd1e
View file https://github.com/openjavaformat/open-java-format/blob/7f98ec805d1fd7150c391ec605247b71edc5d922/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I1260.output
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/143/{{ revealButtonHref }}
...va-format/src/test/resources/com/palantir/javaformat/java/testdata/I1260EmptyBlocks.inputhttps://github.com/openjavaformat/open-java-format/pull/143/files#diff-ee88b152b9711af3409eed465f0c4b7a2600147ee846413d3bd74116510210a2
View file https://github.com/openjavaformat/open-java-format/blob/7f98ec805d1fd7150c391ec605247b71edc5d922/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I1260EmptyBlocks.input
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/143/{{ revealButtonHref }}
...a-format/src/test/resources/com/palantir/javaformat/java/testdata/I1260EmptyBlocks.outputhttps://github.com/openjavaformat/open-java-format/pull/143/files#diff-e7c375ed457ab4463341c3da74422ae861bf0a8d8991ff06616ba76a1ff1884b
View file https://github.com/openjavaformat/open-java-format/blob/7f98ec805d1fd7150c391ec605247b71edc5d922/open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I1260EmptyBlocks.output
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/143/{{ revealButtonHref }}
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/143/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.