René's URL Explorer Experiment


Title: Cache the indentation strings of the output lines (google-java-format #1466) by abashev · Pull Request #105 · openjavaformat/open-java-format · GitHub

Open Graph Title: Cache the indentation strings of the output lines (google-java-format #1466) by abashev · Pull Request #105 · openjavaformat/open-java-format

X Title: Cache the indentation strings of the output lines (google-java-format #1466) by abashev · Pull Request #105 · openjavaformat/open-java-format

Description: Port of google/google-java-format#1466 (Liam Miller-Cushon, author kept). Every output line's indentation was a fresh " ".repeat(indent); JavaOutput.spaces(int) now hands out one String per width up to 100 spaces, built on first use. Wider widths are built as before, zero or less gives the empty string. Upstream's second half, Style.indentString delegating to the cache, has no counterpart here: the fork's Style knows no tabs, and JavaOutput.indent is the only caller. TDD JavaOutputTest was written first and did not compile: the same instance for the same width, the empty string at zero and below, and a width beyond the cache. What it buys Measured with a small harness (ThreadMXBean.getThreadAllocatedBytes on one thread, the 135 java.util files of JDK 21, six warm-up and six measured passes, three JVMs each): allocated per pass per output line time per pass main 1,980–1,981 MB 17,761–17,772 B 828–878 ms this branch 1,976–1,978 MB 17,728–17,746 B 821–843 ms About 30 bytes per output line, 0.2 % of what formatting allocates, and the time does not move. It is upstream alignment more than a measurable win; merging decides whether that is worth the twenty lines. Checks :open-java-format:test on JDK 21: 1600 tests, 0 failures. The JDK 21 sources (15,747 files), formatted with main's jar and this branch's jar, are identical.

Open Graph Description: Port of google/google-java-format#1466 (Liam Miller-Cushon, author kept). Every output line's indentation was a fresh " ".repeat(indent); JavaOutput.spaces(int) now hands out one Stri...

X Description: Port of google/google-java-format#1466 (Liam Miller-Cushon, author kept). Every output line's indentation was a fresh " ".repeat(indent); JavaOutput.spaces(int) now hands ...

Opengraph URL: https://github.com/openjavaformat/open-java-format/pull/105

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b82d3244-d3c4-b931-0974-a192ddc54831
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC364:197A56:6D545:95751:6AFBC77A
html-safe-nonce955efa1999b628367c655c14e4e0ad4e70cd830f254dea070f0677d6d6033e82
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzY0OjE5N0E1Njo2RDU0NTo5NTc1MTo2QUZCQzc3QSIsInZpc2l0b3JfaWQiOiI4NTg4Mzc0OTc4NDc0NjU4NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd45a53716521cbd3d6440b82829a7a3971b53ff25e5b22421042d034e2185cc9
hovercard-subject-tagpull_request:4728874709
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/openjavaformat/open-java-format/pull/105/files
twitter:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/214171?s=400&v=4
og:image:altPort of google/google-java-format#1466 (Liam Miller-Cushon, author kept). Every output line's indentation was a fresh " ".repeat(indent); JavaOutput.spaces(int) now hands out one Stri...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/pull/105/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F105%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fpull%2F105%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/pull/105/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/105/files
Reloadhttps://github.com/openjavaformat/open-java-format/pull/105/files
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenjavaformat%2Fopen-java-format%2Fissues%2Fnew%2Fchoose
abashevhttps://github.com/abashev
mainhttps://github.com/openjavaformat/open-java-format/tree/main
gjf-1466-cached-indent-spaceshttps://github.com/openjavaformat/open-java-format/tree/gjf-1466-cached-indent-spaces
Conversation 1 https://github.com/openjavaformat/open-java-format/pull/105
Commits 1 https://github.com/openjavaformat/open-java-format/pull/105/commits
Checks 16 https://github.com/openjavaformat/open-java-format/pull/105/checks
Files changed https://github.com/openjavaformat/open-java-format/pull/105/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/105/files
Cache the indentation strings of the output lines (google-java-format #1466) https://github.com/openjavaformat/open-java-format/pull/105/files#top
Show all changes 1 commit https://github.com/openjavaformat/open-java-format/pull/105/files
4a51f26 Cache the indentation strings of the output lines cushon Oct 3, 2026 https://github.com/openjavaformat/open-java-format/pull/105/commits/4a51f26be29c1e816f26e5fbcd1ada5e1d2433c8
Clear filters https://github.com/openjavaformat/open-java-format/pull/105/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/105/files
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/105/files
JavaOutput.java https://github.com/openjavaformat/open-java-format/pull/105/files#diff-d8844f38acd02a34d15f174901783e7f3577a4b3cb9b6694de7fe1e05374afb9
JavaOutputTest.java https://github.com/openjavaformat/open-java-format/pull/105/files#diff-77b39a800231c14b6046872cfeee7462eab60ce4a88dba1b5cf41708f91bc882
open-java-format/src/main/java/com/palantir/javaformat/java/JavaOutput.javahttps://github.com/openjavaformat/open-java-format/pull/105/files#diff-d8844f38acd02a34d15f174901783e7f3577a4b3cb9b6694de7fe1e05374afb9
View file https://github.com/openjavaformat/open-java-format/blob/4a51f26be29c1e816f26e5fbcd1ada5e1d2433c8/open-java-format/src/main/java/com/palantir/javaformat/java/JavaOutput.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/105/{{ revealButtonHref }}
https://github.com/openjavaformat/open-java-format/pull/105/files#diff-d8844f38acd02a34d15f174901783e7f3577a4b3cb9b6694de7fe1e05374afb9
https://github.com/openjavaformat/open-java-format/pull/105/files#diff-d8844f38acd02a34d15f174901783e7f3577a4b3cb9b6694de7fe1e05374afb9
https://github.com/openjavaformat/open-java-format/pull/105/files#diff-d8844f38acd02a34d15f174901783e7f3577a4b3cb9b6694de7fe1e05374afb9
https://github.com/openjavaformat/open-java-format/pull/105/files#diff-d8844f38acd02a34d15f174901783e7f3577a4b3cb9b6694de7fe1e05374afb9
open-java-format/src/test/java/com/palantir/javaformat/java/JavaOutputTest.javahttps://github.com/openjavaformat/open-java-format/pull/105/files#diff-77b39a800231c14b6046872cfeee7462eab60ce4a88dba1b5cf41708f91bc882
View file https://github.com/openjavaformat/open-java-format/blob/4a51f26be29c1e816f26e5fbcd1ada5e1d2433c8/open-java-format/src/test/java/com/palantir/javaformat/java/JavaOutputTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/openjavaformat/open-java-format/pull/105/{{ revealButtonHref }}
Please reload this pagehttps://github.com/openjavaformat/open-java-format/pull/105/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.