Title: A line comment before the `))` closing a lambda body is joined onto the code line and swallows the parentheses (upstream #1792) · Issue #62 · openjavaformat/open-java-format · GitHub
Open Graph Title: A line comment before the `))` closing a lambda body is joined onto the code line and swallows the parentheses (upstream #1792) · Issue #62 · openjavaformat/open-java-format
X Title: A line comment before the `))` closing a lambda body is joined onto the code line and swallows the parentheses (upstream #1792) · Issue #62 · openjavaformat/open-java-format
Description: What palantir/palantir-java-format#1792 (filed 2026-09-24, no answer yet) reports that // comments sitting right before the )) which close a lambda's parenthesized body and the call around it are joined onto the preceding code line, so t...
Open Graph Description: What palantir/palantir-java-format#1792 (filed 2026-09-24, no answer yet) reports that // comments sitting right before the )) which close a lambda's parenthesized body and the call around it are j...
X Description: What palantir/palantir-java-format#1792 (filed 2026-09-24, no answer yet) reports that // comments sitting right before the )) which close a lambda's parenthesized body and the call around it a...
Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/62
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"A line comment before the `))` closing a lambda body is joined onto the code line and swallows the parentheses (upstream #1792)","articleBody":"### What\n\n[palantir/palantir-java-format#1792](https://github.com/palantir/palantir-java-format/issues/1792) (filed 2026-09-24, no answer yet) reports that `//` comments sitting right before the `))` which close a lambda's parenthesized body and the call around it are joined onto the preceding code line, so the `))` ends up inside the comment. The reporter sees it on 2.50.0, 2.80.0 and 2.99.0 in both styles, and says google-java-format 1.36.1 keeps the comments on their own lines.\n\nIt reproduces here on `main` (86cdc74e, 2.98.0.3-8-g86cdc74) with the reporter's input:\n\n```java\nimport java.util.stream.IntStream;\n\nclass Repro {\n int find(Item[] items) {\n return IntStream.range(0, items.length)\n .filter(i -> (items[i].getName().equals(\"alpha\") || items[i].getName().equals(\"beta\")\n || items[i].getName().equals(\"gamma\")\n // || (items[i].getName().equals(\"delta\") && items.length > i\n // && items[i + 1].getName().equals(\"epsilon\"))\n )).findFirst().orElse(-1);\n }\n}\n```\n\n`Formatter.formatSource` returns:\n\n```java\n .filter(i -> (items[i].getName().equals(\"alpha\")\n || items[i].getName().equals(\"beta\")\n || items[i].getName().equals(\"gamma\")// || (items[i].getName().equals(\"delta\") && items.length >\n // i// && items[i + 1].getName().equals(\"epsilon\"))))\n .findFirst()\n .orElse(-1);\n```\n\nThe first comment is glued to `(\"gamma\")`, the second to the first, the `))` that closed the body and the call are inside the comment, and the comment reflow then rewraps the joined line, which is where `// i//` comes from. The text does not parse. The CLI notices only because its import pass parses the result again: `open-java-format Repro.java` prints `Repro.java:11:29: error: ')' expected` (a position in the output, not the input), exits with 2 and writes nothing. A caller of `formatSource` gets the text as is. Upstream's output differs from ours only in that `.filter(` is broken before the lambda; the defect is the same.\n\n### Where it stops\n\nOne comment line is enough. What decides is the lambda's parenthesized body being broken at its `||` while `i -> (` stays on the line of the call; the dotted chain plays no part:\n\n| Input shape | Result |\n| --- | --- |\n| `check(i -> (a \\|\\| b` … `// c` … `))`, a plain call | joined, does not parse |\n| the same with a body short enough that `(a(i)` moves to the line after `i ->` | comment on its own line, parses |\n| `.filter(i -> a \\|\\| b` … `// c` … `)`, no parentheses around the body | comment on its own line, parses |\n| `check((a \\|\\| b` … `// c` … `))`, parentheses but no lambda | comment on its own line, parses |\n| `check(a \\|\\| b` … `// c` … `)` and `return (a \\|\\| b` … `// c` … `);` | comment on its own line, parses |\n\nNone of the 15,747 files of the JDK 21 sources has a `//` line directly before `))`. Five have one before a single `)` (`SunGraphics2D`, `LSSerializerImpl`, `WalkerFactory`, `XMLGregorianCalendarImpl` and `foreign/snippet-files/Snippets`), and all five format today.\n\n### Why\n\nNot looked into yet. A `//` comment ends its line by construction, so the break after the comment is lost when the lambda body's level is written out. google-java-format lays the same input out correctly, which points at the lambda's own layout rather than at the comment handling both share. The reporter names palantir/palantir-java-format#1152 (a trailing comment wrapped to the next line, indented wrongly) as possibly related; that one stays valid Java.\n\n### Done when\n\n- the input above formats with each comment on its own line and `))` after them, as google-java-format does, and a golden covers it together with the plain-call shape;\n- a second run changes nothing;\n- the five JDK files with a comment before a single `)` format as they do today, and a corpus run shows no other change: only files that fail today should move.\n","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-09-24T12:09:08Z","url":"https://github.com/openjavaformat/open-java-format/issues/62"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5d4a5800-5c63-af54-8885-9404cd071835 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 82AE:14CDE1:59EA05:78227E:6AFBC738 |
| html-safe-nonce | 42adb5edbf4071addebaab190eb536d4acc655d911eb87446a73ffa77d75ff10 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkFFOjE0Q0RFMTo1OUVBMDU6NzgyMjdFOjZBRkJDNzM4IiwidmlzaXRvcl9pZCI6IjgyNjUzNDYxOTQyMDExMDIxMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7aaef201b49b8aa966a6b79a8d3b5d57e74f349c889316343bf3828998966e4e |
| hovercard-subject-tag | issue:5568064538 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/62/issue_layout |
| twitter:image | https://opengraph.githubassets.com/88e73370b47eeec4b7d9abdbf2281e5008dcacf9cd6cead15fd7972640435bab/openjavaformat/open-java-format/issues/62 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/88e73370b47eeec4b7d9abdbf2281e5008dcacf9cd6cead15fd7972640435bab/openjavaformat/open-java-format/issues/62 |
| og:image:alt | What palantir/palantir-java-format#1792 (filed 2026-09-24, no answer yet) reports that // comments sitting right before the )) which close a lambda's parenthesized body and the call around it are j... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | abashev |
| hostname | github.com |
| expected-hostname | github.com |
| None | d440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b |
| turbo-cache-control | no-preview |
| go-import | github.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git |
| octolytics-dimension-user_id | 325177626 |
| octolytics-dimension-user_login | openjavaformat |
| octolytics-dimension-repository_id | 1288055459 |
| octolytics-dimension-repository_nwo | openjavaformat/open-java-format |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 214273098 |
| octolytics-dimension-repository_parent_nwo | palantir/palantir-java-format |
| octolytics-dimension-repository_network_root_id | 214273098 |
| octolytics-dimension-repository_network_root_nwo | palantir/palantir-java-format |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2c43021aed8695990c86c0eaaedc600bfeffec36 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width