René's URL Explorer Experiment


Title: Removing an unused import leaves two blank lines, and only a second run removes one · Issue #37 · openjavaformat/open-java-format · GitHub

Open Graph Title: Removing an unused import leaves two blank lines, and only a second run removes one · Issue #37 · openjavaformat/open-java-format

X Title: Removing an unused import leaves two blank lines, and only a second run removes one · Issue #37 · openjavaformat/open-java-format

Description: What Reported upstream as google/google-java-format#598 (2021) and again as google/google-java-format#1436 (2026-08). It reproduces here on main. With the only import unused: package com.example; import static io.grpc.MethodDescriptor.ge...

Open Graph Description: What Reported upstream as google/google-java-format#598 (2021) and again as google/google-java-format#1436 (2026-08). It reproduces here on main. With the only import unused: package com.example; i...

X Description: What Reported upstream as google/google-java-format#598 (2021) and again as google/google-java-format#1436 (2026-08). It reproduces here on main. With the only import unused: package com.example; i...

Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/37

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Removing an unused import leaves two blank lines, and only a second run removes one","articleBody":"### What\n\nReported upstream as [google/google-java-format#598](https://github.com/google/google-java-format/issues/598) (2021) and again as [google/google-java-format#1436](https://github.com/google/google-java-format/issues/1436) (2026-08). It reproduces here on `main`. With the only import unused:\n\n``` java\npackage com.example;\n\nimport static io.grpc.MethodDescriptor.generateFullMethodName;\n\n/**\n * Javadoc for class.\n */\npublic class TestBug {\n}\n```\n\n`open-java-format TestBug.java` prints two blank lines after the package line, and a run on that output removes one. So `--replace` writes a file that `--dry-run --set-exit-if-changed` then reports as unformatted, and our GitHub Action fails on a file the formatter has just written.\n\nThe Gradle and Spotless step prints one blank line for the same file, so the two entry points also disagree about it.\n\n### Why it happens\n\nThe command line formats first and fixes imports afterwards (`FormatFileCallable.formatFile`); the library entry point that Gradle uses, `Formatter.formatSourceAndFixImports`, fixes imports first and then formats. `RemoveUnusedImports` deletes an import with its line break but leaves the blank lines around it, so an import that sat between two blank lines leaves both behind. On the library path the formatting that follows collapses them; on the command line nothing runs after it.\n\n### Fix\n\nPort [google/google-java-format#1437](https://github.com/google/google-java-format/pull/1437) by arimu1 (open): `RemoveUnusedImports` merges adjacent deleted imports into one range and, when that range sits between blank lines or at the start of the file, deletes one of the blank lines too. That fixes the command line without changing the order of its steps, which `--lines` and `--offset` depend on.\n\n### Done when\n\n- one command-line run on the file above, and on the one from google/google-java-format#598, gives what a second run gives;\n- `RemoveUnusedImportsTest` covers a deleted import between blank lines, a deleted import at the start of the file, and a partial deletion that keeps its blank line;\n- the commit keeps the upstream author and names the upstream PR.\n","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-09-23T07:15:28Z","url":"https://github.com/openjavaformat/open-java-format/issues/37"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4d287476-3787-6607-976b-b20b58f794a2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA162:1D8DF0:F2EBC:1451D8:6AFBAEE1
html-safe-nonce85eb342786df4a7e8de1c0009952951891cc26f193d28b68a715cfb28dc3c087
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTYyOjFEOERGMDpGMkVCQzoxNDUxRDg6NkFGQkFFRTEiLCJ2aXNpdG9yX2lkIjoiNjUwMDI0MjgwMTY2NDE3NTg0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac89d7b1f65f1030b38f7992eed2a7989e5f338ee1c4e4a8621349ab7c793618bf
hovercard-subject-tagissue:5550086019
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/37/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f5e680a34e19702f50c32d3ca9abd62ba90904d4ee50fb95867a7e2345beebf8/openjavaformat/open-java-format/issues/37
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f5e680a34e19702f50c32d3ca9abd62ba90904d4ee50fb95867a7e2345beebf8/openjavaformat/open-java-format/issues/37
og:image:altWhat Reported upstream as google/google-java-format#598 (2021) and again as google/google-java-format#1436 (2026-08). It reproduces here on main. With the only import unused: package com.example; i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabashev
hostnamegithub.com
expected-hostnamegithub.com
Nonee25fbd830d3e6ad0e8935c105cf4fdc70c593dffcd27bb45b790ae4fece5ea55
turbo-cache-controlno-preview
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release08c8f17f9d27054a108b8b6254e405de0151f660
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/issues/37#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F37
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F37
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/issues/37
Reloadhttps://github.com/openjavaformat/open-java-format/issues/37
Reloadhttps://github.com/openjavaformat/open-java-format/issues/37
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
https://github.com/openjavaformat/open-java-format
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/37
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/37
#43https://github.com/openjavaformat/open-java-format/pull/43
Removing an unused import leaves two blank lines, and only a second run removes onehttps://github.com/openjavaformat/open-java-format/issues/37#top
#43https://github.com/openjavaformat/open-java-format/pull/43
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/abashev
abashevhttps://github.com/abashev
on Sep 23, 2026https://github.com/openjavaformat/open-java-format/issues/37#issue-5550086019
google/google-java-format#598https://github.com/google/google-java-format/issues/598
google/google-java-format#1436https://github.com/google/google-java-format/issues/1436
google/google-java-format#1437https://github.com/google/google-java-format/pull/1437
Removing unused imports leaves extra blank line after package statement, isn't idempotent google/google-java-format#598https://github.com/google/google-java-format/issues/598
abashevhttps://github.com/abashev
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
on Sep 23, 2026https://github.com/openjavaformat/open-java-format/issues/37#event-31657286865
abashevhttps://github.com/abashev
completedhttps://github.com/openjavaformat/open-java-format/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#43https://github.com/openjavaformat/open-java-format/pull/43
on Sep 23, 2026https://github.com/openjavaformat/open-java-format/issues/37#event-31661005602
abashevhttps://github.com/abashev
on Oct 30, 2026https://github.com/openjavaformat/open-java-format/issues/37#event-34711634199
Move the tests of unused import removal into case fileshttps://github.com/openjavaformat/open-java-format/commit/e66ee55fd7ea0fa67ce20a2711c2ad830e059f71
e66ee55https://github.com/openjavaformat/open-java-format/commit/e66ee55fd7ea0fa67ce20a2711c2ad830e059f71
Sign up for freehttps://github.com/signup?return_to=https://github.com/openjavaformat/open-java-format/issues/37
Sign in to commenthttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/37
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.