Title: Multi-line comments on one line double the indent each time, up to an OutOfMemoryError · Issue #36 · openjavaformat/open-java-format · GitHub
Open Graph Title: Multi-line comments on one line double the indent each time, up to an OutOfMemoryError · Issue #36 · openjavaformat/open-java-format
X Title: Multi-line comments on one line double the indent each time, up to an OutOfMemoryError · Issue #36 · openjavaformat/open-java-format
Description: What Reported upstream as google/google-java-format#413 (open since 2019-11-05): a 6 kB file of commented-out code ran out of memory with a 12 GB heap, and its output would have been about 3 GB. It reproduces here on main (53ac7d8). The ...
Open Graph Description: What Reported upstream as google/google-java-format#413 (open since 2019-11-05): a 6 kB file of commented-out code ran out of memory with a 12 GB heap, and its output would have been about 3 GB. It...
X Description: What Reported upstream as google/google-java-format#413 (open since 2019-11-05): a 6 kB file of commented-out code ran out of memory with a 12 GB heap, and its output would have been about 3 GB. It...
Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/36
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Multi-line comments on one line double the indent each time, up to an OutOfMemoryError","articleBody":"### What\n\nReported upstream as [google/google-java-format#413](https://github.com/google/google-java-format/issues/413) (open since 2019-11-05): a 6 kB file of commented-out code ran out of memory with a 12 GB heap, and its output would have been about 3 GB. It reproduces here on `main` (53ac7d86). The shape is block comments that end and start on the same line, as in commented-out code that had javadoc in it:\n\n``` java\n/*\nclass X {\n\t*//** javadoc *//*\n\tpublic void foo(Bar bar) {}\n\n\t*//** javadoc *//*\n\tpublic void foo(Bar bar) {}\n\n\t*//** javadoc *//*\n\tpublic void foo(Bar bar) {}\n\n\t*//** javadoc *//*\n\tpublic void foo(Bar bar) {}\n}*/\n```\n\nThe continuation lines of these comments come out indented by 17, 50, 116 and 248 columns: each comment on the line starts twice as far right as the one before it. The file size grows the same way:\n\n| comments | input | output |\n| --- | --- | --- |\n| 6 | 317 B | 4.3 kB |\n| 10 | 517 B | 68 kB |\n| 16 | 817 B | 4.3 MB |\n\n### Why it happens\n\n`Comment.computeBreaks` moves the column past a comment by adding the length of the comment's last line:\n\n``` java\nint firstLineLength = text.length() - Iterators.getLast(Newlines.lineOffsetIterator(text));\nreturn state.withColumn(state.column() + firstLineLength)\n```\n\nFor a one-line comment that is right. For a multi-line one, `JavaCommentsHelper.rewrite` has just re-indented the continuation lines to start at `state.column()`, so the last line already contains the column, and it is counted twice. The next comment on that line is re-indented from the doubled column, and so on. Despite its name, `firstLineLength` holds the length of the last line.\n\ngoogle-java-format has the same code in `Doc.Tok.computeBreaks`.\n\n### Fix\n\nAfter a comment that spans lines, the column is the length of its last line; after a one-line comment it stays `column + length`.\n\nThe output changes only where something follows a multi-line comment on that comment's last line, so a corpus run should show next to nothing.\n\n### Done when\n\n- a golden of the file above indents each comment's continuation lines to the column where that comment starts, and a second run changes nothing;\n- a test formats twenty such comments into a small output (the old code writes about 70 MB);\n- a corpus run says how many files change.\n","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-09-23T07:15:26Z","url":"https://github.com/openjavaformat/open-java-format/issues/36"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:cf3ec393-e0a2-fe5e-9345-82213ee479a7 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8200:13BAA8:5CF971:7B82E9:6AFBC732 |
| html-safe-nonce | 58e37aa7e3a44fcd348933c2546e5c4e4a5fc8686c2e7ade7509d128a99cf037 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjAwOjEzQkFBODo1Q0Y5NzE6N0I4MkU5OjZBRkJDNzMyIiwidmlzaXRvcl9pZCI6IjM1NTk4MDYyMjgyOTg5NzUwMjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9e687b357801280d2ad924cfad917cf9b1d57b57e8d4d074cff54a4ea70d6e00 |
| hovercard-subject-tag | issue:5550085739 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/36/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9a90ffec389ae94979e693bd63a73c4aed4c305f0bdbdce890dbcf9a1a638641/openjavaformat/open-java-format/issues/36 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9a90ffec389ae94979e693bd63a73c4aed4c305f0bdbdce890dbcf9a1a638641/openjavaformat/open-java-format/issues/36 |
| og:image:alt | What Reported upstream as google/google-java-format#413 (open since 2019-11-05): a 6 kB file of commented-out code ran out of memory with a 12 GB heap, and its output would have been about 3 GB. It... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | abashev |
| hostname | github.com |
| expected-hostname | github.com |
| None | d440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b |
| turbo-cache-control | no-preview |
| go-import | github.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git |
| octolytics-dimension-user_id | 325177626 |
| octolytics-dimension-user_login | openjavaformat |
| octolytics-dimension-repository_id | 1288055459 |
| octolytics-dimension-repository_nwo | openjavaformat/open-java-format |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 214273098 |
| octolytics-dimension-repository_parent_nwo | palantir/palantir-java-format |
| octolytics-dimension-repository_network_root_id | 214273098 |
| octolytics-dimension-repository_network_root_nwo | palantir/palantir-java-format |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2c43021aed8695990c86c0eaaedc600bfeffec36 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width