Title: Bring over upstream PR #1784: run the string wrapping pass to a fixed point · Issue #34 · openjavaformat/open-java-format · GitHub
Open Graph Title: Bring over upstream PR #1784: run the string wrapping pass to a fixed point · Issue #34 · openjavaformat/open-java-format
X Title: Bring over upstream PR #1784: run the string wrapping pass to a fixed point · Issue #34 · openjavaformat/open-java-format
Description: What palantir/palantir-java-format#1784 by Zayan Khan makes the formatter idempotent for text blocks inside nested array initialisers. It fixes upstream #1343, is 4 files and +83 −0, and has been open since 2026-09-15 with the CLA unsign...
Open Graph Description: What palantir/palantir-java-format#1784 by Zayan Khan makes the formatter idempotent for text blocks inside nested array initialisers. It fixes upstream #1343, is 4 files and +83 −0, and has been o...
X Description: What palantir/palantir-java-format#1784 by Zayan Khan makes the formatter idempotent for text blocks inside nested array initialisers. It fixes upstream #1343, is 4 files and +83 −0, and has been o...
Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/34
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bring over upstream PR #1784: run the string wrapping pass to a fixed point","articleBody":"### What\n\n[palantir/palantir-java-format#1784](https://github.com/palantir/palantir-java-format/pull/1784) by Zayan Khan makes the formatter idempotent for text blocks inside nested array initialisers. It fixes upstream [#1343](https://github.com/palantir/palantir-java-format/issues/1343), is 4 files and +83 −0, and has been open since 2026-09-15 with the CLA unsigned — where #1707, #1786 and #1731 are.\n\nIt reproduces here on 2.98.0.2. Format this file twice:\n\n``` java\nclass T {\n String[][] x = {\n {\n \"\"\"\n // tmp fix\n @Deprecated\n class Test {}\n \"\"\"\n },\n {\n \"\"\"\n\n @Deprecated\n class Test {}\n \"\"\"\n }\n };\n}\n```\n\nThe second pass moves the second text block's content four columns left. So `open-java-format --replace` writes a file that `open-java-format --dry-run --set-exit-if-changed` then reports as unformatted: our own [GitHub Action](https://openjavaformat.dev/get-started/github-actions/) fails on output the formatter just produced.\n\n### Why it happens\n\n`StringWrapper` derives a text block's indentation from the layout around it, and the same pass moves that layout, so one round is not always a fixed point. `wrap` already knows this — it recomputes its replacements after reformatting, twice — it just stops at two rounds, and nested array initialisers need three. The upstream change extracts the body as `wrapOnce` and iterates while it keeps changing the source, bounded by `MAX_ROUNDS = 5`.\n\n### Why it fits the 2.x promise better than most\n\nOutput only changes for files that were never stable to begin with: for a file that is already a fixed point, one round is unchanged. Upstream says every existing golden regenerates identically, and the same held here when I tried it. That still needs to be shown on a corpus before it ships.\n\n### Tried here\n\nCherry-picked onto `main` to see what it takes; the branch was thrown away, nothing is pushed.\n\n- The cherry-pick applies with rename detection, as in #22: only the two new testdata files land as \"added in a renamed directory\".\n- `./gradlew test` passes on JDK 21, and the new golden `palantir-issue-1343-text-block-indent-stable` runs — 4 cases, all green.\n- The file above becomes idempotent with the change.\n\n### Done when\n\n- the change is on `main` with Zayan Khan as the author and the upstream PR named in the commit message;\n- a corpus run says how many files it moves, and each of them is a file the old code did not reach a fixed point on;\n- the new golden is in, and `FormatterIntegrationTest`'s idempotence cases cover it;\n- it ships in a release, with the version question of #22 answered.","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-09-22T17:27:33Z","url":"https://github.com/openjavaformat/open-java-format/issues/34"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:97e707c6-fb5f-2977-a599-e5c660298dfd |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D700:1B1794:2CA698:3AFE06:6AFBB791 |
| html-safe-nonce | 81a80d1f399d6ce260094658df3a0a8d03d326fcdf693abc8b18eec7d088807d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzAwOjFCMTc5NDoyQ0E2OTg6M0FGRTA2OjZBRkJCNzkxIiwidmlzaXRvcl9pZCI6IjQzNTg5MzY0NzYyNzY5OTU5ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b0370c7796f0229d1d04d47b2fafe134ebf73648b23cf10a928de81989e83d4f |
| hovercard-subject-tag | issue:5542946126 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/34/issue_layout |
| twitter:image | https://opengraph.githubassets.com/734de36fac645dff62f6feaead5c43c3c0edfd3d4bc87acaefb017de516b6fbb/openjavaformat/open-java-format/issues/34 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/734de36fac645dff62f6feaead5c43c3c0edfd3d4bc87acaefb017de516b6fbb/openjavaformat/open-java-format/issues/34 |
| og:image:alt | What palantir/palantir-java-format#1784 by Zayan Khan makes the formatter idempotent for text blocks inside nested array initialisers. It fixes upstream #1343, is 4 files and +83 −0, and has been o... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | abashev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c |
| turbo-cache-control | no-preview |
| go-import | github.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git |
| octolytics-dimension-user_id | 325177626 |
| octolytics-dimension-user_login | openjavaformat |
| octolytics-dimension-repository_id | 1288055459 |
| octolytics-dimension-repository_nwo | openjavaformat/open-java-format |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 214273098 |
| octolytics-dimension-repository_parent_nwo | palantir/palantir-java-format |
| octolytics-dimension-repository_network_root_id | 214273098 |
| octolytics-dimension-repository_network_root_nwo | palantir/palantir-java-format |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e4cce0e99cf61481a318ff12c2e8580153a6c7c6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width