René's URL Explorer Experiment


Title: Bring over upstream PR #1784: run the string wrapping pass to a fixed point · Issue #34 · openjavaformat/open-java-format · GitHub

Open Graph Title: Bring over upstream PR #1784: run the string wrapping pass to a fixed point · Issue #34 · openjavaformat/open-java-format

X Title: Bring over upstream PR #1784: run the string wrapping pass to a fixed point · Issue #34 · openjavaformat/open-java-format

Description: What palantir/palantir-java-format#1784 by Zayan Khan makes the formatter idempotent for text blocks inside nested array initialisers. It fixes upstream #1343, is 4 files and +83 −0, and has been open since 2026-09-15 with the CLA unsign...

Open Graph Description: What palantir/palantir-java-format#1784 by Zayan Khan makes the formatter idempotent for text blocks inside nested array initialisers. It fixes upstream #1343, is 4 files and +83 −0, and has been o...

X Description: What palantir/palantir-java-format#1784 by Zayan Khan makes the formatter idempotent for text blocks inside nested array initialisers. It fixes upstream #1343, is 4 files and +83 −0, and has been o...

Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/34

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bring over upstream PR #1784: run the string wrapping pass to a fixed point","articleBody":"### What\n\n[palantir/palantir-java-format#1784](https://github.com/palantir/palantir-java-format/pull/1784) by Zayan Khan makes the formatter idempotent for text blocks inside nested array initialisers. It fixes upstream [#1343](https://github.com/palantir/palantir-java-format/issues/1343), is 4 files and +83 −0, and has been open since 2026-09-15 with the CLA unsigned — where #1707, #1786 and #1731 are.\n\nIt reproduces here on 2.98.0.2. Format this file twice:\n\n``` java\nclass T {\n    String[][] x = {\n        {\n            \"\"\"\n            // tmp fix\n            @Deprecated\n            class Test {}\n            \"\"\"\n        },\n        {\n            \"\"\"\n\n            @Deprecated\n            class Test {}\n            \"\"\"\n        }\n    };\n}\n```\n\nThe second pass moves the second text block's content four columns left. So `open-java-format --replace` writes a file that `open-java-format --dry-run --set-exit-if-changed` then reports as unformatted: our own [GitHub Action](https://openjavaformat.dev/get-started/github-actions/) fails on output the formatter just produced.\n\n### Why it happens\n\n`StringWrapper` derives a text block's indentation from the layout around it, and the same pass moves that layout, so one round is not always a fixed point. `wrap` already knows this — it recomputes its replacements after reformatting, twice — it just stops at two rounds, and nested array initialisers need three. The upstream change extracts the body as `wrapOnce` and iterates while it keeps changing the source, bounded by `MAX_ROUNDS = 5`.\n\n### Why it fits the 2.x promise better than most\n\nOutput only changes for files that were never stable to begin with: for a file that is already a fixed point, one round is unchanged. Upstream says every existing golden regenerates identically, and the same held here when I tried it. That still needs to be shown on a corpus before it ships.\n\n### Tried here\n\nCherry-picked onto `main` to see what it takes; the branch was thrown away, nothing is pushed.\n\n- The cherry-pick applies with rename detection, as in #22: only the two new testdata files land as \"added in a renamed directory\".\n- `./gradlew test` passes on JDK 21, and the new golden `palantir-issue-1343-text-block-indent-stable` runs — 4 cases, all green.\n- The file above becomes idempotent with the change.\n\n### Done when\n\n- the change is on `main` with Zayan Khan as the author and the upstream PR named in the commit message;\n- a corpus run says how many files it moves, and each of them is a file the old code did not reach a fixed point on;\n- the new golden is in, and `FormatterIntegrationTest`'s idempotence cases cover it;\n- it ships in a release, with the version question of #22 answered.","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-09-22T17:27:33Z","url":"https://github.com/openjavaformat/open-java-format/issues/34"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:97e707c6-fb5f-2977-a599-e5c660298dfd
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD700:1B1794:2CA698:3AFE06:6AFBB791
html-safe-nonce81a80d1f399d6ce260094658df3a0a8d03d326fcdf693abc8b18eec7d088807d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzAwOjFCMTc5NDoyQ0E2OTg6M0FGRTA2OjZBRkJCNzkxIiwidmlzaXRvcl9pZCI6IjQzNTg5MzY0NzYyNzY5OTU5ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb0370c7796f0229d1d04d47b2fafe134ebf73648b23cf10a928de81989e83d4f
hovercard-subject-tagissue:5542946126
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/34/issue_layout
twitter:imagehttps://opengraph.githubassets.com/734de36fac645dff62f6feaead5c43c3c0edfd3d4bc87acaefb017de516b6fbb/openjavaformat/open-java-format/issues/34
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/734de36fac645dff62f6feaead5c43c3c0edfd3d4bc87acaefb017de516b6fbb/openjavaformat/open-java-format/issues/34
og:image:altWhat palantir/palantir-java-format#1784 by Zayan Khan makes the formatter idempotent for text blocks inside nested array initialisers. It fixes upstream #1343, is 4 files and +83 −0, and has been o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabashev
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/issues/34#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F34
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F34
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/issues/34
Reloadhttps://github.com/openjavaformat/open-java-format/issues/34
Reloadhttps://github.com/openjavaformat/open-java-format/issues/34
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
https://github.com/openjavaformat/open-java-format
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/34
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/34
#46https://github.com/openjavaformat/open-java-format/pull/46
Bring over upstream PR #1784: run the string wrapping pass to a fixed pointhttps://github.com/openjavaformat/open-java-format/issues/34#top
#46https://github.com/openjavaformat/open-java-format/pull/46
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/abashev
abashevhttps://github.com/abashev
on Sep 22, 2026https://github.com/openjavaformat/open-java-format/issues/34#issue-5542946126
palantir/palantir-java-format#1784https://github.com/palantir/palantir-java-format/pull/1784
#1343https://github.com/palantir/palantir-java-format/issues/1343
palantir#1707https://github.com/palantir/palantir-java-format/pull/1707
palantir#1786https://github.com/palantir/palantir-java-format/pull/1786
palantir#1731https://github.com/palantir/palantir-java-format/pull/1731
GitHub Actionhttps://openjavaformat.dev/get-started/github-actions/
Bring over upstream PRs #1707 (Java 25 syntax) and #1786 (JDK 27 end positions) #22https://github.com/openjavaformat/open-java-format/issues/22
Bring over upstream PRs #1707 (Java 25 syntax) and #1786 (JDK 27 end positions) #22https://github.com/openjavaformat/open-java-format/issues/22
abashevhttps://github.com/abashev
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
on Sep 22, 2026https://github.com/openjavaformat/open-java-format/issues/34#event-31618610144
https://github.com/abashev
abashevhttps://github.com/abashev
on Sep 22, 2026https://github.com/openjavaformat/open-java-format/issues/34#issuecomment-5780978935
abashevhttps://github.com/abashev
completedhttps://github.com/openjavaformat/open-java-format/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#46https://github.com/openjavaformat/open-java-format/pull/46
on Sep 23, 2026https://github.com/openjavaformat/open-java-format/issues/34#event-31661136711
Sign up for freehttps://github.com/signup?return_to=https://github.com/openjavaformat/open-java-format/issues/34
Sign in to commenthttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/34
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.