Title: One input, two outputs: getFormatReplacements does not reflow long strings · Issue #33 · openjavaformat/open-java-format · GitHub
Open Graph Title: One input, two outputs: getFormatReplacements does not reflow long strings · Issue #33 · openjavaformat/open-java-format
X Title: One input, two outputs: getFormatReplacements does not reflow long strings · Issue #33 · openjavaformat/open-java-format
Description: What Upstream palantir/palantir-java-format#1452 (open since 2025-10-24) reports that IntelliJ and Maven format the same file differently: the IDE wraps a long string, the build leaves it alone, so editing a file in the IDE pollutes the ...
Open Graph Description: What Upstream palantir/palantir-java-format#1452 (open since 2025-10-24) reports that IntelliJ and Maven format the same file differently: the IDE wraps a long string, the build leaves it alone, so...
X Description: What Upstream palantir/palantir-java-format#1452 (open since 2025-10-24) reports that IntelliJ and Maven format the same file differently: the IDE wraps a long string, the build leaves it alone, so...
Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/33
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"One input, two outputs: getFormatReplacements does not reflow long strings","articleBody":"### What\n\nUpstream [palantir/palantir-java-format#1452](https://github.com/palantir/palantir-java-format/issues/1452) (open since 2025-10-24) reports that IntelliJ and Maven format the same file differently: the IDE wraps a long string, the build leaves it alone, so editing a file in the IDE pollutes the commit and then fails the build's check. The reason is that the two go through different entry points of the library.\n\nWe have the same split, in a different place. Checked here on 2.98.0.2 with the reporter's file:\n\n``` java\nclass Test {\n public static void main(String[] args) {\n String example =\n \"blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah blah\";\n }\n}\n```\n\n| Path | What it calls | Wraps the long string |\n| --- | --- | --- |\n| CLI, the GitHub Action, the pre-commit hook | `Main`, reflow on unless `--skip-reflowing-long-strings` | yes |\n| Gradle, the Spotless step | `formatSourceReflowStringsAndFixImports` | yes |\n| IntelliJ plugin | the native binary or the bootstrapped CLI with `--output-replacements` | yes |\n| Eclipse plugin, and anything else on the SPI | `FormatterService.getFormatReplacements` | **no** |\n\nRunning both library entry points over that file gives two different files: `getFormatReplacements` keeps the 119-column line, `formatSourceAndFixImports` breaks it into a concatenation. `Formatter.formatSourceAndFixImports` ends with `StringWrapper.wrap`; `Formatter.getFormatReplacements` has no such step.\n\n### Why it matters here\n\nThe manifesto says one style and nothing to tune, which only holds if the same file gives the same bytes wherever it is formatted. Today a file formatted by the Eclipse plugin can fail the check the GitHub Action runs, and neither output is wrong by itself. The Maven plugin in #26 would have to pick a side as well, and whichever it picks, half the users disagree with it.\n\n### To decide first\n\n- **Make the SPI reflow**, so `getFormatReplacements` wraps the ranges it is asked to format, as the CLI does for `--character-ranges`. Every path then agrees. It changes what the SPI returns, so it is an output change for anything embedding the library — the same version question as #22 and #31.\n- **Or leave the library alone** and fix the Eclipse plugin, then say in the SPI javadoc which method reflows and which does not.\n- Whether reflowing is right for a *range* format at all: in the IDE, wrapping a string the user did not touch is exactly what upstream's reporter complains about.\n\n### Done when\n\n- a test formats one file through every entry point — CLI, the Spotless step, the SPI, the native binary — and asserts the results are identical;\n- the Eclipse plugin agrees with the CLI;\n- the SPI javadoc states what each method does to long strings;\n- whatever the Maven plugin (#26) is built on inherits that answer.","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-09-22T17:18:12Z","url":"https://github.com/openjavaformat/open-java-format/issues/33"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:586c9b4c-9b93-6dd7-c930-114d49c5ec1d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8A18:B6082:5BE3F2:7A6F40:6AFBC73E |
| html-safe-nonce | 42c4a15b0da5777b9b07d9f8c4ece0292e22a3d04d290af0c981dc0bcb7f5d62 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTE4OkI2MDgyOjVCRTNGMjo3QTZGNDA6NkFGQkM3M0UiLCJ2aXNpdG9yX2lkIjoiODk4NDAwMzcyNzMwODA4MDk1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4409d450e127d078ed008faa7f9982b35782087e601b32d4ba5dd2dd3e9ee087 |
| hovercard-subject-tag | issue:5542850926 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/33/issue_layout |
| twitter:image | https://opengraph.githubassets.com/81140bf605f7e5b0d7f678b1fec5f0aa0313a74c7d1a72a97e0f243482a89924/openjavaformat/open-java-format/issues/33 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/81140bf605f7e5b0d7f678b1fec5f0aa0313a74c7d1a72a97e0f243482a89924/openjavaformat/open-java-format/issues/33 |
| og:image:alt | What Upstream palantir/palantir-java-format#1452 (open since 2025-10-24) reports that IntelliJ and Maven format the same file differently: the IDE wraps a long string, the build leaves it alone, so... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | abashev |
| hostname | github.com |
| expected-hostname | github.com |
| None | d440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b |
| turbo-cache-control | no-preview |
| go-import | github.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git |
| octolytics-dimension-user_id | 325177626 |
| octolytics-dimension-user_login | openjavaformat |
| octolytics-dimension-repository_id | 1288055459 |
| octolytics-dimension-repository_nwo | openjavaformat/open-java-format |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 214273098 |
| octolytics-dimension-repository_parent_nwo | palantir/palantir-java-format |
| octolytics-dimension-repository_network_root_id | 214273098 |
| octolytics-dimension-repository_network_root_nwo | palantir/palantir-java-format |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2c43021aed8695990c86c0eaaedc600bfeffec36 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width