René's URL Explorer Experiment


Title: A long string containing \\t fails to format: spurious "unclosed string literal" · Issue #32 · openjavaformat/open-java-format · GitHub

Open Graph Title: A long string containing \\t fails to format: spurious "unclosed string literal" · Issue #32 · openjavaformat/open-java-format

X Title: A long string containing \\t fails to format: spurious "unclosed string literal" · Issue #32 · openjavaformat/open-java-format

Description: What Reported upstream as palantir/palantir-java-format#1680 (open since 2026-05-29, no comments). It reproduces here on 2.98.0.2. Minimal case: class C { void m(java.sql.Connection con) throws Exception { con.createStatement() .execute(...

Open Graph Description: What Reported upstream as palantir/palantir-java-format#1680 (open since 2026-05-29, no comments). It reproduces here on 2.98.0.2. Minimal case: class C { void m(java.sql.Connection con) throws Exc...

X Description: What Reported upstream as palantir/palantir-java-format#1680 (open since 2026-05-29, no comments). It reproduces here on 2.98.0.2. Minimal case: class C { void m(java.sql.Connection con) throws Exc...

Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/32

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"A long string containing \\\\t fails to format: spurious \"unclosed string literal\"","articleBody":"### What\n\nReported upstream as [palantir/palantir-java-format#1680](https://github.com/palantir/palantir-java-format/issues/1680) (open since 2026-05-29, no comments). It reproduces here on 2.98.0.2. Minimal case:\n\n``` java\nclass C {\n    void m(java.sql.Connection con) throws Exception {\n        con.createStatement()\n                .execute(\"ALTER DATABASE tempdb MODIFY FILE (NAME = 'tempdev', FILENAME = 'D:\\\\tempDb\\\\DATA\\\\tempdb.mdf')\");\n    }\n}\n```\n\n`open-java-format C.java` exits 2 with `C.java:5:26: error: unclosed string literal`, while `javac` compiles the same file. Replace the escaped backslashes with forward slashes and the file formats.\n\nIn the upstream report the errors point at methods further down the file, which makes the cause hard to see: the line and column come from the rewritten source the formatter parses to check itself, not from the file on disk.\n\n### Why it happens\n\n`StringWrapper.stringComponents` splits the literal's source text at whitespace and at escaped whitespace, and `hasEscapedWhitespaceAt`/`hasEscapedNewlineAt` look for `\\t`, `\\n` and `\\r` without asking whether that backslash is itself escaped. In `DATA\\\\tempDb` the second backslash and the `t` look like an escaped tab, so the split lands inside the escaped backslash. `StringWrapper.getReflowReplacements` on the file above returns:\n\n``` java\n\"ALTER DATABASE tempdb MODIFY FILE (NAME = 'tempdev', FILENAME = 'D:\\\\tempDb\\\\DATA\\\"\n        + \"\\tempdb.mdf')\"\n```\n\nThe first piece ends in a lone backslash, which escapes the closing quote — that is the error. The second piece starts with `\\t`, a tab, so even if it parsed the string would no longer be the one the author wrote.\n\n`\\n` and `\\r` are mis-read the same way, but that branch advances past the escape, so the split is merely in an odd place and the result still parses and still means the same: the same file with `D:\\\\nempDb` formats fine. Only `\\\\t` produces code that does not parse.\n\n### Fix\n\nWalk the literal left to right consuming escape sequences, so that `\\\\` takes two characters and the `t` after it is an ordinary letter.\n\nMind the output promise: files whose long strings contain `\\\\n` or `\\\\r` format today, and the fix moves where they are split, so their output changes. Measure that over a corpus and decide which release it belongs to, as in #22 and #31.\n\n### Done when\n\n- the file above formats, and formatting it twice is a no-op;\n- a golden covers a wrapped literal with `\\\\t`, `\\\\n`, `\\\\r`, `\\\\\\\\` and `\\u` escapes, and fails without the fix;\n- a test asserts the string's value is unchanged by wrapping, not only that the result parses;\n- a corpus run says how many files the `\\\\n`/`\\\\r` split moves.","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-09-22T17:17:54Z","url":"https://github.com/openjavaformat/open-java-format/issues/32"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9aca30bb-1cbf-750a-9526-d78f9cada3b8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB44E:32BC13:133C40:1A7E9F:6AFBBB59
html-safe-noncee03f05dd73b7ab87aa6e85b4f95a1d8bfd896e265920b7c8b7554f38cd0e166d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDRFOjMyQkMxMzoxMzNDNDA6MUE3RTlGOjZBRkJCQjU5IiwidmlzaXRvcl9pZCI6IjU2MTU1MTU2MjUwMDM0MDAwMjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace281cdd64eb8ac1f2d9989a3490b8a9033ca092858ddac1b3c07a20c8eb2bcd4
hovercard-subject-tagissue:5542847953
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/32/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3ae32e36e30ff16b4c1e7036140a076ae964107afe569716129a0b5f92573b0d/openjavaformat/open-java-format/issues/32
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3ae32e36e30ff16b4c1e7036140a076ae964107afe569716129a0b5f92573b0d/openjavaformat/open-java-format/issues/32
og:image:altWhat Reported upstream as palantir/palantir-java-format#1680 (open since 2026-05-29, no comments). It reproduces here on 2.98.0.2. Minimal case: class C { void m(java.sql.Connection con) throws Exc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabashev
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/issues/32#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F32
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F32
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/issues/32
Reloadhttps://github.com/openjavaformat/open-java-format/issues/32
Reloadhttps://github.com/openjavaformat/open-java-format/issues/32
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
https://github.com/openjavaformat/open-java-format
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/32
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/32
A long string containing \\t fails to format: spurious "unclosed string literal"https://github.com/openjavaformat/open-java-format/issues/32#top
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/abashev
abashevhttps://github.com/abashev
on Sep 22, 2026https://github.com/openjavaformat/open-java-format/issues/32#issue-5542847953
palantir/palantir-java-format#1680https://github.com/palantir/palantir-java-format/issues/1680
#22https://github.com/openjavaformat/open-java-format/issues/22
#31https://github.com/openjavaformat/open-java-format/issues/31
abashevhttps://github.com/abashev
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
on Sep 22, 2026https://github.com/openjavaformat/open-java-format/issues/32#event-31618047059
abashevhttps://github.com/abashev
on Sep 23, 2026https://github.com/openjavaformat/open-java-format/issues/32#event-31654810126
Stop splitting long strings inside an escaped backslashhttps://github.com/openjavaformat/open-java-format/commit/53ac7d8601ce28fb02e4c339e9a115b4e090dc15
53ac7d8https://github.com/openjavaformat/open-java-format/commit/53ac7d8601ce28fb02e4c339e9a115b4e090dc15
https://github.com/abashev
abashevhttps://github.com/abashev
on Sep 23, 2026https://github.com/openjavaformat/open-java-format/issues/32#issuecomment-5790117287
53ac7d8https://github.com/openjavaformat/open-java-format/commit/53ac7d8601ce28fb02e4c339e9a115b4e090dc15
abashevhttps://github.com/abashev
completedhttps://github.com/openjavaformat/open-java-format/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 23, 2026https://github.com/openjavaformat/open-java-format/issues/32#event-31654822129
abashevhttps://github.com/abashev
on Sep 25, 2026https://github.com/openjavaformat/open-java-format/issues/32#event-31861915212
List the class name and tab fixes on Migrate, with a link for each ch…https://github.com/openjavaformat/docs/commit/1627ba45b1bb2ab3ae5da95aa8aa6c1fc76a5834
1627ba4https://github.com/openjavaformat/docs/commit/1627ba45b1bb2ab3ae5da95aa8aa6c1fc76a5834
Sign up for freehttps://github.com/signup?return_to=https://github.com/openjavaformat/open-java-format/issues/32
Sign in to commenthttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/32
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.