René's URL Explorer Experiment


Title: Read, format and write each file on a worker thread, and keep only what the output needs · Issue #228 · openjavaformat/open-java-format · GitHub

Open Graph Title: Read, format and write each file on a worker thread, and keep only what the output needs · Issue #228 · openjavaformat/open-java-format

X Title: Read, format and write each file on a worker thread, and keep only what the output needs · Issue #228 · openjavaformat/open-java-format

Description: What happens Main.formatFiles reads every file on the main thread, as new String(Files.readAllBytes(path), UTF_8), keeps the text in a map and submits it to the pool. It then takes the results on the main thread, in the order the files w...

Open Graph Description: What happens Main.formatFiles reads every file on the main thread, as new String(Files.readAllBytes(path), UTF_8), keeps the text in a map and submits it to the pool. It then takes the results on t...

X Description: What happens Main.formatFiles reads every file on the main thread, as new String(Files.readAllBytes(path), UTF_8), keeps the text in a map and submits it to the pool. It then takes the results on t...

Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/228

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Read, format and write each file on a worker thread, and keep only what the output needs","articleBody":"### What happens\n\n`Main.formatFiles` reads every file on the main thread, as `new String(Files.readAllBytes(path), UTF_8)`, keeps the text in a map and submits it to the pool. It then takes the results on the main thread, in the order the files were given, and compares, writes or prints each one there. Every input and every output stays referenced until the loop is over, and a file that is done waits for all the files before it to be written or printed.\n\n### google-java-format\n\nThe same, and it waits longer. It reads on the main thread too, and an `ExecutorCompletionService` hands back the results as they finish, but all of them go into a list, which is sorted by path, and only then is anything written or printed.\n\n### Where the time goes now\n\n865 files from `java.base` of JDK 21, 16 MB of source, formatted with `--replace` on 10 cores with 21.0.2:\n\n| | Wall | CPU | Peak RSS |\n|---|---|---|---|\n| Native binary | 7.0 s | 15 s, about 2 cores busy | 2.4 GB |\n| `java -cp ... Main`, JDK 21 | 6.2 s | 44 s, about 7 cores busy | 4.3 GB |\n\nReading the 865 files on one thread takes 0.04 s, and their text with the formatted text comes to some tens of megabytes. Neither is what holds the run back. In the native run, `-XX:+PrintGC` shows 40 collections that paused it for 5.0 of its 6.9 s: 17 full ones for 3.05 s and 23 incremental ones for 1.94 s, with the heap at up to 1.9 GB before a collection. The image is built without `--gc`, so it has the serial collector, which stops every thread: 20 threads format on about 2 cores.\n\n### Proposal\n\n- **One task does all of one file and hands back an immutable result.** It reads the file on its worker thread, formats it, writes it for `--replace`, and returns the path, whether the file changed, the diagnostics or the exception, and the formatted text only where it is printed, to standard output without `--replace` or `--dry-run`.\n- **The main thread passes on paths and prints results.** It takes the results in the order the files were given for what it prints, the formatted text, the paths of `--dry-run` and the messages, so that the output keeps its order, and lets go of each result once it is printed. With `--replace` no file waits for an earlier one to be written.\n- **A bound on what is in flight**, a small multiple of the pool size, so that memory does not grow with the number of files.\n\n### To measure first\n\nFor the native binary the collector is the bigger lever: a larger young generation or another collector where GraalVM offers one for the platform, and fewer than 20 threads under a serial collector. Each change can be measured on the run above.\n","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-11-13T21:41:39Z","url":"https://github.com/openjavaformat/open-java-format/issues/228"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a91ad537-7356-d2ea-3529-793285eb9a10
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD764:20CEDF:2C4E79:3ABCAB:6AFBB794
html-safe-noncebeaa11d17a6e7f807f9af453f1ebda3410ee5312536a5a6852c7ad5c9209a8d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzY0OjIwQ0VERjoyQzRFNzk6M0FCQ0FCOjZBRkJCNzk0IiwidmlzaXRvcl9pZCI6IjQ4NDE1OTcyMDQ0MjAwODE1NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac44f911fa26ee5f7ca218d006bbc13af06d53982a14bc2ac5129cec9a16b65493
hovercard-subject-tagissue:6380471051
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/228/issue_layout
twitter:imagehttps://opengraph.githubassets.com/425a4f20e10e4e0d22b85a2ac7e05ae695b9399346a6d628224cffeb1df59051/openjavaformat/open-java-format/issues/228
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/425a4f20e10e4e0d22b85a2ac7e05ae695b9399346a6d628224cffeb1df59051/openjavaformat/open-java-format/issues/228
og:image:altWhat happens Main.formatFiles reads every file on the main thread, as new String(Files.readAllBytes(path), UTF_8), keeps the text in a map and submits it to the pool. It then takes the results on t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabashev
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/issues/228#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F228
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F228
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/issues/228
Reloadhttps://github.com/openjavaformat/open-java-format/issues/228
Reloadhttps://github.com/openjavaformat/open-java-format/issues/228
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
https://github.com/openjavaformat/open-java-format
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/228
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/228
Read, format and write each file on a worker thread, and keep only what the output needshttps://github.com/openjavaformat/open-java-format/issues/228#top
enhancementNew feature or requesthttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/abashev
abashevhttps://github.com/abashev
on Nov 13, 2026https://github.com/openjavaformat/open-java-format/issues/228#issue-6380471051
abashevhttps://github.com/abashev
enhancementNew feature or requesthttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Nov 13, 2026https://github.com/openjavaformat/open-java-format/issues/228#event-36076842989
Sign up for freehttps://github.com/signup?return_to=https://github.com/openjavaformat/open-java-format/issues/228
Sign in to commenthttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/228
enhancementNew feature or requesthttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.