René's URL Explorer Experiment


Title: Tests pin the formatter's pieces, not the routes users run · Issue #225 · openjavaformat/open-java-format · GitHub

Open Graph Title: Tests pin the formatter's pieces, not the routes users run · Issue #225 · openjavaformat/open-java-format

X Title: Tests pin the formatter's pieces, not the routes users run · Issue #225 · openjavaformat/open-java-format

Description: What happens The tests that pin what the formatter writes call pieces of it, not the routes users run, so two routes could drift apart without a test failing (#219). Tests What they call What users run FormatterCasesTest, 915 cases Forma...

Open Graph Description: What happens The tests that pin what the formatter writes call pieces of it, not the routes users run, so two routes could drift apart without a test failing (#219). Tests What they call What users...

X Description: What happens The tests that pin what the formatter writes call pieces of it, not the routes users run, so two routes could drift apart without a test failing (#219). Tests What they call What users...

Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/225

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Tests pin the formatter's pieces, not the routes users run","articleBody":"### What happens\n\nThe tests that pin what the formatter writes call pieces of it, not the routes users run, so two routes could drift apart without a test failing (#219).\n\n| Tests | What they call | What users run |\n|---|---|---|\n| `FormatterCasesTest`, 915 cases | `Formatter.formatSourceAndFixImports` | the Maven plugin and the Spotless step; the command line, the native binary and the GitHub Action go through `FormatFileCallable.formatFile`, a second implementation of the same steps |\n| `PartialFormattingTest`, 60 tests | `Main --lines` without `--output-replacements`, and `Formatter.getFormatReplacements` | IntelliJ IDEA and `formatDiff` use `--output-replacements` and `FormatterService.getFormatReplacements`; before #220 no test ran `--output-replacements` |\n| `FormatterIntegrationTest`, 2 pairs left | `formatSource` and then `StringWrapper.wrap`, put together in the test | no route |\n\nThe cases also never reach the places where the routes differ: all 915 give their expected output with the imports fixed before formatting and after it. The one test that did, `ModuleImportTest.keepsACommentBetweenThePartsOfTheModuleName`, pinned what `formatSourceAndFixImports` wrote, which the command line never printed.\n\nAnd the tests that need a newer JDK are skipped on JDK 21, where a local build runs: 14 skipped there against 2 on JDK 25. The first push of #220 passed locally and failed CI's JDK 25 to 28 builds on that `ModuleImportTest`.\n\n### Proposal\n\n1. **One implementation.** `FormatFileCallable.formatFile` calls the same method as `formatSourceAndFixImports`, with the flags of the command line, as google-java-format now does with one `Formatter.formatSource(input, ranges, removeUnusedImports, sortImports, reflowLongStrings)`. Then the 915 cases test the command line.\n2. **Cases for the seams.** Four cases are ready for `test-cases/imports`: `commentOfARemovedImportGoesWithTheImportAboveIt`, `commentOfARemovedOwnPackageImportGoesWithTheImportAboveIt`, `commentUnderARemovedImportStaysOnTheClass` and `semicolonAfterTheLastImportStaysOnALineOfItsOwn`. Each passes with #220 and fails with the imports fixed first. What a case file cannot say yet, a failure, a JDK it needs, a range, stays in `FormatterServiceImplTest` and `ModuleImportTest`.\n3. **Cases through the routes.** `FormatterCasesTest` runs each case through `Main`, through `FormatterServiceImpl`, and in CI's native jobs through the native binary.\n4. **Ranges on the cases.** For each case, the lines where the code before and after differ are formatted as a range, as `formatDiff` does, through `--output-replacements` and through the in-process service, and the two compared; and formatting any range of the expected output leaves it as it is.\n5. **A rule and a task.** CLAUDE.md says that a test which pins the output users get goes through `Main` or `FormatterService`, while `ImportOrderer`, `RemoveUnusedImports` and `StringWrapper` keep their unit tests. A mise task runs the tests as CI's JDK 25 and 27 builds do, with their TestKit Gradle versions.\n","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-11-13T20:36:27Z","url":"https://github.com/openjavaformat/open-java-format/issues/225"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c771dcee-6e73-5822-8d38-3e70da5ceef2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD7AA:13F309:2B1E33:3903A5:6AFBB798
html-safe-nonce49d217e1e4180d684a7f8f4dd51f9cfa68045b25620b2de13be3524e5d12425f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0FBOjEzRjMwOToyQjFFMzM6MzkwM0E1OjZBRkJCNzk4IiwidmlzaXRvcl9pZCI6Ijg4MjcxMjE4MzA1NDkyMzk3MDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacddc57c2f5a2dda920dcb34b7c9d2a7cdac344dc47e649c00db7e2e682b46914e
hovercard-subject-tagissue:6379516442
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/225/issue_layout
twitter:imagehttps://opengraph.githubassets.com/003618937ef49d331dcaefbb2bf5a0e9c3160dc814a7788c2df0a05d6904a09f/openjavaformat/open-java-format/issues/225
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/003618937ef49d331dcaefbb2bf5a0e9c3160dc814a7788c2df0a05d6904a09f/openjavaformat/open-java-format/issues/225
og:image:altWhat happens The tests that pin what the formatter writes call pieces of it, not the routes users run, so two routes could drift apart without a test failing (#219). Tests What they call What users...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabashev
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/issues/225#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F225
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F225
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/issues/225
Reloadhttps://github.com/openjavaformat/open-java-format/issues/225
Reloadhttps://github.com/openjavaformat/open-java-format/issues/225
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
https://github.com/openjavaformat/open-java-format
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/225
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/225
Tests pin the formatter's pieces, not the routes users runhttps://github.com/openjavaformat/open-java-format/issues/225#top
enhancementNew feature or requesthttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/abashev
abashevhttps://github.com/abashev
on Nov 13, 2026https://github.com/openjavaformat/open-java-format/issues/225#issue-6379516442
#219https://github.com/openjavaformat/open-java-format/issues/219
#220https://github.com/openjavaformat/open-java-format/pull/220
#220https://github.com/openjavaformat/open-java-format/pull/220
Format the same on every route: formatDiff on the JVM, ranges, and the order of fixing imports #220https://github.com/openjavaformat/open-java-format/pull/220
abashevhttps://github.com/abashev
enhancementNew feature or requesthttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Nov 13, 2026https://github.com/openjavaformat/open-java-format/issues/225#event-36071762244
Sign up for freehttps://github.com/signup?return_to=https://github.com/openjavaformat/open-java-format/issues/225
Sign in to commenthttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/225
enhancementNew feature or requesthttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.