Title: Cleanup pass: drop empty annotation parentheses · Issue #217 · openjavaformat/open-java-format · GitHub
Open Graph Title: Cleanup pass: drop empty annotation parentheses · Issue #217 · openjavaformat/open-java-format
X Title: Cleanup pass: drop empty annotation parentheses · Issue #217 · openjavaformat/open-java-format
Description: Upstream: google/google-java-format#1504 Kind: idea | Priority: low google-java-format#1504 (merged 2026-10-29, copybara export) extends the --cleanup AST pass introduced in google-java-format#1492 so that @Anno() becomes @Anno. Comments...
Open Graph Description: Upstream: google/google-java-format#1504 Kind: idea | Priority: low google-java-format#1504 (merged 2026-10-29, copybara export) extends the --cleanup AST pass introduced in google-java-format#1492...
X Description: Upstream: google/google-java-format#1504 Kind: idea | Priority: low google-java-format#1504 (merged 2026-10-29, copybara export) extends the --cleanup AST pass introduced in google-java-format#1492...
Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/217
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Cleanup pass: drop empty annotation parentheses","articleBody":"**Upstream:** https://github.com/google/google-java-format/pull/1504 \n**Kind:** idea | **Priority:** low\n\n[google-java-format#1504](https://github.com/google/google-java-format/pull/1504) (merged 2026-10-29, copybara export) extends the `--cleanup` AST pass introduced in [google-java-format#1492](https://github.com/google/google-java-format/pull/1492) so that `@Anno()` becomes `@Anno`. Comments inside the parentheses are kept, and a space is inserted when the annotation is directly followed by an identifier.\n\nWhy it matters: it is one more non-whitespace rewrite that users of google-java-format will get by default, and it belongs with our existing cleanup tickets (brace insertion, redundant semicolons, unified cleanup pipeline). We have no cleanup pass beyond `RemoveUnusedImports`, so this is only worth doing if we adopt that pass at all.\n\n**Before** (upstream behaviour before the change; I believe ours does not touch annotation parentheses but did not run it):\n```java\nclass T {\n `@Anno`() int x;\n `@Anno`()int y;\n}\n```\n**After** (with the change, from the upstream description):\n```java\nclass T {\n `@Anno` int x;\n `@Anno` int y;\n}\n```\n\nAffected files in our repo:\n- open-java-format/src/main/java/com/palantir/javaformat/java/RemoveUnusedImports.java (only existing non-whitespace pass)\n- open-java-format/src/main/java/com/palantir/javaformat/java/Formatter.java (where a pass would be wired in)\n\nSuggested action: watch. Decide together with the other cleanup tickets; if a cleanup pass is added, this is a cheap rule.\n\n---\n_Filed from an upstream-watch ticket after manual review._","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-11-12T12:01:57Z","url":"https://github.com/openjavaformat/open-java-format/issues/217"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f0d610f9-587a-e019-562b-77f7eb8b2bd4 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D77C:39575D:28A2FE:365275:6AFBB795 |
| html-safe-nonce | d3790b8e6a0960f3ac121f0875ea013f3b9837c16c9eb72738879aebb9a78908 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzdDOjM5NTc1RDoyOEEyRkU6MzY1Mjc1OjZBRkJCNzk1IiwidmlzaXRvcl9pZCI6Ijc3ODg3MjM3ODIwNTQyOTU0NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5a9dcf486a6a05d06a8f3f35854ffe69575c08f3b1ca2e478a0cbe6805d1dd4b |
| hovercard-subject-tag | issue:6349354536 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/217/issue_layout |
| twitter:image | https://opengraph.githubassets.com/7825944e5a8a53defb74d220befdff32f5b332d84e5c28b7209b870c5728fdb5/openjavaformat/open-java-format/issues/217 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7825944e5a8a53defb74d220befdff32f5b332d84e5c28b7209b870c5728fdb5/openjavaformat/open-java-format/issues/217 |
| og:image:alt | Upstream: google/google-java-format#1504 Kind: idea | Priority: low google-java-format#1504 (merged 2026-10-29, copybara export) extends the --cleanup AST pass introduced in google-java-format#1492... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | abashev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c |
| turbo-cache-control | no-preview |
| go-import | github.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git |
| octolytics-dimension-user_id | 325177626 |
| octolytics-dimension-user_login | openjavaformat |
| octolytics-dimension-repository_id | 1288055459 |
| octolytics-dimension-repository_nwo | openjavaformat/open-java-format |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 214273098 |
| octolytics-dimension-repository_parent_nwo | palantir/palantir-java-format |
| octolytics-dimension-repository_network_root_id | 214273098 |
| octolytics-dimension-repository_network_root_nwo | palantir/palantir-java-format |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e4cce0e99cf61481a318ff12c2e8580153a6c7c6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width