René's URL Explorer Experiment


Title: Partial formatting should reflow only long strings inside the requested ranges · Issue #177 · openjavaformat/open-java-format · GitHub

Open Graph Title: Partial formatting should reflow only long strings inside the requested ranges · Issue #177 · openjavaformat/open-java-format

X Title: Partial formatting should reflow only long strings inside the requested ranges · Issue #177 · openjavaformat/open-java-format

Description: Upstream: google/google-java-format#1514 Kind: bug | Priority: medium google-java-format#1514 (merged 2026-10-30, copybara export) fixes google-java-format#1114: with --lines, --offset/--length or the library range APIs, only the request...

Open Graph Description: Upstream: google/google-java-format#1514 Kind: bug | Priority: medium google-java-format#1514 (merged 2026-10-30, copybara export) fixes google-java-format#1114: with --lines, --offset/--length or ...

X Description: Upstream: google/google-java-format#1514 Kind: bug | Priority: medium google-java-format#1514 (merged 2026-10-30, copybara export) fixes google-java-format#1114: with --lines, --offset/--length or ...

Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/177

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Partial formatting should reflow only long strings inside the requested ranges","articleBody":"**Upstream:** https://github.com/google/google-java-format/pull/1514  \n**Kind:** bug | **Priority:** medium\n\n[google-java-format#1514](https://github.com/google/google-java-format/pull/1514) (merged 2026-10-30, copybara export) fixes [google-java-format#1114](https://github.com/google/google-java-format/issues/1114): with `--lines`, `--offset`/`--length` or the library range APIs, only the requested ranges were reformatted, yet every long string literal in the file was still reflowed. Tools that format only changed lines (the git-diff wrapper script, editor integrations) therefore produced unrelated edits elsewhere in the file. Upstream maps the requested ranges onto the formatted output and hands them to `StringWrapper`, which now reflows only literals that intersect them; the offset mapping was extracted from `Cleanups` into a shared `Edit` class.\n\nWhy it matters: our code has the same flaw. In `FormatFileCallable.formatFile` the CLI formats the requested ranges and then calls `StringWrapper.wrap` on the whole file, so a long string on a line outside the range is wrapped anyway. The replacements path (IDE plugins) is only half guarded: `StringWrapper.linesNeedWrapping` checks whether a long line overlaps the range, but once it does, `wrap` is run on the entire text and the result replaces the whole file, again touching strings outside the range. Running with `--lines` on a changed line is the normal workflow in IDEs and pre-commit hooks, so this produces noisy diffs.\n\n**Before** (how it is formatted today; derived from our code path, not run):\n```java\nclass Test {\n  void foo() {\n    int a = 1;\n    System.err.println(\"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\");\n  }\n}\n```\nFormatting only line 3 (`--lines 3:3`) also rewrites line 4:\n```java\n    System.err.println(\n        \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\");\n```\n**After** (with the change):\n```java\nclass Test {\n  void foo() {\n    int a = 1;\n    System.err.println(\"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\");\n  }\n}\n```\nLine 4 is left as it was because it is outside the requested range; formatting `--lines 4:4` would still wrap it.\n\nAffected files in our repo:\n- open-java-format/src/main/java/com/palantir/javaformat/java/StringWrapper.java (`wrap`, `wrapOnce`, `getReflowReplacements`, `linesNeedWrapping`)\n- open-java-format/src/main/java/com/palantir/javaformat/java/FormatFileCallable.java (`call`, `formatFile`)\n- open-java-format/src/main/java/com/palantir/javaformat/java/Formatter.java (`formatSourceAndFixImports`, which wraps the whole file)\n\nThe upstream diff will not apply cleanly: we have no `Cleanups` or `Edit` classes (see the existing ticket on the unified cleanups pipeline), and our `StringWrapper` works from a `TreeRangeMap` of replacements rather than upstream's structure. The idea ports directly, though: our `getReflowReplacements` already produces per-literal ranges, so they can be filtered by overlap with the formatted-output ranges before applying.\n\nSuggested action: port the idea. Add a range filter to `StringWrapper.wrap` and pass the mapped requested ranges from `FormatFileCallable`; keep whole-file behaviour when no range is given. Upstream's `StringWrapperTest` and `MainTest` cases from the PR are a good source of tests.\n\n---\n_Filed from an upstream-watch ticket after manual review._","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-10-31T11:34:52Z","url":"https://github.com/openjavaformat/open-java-format/issues/177"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6dacec10-99c4-be2c-937b-b323a64681eb
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8A52:33D4D9:87FCD:BA196:6AFBB796
html-safe-nonce059b183bdbff391de2515287dca1617228947f262c1d8a92ce57e9d4b45789fc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTUyOjMzRDREOTo4N0ZDRDpCQTE5Njo2QUZCQjc5NiIsInZpc2l0b3JfaWQiOiIyODYxMDIwNDA5MzU4OTU2NDM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac350fa3cf98c7394ea5d86276760c8b0176e77d8e1ffe8f4e97d7226e8d8a0566
hovercard-subject-tagissue:6134334551
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/177/issue_layout
twitter:imagehttps://opengraph.githubassets.com/6ae94b07694e72e88df083349d5d5913deebbca90b687a66283f91d146c9fa77/openjavaformat/open-java-format/issues/177
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6ae94b07694e72e88df083349d5d5913deebbca90b687a66283f91d146c9fa77/openjavaformat/open-java-format/issues/177
og:image:altUpstream: google/google-java-format#1514 Kind: bug | Priority: medium google-java-format#1514 (merged 2026-10-30, copybara export) fixes google-java-format#1114: with --lines, --offset/--length or ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabashev
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/issues/177#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F177
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F177
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/issues/177
Reloadhttps://github.com/openjavaformat/open-java-format/issues/177
Reloadhttps://github.com/openjavaformat/open-java-format/issues/177
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
https://github.com/openjavaformat/open-java-format
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/177
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/177
Partial formatting should reflow only long strings inside the requested rangeshttps://github.com/openjavaformat/open-java-format/issues/177#top
https://github.com/abashev
abashevhttps://github.com/abashev
on Oct 31, 2026https://github.com/openjavaformat/open-java-format/issues/177#issue-6134334551
google/google-java-format#1514https://github.com/google/google-java-format/pull/1514
google-java-format#1514https://github.com/google/google-java-format/pull/1514
google-java-format#1114https://github.com/google/google-java-format/issues/1114
Sign up for freehttps://github.com/signup?return_to=https://github.com/openjavaformat/open-java-format/issues/177
Sign in to commenthttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/177
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.