Title: Partial formatting should reflow only long strings inside the requested ranges · Issue #177 · openjavaformat/open-java-format · GitHub
Open Graph Title: Partial formatting should reflow only long strings inside the requested ranges · Issue #177 · openjavaformat/open-java-format
X Title: Partial formatting should reflow only long strings inside the requested ranges · Issue #177 · openjavaformat/open-java-format
Description: Upstream: google/google-java-format#1514 Kind: bug | Priority: medium google-java-format#1514 (merged 2026-10-30, copybara export) fixes google-java-format#1114: with --lines, --offset/--length or the library range APIs, only the request...
Open Graph Description: Upstream: google/google-java-format#1514 Kind: bug | Priority: medium google-java-format#1514 (merged 2026-10-30, copybara export) fixes google-java-format#1114: with --lines, --offset/--length or ...
X Description: Upstream: google/google-java-format#1514 Kind: bug | Priority: medium google-java-format#1514 (merged 2026-10-30, copybara export) fixes google-java-format#1114: with --lines, --offset/--length or ...
Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/177
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Partial formatting should reflow only long strings inside the requested ranges","articleBody":"**Upstream:** https://github.com/google/google-java-format/pull/1514 \n**Kind:** bug | **Priority:** medium\n\n[google-java-format#1514](https://github.com/google/google-java-format/pull/1514) (merged 2026-10-30, copybara export) fixes [google-java-format#1114](https://github.com/google/google-java-format/issues/1114): with `--lines`, `--offset`/`--length` or the library range APIs, only the requested ranges were reformatted, yet every long string literal in the file was still reflowed. Tools that format only changed lines (the git-diff wrapper script, editor integrations) therefore produced unrelated edits elsewhere in the file. Upstream maps the requested ranges onto the formatted output and hands them to `StringWrapper`, which now reflows only literals that intersect them; the offset mapping was extracted from `Cleanups` into a shared `Edit` class.\n\nWhy it matters: our code has the same flaw. In `FormatFileCallable.formatFile` the CLI formats the requested ranges and then calls `StringWrapper.wrap` on the whole file, so a long string on a line outside the range is wrapped anyway. The replacements path (IDE plugins) is only half guarded: `StringWrapper.linesNeedWrapping` checks whether a long line overlaps the range, but once it does, `wrap` is run on the entire text and the result replaces the whole file, again touching strings outside the range. Running with `--lines` on a changed line is the normal workflow in IDEs and pre-commit hooks, so this produces noisy diffs.\n\n**Before** (how it is formatted today; derived from our code path, not run):\n```java\nclass Test {\n void foo() {\n int a = 1;\n System.err.println(\"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\");\n }\n}\n```\nFormatting only line 3 (`--lines 3:3`) also rewrites line 4:\n```java\n System.err.println(\n \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\");\n```\n**After** (with the change):\n```java\nclass Test {\n void foo() {\n int a = 1;\n System.err.println(\"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\");\n }\n}\n```\nLine 4 is left as it was because it is outside the requested range; formatting `--lines 4:4` would still wrap it.\n\nAffected files in our repo:\n- open-java-format/src/main/java/com/palantir/javaformat/java/StringWrapper.java (`wrap`, `wrapOnce`, `getReflowReplacements`, `linesNeedWrapping`)\n- open-java-format/src/main/java/com/palantir/javaformat/java/FormatFileCallable.java (`call`, `formatFile`)\n- open-java-format/src/main/java/com/palantir/javaformat/java/Formatter.java (`formatSourceAndFixImports`, which wraps the whole file)\n\nThe upstream diff will not apply cleanly: we have no `Cleanups` or `Edit` classes (see the existing ticket on the unified cleanups pipeline), and our `StringWrapper` works from a `TreeRangeMap` of replacements rather than upstream's structure. The idea ports directly, though: our `getReflowReplacements` already produces per-literal ranges, so they can be filtered by overlap with the formatted-output ranges before applying.\n\nSuggested action: port the idea. Add a range filter to `StringWrapper.wrap` and pass the mapped requested ranges from `FormatFileCallable`; keep whole-file behaviour when no range is given. Upstream's `StringWrapperTest` and `MainTest` cases from the PR are a good source of tests.\n\n---\n_Filed from an upstream-watch ticket after manual review._","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-10-31T11:34:52Z","url":"https://github.com/openjavaformat/open-java-format/issues/177"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6dacec10-99c4-be2c-937b-b323a64681eb |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8A52:33D4D9:87FCD:BA196:6AFBB796 |
| html-safe-nonce | 059b183bdbff391de2515287dca1617228947f262c1d8a92ce57e9d4b45789fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTUyOjMzRDREOTo4N0ZDRDpCQTE5Njo2QUZCQjc5NiIsInZpc2l0b3JfaWQiOiIyODYxMDIwNDA5MzU4OTU2NDM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 350fa3cf98c7394ea5d86276760c8b0176e77d8e1ffe8f4e97d7226e8d8a0566 |
| hovercard-subject-tag | issue:6134334551 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/177/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6ae94b07694e72e88df083349d5d5913deebbca90b687a66283f91d146c9fa77/openjavaformat/open-java-format/issues/177 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6ae94b07694e72e88df083349d5d5913deebbca90b687a66283f91d146c9fa77/openjavaformat/open-java-format/issues/177 |
| og:image:alt | Upstream: google/google-java-format#1514 Kind: bug | Priority: medium google-java-format#1514 (merged 2026-10-30, copybara export) fixes google-java-format#1114: with --lines, --offset/--length or ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | abashev |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c |
| turbo-cache-control | no-preview |
| go-import | github.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git |
| octolytics-dimension-user_id | 325177626 |
| octolytics-dimension-user_login | openjavaformat |
| octolytics-dimension-repository_id | 1288055459 |
| octolytics-dimension-repository_nwo | openjavaformat/open-java-format |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 214273098 |
| octolytics-dimension-repository_parent_nwo | palantir/palantir-java-format |
| octolytics-dimension-repository_network_root_id | 214273098 |
| octolytics-dimension-repository_network_root_nwo | palantir/palantir-java-format |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e4cce0e99cf61481a318ff12c2e8580153a6c7c6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width