René's URL Explorer Experiment


Title: Do not strip a used `java.lang.X` import: it may be the only thing that picks the right class · Issue #149 · openjavaformat/open-java-format · GitHub

Open Graph Title: Do not strip a used `java.lang.X` import: it may be the only thing that picks the right class · Issue #149 · openjavaformat/open-java-format

X Title: Do not strip a used `java.lang.X` import: it may be the only thing that picks the right class · Issue #149 · openjavaformat/open-java-format

Description: Upstream: palantir#1778 Kind: bug | Priority: medium palantir-java-format#1778 (closed without merging on 2026-10-17, by an outside contributor; it fixes palantir-java-format issue 1334) points out that unused-import removal deletes ever...

Open Graph Description: Upstream: palantir#1778 Kind: bug | Priority: medium palantir-java-format#1778 (closed without merging on 2026-10-17, by an outside contributor; it fixes palantir-java-format issue 1334) points out...

X Description: Upstream: palantir#1778 Kind: bug | Priority: medium palantir-java-format#1778 (closed without merging on 2026-10-17, by an outside contributor; it fixes palantir-java-format issue 1334) points out...

Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/149

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Do not strip a used `java.lang.X` import: it may be the only thing that picks the right class","articleBody":"**Upstream:** https://github.com/palantir/palantir-java-format/pull/1778  \n**Kind:** bug | **Priority:** medium\n\n[palantir-java-format#1778](https://github.com/palantir/palantir-java-format/pull/1778) (closed without merging on 2026-10-17, by an outside contributor; it fixes palantir-java-format issue 1334) points out that unused-import removal deletes every single-type import whose qualifier is `java.lang`. That is unsound: a single-type import shadows both a same-package class and a class pulled in by a wildcard import. If the file also sees another `Byte` (in its own package or via `import some.pkg.*`), removing `import java.lang.Byte;` either makes the name ambiguous or silently rebinds it to the other class, and the build breaks. The proposed fix removes a `java.lang` single-type import only when its simple name is not referenced anywhere in the file (code or Javadoc); `import java.lang.*;` and unused `java.lang.X` imports are still removed.\n\nWhy it matters to us: our `RemoveUnusedImports` still has the unconditional `java.lang` branch (around line 330), so we have the same defect. A formatter that changes which class a name binds to is a correctness problem, not a cosmetic one, even though the trigger is rare. Upstream did not accept the change, so we would be adopting it on our own.\n\nAffected files: `open-java-format/src/main/java/com/palantir/javaformat/java/RemoveUnusedImports.java` and its unit test.\n\n**Before** (how it is formatted today; derived from our code, not run):\n```java\npackage bar;\n\nimport foo.*;\nimport java.lang.Byte;\n\nclass Test {\n    Byte b;\n}\n```\nbecomes\n```java\npackage bar;\n\nimport foo.*;\n\nclass Test {\n    Byte b;\n}\n```\n**After** (with the change): the `java.lang.Byte` import stays, because `Byte` is used in the file.\n\nSuggested action: port the idea (small change in one method; check that the existing test which expects a used `java.lang` import to disappear is updated). The PR also adds an agent-instructions file to the repo root; do not take that over.\n\n---\n_Filed from an upstream-watch ticket after manual review._","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-10-23T21:46:31Z","url":"https://github.com/openjavaformat/open-java-format/issues/149"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ae858d9f-70bf-1c1c-da53-bc53ca132dc3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8222:CF711:5AA141:7920C8:6AFBC734
html-safe-nonce2880e1efea8c6a23b473b4475fd43cc3f29ca9f1e85d1b8c1ced084985793da6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjIyOkNGNzExOjVBQTE0MTo3OTIwQzg6NkFGQkM3MzQiLCJ2aXNpdG9yX2lkIjoiNjQ5MjA2NzM0MDAwNjE4MDY2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca94de27ce8861af41686799a41f3a2b36181e34f9855f58782e00dc53e59a90c
hovercard-subject-tagissue:6005928898
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/149/issue_layout
twitter:imagehttps://opengraph.githubassets.com/81cf1646129473867f8ec34f8aca64262751fd22f66583334a9ba1639cd80dda/openjavaformat/open-java-format/issues/149
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/81cf1646129473867f8ec34f8aca64262751fd22f66583334a9ba1639cd80dda/openjavaformat/open-java-format/issues/149
og:image:altUpstream: palantir#1778 Kind: bug | Priority: medium palantir-java-format#1778 (closed without merging on 2026-10-17, by an outside contributor; it fixes palantir-java-format issue 1334) points out...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabashev
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/issues/149#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F149
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F149
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/issues/149
Reloadhttps://github.com/openjavaformat/open-java-format/issues/149
Reloadhttps://github.com/openjavaformat/open-java-format/issues/149
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
https://github.com/openjavaformat/open-java-format
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/149
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/149
#174https://github.com/openjavaformat/open-java-format/pull/174
Do not strip a used java.lang.X import: it may be the only thing that picks the right classhttps://github.com/openjavaformat/open-java-format/issues/149#top
#174https://github.com/openjavaformat/open-java-format/pull/174
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/abashev
abashevhttps://github.com/abashev
on Oct 23, 2026https://github.com/openjavaformat/open-java-format/issues/149#issue-6005928898
palantir#1778https://github.com/palantir/palantir-java-format/pull/1778
palantir-java-format#1778https://github.com/palantir/palantir-java-format/pull/1778
abashevhttps://github.com/abashev
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
on Oct 30, 2026https://github.com/openjavaformat/open-java-format/issues/149#event-34679206670
abashevhttps://github.com/abashev
completedhttps://github.com/openjavaformat/open-java-format/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#174https://github.com/openjavaformat/open-java-format/pull/174
on Oct 30, 2026https://github.com/openjavaformat/open-java-format/issues/149#event-34722965181
Sign up for freehttps://github.com/signup?return_to=https://github.com/openjavaformat/open-java-format/issues/149
Sign in to commenthttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/149
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.