Title: Do not strip a used `java.lang.X` import: it may be the only thing that picks the right class · Issue #149 · openjavaformat/open-java-format · GitHub
Open Graph Title: Do not strip a used `java.lang.X` import: it may be the only thing that picks the right class · Issue #149 · openjavaformat/open-java-format
X Title: Do not strip a used `java.lang.X` import: it may be the only thing that picks the right class · Issue #149 · openjavaformat/open-java-format
Description: Upstream: palantir#1778 Kind: bug | Priority: medium palantir-java-format#1778 (closed without merging on 2026-10-17, by an outside contributor; it fixes palantir-java-format issue 1334) points out that unused-import removal deletes ever...
Open Graph Description: Upstream: palantir#1778 Kind: bug | Priority: medium palantir-java-format#1778 (closed without merging on 2026-10-17, by an outside contributor; it fixes palantir-java-format issue 1334) points out...
X Description: Upstream: palantir#1778 Kind: bug | Priority: medium palantir-java-format#1778 (closed without merging on 2026-10-17, by an outside contributor; it fixes palantir-java-format issue 1334) points out...
Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/149
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Do not strip a used `java.lang.X` import: it may be the only thing that picks the right class","articleBody":"**Upstream:** https://github.com/palantir/palantir-java-format/pull/1778 \n**Kind:** bug | **Priority:** medium\n\n[palantir-java-format#1778](https://github.com/palantir/palantir-java-format/pull/1778) (closed without merging on 2026-10-17, by an outside contributor; it fixes palantir-java-format issue 1334) points out that unused-import removal deletes every single-type import whose qualifier is `java.lang`. That is unsound: a single-type import shadows both a same-package class and a class pulled in by a wildcard import. If the file also sees another `Byte` (in its own package or via `import some.pkg.*`), removing `import java.lang.Byte;` either makes the name ambiguous or silently rebinds it to the other class, and the build breaks. The proposed fix removes a `java.lang` single-type import only when its simple name is not referenced anywhere in the file (code or Javadoc); `import java.lang.*;` and unused `java.lang.X` imports are still removed.\n\nWhy it matters to us: our `RemoveUnusedImports` still has the unconditional `java.lang` branch (around line 330), so we have the same defect. A formatter that changes which class a name binds to is a correctness problem, not a cosmetic one, even though the trigger is rare. Upstream did not accept the change, so we would be adopting it on our own.\n\nAffected files: `open-java-format/src/main/java/com/palantir/javaformat/java/RemoveUnusedImports.java` and its unit test.\n\n**Before** (how it is formatted today; derived from our code, not run):\n```java\npackage bar;\n\nimport foo.*;\nimport java.lang.Byte;\n\nclass Test {\n Byte b;\n}\n```\nbecomes\n```java\npackage bar;\n\nimport foo.*;\n\nclass Test {\n Byte b;\n}\n```\n**After** (with the change): the `java.lang.Byte` import stays, because `Byte` is used in the file.\n\nSuggested action: port the idea (small change in one method; check that the existing test which expects a used `java.lang` import to disappear is updated). The PR also adds an agent-instructions file to the repo root; do not take that over.\n\n---\n_Filed from an upstream-watch ticket after manual review._","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-10-23T21:46:31Z","url":"https://github.com/openjavaformat/open-java-format/issues/149"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ae858d9f-70bf-1c1c-da53-bc53ca132dc3 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8222:CF711:5AA141:7920C8:6AFBC734 |
| html-safe-nonce | 2880e1efea8c6a23b473b4475fd43cc3f29ca9f1e85d1b8c1ced084985793da6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjIyOkNGNzExOjVBQTE0MTo3OTIwQzg6NkFGQkM3MzQiLCJ2aXNpdG9yX2lkIjoiNjQ5MjA2NzM0MDAwNjE4MDY2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a94de27ce8861af41686799a41f3a2b36181e34f9855f58782e00dc53e59a90c |
| hovercard-subject-tag | issue:6005928898 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/149/issue_layout |
| twitter:image | https://opengraph.githubassets.com/81cf1646129473867f8ec34f8aca64262751fd22f66583334a9ba1639cd80dda/openjavaformat/open-java-format/issues/149 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/81cf1646129473867f8ec34f8aca64262751fd22f66583334a9ba1639cd80dda/openjavaformat/open-java-format/issues/149 |
| og:image:alt | Upstream: palantir#1778 Kind: bug | Priority: medium palantir-java-format#1778 (closed without merging on 2026-10-17, by an outside contributor; it fixes palantir-java-format issue 1334) points out... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | abashev |
| hostname | github.com |
| expected-hostname | github.com |
| None | d440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b |
| turbo-cache-control | no-preview |
| go-import | github.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git |
| octolytics-dimension-user_id | 325177626 |
| octolytics-dimension-user_login | openjavaformat |
| octolytics-dimension-repository_id | 1288055459 |
| octolytics-dimension-repository_nwo | openjavaformat/open-java-format |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 214273098 |
| octolytics-dimension-repository_parent_nwo | palantir/palantir-java-format |
| octolytics-dimension-repository_network_root_id | 214273098 |
| octolytics-dimension-repository_network_root_nwo | palantir/palantir-java-format |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2c43021aed8695990c86c0eaaedc600bfeffec36 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width