René's URL Explorer Experiment


Title: Join `"a " + "b"` string concatenations that end up on one line · Issue #148 · openjavaformat/open-java-format · GitHub

Open Graph Title: Join `"a " + "b"` string concatenations that end up on one line · Issue #148 · openjavaformat/open-java-format

X Title: Join `"a " + "b"` string concatenations that end up on one line · Issue #148 · openjavaformat/open-java-format

Description: Upstream: palantir#1781 Kind: bug | Priority: low palantir-java-format#1781 (closed unmerged on 2026-10-17) describes a leftover of string wrapping: when a long concatenation of literals is re-wrapped and the pieces end up on the same li...

Open Graph Description: Upstream: palantir#1781 Kind: bug | Priority: low palantir-java-format#1781 (closed unmerged on 2026-10-17) describes a leftover of string wrapping: when a long concatenation of literals is re-wrap...

X Description: Upstream: palantir#1781 Kind: bug | Priority: low palantir-java-format#1781 (closed unmerged on 2026-10-17) describes a leftover of string wrapping: when a long concatenation of literals is re-wrap...

Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/148

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Join `\"a \" + \"b\"` string concatenations that end up on one line","articleBody":"**Upstream:** https://github.com/palantir/palantir-java-format/pull/1781  \n**Kind:** bug | **Priority:** low\n\n[palantir-java-format#1781](https://github.com/palantir/palantir-java-format/pull/1781) (closed unmerged on 2026-10-17) describes a leftover of string wrapping: when a long concatenation of literals is re-wrapped and the pieces end up on the same line, the `+` between two adjacent literals stays, because the string-wrapping pass only acts on lines that exceed the column limit. The PR adds a pass that merges runs of adjacent literals which already share a line into one literal, guarded so that it never merges across a comment (NON-NLS markers), never touches text blocks, and refuses merges that would change an octal escape such as `\"\\1\" + \"2\"`.\n\nWhy it matters to us: our `StringWrapper` has no such joining pass, so we should leave the same `\"...\" + \"...\"` residue and the formatting stays dependent on how the author wrapped the string. It also interacts with our open work on NON-NLS markers (our #23). The idea also changes the semantics-adjacent text of string literals, so the escape guard is the part to get right.\n\nAffected files: `open-java-format/src/main/java/com/palantir/javaformat/java/StringWrapper.java` (including the fast-path checks that decide whether wrapping is needed).\n\n**Before** (upstream behaviour before the change; our StringWrapper has no joining pass, not run):\n```java\nthrow new SafeIllegalArgumentException(\n        \"Invalid recipient field - contains multiple \" + \"foreign key properties.\",\n        UnsafeArg.of(\"field\", maybeField));\n```\n**After** (with the change):\n```java\nthrow new SafeIllegalArgumentException(\n        \"Invalid recipient field - contains multiple foreign key properties.\",\n        UnsafeArg.of(\"field\", maybeField));\n```\n\nSuggested action: investigate; adopt the idea only with the escape and comment guards, low priority.\n\n---\n_Filed from an upstream-watch ticket after manual review._","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-10-23T21:46:11Z","url":"https://github.com/openjavaformat/open-java-format/issues/148"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9832234a-93fd-3027-64da-16681a42d7d8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8A2E:1B1794:61142C:803B9B:6AFBC740
html-safe-nonce6bcfe295ec9099d9b1db7c8a4e595b9f0b6f5a5ff196da9ed5958bd655c362f0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTJFOjFCMTc5NDo2MTE0MkM6ODAzQjlCOjZBRkJDNzQwIiwidmlzaXRvcl9pZCI6IjU1MTc1ODI5MzYwNjYyMTM2OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf5eaa5d2fa56ee77ce0c35e92e6317627cf34d55c37be7762250454aff98296f
hovercard-subject-tagissue:6005924859
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/148/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d5f8056cbe1095da2a27d4f024e6dd5e843a73ebf6178645839e8e1181e7b393/openjavaformat/open-java-format/issues/148
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d5f8056cbe1095da2a27d4f024e6dd5e843a73ebf6178645839e8e1181e7b393/openjavaformat/open-java-format/issues/148
og:image:altUpstream: palantir#1781 Kind: bug | Priority: low palantir-java-format#1781 (closed unmerged on 2026-10-17) describes a leftover of string wrapping: when a long concatenation of literals is re-wrap...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabashev
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/issues/148#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F148
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F148
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/issues/148
Reloadhttps://github.com/openjavaformat/open-java-format/issues/148
Reloadhttps://github.com/openjavaformat/open-java-format/issues/148
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
https://github.com/openjavaformat/open-java-format
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/148
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/148
#176https://github.com/openjavaformat/open-java-format/pull/176
Join "a " + "b" string concatenations that end up on one linehttps://github.com/openjavaformat/open-java-format/issues/148#top
#176https://github.com/openjavaformat/open-java-format/pull/176
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/abashev
abashevhttps://github.com/abashev
on Oct 23, 2026https://github.com/openjavaformat/open-java-format/issues/148#issue-6005924859
palantir#1781https://github.com/palantir/palantir-java-format/pull/1781
palantir-java-format#1781https://github.com/palantir/palantir-java-format/pull/1781
#23https://github.com/openjavaformat/open-java-format/issues/23
abashevhttps://github.com/abashev
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
on Oct 30, 2026https://github.com/openjavaformat/open-java-format/issues/148#event-34679209599
abashevhttps://github.com/abashev
completedhttps://github.com/openjavaformat/open-java-format/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
da784aahttps://github.com/openjavaformat/open-java-format/commit/da784aa8b7da1be8ddbfcc61ec21d7b1d1be23c9
on Oct 31, 2026https://github.com/openjavaformat/open-java-format/issues/148#event-34768794533
Sign up for freehttps://github.com/signup?return_to=https://github.com/openjavaformat/open-java-format/issues/148
Sign in to commenthttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/148
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.