René's URL Explorer Experiment


Title: Insert missing braces around single-statement if/else/for/while/do bodies (--cleanup) · Issue #147 · openjavaformat/open-java-format · GitHub

Open Graph Title: Insert missing braces around single-statement if/else/for/while/do bodies (--cleanup) · Issue #147 · openjavaformat/open-java-format

X Title: Insert missing braces around single-statement if/else/for/while/do bodies (--cleanup) · Issue #147 · openjavaformat/open-java-format

Description: Upstream: google/google-java-format#1492 Kind: feature | Priority: medium google-java-format#1492 (merged 2026-10-22, a Google-internal change exported by copybara) adds a --cleanup[=true|false] flag and a matching JavaFormatterOptions.B...

Open Graph Description: Upstream: google/google-java-format#1492 Kind: feature | Priority: medium google-java-format#1492 (merged 2026-10-22, a Google-internal change exported by copybara) adds a --cleanup[=true|false] fl...

X Description: Upstream: google/google-java-format#1492 Kind: feature | Priority: medium google-java-format#1492 (merged 2026-10-22, a Google-internal change exported by copybara) adds a --cleanup[=true|false] fl...

Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/147

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Insert missing braces around single-statement if/else/for/while/do bodies (--cleanup)","articleBody":"**Upstream:** https://github.com/google/google-java-format/pull/1492  \n**Kind:** feature | **Priority:** medium\n\n[google-java-format#1492](https://github.com/google/google-java-format/pull/1492) (merged 2026-10-22, a Google-internal change exported by copybara) adds a `--cleanup[=true|false]` flag and a matching `JavaFormatterOptions.Builder.cleanup(boolean)` option, on by default. It gates a new AST cleanup pass (`CleanupScanner`) that wraps unbraced bodies of `if`, `else`, `for`, `do` and `while` in braces, keeps trailing comments on the opening-brace line, and handles nested if/else chains. The pass runs inside the cleanups pipeline introduced by [google-java-format#1488](https://github.com/google/google-java-format/pull/1488).\n\nWhy it matters: it is the first non-whitespace rewrite google-java-format applies by default, so users of our fork who also use that tool may expect the same result. It changes formatted output for existing code bases, which is why upstream made it switchable. A follow-up in [google-java-format#1491](https://github.com/google/google-java-format/pull/1491) adds redundant-semicolon removal to the same pass. We have no brace insertion today (no scanner of this kind in our sources).\n\n**Before** (how it is formatted today, our formatter keeps the unbraced body):\n```java\nclass T {\n  void f(boolean a, boolean b) {\n    if (a)\n      if (b) doA();\n      else doB();\n    while (a) doA();\n  }\n}\n```\n**After** (with the change, from upstream test expectations):\n```java\nclass T {\n  void f(boolean a, boolean b) {\n    if (a) {\n      if (b) {\n        doA();\n      } else {\n        doB();\n      }\n    }\n    while (a) {\n      doA();\n    }\n  }\n}\n```\n(Indentation shown at two spaces for brevity; ours would use the project's four-space layout.)\n\nAffected files in our repo:\n- open-java-format/src/main/java/com/palantir/javaformat/java/Formatter.java (pipeline entry points)\n- open-java-format/src/main/java/com/palantir/javaformat/java/CommandLineOptions.java and CommandLineOptionsParser.java (new flag)\n- open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java (statement visiting, for context)\n- open-java-format/src/test/resources/com/palantir/javaformat/java/testdata (goldens would need an opt-out)\n\nSuggested action: investigate. Decide whether we want any non-whitespace rewrite, and if so make it opt-in (default off) so existing output does not change. Depends on the cleanups-pipeline decision in the existing ticket for google-java-format#1488. Otherwise ignore-with-reason (\"formatter should not rewrite code\").\n\n---\n_Filed from an upstream-watch ticket after manual review._","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-10-23T18:43:57Z","url":"https://github.com/openjavaformat/open-java-format/issues/147"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6438c9d0-5d59-7879-9891-18c2fe0fb087
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD73C:C4A52:2C6A22:3AC080:6AFBB793
html-safe-noncef4021e5bd2aff06536b8c3c907c693e900023986b8d895f22f3695fcca5de208
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzNDOkM0QTUyOjJDNkEyMjozQUMwODA6NkFGQkI3OTMiLCJ2aXNpdG9yX2lkIjoiMjYzMDA3ODU1NzU2NDE1NTc5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5295741c00efb5d18fea87fe81d249fb3d8653969ebd2e03d19f39defccf90a3
hovercard-subject-tagissue:6003566599
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/147/issue_layout
twitter:imagehttps://opengraph.githubassets.com/14fbcc2a7dd67aa626f980af8e1194c0cd44967d42434a89c2f7703b239c4cde/openjavaformat/open-java-format/issues/147
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/14fbcc2a7dd67aa626f980af8e1194c0cd44967d42434a89c2f7703b239c4cde/openjavaformat/open-java-format/issues/147
og:image:altUpstream: google/google-java-format#1492 Kind: feature | Priority: medium google-java-format#1492 (merged 2026-10-22, a Google-internal change exported by copybara) adds a --cleanup[=true|false] fl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabashev
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/issues/147#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F147
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F147
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/issues/147
Reloadhttps://github.com/openjavaformat/open-java-format/issues/147
Reloadhttps://github.com/openjavaformat/open-java-format/issues/147
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
https://github.com/openjavaformat/open-java-format
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/147
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/147
Insert missing braces around single-statement if/else/for/while/do bodies (--cleanup)https://github.com/openjavaformat/open-java-format/issues/147#top
enhancementNew feature or requesthttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/abashev
abashevhttps://github.com/abashev
on Oct 23, 2026https://github.com/openjavaformat/open-java-format/issues/147#issue-6003566599
google/google-java-format#1492https://github.com/google/google-java-format/pull/1492
google-java-format#1492https://github.com/google/google-java-format/pull/1492
google-java-format#1488https://github.com/google/google-java-format/pull/1488
google-java-format#1491https://github.com/google/google-java-format/pull/1491
abashevhttps://github.com/abashev
enhancementNew feature or requesthttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22enhancement%22
on Oct 30, 2026https://github.com/openjavaformat/open-java-format/issues/147#event-34679229698
Sign up for freehttps://github.com/signup?return_to=https://github.com/openjavaformat/open-java-format/issues/147
Sign in to commenthttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/147
enhancementNew feature or requesthttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.