René's URL Explorer Experiment


Title: Trailing comment after `{` is over-indented on the first pass (non-idempotent) · Issue #129 · openjavaformat/open-java-format · GitHub

Open Graph Title: Trailing comment after `{` is over-indented on the first pass (non-idempotent) · Issue #129 · openjavaformat/open-java-format

X Title: Trailing comment after `{` is over-indented on the first pass (non-idempotent) · Issue #129 · openjavaformat/open-java-format

Description: Upstream: google/google-java-format#1464 Kind: bug | Priority: medium Open PR google-java-format#1464 (fixes gjf issue google-java-format#1260): for { /* comment */ stmt; } and the analogous array initializer, visitBlock / visitArrayInit...

Open Graph Description: Upstream: google/google-java-format#1464 Kind: bug | Priority: medium Open PR google-java-format#1464 (fixes gjf issue google-java-format#1260): for { /* comment */ stmt; } and the analogous array ...

X Description: Upstream: google/google-java-format#1464 Kind: bug | Priority: medium Open PR google-java-format#1464 (fixes gjf issue google-java-format#1260): for { /* comment */ stmt; } and the analogous array ...

Opengraph URL: https://github.com/openjavaformat/open-java-format/issues/129

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Trailing comment after `{` is over-indented on the first pass (non-idempotent)","articleBody":"**Upstream:** https://github.com/google/google-java-format/pull/1464  \n**Kind:** bug | **Priority:** medium\n\nOpen PR [google-java-format#1464](https://github.com/google/google-java-format/issues/1464) (fixes gjf issue [google-java-format#1260](https://github.com/google/google-java-format/issues/1260)): for `{ /* comment */ stmt; }` and the analogous\narray initializer, `visitBlock` / `visitArrayInitializer` open a `plusTwo` level and then\nemit `tokenBreakTrailingComment(\"{\", plusTwo)`, stacking a second indent. A comment broken\nout after `{` lands one indent deeper than the statements, and a second format run moves\nit back, so the formatter is not idempotent. The fix uses `ZERO` for the trailing-comment\nindent when the block/initializer is non-empty and keeps `plusTwo` for empty ones.\n\nWhy it matters to us: we have exactly the same pattern, so the bug very likely reproduces\nin both GOOGLE and PALANTIR styles. Idempotency bugs break `spotlessCheck`-style CI.\n\nAffected files in our repo:\n- open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java\n  - visitBlock: `builder.open(plusTwo)` then `tokenBreakTrailingComment(\"{\", plusTwo)` (around line 2151-2152)\n  - visitArrayInitializer, non-empty branch (around line 541-542)\n  - other `tokenBreakTrailingComment(\"{\", plusTwo)` sites (lines ~857, 1886, 2145, 2519, 3766, 3783) should be checked for the same stacking\n\nSuggested action: port. Reproduce first with the I1260 input from the PR on our formatter\n(both styles), then apply the two-line change; the logic applies cleanly, the code differs\nonly in formatting and the extra BreakBehaviour arguments on our `open` calls.\n\n---\n_Filed from an upstream-watch ticket after manual review._","author":{"url":"https://github.com/abashev","@type":"Person","name":"abashev"},"datePublished":"2026-10-16T21:06:03Z","url":"https://github.com/openjavaformat/open-java-format/issues/129"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:841afa28-2260-6b9c-44a1-9c247a3fe323
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id825A:22AECE:6095E8:8007B6:6AFBC734
html-safe-nonce21bdb9d5016bddba5aebc3d551eb5ddb98ed8dba633d2c8f3dec59fa7205aabe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjVBOjIyQUVDRTo2MDk1RTg6ODAwN0I2OjZBRkJDNzM0IiwidmlzaXRvcl9pZCI6IjU4NDU2MTkyODM4NjU2MTgyMjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3010486716648a462901482938521f36aa5eedc4b612eb17c3a0fe4e6c99b9d5
hovercard-subject-tagissue:5891191764
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openjavaformat/open-java-format/129/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8ba99fa06eb2e96e3864f6a7403933fea6f2cc758a0d9a51f74b97891e059037/openjavaformat/open-java-format/issues/129
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8ba99fa06eb2e96e3864f6a7403933fea6f2cc758a0d9a51f74b97891e059037/openjavaformat/open-java-format/issues/129
og:image:altUpstream: google/google-java-format#1464 Kind: bug | Priority: medium Open PR google-java-format#1464 (fixes gjf issue google-java-format#1260): for { /* comment */ stmt; } and the analogous array ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabashev
hostnamegithub.com
expected-hostnamegithub.com
Noned440bda0d812801778b27bfe9f7c1ce9ff22420c73f6f95150c4fcbca311c50b
turbo-cache-controlno-preview
go-importgithub.com/openjavaformat/open-java-format git https://github.com/openjavaformat/open-java-format.git
octolytics-dimension-user_id325177626
octolytics-dimension-user_loginopenjavaformat
octolytics-dimension-repository_id1288055459
octolytics-dimension-repository_nwoopenjavaformat/open-java-format
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id214273098
octolytics-dimension-repository_parent_nwopalantir/palantir-java-format
octolytics-dimension-repository_network_root_id214273098
octolytics-dimension-repository_network_root_nwopalantir/palantir-java-format
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2c43021aed8695990c86c0eaaedc600bfeffec36
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/openjavaformat/open-java-format/issues/129#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F129
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenjavaformat%2Fopen-java-format%2Fissues%2F129
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openjavaformat%2Fopen-java-format
Reloadhttps://github.com/openjavaformat/open-java-format/issues/129
Reloadhttps://github.com/openjavaformat/open-java-format/issues/129
Reloadhttps://github.com/openjavaformat/open-java-format/issues/129
openjavaformathttps://github.com/openjavaformat
open-java-formathttps://github.com/openjavaformat/open-java-format
Codehttps://github.com/openjavaformat/open-java-format
Issues30 (30)https://github.com/openjavaformat/open-java-format/issues
Pull requests5 (5)https://github.com/openjavaformat/open-java-format/pulls
Discussionshttps://github.com/openjavaformat/open-java-format/discussions
Actionshttps://github.com/openjavaformat/open-java-format/actions
Security and qualityhttps://github.com/openjavaformat/open-java-format/security
Insightshttps://github.com/openjavaformat/open-java-format/pulse
https://github.com/openjavaformat/open-java-format
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/129
New issuehttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/129
#143https://github.com/openjavaformat/open-java-format/pull/143
Trailing comment after { is over-indented on the first pass (non-idempotent)https://github.com/openjavaformat/open-java-format/issues/129#top
#143https://github.com/openjavaformat/open-java-format/pull/143
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/abashev
abashevhttps://github.com/abashev
on Oct 16, 2026https://github.com/openjavaformat/open-java-format/issues/129#issue-5891191764
google/google-java-format#1464https://github.com/google/google-java-format/pull/1464
google-java-format#1464https://github.com/google/google-java-format/issues/1464
google-java-format#1260https://github.com/google/google-java-format/issues/1260
abashevhttps://github.com/abashev
completedhttps://github.com/openjavaformat/open-java-format/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#143https://github.com/openjavaformat/open-java-format/pull/143
on Oct 21, 2026https://github.com/openjavaformat/open-java-format/issues/129#event-33820880596
abashevhttps://github.com/abashev
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
on Oct 30, 2026https://github.com/openjavaformat/open-java-format/issues/129#event-34679215260
Sign up for freehttps://github.com/signup?return_to=https://github.com/openjavaformat/open-java-format/issues/129
Sign in to commenthttps://github.com/login?return_to=https://github.com/openjavaformat/open-java-format/issues/129
bugSomething isn't workinghttps://github.com/openjavaformat/open-java-format/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.