René's URL Explorer Experiment


Title: fix: Fail when duplicate names are generated by forest-benchling · Pull Request #336 · openapi-generators/openapi-python-client · GitHub

Open Graph Title: fix: Fail when duplicate names are generated by forest-benchling · Pull Request #336 · openapi-generators/openapi-python-client

X Title: fix: Fail when duplicate names are generated by forest-benchling · Pull Request #336 · openapi-generators/openapi-python-client

Description: Previously, it would silently create buggy code if duplicate models were generated with the same name; see #335 and #323.

Open Graph Description: Previously, it would silently create buggy code if duplicate models were generated with the same name; see #335 and #323.

X Description: Previously, it would silently create buggy code if duplicate models were generated with the same name; see #335 and #323.

Opengraph URL: https://github.com/openapi-generators/openapi-python-client/pull/336

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d443cdf6-b76b-cfea-a79d-08532fb79a7c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id801A:1B7AB8:620701:7FFC2A:69828F07
html-safe-nonceda6f6ff898710cfce8868b89616742e8f526745a4fb59b3a085977baeab91539
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDFBOjFCN0FCODo2MjA3MDE6N0ZGQzJBOjY5ODI4RjA3IiwidmlzaXRvcl9pZCI6IjE5ODg3Njc5MjIyMzUwMTkwMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac167ec4ea7438cf7843e7ce5b34a552d2b4e9fc0e6fd08055115ea699a79beb60
hovercard-subject-tagpull_request:571251016
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/openapi-generators/openapi-python-client/336/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c88746e532e363f0aed341d2476e3099f685a905a419a42802b143a3d2dd1a98/openapi-generators/openapi-python-client/pull/336
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c88746e532e363f0aed341d2476e3099f685a905a419a42802b143a3d2dd1a98/openapi-generators/openapi-python-client/pull/336
og:image:altPreviously, it would silently create buggy code if duplicate models were generated with the same name; see #335 and #323.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameforest-benchling
hostnamegithub.com
expected-hostnamegithub.com
None502ff2009aec8671c806fca4ec6d758f90b6b96901b01d5f0ed23cc438efdf0f
turbo-cache-controlno-preview
go-importgithub.com/openapi-generators/openapi-python-client git https://github.com/openapi-generators/openapi-python-client.git
octolytics-dimension-user_id84925606
octolytics-dimension-user_loginopenapi-generators
octolytics-dimension-repository_id240776275
octolytics-dimension-repository_nwoopenapi-generators/openapi-python-client
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id240776275
octolytics-dimension-repository_network_root_nwoopenapi-generators/openapi-python-client
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e7b93cf13221e895180e11ba3b1028b0b71f0ac
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openapi-generators/openapi-python-client/pull/336#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F336
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F336
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=openapi-generators%2Fopenapi-python-client
Reloadhttps://github.com/openapi-generators/openapi-python-client/pull/336
Reloadhttps://github.com/openapi-generators/openapi-python-client/pull/336
Reloadhttps://github.com/openapi-generators/openapi-python-client/pull/336
openapi-generators https://github.com/openapi-generators
openapi-python-clienthttps://github.com/openapi-generators/openapi-python-client
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
Notifications https://github.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Fork 264 https://github.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Star 1.9k https://github.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Code https://github.com/openapi-generators/openapi-python-client
Issues 77 https://github.com/openapi-generators/openapi-python-client/issues
Pull requests 14 https://github.com/openapi-generators/openapi-python-client/pulls
Discussions https://github.com/openapi-generators/openapi-python-client/discussions
Actions https://github.com/openapi-generators/openapi-python-client/actions
Security 2 https://github.com/openapi-generators/openapi-python-client/security
Insights https://github.com/openapi-generators/openapi-python-client/pulse
Code https://github.com/openapi-generators/openapi-python-client
Issues https://github.com/openapi-generators/openapi-python-client/issues
Pull requests https://github.com/openapi-generators/openapi-python-client/pulls
Discussions https://github.com/openapi-generators/openapi-python-client/discussions
Actions https://github.com/openapi-generators/openapi-python-client/actions
Security https://github.com/openapi-generators/openapi-python-client/security
Insights https://github.com/openapi-generators/openapi-python-client/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/openapi-generators/openapi-python-client/pull/336#issue-comment-box
dbantyhttps://github.com/dbanty
openapi-generators:mainhttps://github.com/openapi-generators/openapi-python-client/tree/main
benchling:forest-clashhttps://github.com/benchling/openapi-python-client/tree/forest-clash
fix: Fail when duplicate names are generated https://github.com/openapi-generators/openapi-python-client/pull/336#top
dbantyhttps://github.com/dbanty
openapi-generators:mainhttps://github.com/openapi-generators/openapi-python-client/tree/main
benchling:forest-clashhttps://github.com/benchling/openapi-python-client/tree/forest-clash
Conversation 7 https://github.com/openapi-generators/openapi-python-client/pull/336
Commits 9 https://github.com/openapi-generators/openapi-python-client/pull/336/commits
Checks 0 https://github.com/openapi-generators/openapi-python-client/pull/336/checks
Files changed https://github.com/openapi-generators/openapi-python-client/pull/336/files
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
https://github.co/hiddenchars
https://github.com/openapi-generators/openapi-python-client/pull/{{ revealButtonHref }}
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
Feb 10, 2021https://github.com/openapi-generators/openapi-python-client/pull/336#issue-805691168
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
#335https://github.com/openapi-generators/openapi-python-client/pull/335
#323https://github.com/openapi-generators/openapi-python-client/issues/323
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
https://github.com/forest-benchling
Fail on duplicate nameshttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/4ccbce9e27c1add40ec543ad760517bf45612e51
4ccbce9https://github.com/openapi-generators/openapi-python-client/pull/336/commits/4ccbce9e27c1add40ec543ad760517bf45612e51
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Feb 10, 2021https://github.com/openapi-generators/openapi-python-client/pull/336#issuecomment-776856881
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
Codecovhttps://codecov.io/gh/triaxtec/openapi-python-client/pull/336?src=pr&el=h1
#336https://codecov.io/gh/triaxtec/openapi-python-client/pull/336?src=pr&el=desc
ba9bf86https://github.com/openapi-generators/openapi-python-client/commit/ba9bf8692991631d3683144ad9a99d5fdd5f2261
mainhttps://codecov.io/gh/triaxtec/openapi-python-client/commit/28336026743a61a42b306247aaf546d5713fa6af?el=desc
2833602https://github.com/openapi-generators/openapi-python-client/commit/28336026743a61a42b306247aaf546d5713fa6af
https://codecov.io/gh/triaxtec/openapi-python-client/pull/336?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/triaxtec/openapi-python-client/pull/336?src=pr&el=tree
...penapi_python_client/parser/properties/__init__.pyhttps://codecov.io/gh/triaxtec/openapi-python-client/pull/336/diff?src=pr&el=tree#diff-b3BlbmFwaV9weXRob25fY2xpZW50L3BhcnNlci9wcm9wZXJ0aWVzL19faW5pdF9fLnB5
Continue to review full report at Codecovhttps://codecov.io/gh/triaxtec/openapi-python-client/pull/336?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/triaxtec/openapi-python-client/pull/336?src=pr&el=footer
2833602...3ae0f18https://codecov.io/gh/triaxtec/openapi-python-client/pull/336?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
Feb 10, 2021https://github.com/openapi-generators/openapi-python-client/pull/336#issuecomment-776858106
@dbantyhttps://github.com/dbanty
@emannhttps://github.com/emann
@bowenwrhttps://github.com/bowenwr
@packyghttps://github.com/packyg
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
https://github.com/dbanty
dbantyhttps://github.com/dbanty
Feb 10, 2021 https://github.com/openapi-generators/openapi-python-client/pull/336#pullrequestreview-587866208
View reviewed changes https://github.com/openapi-generators/openapi-python-client/pull/336/files/4ccbce9e27c1add40ec543ad760517bf45612e51
openapi_python_client/parser/properties/__init__.pyhttps://github.com/openapi-generators/openapi-python-client/pull/336/files/4ccbce9e27c1add40ec543ad760517bf45612e51#diff-61e8ac1a0d02be37f61e720be24f89c399fc6325938adfe140017e45198dc241
dbantyhttps://github.com/dbanty
Feb 10, 2021https://github.com/openapi-generators/openapi-python-client/pull/336#discussion_r573928458
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
forest-benchlinghttps://github.com/forest-benchling
Feb 10, 2021https://github.com/openapi-generators/openapi-python-client/pull/336#discussion_r573986836
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
forest-benchlinghttps://github.com/forest-benchling
February 10, 2021 13:48https://github.com/openapi-generators/openapi-python-client/pull/336#commits-pushed-3f86bee
https://github.com/forest-benchling
Use PropertyErrorhttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/3f86bee3bb1eef9afa9e7c4a111ae93d9a9cc24e
3f86beehttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/3f86bee3bb1eef9afa9e7c4a111ae93d9a9cc24e
https://github.com/forest-benchling
Remove elsehttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/2655a8fc26c7cb145b918283ff2893b6e9894bf8
2655a8fhttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/2655a8fc26c7cb145b918283ff2893b6e9894bf8
https://github.com/forest-benchling
Revert openAPIhttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/bb4d8d571bc312f78651e05f7d8a82f11afc312d
bb4d8d5https://github.com/openapi-generators/openapi-python-client/pull/336/commits/bb4d8d571bc312f78651e05f7d8a82f11afc312d
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
dbantyhttps://github.com/dbanty
February 10, 2021 18:51https://github.com/openapi-generators/openapi-python-client/pull/336#event-4316419305
https://github.com/dbanty
dbantyhttps://github.com/dbanty
Feb 10, 2021 https://github.com/openapi-generators/openapi-python-client/pull/336#pullrequestreview-587963034
View reviewed changes https://github.com/openapi-generators/openapi-python-client/pull/336/files/bb4d8d571bc312f78651e05f7d8a82f11afc312d
dbantyhttps://github.com/dbanty
https://github.com/openapi-generators/openapi-python-client/pull/336#pullrequestreview-587963034
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#334https://github.com/openapi-generators/openapi-python-client/pull/334
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
forest-benchlinghttps://github.com/forest-benchling
February 10, 2021 14:19https://github.com/openapi-generators/openapi-python-client/pull/336#commits-pushed-bb66d55
https://github.com/forest-benchling
Add test and remove enum checkhttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/bb66d55febacf82072d8ff74ba508cc5d766896f
bb66d55https://github.com/openapi-generators/openapi-python-client/pull/336/commits/bb66d55febacf82072d8ff74ba508cc5d766896f
https://github.com/forest-benchling
Merge remote-tracking branch 'upstream/main' into forest-clashhttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/8c4ff2dd401fdfda024c5a7582a59a4d1247099a
8c4ff2dhttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/8c4ff2dd401fdfda024c5a7582a59a4d1247099a
https://github.com/forest-benchling
Remove whitespacehttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/e2a2b9b78553a68878e3834c49c409fce1a4cbdf
e2a2b9bhttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/e2a2b9b78553a68878e3834c49c409fce1a4cbdf
https://github.com/forest-benchling
Add back whitespacehttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/9b53646b5c588d9a9aa1a9ad4c2c90af3785c7e0
9b53646https://github.com/openapi-generators/openapi-python-client/pull/336/commits/9b53646b5c588d9a9aa1a9ad4c2c90af3785c7e0
https://github.com/forest-benchling
Remove mockerhttps://github.com/openapi-generators/openapi-python-client/pull/336/commits/3ae0f18ac8babc39f0453be5532510874f11163b
3ae0f18https://github.com/openapi-generators/openapi-python-client/pull/336/commits/3ae0f18ac8babc39f0453be5532510874f11163b
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
Feb 10, 2021https://github.com/openapi-generators/openapi-python-client/pull/336#issuecomment-776960455
@dbantyhttps://github.com/dbanty
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
https://github.com/dbanty
dbantyhttps://github.com/dbanty
Feb 10, 2021 https://github.com/openapi-generators/openapi-python-client/pull/336#pullrequestreview-588030195
View reviewed changes https://github.com/openapi-generators/openapi-python-client/pull/336/files/3ae0f18ac8babc39f0453be5532510874f11163b
https://github.com/dbanty
dbantyhttps://github.com/dbanty
Feb 10, 2021https://github.com/openapi-generators/openapi-python-client/pull/336#issuecomment-777013102
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
https://github.com/dbanty
dbantyhttps://github.com/dbanty
2bfe610https://github.com/openapi-generators/openapi-python-client/commit/2bfe610cf372682c7fa2999b5eb432944368423c
Feb 10, 2021https://github.com/openapi-generators/openapi-python-client/pull/336#event-4316855815
dbantyhttps://github.com/dbanty
Feb 10, 2021 https://github.com/openapi-generators/openapi-python-client/pull/336#ref-commit-968d614
https://github.com/dbanty
docs: Add CHANGELOG entry forhttps://github.com/openapi-generators/openapi-python-client/commit/968d6142e7454f912ad415e3970e5491efb8f37a
#336https://github.com/openapi-generators/openapi-python-client/pull/336
968d614https://github.com/openapi-generators/openapi-python-client/commit/968d6142e7454f912ad415e3970e5491efb8f37a
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
February 10, 2021 21:31https://github.com/openapi-generators/openapi-python-client/pull/336#event-4317080551
https://github.com/dbanty
dbantyhttps://github.com/dbanty
Apr 4, 2021 https://github.com/openapi-generators/openapi-python-client/pull/336#ref-issue-798573461
Name clashes between auto-generated models and explicitly defined models #323 https://github.com/openapi-generators/openapi-python-client/issues/323
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F336
https://github.com/dbanty
dbanty https://github.com/dbanty
https://github.com/openapi-generators/openapi-python-client/pull/336/files/3ae0f18ac8babc39f0453be5532510874f11163b
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/336
https://github.com/forest-benchling
https://github.com/dbanty
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.