René's URL Explorer Experiment


Title: Fix additionalProperty Union spacing and construction (#266) by dbanty · Pull Request #273 · openapi-generators/openapi-python-client · GitHub

Open Graph Title: Fix additionalProperty Union spacing and construction (#266) by dbanty · Pull Request #273 · openapi-generators/openapi-python-client

X Title: Fix additionalProperty Union spacing and construction (#266) by dbanty · Pull Request #273 · openapi-generators/openapi-python-client

Description: Based on #268, fixes #266.

Open Graph Description: Based on #268, fixes #266.

X Description: Based on #268, fixes #266.

Opengraph URL: https://github.com/openapi-generators/openapi-python-client/pull/273

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cd464435-c6c6-39e5-add6-ef1b83670af6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9764:2C5558:4FAAC6:6C818F:69809AAF
html-safe-nonce2a9ecea76571c73433e0529d0894c2f11dc06907a638849687ee4dc1dccec8ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzY0OjJDNTU1ODo0RkFBQzY6NkM4MThGOjY5ODA5QUFGIiwidmlzaXRvcl9pZCI6IjY0NjUzNzg5ODAxMzk2NzAxOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd7f3efd0c71f968cde7319f47999d7e5b4381ea24cc3dbefce8c23a3642c3cfb
hovercard-subject-tagpull_request:543105819
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/openapi-generators/openapi-python-client/273/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6a0db23f2986deec8a9771e2d8d79197197d8742849b36f765eeeda5ca12aa1b/openapi-generators/openapi-python-client/pull/273
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6a0db23f2986deec8a9771e2d8d79197197d8742849b36f765eeeda5ca12aa1b/openapi-generators/openapi-python-client/pull/273
og:image:altBased on #268, fixes #266.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedbanty
hostnamegithub.com
expected-hostnamegithub.com
Nonec56f5f95bb0c3376cbc3c4b222c4f5b1ec18eba52cfeb21288e62fd4b100bd85
turbo-cache-controlno-preview
go-importgithub.com/openapi-generators/openapi-python-client git https://github.com/openapi-generators/openapi-python-client.git
octolytics-dimension-user_id84925606
octolytics-dimension-user_loginopenapi-generators
octolytics-dimension-repository_id240776275
octolytics-dimension-repository_nwoopenapi-generators/openapi-python-client
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id240776275
octolytics-dimension-repository_network_root_nwoopenapi-generators/openapi-python-client
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseffc0eec1a796e66c7f4ef486af4da95b7d6bc36b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openapi-generators/openapi-python-client/pull/273#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F273
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F273
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=openapi-generators%2Fopenapi-python-client
Reloadhttps://github.com/openapi-generators/openapi-python-client/pull/273
Reloadhttps://github.com/openapi-generators/openapi-python-client/pull/273
Reloadhttps://github.com/openapi-generators/openapi-python-client/pull/273
openapi-generators https://github.com/openapi-generators
openapi-python-clienthttps://github.com/openapi-generators/openapi-python-client
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/273
Notifications https://github.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Fork 264 https://github.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Star 1.9k https://github.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Code https://github.com/openapi-generators/openapi-python-client
Issues 77 https://github.com/openapi-generators/openapi-python-client/issues
Pull requests 14 https://github.com/openapi-generators/openapi-python-client/pulls
Discussions https://github.com/openapi-generators/openapi-python-client/discussions
Actions https://github.com/openapi-generators/openapi-python-client/actions
Security 2 https://github.com/openapi-generators/openapi-python-client/security
Insights https://github.com/openapi-generators/openapi-python-client/pulse
Code https://github.com/openapi-generators/openapi-python-client
Issues https://github.com/openapi-generators/openapi-python-client/issues
Pull requests https://github.com/openapi-generators/openapi-python-client/pulls
Discussions https://github.com/openapi-generators/openapi-python-client/discussions
Actions https://github.com/openapi-generators/openapi-python-client/actions
Security https://github.com/openapi-generators/openapi-python-client/security
Insights https://github.com/openapi-generators/openapi-python-client/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/openapi-generators/openapi-python-client/pull/273#issue-comment-box
dbantyhttps://github.com/dbanty
mainhttps://github.com/openapi-generators/openapi-python-client/tree/main
issue-266https://github.com/openapi-generators/openapi-python-client/tree/issue-266
Fix additionalProperty Union spacing and construction (#266) https://github.com/openapi-generators/openapi-python-client/pull/273#top
dbantyhttps://github.com/dbanty
mainhttps://github.com/openapi-generators/openapi-python-client/tree/main
issue-266https://github.com/openapi-generators/openapi-python-client/tree/issue-266
Conversation 5 https://github.com/openapi-generators/openapi-python-client/pull/273
Commits 13 https://github.com/openapi-generators/openapi-python-client/pull/273/commits
Checks 0 https://github.com/openapi-generators/openapi-python-client/pull/273/checks
Files changed https://github.com/openapi-generators/openapi-python-client/pull/273/files
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/273
https://github.co/hiddenchars
https://github.com/openapi-generators/openapi-python-client/pull/{{ revealButtonHref }}
https://github.com/dbanty
dbantyhttps://github.com/dbanty
Dec 20, 2020https://github.com/openapi-generators/openapi-python-client/pull/273#issue-771653940
#268https://github.com/openapi-generators/openapi-python-client/pull/268
#266https://github.com/openapi-generators/openapi-python-client/issues/266
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/273
packyghttps://github.com/packyg
December 15, 2020 10:23https://github.com/openapi-generators/openapi-python-client/pull/273#commits-pushed-ca2a18b
https://github.com/packyg
Fix indentation of union-ed addtionalPropertieshttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/ca2a18be6822831d16e5c33873536ee77248f373
ca2a18bhttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/ca2a18be6822831d16e5c33873536ee77248f373
https://github.com/packyg
Typing fixeshttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/ab6622d48c7e9c469cbfbe8d74aec82c17cae2cf
ab6622dhttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/ab6622d48c7e9c469cbfbe8d74aec82c17cae2cf
https://github.com/packyg
Add ModelWithAnyJsonProperties to e2e testshttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/45d18013045bc3496524f657e518821b88cc2e88
45d1801https://github.com/openapi-generators/openapi-python-client/pull/273/commits/45d18013045bc3496524f657e518821b88cc2e88
https://github.com/packyg
Regen golden recordhttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/85fc68591683606047dd9443b1b542fdce0d8fe1
85fc685https://github.com/openapi-generators/openapi-python-client/pull/273/commits/85fc68591683606047dd9443b1b542fdce0d8fe1
https://github.com/packyg
Add return type for get_instance_type_stringhttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/bd59aa65094472fe777600a94a9f9e3600301a14
bd59aa6https://github.com/openapi-generators/openapi-python-client/pull/273/commits/bd59aa65094472fe777600a94a9f9e3600301a14
https://github.com/packyg
Union Property - use data from inner function when returning primit…https://github.com/openapi-generators/openapi-python-client/pull/273/commits/c5f21b58f72cb06774ce602c5d4235f650a2467c
c5f21b5https://github.com/openapi-generators/openapi-python-client/pull/273/commits/c5f21b58f72cb06774ce602c5d4235f650a2467c
https://github.com/packyg
Update golden recordhttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/0521e366e5aefd757fa4becf978240a6077284a1
0521e36https://github.com/openapi-generators/openapi-python-client/pull/273/commits/0521e366e5aefd757fa4becf978240a6077284a1
https://github.com/packyg
Update union properties handling of props with and without templatehttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/9a679afcb4e21aded441e265239f38e31d75aca9
9a679afhttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/9a679afcb4e21aded441e265239f38e31d75aca9
https://github.com/packyg
Update golden recordhttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/bfab9d4312a4717324eb9fc5f6214c62ec2b904b
bfab9d4https://github.com/openapi-generators/openapi-python-client/pull/273/commits/bfab9d4312a4717324eb9fc5f6214c62ec2b904b
https://github.com/dbanty
Perf improvements tohttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/a3653842a0ec0efe89669f0dc2f7572d8522e017
#268https://github.com/openapi-generators/openapi-python-client/pull/268
(additionalProperties Union Fix):https://github.com/openapi-generators/openapi-python-client/pull/273/commits/a3653842a0ec0efe89669f0dc2f7572d8522e017
a365384https://github.com/openapi-generators/openapi-python-client/pull/273/commits/a3653842a0ec0efe89669f0dc2f7572d8522e017
https://github.com/dbanty
Merge branch 'main' into issue-266https://github.com/openapi-generators/openapi-python-client/pull/273/commits/d7e4b347cc3fc1399f95c513e446385096af81c7
d7e4b34https://github.com/openapi-generators/openapi-python-client/pull/273/commits/d7e4b347cc3fc1399f95c513e446385096af81c7
https://github.com/dbanty
Run isort, fix unit testhttps://github.com/openapi-generators/openapi-python-client/pull/273/commits/8a1bef36ae4995f7fb56fb2fcc90fb61c895b630
8a1bef3https://github.com/openapi-generators/openapi-python-client/pull/273/commits/8a1bef36ae4995f7fb56fb2fcc90fb61c895b630
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Dec 20, 2020https://github.com/openapi-generators/openapi-python-client/pull/273#issuecomment-748641564
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/273
Codecovhttps://codecov.io/gh/triaxtec/openapi-python-client/pull/273?src=pr&el=h1
#273https://codecov.io/gh/triaxtec/openapi-python-client/pull/273?src=pr&el=desc
397d655https://github.com/openapi-generators/openapi-python-client/commit/397d655c03143134d8fd2242aeb4811ea3d95a4d
mainhttps://codecov.io/gh/triaxtec/openapi-python-client/commit/e2d6e273af05e4124c6d83de4e57e375c7012211?el=desc
e2d6e27https://github.com/openapi-generators/openapi-python-client/commit/e2d6e273af05e4124c6d83de4e57e375c7012211
https://codecov.io/gh/triaxtec/openapi-python-client/pull/273?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/triaxtec/openapi-python-client/pull/273?src=pr&el=tree
openapi_python_client/__init__.pyhttps://codecov.io/gh/triaxtec/openapi-python-client/pull/273/diff?src=pr&el=tree#diff-b3BlbmFwaV9weXRob25fY2xpZW50L19faW5pdF9fLnB5
...penapi_python_client/parser/properties/__init__.pyhttps://codecov.io/gh/triaxtec/openapi-python-client/pull/273/diff?src=pr&el=tree#diff-b3BlbmFwaV9weXRob25fY2xpZW50L3BhcnNlci9wcm9wZXJ0aWVzL19faW5pdF9fLnB5
...penapi_python_client/parser/properties/property.pyhttps://codecov.io/gh/triaxtec/openapi-python-client/pull/273/diff?src=pr&el=tree#diff-b3BlbmFwaV9weXRob25fY2xpZW50L3BhcnNlci9wcm9wZXJ0aWVzL3Byb3BlcnR5LnB5
Continue to review full report at Codecovhttps://codecov.io/gh/triaxtec/openapi-python-client/pull/273?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/triaxtec/openapi-python-client/pull/273?src=pr&el=footer
e2d6e27...397d655https://codecov.io/gh/triaxtec/openapi-python-client/pull/273?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/273
https://github.com/dbanty
dbantyhttps://github.com/dbanty
Dec 20, 2020 https://github.com/openapi-generators/openapi-python-client/pull/273#ref-pullrequest-768264438
bugfix: correct indentation of additionalProperties that are union types #266 #268 https://github.com/openapi-generators/openapi-python-client/pull/268
https://github.com/dbanty
dbantyhttps://github.com/dbanty
December 20, 2020 18:18https://github.com/openapi-generators/openapi-python-client/pull/273#event-4133547587
https://github.com/dbanty
dbantyhttps://github.com/dbanty
emannhttps://github.com/emann
December 20, 2020 18:19https://github.com/openapi-generators/openapi-python-client/pull/273#event-4133547785
https://github.com/dbanty
dbantyhttps://github.com/dbanty
0.7.3https://github.com/openapi-generators/openapi-python-client/milestone/17
Dec 20, 2020https://github.com/openapi-generators/openapi-python-client/pull/273#event-4133555010
https://github.com/emann
emannhttps://github.com/emann
Dec 21, 2020 https://github.com/openapi-generators/openapi-python-client/pull/273#pullrequestreview-556536099
View reviewed changes https://github.com/openapi-generators/openapi-python-client/pull/273/files/8a1bef36ae4995f7fb56fb2fcc90fb61c895b630
emannhttps://github.com/emann
https://github.com/openapi-generators/openapi-python-client/pull/273#pullrequestreview-556536099
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/273
openapi_python_client/parser/properties/__init__.pyhttps://github.com/openapi-generators/openapi-python-client/pull/273/files/8a1bef36ae4995f7fb56fb2fcc90fb61c895b630#diff-61e8ac1a0d02be37f61e720be24f89c399fc6325938adfe140017e45198dc241
emannhttps://github.com/emann
Dec 21, 2020https://github.com/openapi-generators/openapi-python-client/pull/273#discussion_r546827222
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/273
dbantyhttps://github.com/dbanty
Dec 21, 2020https://github.com/openapi-generators/openapi-python-client/pull/273#discussion_r546830835
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/273
emannhttps://github.com/emann
Dec 21, 2020https://github.com/openapi-generators/openapi-python-client/pull/273#discussion_r546834410
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/273
https://github.com/dbanty
Merge branch 'main' into issue-266https://github.com/openapi-generators/openapi-python-client/pull/273/commits/397d655c03143134d8fd2242aeb4811ea3d95a4d
397d655https://github.com/openapi-generators/openapi-python-client/pull/273/commits/397d655c03143134d8fd2242aeb4811ea3d95a4d
https://github.com/dbanty
dbantyhttps://github.com/dbanty
20eed9ehttps://github.com/openapi-generators/openapi-python-client/commit/20eed9edfca70997b5048d39bbce877488974115
Dec 21, 2020https://github.com/openapi-generators/openapi-python-client/pull/273#event-4137060643
https://github.com/dbanty
dbantyhttps://github.com/dbanty
December 21, 2020 18:00https://github.com/openapi-generators/openapi-python-client/pull/273#event-4137060730
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fpull%2F273
https://github.com/emann
emann https://github.com/emann
https://github.com/openapi-generators/openapi-python-client/pull/273/files/8a1bef36ae4995f7fb56fb2fcc90fb61c895b630
0.7.3 https://github.com/openapi-generators/openapi-python-client/milestone/17
Invalid python generated when using nested dictionaries https://github.com/openapi-generators/openapi-python-client/issues/266
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/pull/273
https://github.com/dbanty
https://github.com/emann
https://github.com/packyg
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.