René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Endpoints with hyphens in parameter names trigger `Incorrect path templating` warning, are not generated","articleBody":"**Describe the bug**\r\n\r\n`openapi-python-client` fails to generate endpoints and throws `incorrect path templating` warnings when the path has a parameter with a hyphen.\r\n\r\nRenaming the parameters fixes the issue. Hyphens in parameter names don't seem to go against Swagger/OpenAPI naming conventions, which would indicate that the issue is with `openapi-python-client`, though I haven't found any existing issues around this.\r\n\r\n**OpenAPI Spec File**\r\n\r\nThis is from an OpenAPI spec generated from [a Swagger spec](https://codeberg.org/swagger.v1.json) with [swagger-converter](https://github.com/swagger-api/swagger-converter). \r\n\r\n```\r\n  \"paths\": {\r\n    \"/activitypub/user-id/{user-id}\":\r\n      \"get\": {\r\n        \"parameters\": [\r\n          {\r\n            \"name\": \"user-id\",\r\n            ...\r\n          }\r\n        ],\r\n        ...\r\n      }\r\n    },\r\n    \"/activitypub/user-id/{user-id}/inbox\": {\r\n      \"post\": {\r\n        \"parameters\": [\r\n          {\r\n            \"name\": \"user-id\",\r\n            ...\r\n          }\r\n        ],\r\n        ...\r\n      }\r\n    },\r\n  ...\r\n  }\r\n```\r\n\r\n**Desktop (please complete the following information):**\r\n - OS: Linux Manjaro\r\n - Python Version: 3.12.2\r\n - openapi-python-client version: 0.17.3\r\n\r\n**Additional context**\r\n\r\nWarnings:\r\n\r\n```\r\nWARNING parsing GET /activitypub/user-id/{user-id} within activitypub. Endpoint will not be generated.\r\nIncorrect path templating for /activitypub/user-id/{user-id} (Path parameters do not match with path)\r\n\r\nWARNING parsing POST /activitypub/user-id/{user-id}/inbox within activitypub. Endpoint will not be generated.\r\nIncorrect path templating for /activitypub/user-id/{user-id}/inbox (Path parameters do not match with path)\r\n```\r\n\r\nTo diagnose, I added the following print statements to `parser/openapi.py`:\r\n\r\n```python\r\n    def sort_parameters(*, endpoint: \"Endpoint\") -\u003e Union[\"Endpoint\", ParseError]:\r\n        # ...\r\n        print(endpoint.name, endpoint.path)                                                   # \u003c- new\r\n        print(f'\\tparameters_from_path: {parameters_from_path}')                              # \u003c- new\r\n        print(f'\\tendpoint {endpoint.name}.path_parameters: {endpoint.path_parameters}')      # \u003c- new\r\n\r\n        if parameters_from_path != [param.name for param in endpoint.path_parameters]:\r\n            return ParseError(\r\n                detail=f\"Incorrect path templating for {endpoint.path} (Path parameters do not match with path)\",\r\n            )\r\n        return endpoint\r\n```\r\n\r\nFor comparison, replacing one of the `user-id` occurrences with `userid` and generating a client yields this:\r\n\r\n```\r\n('activitypubPerson /activitypub/user-id/{userid}'\r\n \"      parameters_from_path: ['userid']\"\r\n \"      endpoint activitypubPerson.path_parameters: [IntProperty(name='userid', \"\r\n \"required=True, default=None, python_name='userid', description=None, \"\r\n 'example=None)]'\r\n 'activitypubPersonInbox /activitypub/user-id/{user-id}/inbox'\r\n '      parameters_from_path: []'\r\n '      endpoint activitypubPersonInbox.path_parameters: '\r\n \"[IntProperty(name='user-id', required=True, default=None, \"\r\n \"python_name='user_id', description=None, example=None)]\"\r\n ...\r\n)\r\n```","author":{"url":"https://github.com/harabat","@type":"Person","name":"harabat"},"datePublished":"2024-02-22T16:54:22.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/976/openapi-python-client/issues/976"}