René's URL Explorer Experiment


Title: Invalid python generated when using nested dictionaries · Issue #266 · openapi-generators/openapi-python-client · GitHub

Open Graph Title: Invalid python generated when using nested dictionaries · Issue #266 · openapi-generators/openapi-python-client

X Title: Invalid python generated when using nested dictionaries · Issue #266 · openapi-generators/openapi-python-client

Description: Describe the bug Using openapi-python-client on a valid FastAPI/pydantic API is generating invalid client library on 0.7.2 when there is a somewhat complex set of nested Dict and Union types. To Reproduce Put the following in a main.py f...

Open Graph Description: Describe the bug Using openapi-python-client on a valid FastAPI/pydantic API is generating invalid client library on 0.7.2 when there is a somewhat complex set of nested Dict and Union types. To Re...

X Description: Describe the bug Using openapi-python-client on a valid FastAPI/pydantic API is generating invalid client library on 0.7.2 when there is a somewhat complex set of nested Dict and Union types. To Re...

Opengraph URL: https://github.com/openapi-generators/openapi-python-client/issues/266

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Invalid python generated when using nested dictionaries","articleBody":"**Describe the bug**\r\nUsing `openapi-python-client` on a valid FastAPI/pydantic API is generating invalid client library on 0.7.2 when there is a somewhat complex set of nested `Dict` and `Union` types.\r\n\r\n**To Reproduce**\r\nPut the following in a main.py\r\n```\r\nfrom typing import Any, Dict, List, Union\r\nfrom fastapi import FastAPI\r\nfrom pydantic import (\r\n    BaseModel,\r\n    StrictBool,\r\n    StrictInt,\r\n    StrictFloat,\r\n    StrictStr,\r\n)\r\n\r\napp = FastAPI()\r\n\r\nJSONValue = Union[\r\n    Dict[str, Any], List[Any], StrictBool, StrictFloat, StrictInt, StrictStr, None\r\n]\r\nJSONDict = Dict[str, JSONValue]\r\n\r\nclass ItemMapResource(BaseModel):\r\n    items: JSONDict\r\n\r\n@app.get(\"/\", response_model=ItemMapResource)\r\ndef read_item():\r\n    return ItemMapResource(items={})\r\n```\r\n\r\nRun it like this:\r\n```\r\n uvicorn main:app --reload --port 4000\r\n```\r\n\r\nGenerate a client library like this\r\n```\r\nopenapi-python-client generate --url  http://localhost:4000/openapi.json\r\n```\r\n\r\n**Expected behavior**\r\nShould generate valid python library\r\n\r\n**Actual behavior**\r\nGenerates code with broken indents which fails to execute:\r\n```\r\n@attr.s(auto_attribs=True)\r\nclass ItemMapResourceItems:\r\n    \"\"\"  \"\"\"\r\n    additional_properties: Dict[str, Union[ItemMapResourceItemsAdditionalProperty, List[None], bool, float, int, str]] = attr.ib(init=False, factory=dict)\r\n\r\n\r\n    def to_dict(self) -\u003e Dict[str, Any]:\r\n\r\n        field_dict: Dict[str, Any] = {}\r\n        for prop_name, prop in self.additional_properties.items():\r\n            if isinstance(prop, ItemMapResourceItemsAdditionalProperty):\r\n        field_dict[prop_name] = prop.to_dict()\r\n\r\n    elif isinstance(prop, List[None]):\r\n        field_dict[prop_name] = []\r\n        for additional_property_item_data in prop:\r\n            additional_property_item =  None\r\n\r\n            field_dict[prop_name].append(additional_property_item)\r\n\r\n\r\n\r\n\r\n    elif isinstance(prop, bool):\r\n        field_dict[prop_name] = prop\r\n    elif isinstance(prop, float):\r\n        field_dict[prop_name] = prop\r\n    elif isinstance(prop, int):\r\n        field_dict[prop_name] = prop\r\n    else:\r\n        field_dict[prop_name] = prop\r\n\r\n        field_dict.update({\r\n        })\r\n\r\n        return field_dict\r\n\r\n```\r\nNote the line `if isinstance(prop, ItemMapResourceItemsAdditionalProperty):` is indented incorrectly.\r\n\r\n\r\n\r\n**OpenAPI Spec File**\r\n```\r\n{\"openapi\":\"3.0.2\",\"info\":{\"title\":\"FastAPI\",\"version\":\"0.1.0\"},\"paths\":{\"/\":{\"get\":{\"summary\":\"Read Item\",\"operationId\":\"read_item__get\",\"responses\":{\"200\":{\"description\":\"Successful Response\",\"content\":{\"application/json\":{\"schema\":{\"$ref\":\"#/components/schemas/ItemMapResource\"}}}}}}}},\"components\":{\"schemas\":{\"ItemMapResource\":{\"title\":\"ItemMapResource\",\"required\":[\"items\"],\"type\":\"object\",\"properties\":{\"items\":{\"title\":\"Items\",\"type\":\"object\",\"additionalProperties\":{\"anyOf\":[{\"type\":\"object\"},{\"type\":\"array\",\"items\":{}},{\"type\":\"boolean\"},{\"type\":\"number\"},{\"type\":\"integer\"},{\"type\":\"string\"}]}}}}}}}\r\n```\r\n\r\n**Desktop (please complete the following information):**\r\n - OS: Ubuntu 20.04\r\n - Python Version: 3.8.3\r\n - openapi-python-client version 0.7.2\r\n\r\n**Additional context**\r\nThis worked fine with 0.7.0, so I suspect a regression from #252 ","author":{"url":"https://github.com/joshzana","@type":"Person","name":"joshzana"},"datePublished":"2020-12-15T01:06:45.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/266/openapi-python-client/issues/266"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3fe7db1c-d2b6-6bdc-7849-5664536723bf
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD83C:684C3:38C839:4A7386:6980092D
html-safe-noncee23ca40de4503be3af80bc00baaa541b2003d34f42b469fcecde078cfdd241f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODNDOjY4NEMzOjM4QzgzOTo0QTczODY6Njk4MDA5MkQiLCJ2aXNpdG9yX2lkIjoiMTUzMTUzMTg3NTc3MDY5ODAyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4a0f7d32fda019ef278eaf066a548da01f5c87aad6156a18e5aa74f0dda5a818
hovercard-subject-tagissue:767064858
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/openapi-generators/openapi-python-client/266/issue_layout
twitter:imagehttps://opengraph.githubassets.com/466dc66c3fafc2f67b90bb0abfe9774375a9be886fe5bd8628ed090782d00a83/openapi-generators/openapi-python-client/issues/266
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/466dc66c3fafc2f67b90bb0abfe9774375a9be886fe5bd8628ed090782d00a83/openapi-generators/openapi-python-client/issues/266
og:image:altDescribe the bug Using openapi-python-client on a valid FastAPI/pydantic API is generating invalid client library on 0.7.2 when there is a somewhat complex set of nested Dict and Union types. To Re...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoshzana
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
go-importgithub.com/openapi-generators/openapi-python-client git https://github.com/openapi-generators/openapi-python-client.git
octolytics-dimension-user_id84925606
octolytics-dimension-user_loginopenapi-generators
octolytics-dimension-repository_id240776275
octolytics-dimension-repository_nwoopenapi-generators/openapi-python-client
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id240776275
octolytics-dimension-repository_network_root_nwoopenapi-generators/openapi-python-client
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/openapi-generators/openapi-python-client/issues/266#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2F266
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fopenapi-generators%2Fopenapi-python-client%2Fissues%2F266
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=openapi-generators%2Fopenapi-python-client
Reloadhttps://github.com/openapi-generators/openapi-python-client/issues/266
Reloadhttps://github.com/openapi-generators/openapi-python-client/issues/266
Reloadhttps://github.com/openapi-generators/openapi-python-client/issues/266
openapi-generators https://github.com/openapi-generators
openapi-python-clienthttps://github.com/openapi-generators/openapi-python-client
Please reload this pagehttps://github.com/openapi-generators/openapi-python-client/issues/266
Notifications https://github.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Fork 264 https://github.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Star 1.9k https://github.com/login?return_to=%2Fopenapi-generators%2Fopenapi-python-client
Code https://github.com/openapi-generators/openapi-python-client
Issues 77 https://github.com/openapi-generators/openapi-python-client/issues
Pull requests 14 https://github.com/openapi-generators/openapi-python-client/pulls
Discussions https://github.com/openapi-generators/openapi-python-client/discussions
Actions https://github.com/openapi-generators/openapi-python-client/actions
Security 2 https://github.com/openapi-generators/openapi-python-client/security
Insights https://github.com/openapi-generators/openapi-python-client/pulse
Code https://github.com/openapi-generators/openapi-python-client
Issues https://github.com/openapi-generators/openapi-python-client/issues
Pull requests https://github.com/openapi-generators/openapi-python-client/pulls
Discussions https://github.com/openapi-generators/openapi-python-client/discussions
Actions https://github.com/openapi-generators/openapi-python-client/actions
Security https://github.com/openapi-generators/openapi-python-client/security
Insights https://github.com/openapi-generators/openapi-python-client/pulse
New issuehttps://github.com/login?return_to=https://github.com/openapi-generators/openapi-python-client/issues/266
New issuehttps://github.com/login?return_to=https://github.com/openapi-generators/openapi-python-client/issues/266
#273https://github.com/openapi-generators/openapi-python-client/pull/273
Invalid python generated when using nested dictionarieshttps://github.com/openapi-generators/openapi-python-client/issues/266#top
#273https://github.com/openapi-generators/openapi-python-client/pull/273
🐞bugSomething isn't workinghttps://github.com/openapi-generators/openapi-python-client/issues?q=state%3Aopen%20label%3A%22%F0%9F%90%9Ebug%22
0.7.3https://github.com/openapi-generators/openapi-python-client/milestone/17
https://github.com/joshzana
https://github.com/joshzana
joshzanahttps://github.com/joshzana
on Dec 15, 2020https://github.com/openapi-generators/openapi-python-client/issues/266#issue-767064858
#252https://github.com/openapi-generators/openapi-python-client/pull/252
🐞bugSomething isn't workinghttps://github.com/openapi-generators/openapi-python-client/issues?q=state%3Aopen%20label%3A%22%F0%9F%90%9Ebug%22
0.7.3https://github.com/openapi-generators/openapi-python-client/milestone/17
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.