René's URL Explorer Experiment


Title: refactor: share the Go-type and lowered-type walks the aggregate code grew by mromaszewicz · Pull Request #2592 · oapi-codegen/oapi-codegen · GitHub

Open Graph Title: refactor: share the Go-type and lowered-type walks the aggregate code grew by mromaszewicz · Pull Request #2592 · oapi-codegen/oapi-codegen

X Title: refactor: share the Go-type and lowered-type walks the aggregate code grew by mromaszewicz · Pull Request #2592 · oapi-codegen/oapi-codegen

Description: Generate Go client and server boilerplate from OpenAPI 3 specifications - refactor: share the Go-type and lowered-type walks the aggregate code grew by mromaszewicz · Pull Request #2592 · oapi-codegen/oapi-codegen

Open Graph Description: What was wrong. A review of the allOf/anyOf/oneOf code after #2514, #2589 and #2591 found the same two walks written several times over: Four functions in four files parsed a Go type expression wi...

X Description: What was wrong. A review of the allOf/anyOf/oneOf code after #2514, #2589 and #2591 found the same two walks written several times over: Four functions in four files parsed a Go type expression wi...

Opengraph URL: https://github.com/oapi-codegen/oapi-codegen/pull/2592

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7af9c425-c8ae-ca5a-6882-807120df410c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE02C:19D56D:2EAB409:3D12FC4:6AF9C944
html-safe-noncebe4ae7d44b8738fb35d6a282caacec043daa7d2294c59405145c4b7dfc254718
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDJDOjE5RDU2RDoyRUFCNDA5OjNEMTJGQzQ6NkFGOUM5NDQiLCJ2aXNpdG9yX2lkIjoiMzcwNDU1NjkwODMyNTc1MTEwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0559e8b513244d7584589d71b48d856f01bdd3bdc4b338eed8e7bf93a8b566ca
hovercard-subject-tagpull_request:4672417077
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/oapi-codegen/oapi-codegen/2592/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b56ec49968571268ec4320dac448f5a919551cb12452119cae19dc2a62890503/oapi-codegen/oapi-codegen/pull/2592
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b56ec49968571268ec4320dac448f5a919551cb12452119cae19dc2a62890503/oapi-codegen/oapi-codegen/pull/2592
og:image:altWhat was wrong. A review of the allOf/anyOf/oneOf code after #2514, #2589 and #2591 found the same two walks written several times over: Four functions in four files parsed a Go type expression wi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemromaszewicz
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-cache
go-importgithub.com/oapi-codegen/oapi-codegen git https://github.com/oapi-codegen/oapi-codegen.git
octolytics-dimension-user_id142752710
octolytics-dimension-user_loginoapi-codegen
octolytics-dimension-repository_id173009358
octolytics-dimension-repository_nwooapi-codegen/oapi-codegen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id173009358
octolytics-dimension-repository_network_root_nwooapi-codegen/oapi-codegen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/oapi-codegen/oapi-codegen/pull/2592#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foapi-codegen%2Foapi-codegen%2Fpull%2F2592
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foapi-codegen%2Foapi-codegen%2Fpull%2F2592
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=oapi-codegen%2Foapi-codegen
Reloadhttps://github.com/oapi-codegen/oapi-codegen/pull/2592
Reloadhttps://github.com/oapi-codegen/oapi-codegen/pull/2592
Reloadhttps://github.com/oapi-codegen/oapi-codegen/pull/2592
oapi-codegenhttps://github.com/oapi-codegen
oapi-codegenhttps://github.com/oapi-codegen/oapi-codegen
Codehttps://github.com/oapi-codegen/oapi-codegen
Issues228 (228)https://github.com/oapi-codegen/oapi-codegen/issues
Pull requests70 (70)https://github.com/oapi-codegen/oapi-codegen/pulls
Discussionshttps://github.com/oapi-codegen/oapi-codegen/discussions
Actionshttps://github.com/oapi-codegen/oapi-codegen/actions
Projectshttps://github.com/oapi-codegen/oapi-codegen/projects
Security and quality11 (11)https://github.com/oapi-codegen/oapi-codegen/security
Insightshttps://github.com/oapi-codegen/oapi-codegen/pulse
https://github.com/oapi-codegen/oapi-codegen
mromaszewiczhttps://github.com/mromaszewicz
oapi-codegen:mainhttps://github.com/oapi-codegen/oapi-codegen/tree/main
mromaszewicz:refactor/aggregate-shared-helpershttps://github.com/mromaszewicz/oapi-codegen/tree/refactor/aggregate-shared-helpers
Conversationhttps://github.com/oapi-codegen/oapi-codegen/pull/2592
Commits4 (4)https://github.com/oapi-codegen/oapi-codegen/pull/2592/commits
Checkshttps://github.com/oapi-codegen/oapi-codegen/pull/2592/checks
Files changedhttps://github.com/oapi-codegen/oapi-codegen/pull/2592/files
refactor: share the Go-type and lowered-type walks the aggregate code grewhttps://github.com/oapi-codegen/oapi-codegen/pull/2592#top
mromaszewiczhttps://github.com/mromaszewicz
oapi-codegen:mainhttps://github.com/oapi-codegen/oapi-codegen/tree/main
mromaszewicz:refactor/aggregate-shared-helpershttps://github.com/mromaszewicz/oapi-codegen/tree/refactor/aggregate-shared-helpers
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
Sep 29, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2592#issue-5624960692
#2514https://github.com/oapi-codegen/oapi-codegen/pull/2514
#2589https://github.com/oapi-codegen/oapi-codegen/pull/2589
#2591https://github.com/oapi-codegen/oapi-codegen/pull/2591
fix: lower a v1 allOf of a non-object $ref to the member's type #2591https://github.com/oapi-codegen/oapi-codegen/pull/2591
fix: lower a v1 allOf of a non-object $ref to the member's type #2591https://github.com/oapi-codegen/oapi-codegen/pull/2591
Claude Codehttps://claude.com/claude-code
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2592
mromaszewiczhttps://github.com/mromaszewicz
September 28, 2026 20:56https://github.com/oapi-codegen/oapi-codegen/pull/2592#commits-pushed-b496ddd
https://github.com/mromaszewicz
https://github.com/claude
refactor: read Go type expressions in one placehttps://github.com/oapi-codegen/oapi-codegen/pull/2592/commits/b496ddd6a812f594fd7d82a4704842346cf70d53
b496dddhttps://github.com/oapi-codegen/oapi-codegen/pull/2592/commits/b496ddd6a812f594fd7d82a4704842346cf70d53
https://github.com/mromaszewicz
https://github.com/claude
refactor: find the schema a type was lowered from in one placehttps://github.com/oapi-codegen/oapi-codegen/pull/2592/commits/e9fac87f2a579c657b9ec9e11c79a7cbdb8bae8b
e9fac87https://github.com/oapi-codegen/oapi-codegen/pull/2592/commits/e9fac87f2a579c657b9ec9e11c79a7cbdb8bae8b
https://github.com/mromaszewicz
https://github.com/claude
refactor: remove GenStructFromAllOf, which nothing callshttps://github.com/oapi-codegen/oapi-codegen/pull/2592/commits/210e71a08a8b12718a8c03f4bb91441bc38cb44f
210e71ahttps://github.com/oapi-codegen/oapi-codegen/pull/2592/commits/210e71a08a8b12718a8c03f4bb91441bc38cb44f
oapi-codegen#2591https://github.com/oapi-codegen/oapi-codegen/pull/2591
https://github.com/mromaszewicz
https://github.com/claude
docs: say once why v2 unions nullability, and what v1 does with a sol…https://github.com/oapi-codegen/oapi-codegen/pull/2592/commits/45e12d810300f256e4b883a5e7666e8c4ed526eb
45e12d8https://github.com/oapi-codegen/oapi-codegen/pull/2592/commits/45e12d810300f256e4b883a5e7666e8c4ed526eb
oapi-codegen#2591https://github.com/oapi-codegen/oapi-codegen/pull/2591
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
code ownerhttps://github.com/oapi-codegen/oapi-codegen/blob/a157c2a65f2ba3282ae0ca9a36d8d1f0195d2c5f/.github/CODEOWNERS#L1
September 29, 2026 04:10https://github.com/oapi-codegen/oapi-codegen/pull/2592#event-32048774163
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
internal https://github.com/oapi-codegen/oapi-codegen/issues?q=state%3Aopen%20label%3Ainternal
Sep 29, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2592#event-32048774710
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
Sep 29, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2592#issuecomment-5883512049
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2592
https://app.greptile.com/api/retrigger?id=71108737
https://camo.githubusercontent.com/a7b9b99cff6cd0a6855cb4831e99f3dd0f330f004037ba802705f870a0acdf4e/68747470733a2f2f6772657074696c652d7374617469632d6173736574732e73332e616d617a6f6e6177732e636f6d2f6261646765732f70312e7376673f763d39
▶https://github.com/oapi-codegen/oapi-codegen/pull/2592#discussion_r4129555014
"docs: say once why v2 unions nullability..."https://github.com/oapi-codegen/oapi-codegen/commit/45e12d810300f256e4b883a5e7666e8c4ed526eb
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2592
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
Sep 29, 2026 https://github.com/oapi-codegen/oapi-codegen/pull/2592#pullrequestreview-5347625529
View reviewed changes https://github.com/oapi-codegen/oapi-codegen/pull/2592/files/45e12d810300f256e4b883a5e7666e8c4ed526eb
pkg/codegen/merge_schemas_v1.gohttps://github.com/oapi-codegen/oapi-codegen/pull/2592/files/45e12d810300f256e4b883a5e7666e8c4ed526eb#diff-33dd77614698d0c75b8f61c7c54d4a4dda46ea967580e479d07fb7c0c010acf9
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2592
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
83e2818https://github.com/oapi-codegen/oapi-codegen/commit/83e2818bbeb78a6a886678d2443b256cd9328f16
Sep 29, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2592#event-32049864701
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2592
https://github.co/hiddenchars
https://github.com/oapi-codegen/oapi-codegen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foapi-codegen%2Foapi-codegen%2Fpull%2F2592
https://github.com/apps/greptile-apps
greptile-apps[bot] https://github.com/apps/greptile-apps
https://github.com/oapi-codegen/oapi-codegen/pull/2592/files/45e12d810300f256e4b883a5e7666e8c4ed526eb
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2592
internal https://github.com/oapi-codegen/oapi-codegen/issues?q=state%3Aopen%20label%3Ainternal
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2592
https://github.com/mromaszewicz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.