René's URL Explorer Experiment


Title: refactor: remove duplication in the allOf and union code by mromaszewicz · Pull Request #2584 · oapi-codegen/oapi-codegen · GitHub

Open Graph Title: refactor: remove duplication in the allOf and union code by mromaszewicz · Pull Request #2584 · oapi-codegen/oapi-codegen

X Title: refactor: remove duplication in the allOf and union code by mromaszewicz · Pull Request #2584 · oapi-codegen/oapi-codegen

Description: Generate Go client and server boilerplate from OpenAPI 3 specifications - refactor: remove duplication in the allOf and union code by mromaszewicz · Pull Request #2584 · oapi-codegen/oapi-codegen

Open Graph Description: A cleanup of the allOf and union code after the schema-merging-behavior work (#2562 to #2580). v3 began as a copy of v2 (#2564), and each later PR changed one part of it. So some code stayed duplic...

X Description: A cleanup of the allOf and union code after the schema-merging-behavior work (#2562 to #2580). v3 began as a copy of v2 (#2564), and each later PR changed one part of it. So some code stayed duplic...

Opengraph URL: https://github.com/oapi-codegen/oapi-codegen/pull/2584

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:252225dd-ac88-fea1-c019-ec4faa9c8737
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC336:AC868:2D9602D:3BE21B4:6AF9C9BE
html-safe-noncea2d57ecb73891c30f0edb309681e5f7076165eaf63cb19e8bffbf4e5e6920cd1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzM2OkFDODY4OjJEOTYwMkQ6M0JFMjFCNDo2QUY5QzlCRSIsInZpc2l0b3JfaWQiOiI4NjI0ODA2OTQwODA0NDk5OTAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0e5e07f12f8d1f11c67fe9598e92bd8c7f3bdcfaede8cd60c21aed45b8561aa6
hovercard-subject-tagpull_request:4645135530
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/oapi-codegen/oapi-codegen/2584/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2b6236d335121bdce9231cf01d3449fc170572a3d49c1d8d571c573e1b282f9f/oapi-codegen/oapi-codegen/pull/2584
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2b6236d335121bdce9231cf01d3449fc170572a3d49c1d8d571c573e1b282f9f/oapi-codegen/oapi-codegen/pull/2584
og:image:altA cleanup of the allOf and union code after the schema-merging-behavior work (#2562 to #2580). v3 began as a copy of v2 (#2564), and each later PR changed one part of it. So some code stayed duplic...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemromaszewicz
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-cache
go-importgithub.com/oapi-codegen/oapi-codegen git https://github.com/oapi-codegen/oapi-codegen.git
octolytics-dimension-user_id142752710
octolytics-dimension-user_loginoapi-codegen
octolytics-dimension-repository_id173009358
octolytics-dimension-repository_nwooapi-codegen/oapi-codegen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id173009358
octolytics-dimension-repository_network_root_nwooapi-codegen/oapi-codegen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/oapi-codegen/oapi-codegen/pull/2584#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foapi-codegen%2Foapi-codegen%2Fpull%2F2584
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foapi-codegen%2Foapi-codegen%2Fpull%2F2584
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=oapi-codegen%2Foapi-codegen
Reloadhttps://github.com/oapi-codegen/oapi-codegen/pull/2584
Reloadhttps://github.com/oapi-codegen/oapi-codegen/pull/2584
Reloadhttps://github.com/oapi-codegen/oapi-codegen/pull/2584
oapi-codegenhttps://github.com/oapi-codegen
oapi-codegenhttps://github.com/oapi-codegen/oapi-codegen
Codehttps://github.com/oapi-codegen/oapi-codegen
Issues228 (228)https://github.com/oapi-codegen/oapi-codegen/issues
Pull requests70 (70)https://github.com/oapi-codegen/oapi-codegen/pulls
Discussionshttps://github.com/oapi-codegen/oapi-codegen/discussions
Actionshttps://github.com/oapi-codegen/oapi-codegen/actions
Projectshttps://github.com/oapi-codegen/oapi-codegen/projects
Security and quality11 (11)https://github.com/oapi-codegen/oapi-codegen/security
Insightshttps://github.com/oapi-codegen/oapi-codegen/pulse
https://github.com/oapi-codegen/oapi-codegen
mromaszewiczhttps://github.com/mromaszewicz
oapi-codegen:mainhttps://github.com/oapi-codegen/oapi-codegen/tree/main
mromaszewicz:refactor/v3-dedupehttps://github.com/mromaszewicz/oapi-codegen/tree/refactor/v3-dedupe
Conversationhttps://github.com/oapi-codegen/oapi-codegen/pull/2584
Commits9 (9)https://github.com/oapi-codegen/oapi-codegen/pull/2584/commits
Checkshttps://github.com/oapi-codegen/oapi-codegen/pull/2584/checks
Files changedhttps://github.com/oapi-codegen/oapi-codegen/pull/2584/files
refactor: remove duplication in the allOf and union codehttps://github.com/oapi-codegen/oapi-codegen/pull/2584#top
mromaszewiczhttps://github.com/mromaszewicz
oapi-codegen:mainhttps://github.com/oapi-codegen/oapi-codegen/tree/main
mromaszewicz:refactor/v3-dedupehttps://github.com/mromaszewicz/oapi-codegen/tree/refactor/v3-dedupe
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
Sep 26, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2584#issue-5591570571
#2562https://github.com/oapi-codegen/oapi-codegen/pull/2562
#2580https://github.com/oapi-codegen/oapi-codegen/pull/2580
#2564https://github.com/oapi-codegen/oapi-codegen/pull/2564
v2.8.0 regression: infinite recursion / stack overflow on self-referential allOf+anyOf schemas (side effect of #1904/#1905) #2542https://github.com/oapi-codegen/oapi-codegen/issues/2542
fix: keep a strict response's MarshalJSON behind allOf: [$ref X] #2575https://github.com/oapi-codegen/oapi-codegen/pull/2575
#2582https://github.com/oapi-codegen/oapi-codegen/pull/2582
Claude Codehttps://claude.com/claude-code
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2584
mromaszewiczhttps://github.com/mromaszewicz
September 25, 2026 22:09https://github.com/oapi-codegen/oapi-codegen/pull/2584#commits-pushed-72184d8
https://github.com/mromaszewicz
https://github.com/claude
refactor: one sameSchema for schema-merging-behavior v2 and v3https://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/72184d8df27ec4bf667e65a19b35596e8e74817f
72184d8https://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/72184d8df27ec4bf667e65a19b35596e8e74817f
https://github.com/mromaszewicz
https://github.com/claude
refactor: share the allOf recursion and alias bookkeeping between v2 …https://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/a53f5cd7d9b0c4b7fba899813d0ac92fc7498824
a53f5cdhttps://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/a53f5cd7d9b0c4b7fba899813d0ac92fc7498824
oapi-codegen#2542https://github.com/oapi-codegen/oapi-codegen/issues/2542
https://github.com/mromaszewicz
https://github.com/claude
refactor: share the nullable-union collapse between v2 and v3, in uni…https://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/1394c8d590d1f49f3a5d19d325b3ea38747db02d
1394c8dhttps://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/1394c8d590d1f49f3a5d19d325b3ea38747db02d
https://github.com/mromaszewicz
https://github.com/claude
refactor: drop dead code and constant parameters from the allOf and u…https://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/cdebecca137813aa80216b31c94379410061afa4
cdebecchttps://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/cdebecca137813aa80216b31c94379410061afa4
https://github.com/mromaszewicz
https://github.com/claude
refactor: drop the V2/V3 suffix from one-version allOf and union helpershttps://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/3279909560cf9041c0e3bbea6984d7b43641ff99
3279909https://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/3279909560cf9041c0e3bbea6984d7b43641ff99
oapi-codegen#2563https://github.com/oapi-codegen/oapi-codegen/pull/2563
oapi-codegen#2564https://github.com/oapi-codegen/oapi-codegen/pull/2564
https://github.com/mromaszewicz
https://github.com/claude
refactor: one union.stamp template for the From* and Merge* discrimin…https://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/1a18879e8e3b26c2ae8255b7ce356fddc2b3f206
1a18879https://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/1a18879e8e3b26c2ae8255b7ce356fddc2b3f206
https://github.com/mromaszewicz
https://github.com/claude
refactor(v3): walk allOf trees and alias chains with one iterator eachhttps://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/ca4b760e34101492bfe9cca81bb44f2a7b93747e
ca4b760https://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/ca4b760e34101492bfe9cca81bb44f2a7b93747e
https://github.com/mromaszewicz
https://github.com/claude
refactor: appendUnique for the append-unless-present idiomhttps://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/7cea014d93de55ae7c5b355bc9c0ab44a4937e9c
7cea014https://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/7cea014d93de55ae7c5b355bc9c0ab44a4937e9c
https://github.com/mromaszewicz
https://github.com/claude
docs: bring the allOf and union comments up to date with the codehttps://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/ca6169ec598767f4d4694596eeb92ab3af219b71
ca6169ehttps://github.com/oapi-codegen/oapi-codegen/pull/2584/commits/ca6169ec598767f4d4694596eeb92ab3af219b71
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
code ownerhttps://github.com/oapi-codegen/oapi-codegen/blob/77ce86c5f5fe00f8f68225acbaa0333c5aa68df1/.github/CODEOWNERS#L1
September 26, 2026 05:12https://github.com/oapi-codegen/oapi-codegen/pull/2584#event-31879872772
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
Sep 26, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2584#issuecomment-5843451803
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2584
https://app.greptile.com/api/retrigger?id=69784381
https://camo.githubusercontent.com/a7b9b99cff6cd0a6855cb4831e99f3dd0f330f004037ba802705f870a0acdf4e/68747470733a2f2f6772657074696c652d7374617469632d6173736574732e73332e616d617a6f6e6177732e636f6d2f6261646765732f70312e7376673f763d39
▶https://github.com/oapi-codegen/oapi-codegen/pull/2584#discussion_r4110285501
"docs: bring the allOf and union comments..."https://github.com/oapi-codegen/oapi-codegen/commit/ca6169ec598767f4d4694596eeb92ab3af219b71
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2584
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
Sep 26, 2026 https://github.com/oapi-codegen/oapi-codegen/pull/2584#pullrequestreview-5324708143
View reviewed changes https://github.com/oapi-codegen/oapi-codegen/pull/2584/files/ca6169ec598767f4d4694596eeb92ab3af219b71
pkg/codegen/merge_schemas.gohttps://github.com/oapi-codegen/oapi-codegen/pull/2584/files/ca6169ec598767f4d4694596eeb92ab3af219b71#diff-423bfd1d22f4994f4f0c03f76f15af8371bee0bc5da50efa3ab696e1a60d7d49
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2584
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
c51209bhttps://github.com/oapi-codegen/oapi-codegen/commit/c51209bf66f9bfb2b4106837cdc57a24d58773fe
Sep 26, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2584#event-31880026114
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2584
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
September 26, 2026 05:19https://github.com/oapi-codegen/oapi-codegen/pull/2584#event-31880034796
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
internal https://github.com/oapi-codegen/oapi-codegen/issues?q=state%3Aopen%20label%3Ainternal
Sep 26, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2584#event-31880048503
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
Sep 26, 2026 https://github.com/oapi-codegen/oapi-codegen/pull/2584#ref-pullrequest-5591653553
refactor: read the run's settings once, and pass v3's merge its inputs #2585 https://github.com/oapi-codegen/oapi-codegen/pull/2585
https://github.co/hiddenchars
https://github.com/oapi-codegen/oapi-codegen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foapi-codegen%2Foapi-codegen%2Fpull%2F2584
https://github.com/apps/greptile-apps
greptile-apps[bot] https://github.com/apps/greptile-apps
https://github.com/oapi-codegen/oapi-codegen/pull/2584/files/ca6169ec598767f4d4694596eeb92ab3af219b71
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2584
internal https://github.com/oapi-codegen/oapi-codegen/issues?q=state%3Aopen%20label%3Ainternal
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2584
https://github.com/mromaszewicz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.