René's URL Explorer Experiment

Title: fix: keep a strict response's MarshalJSON behind allOf: [$ref X] by mromaszewicz · Pull Request #2575 · oapi-codegen/oapi-codegen · GitHub

Open Graph Title: fix: keep a strict response's MarshalJSON behind allOf: [$ref X] by mromaszewicz · Pull Request #2575 · oapi-codegen/oapi-codegen

X Title: fix: keep a strict response's MarshalJSON behind allOf: [$ref X] by mromaszewicz · Pull Request #2575 · oapi-codegen/oapi-codegen

Description: In v2, a response whose schema is a single-member allOf: [$ref X] loses data when X has a generated MarshalJSON, which it has for additionalProperties or a union: Open: type: object properties: b: {type: string} additionalProperties: {type: string} Subject: allOf: - $ref: '#/components/schemas/Open' Subject generates as type Subject = Open. The strict server wraps the response in a defined type over it, type GetX200JSONResponse Subject, which has none of Open's methods. It therefore needs a delegating MarshalJSON (#2549). generatesMarshalJSON decides whether it gets one, and couldn't see through the alias. So the envelope had no delegating method, and {"b": "x", "k": "v"} went out as {"b": "x"}. This is a pre-existing bug, found while working on #2574. Fix generateAllOfV2 now records the type such a composition is an alias of, the same aliasOf that generateAllOfV3 sets since #2574, and generatesMarshalJSON follows it. This adds a MarshalJSON method to the affected envelopes and changes nothing else. make generate changes no committed file, so no fixture in the repository hit this. v1 is unaffected: it generates a struct that embeds Open, which already worked. Tests A new matrix shape, allof_single_ref_custom_json, runs under v1, v2 and v3. Before this fix, its v2 cell lost the additional properties at every request and response body position. All three cells now round-trip the sample. TestSingleRefAllOfKeepsCustomJSONV2 checks that the envelopes delegate, for both an additionalProperties target and a union target. 🤖 Generated with Claude Code

Open Graph Description: In v2, a response whose schema is a single-member allOf: [$ref X] loses data when X has a generated MarshalJSON, which it has for additionalProperties or a union: Open: type: object properties:...

X Description: In v2, a response whose schema is a single-member allOf: [$ref X] loses data when X has a generated MarshalJSON, which it has for additionalProperties or a union: Open: type: object properties:...

Opengraph URL: https://github.com/oapi-codegen/oapi-codegen/pull/2575

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width