René's URL Explorer Experiment


Title: fix: keep the properties an allOf member declares next to its own allOf by mromaszewicz · Pull Request #2571 · oapi-codegen/oapi-codegen · GitHub

Open Graph Title: fix: keep the properties an allOf member declares next to its own allOf by mromaszewicz · Pull Request #2571 · oapi-codegen/oapi-codegen

X Title: fix: keep the properties an allOf member declares next to its own allOf by mromaszewicz · Pull Request #2571 · oapi-codegen/oapi-codegen

Description: Generate Go client and server boilerplate from OpenAPI 3 specifications - fix: keep the properties an allOf member declares next to its own allOf by mromaszewicz · Pull Request #2571 · oapi-codegen/oapi-codegen

Open Graph Description: When an allOf member is itself a schema with an allOf, the v2 merge replaces the member with the merge of its allOf, which loses the properties it declares next to that allOf: Mid: type: object pro...

X Description: When an allOf member is itself a schema with an allOf, the v2 merge replaces the member with the merge of its allOf, which loses the properties it declares next to that allOf: Mid: type: object pro...

Opengraph URL: https://github.com/oapi-codegen/oapi-codegen/pull/2571

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ca17f793-3c08-b328-f02f-a9e3dfbe4ff6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97A4:3E754C:29A99EB:375AEC7:6AF9C750
html-safe-nonce1ed1047c3c2e1a03772a71f7ec75e77da4dfafcf0c23ed9e142eebb9abd620c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0E0OjNFNzU0QzoyOUE5OUVCOjM3NUFFQzc6NkFGOUM3NTAiLCJ2aXNpdG9yX2lkIjoiOTIzMTY5Mjc4OTQzNDE0MDk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacda1255a514251885eeaa5411a1294264121b72acf8107a2905d91dc84702721b
hovercard-subject-tagpull_request:4630615174
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/oapi-codegen/oapi-codegen/2571/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/da0a2660b85fd9ed9206253ec1e0b7173badcb0411bdc7ed37e0148491ac64a7/oapi-codegen/oapi-codegen/pull/2571
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/da0a2660b85fd9ed9206253ec1e0b7173badcb0411bdc7ed37e0148491ac64a7/oapi-codegen/oapi-codegen/pull/2571
og:image:altWhen an allOf member is itself a schema with an allOf, the v2 merge replaces the member with the merge of its allOf, which loses the properties it declares next to that allOf: Mid: type: object pro...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemromaszewicz
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-cache
go-importgithub.com/oapi-codegen/oapi-codegen git https://github.com/oapi-codegen/oapi-codegen.git
octolytics-dimension-user_id142752710
octolytics-dimension-user_loginoapi-codegen
octolytics-dimension-repository_id173009358
octolytics-dimension-repository_nwooapi-codegen/oapi-codegen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id173009358
octolytics-dimension-repository_network_root_nwooapi-codegen/oapi-codegen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/oapi-codegen/oapi-codegen/pull/2571#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foapi-codegen%2Foapi-codegen%2Fpull%2F2571
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foapi-codegen%2Foapi-codegen%2Fpull%2F2571
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=oapi-codegen%2Foapi-codegen
Reloadhttps://github.com/oapi-codegen/oapi-codegen/pull/2571
Reloadhttps://github.com/oapi-codegen/oapi-codegen/pull/2571
Reloadhttps://github.com/oapi-codegen/oapi-codegen/pull/2571
oapi-codegenhttps://github.com/oapi-codegen
oapi-codegenhttps://github.com/oapi-codegen/oapi-codegen
Codehttps://github.com/oapi-codegen/oapi-codegen
Issues228 (228)https://github.com/oapi-codegen/oapi-codegen/issues
Pull requests70 (70)https://github.com/oapi-codegen/oapi-codegen/pulls
Discussionshttps://github.com/oapi-codegen/oapi-codegen/discussions
Actionshttps://github.com/oapi-codegen/oapi-codegen/actions
Projectshttps://github.com/oapi-codegen/oapi-codegen/projects
Security and quality11 (11)https://github.com/oapi-codegen/oapi-codegen/security
Insightshttps://github.com/oapi-codegen/oapi-codegen/pulse
https://github.com/oapi-codegen/oapi-codegen
mromaszewiczhttps://github.com/mromaszewicz
oapi-codegen:mainhttps://github.com/oapi-codegen/oapi-codegen/tree/main
mromaszewicz:fix/v2-nested-allof-propertieshttps://github.com/mromaszewicz/oapi-codegen/tree/fix/v2-nested-allof-properties
Conversationhttps://github.com/oapi-codegen/oapi-codegen/pull/2571
Commits2 (2)https://github.com/oapi-codegen/oapi-codegen/pull/2571/commits
Checkshttps://github.com/oapi-codegen/oapi-codegen/pull/2571/checks
Files changedhttps://github.com/oapi-codegen/oapi-codegen/pull/2571/files
fix: keep the properties an allOf member declares next to its own allOfhttps://github.com/oapi-codegen/oapi-codegen/pull/2571#top
mromaszewiczhttps://github.com/mromaszewicz
oapi-codegen:mainhttps://github.com/oapi-codegen/oapi-codegen/tree/main
mromaszewicz:fix/v2-nested-allof-propertieshttps://github.com/mromaszewicz/oapi-codegen/tree/fix/v2-nested-allof-properties
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
Sep 24, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2571#issue-5574010067
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2571
https://github.com/mromaszewicz
https://github.com/claude
fix: keep the properties an allOf member declares next to its own allOfhttps://github.com/oapi-codegen/oapi-codegen/pull/2571/commits/773cde64c0a3d0b9989d1733c665bc85bfbec733
773cde6https://github.com/oapi-codegen/oapi-codegen/pull/2571/commits/773cde64c0a3d0b9989d1733c665bc85bfbec733
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
code ownerhttps://github.com/oapi-codegen/oapi-codegen/blob/a1f70777dbf2366ceaf943398a6708ac0ccbf42f/.github/CODEOWNERS#L1
September 24, 2026 20:14https://github.com/oapi-codegen/oapi-codegen/pull/2571#event-31787642587
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
bug https://github.com/oapi-codegen/oapi-codegen/issues?q=state%3Aopen%20label%3Abug
Sep 24, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2571#event-31787831585
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
Sep 24, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2571#issuecomment-5821597451
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2571
https://app.greptile.com/api/retrigger?id=68942440
https://camo.githubusercontent.com/a7b9b99cff6cd0a6855cb4831e99f3dd0f330f004037ba802705f870a0acdf4e/68747470733a2f2f6772657074696c652d7374617469632d6173736574732e73332e616d617a6f6e6177732e636f6d2f6261646765732f70312e7376673f763d39
▶https://github.com/oapi-codegen/oapi-codegen/pull/2571#discussion_r4098172566
"fix: only add nested allOf properties wh..."https://github.com/oapi-codegen/oapi-codegen/commit/7500383e434203c1526e22774ed39fc0f7e624c2
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2571
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
Sep 24, 2026 https://github.com/oapi-codegen/oapi-codegen/pull/2571#pullrequestreview-5309766522
View reviewed changes https://github.com/oapi-codegen/oapi-codegen/pull/2571/files/773cde64c0a3d0b9989d1733c665bc85bfbec733
pkg/codegen/merge_schemas_v2.gohttps://github.com/oapi-codegen/oapi-codegen/pull/2571/files/773cde64c0a3d0b9989d1733c665bc85bfbec733#diff-1065c033305b0b9789859f09d43422e140645a618253f3adbc95bca5fa6a80e4
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2571
pkg/codegen/merge_schemas_v2.gohttps://github.com/oapi-codegen/oapi-codegen/pull/2571/files/773cde64c0a3d0b9989d1733c665bc85bfbec733#diff-1065c033305b0b9789859f09d43422e140645a618253f3adbc95bca5fa6a80e4
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2571
pkg/codegen/merge_schemas_v2.gohttps://github.com/oapi-codegen/oapi-codegen/pull/2571/files/773cde64c0a3d0b9989d1733c665bc85bfbec733#diff-1065c033305b0b9789859f09d43422e140645a618253f3adbc95bca5fa6a80e4
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2571
https://github.com/mromaszewicz
https://github.com/claude
fix: only add nested allOf properties where that adds fields and noth…https://github.com/oapi-codegen/oapi-codegen/pull/2571/commits/7500383e434203c1526e22774ed39fc0f7e624c2
7500383https://github.com/oapi-codegen/oapi-codegen/pull/2571/commits/7500383e434203c1526e22774ed39fc0f7e624c2
https://github.com/apps/greptile-apps
greptile-appshttps://github.com/apps/greptile-apps
Sep 24, 2026 https://github.com/oapi-codegen/oapi-codegen/pull/2571#pullrequestreview-5309868500
View reviewed changes https://github.com/oapi-codegen/oapi-codegen/pull/2571/files/7500383e434203c1526e22774ed39fc0f7e624c2
pkg/codegen/merge_schemas_v2.gohttps://github.com/oapi-codegen/oapi-codegen/pull/2571/files/7500383e434203c1526e22774ed39fc0f7e624c2#diff-1065c033305b0b9789859f09d43422e140645a618253f3adbc95bca5fa6a80e4
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2571
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
11315ddhttps://github.com/oapi-codegen/oapi-codegen/commit/11315dde516246209f2879ce208ea87fcc9b3f2c
Sep 24, 2026https://github.com/oapi-codegen/oapi-codegen/pull/2571#event-31788729490
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2571
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
Sep 24, 2026 https://github.com/oapi-codegen/oapi-codegen/pull/2571#ref-pullrequest-5574237501
chore: update comment in v2 schema merging #2573 https://github.com/oapi-codegen/oapi-codegen/pull/2573
mromaszewiczhttps://github.com/mromaszewicz
Sep 24, 2026 https://github.com/oapi-codegen/oapi-codegen/pull/2571#ref-commit-03ba303
https://github.com/mromaszewicz
https://github.com/claude
chore: update comment in v2 schema merging (https://github.com/oapi-codegen/oapi-codegen/commit/03ba30385d6f6b71c4ef4d46e108e1d252286a4d
#2573https://github.com/oapi-codegen/oapi-codegen/pull/2573
)https://github.com/oapi-codegen/oapi-codegen/commit/03ba30385d6f6b71c4ef4d46e108e1d252286a4d
03ba303https://github.com/oapi-codegen/oapi-codegen/commit/03ba30385d6f6b71c4ef4d46e108e1d252286a4d
#2571https://github.com/oapi-codegen/oapi-codegen/pull/2571
mromaszewiczhttps://github.com/mromaszewicz
Sep 24, 2026 https://github.com/oapi-codegen/oapi-codegen/pull/2571#ref-commit-d2b4bf3
https://github.com/mromaszewicz
https://github.com/claude
feat(v3): merge allOf keywords by their meaning, and name conflictshttps://github.com/mromaszewicz/oapi-codegen/commit/d2b4bf30e91d5cee90d84922dd281413fb51cc6c
d2b4bf3https://github.com/mromaszewicz/oapi-codegen/commit/d2b4bf30e91d5cee90d84922dd281413fb51cc6c
oapi-codegen#1633https://github.com/oapi-codegen/oapi-codegen/issues/1633
oapi-codegen#2571https://github.com/oapi-codegen/oapi-codegen/pull/2571
oapi-codegen#2571https://github.com/oapi-codegen/oapi-codegen/pull/2571
oapi-codegen#1633https://github.com/oapi-codegen/oapi-codegen/issues/1633
mromaszewiczhttps://github.com/mromaszewicz
Sep 24, 2026 https://github.com/oapi-codegen/oapi-codegen/pull/2571#ref-commit-f8781ee
https://github.com/mromaszewicz
https://github.com/claude
test(v3): cover a nested member's own properties where v2 keeps a maphttps://github.com/mromaszewicz/oapi-codegen/commit/f8781ee385a4aea363017fe41db074e924d1befe
f8781eehttps://github.com/mromaszewicz/oapi-codegen/commit/f8781ee385a4aea363017fe41db074e924d1befe
oapi-codegen#2571https://github.com/oapi-codegen/oapi-codegen/pull/2571
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
Sep 24, 2026 https://github.com/oapi-codegen/oapi-codegen/pull/2571#ref-pullrequest-5574080321
feat(v3): merge allOf members by what allOf means #2572 https://github.com/oapi-codegen/oapi-codegen/pull/2572
mromaszewiczhttps://github.com/mromaszewicz
Sep 24, 2026 https://github.com/oapi-codegen/oapi-codegen/pull/2571#ref-commit-96133d3
https://github.com/mromaszewicz
https://github.com/claude
feat(v3): merge allOf members by what allOf means (https://github.com/oapi-codegen/oapi-codegen/commit/96133d325ca25870309de635f65e929ff990d40f
#2572https://github.com/oapi-codegen/oapi-codegen/pull/2572
)https://github.com/oapi-codegen/oapi-codegen/commit/96133d325ca25870309de635f65e929ff990d40f
96133d3https://github.com/oapi-codegen/oapi-codegen/commit/96133d325ca25870309de635f65e929ff990d40f
#1633https://github.com/oapi-codegen/oapi-codegen/issues/1633
#2571https://github.com/oapi-codegen/oapi-codegen/pull/2571
#2571https://github.com/oapi-codegen/oapi-codegen/pull/2571
#1633https://github.com/oapi-codegen/oapi-codegen/issues/1633
#2107https://github.com/oapi-codegen/oapi-codegen/issues/2107
#2542https://github.com/oapi-codegen/oapi-codegen/issues/2542
#2107https://github.com/oapi-codegen/oapi-codegen/issues/2107
#2571https://github.com/oapi-codegen/oapi-codegen/pull/2571
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
September 26, 2026 00:47https://github.com/oapi-codegen/oapi-codegen/pull/2571#event-31873359487
https://github.co/hiddenchars
https://github.com/oapi-codegen/oapi-codegen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foapi-codegen%2Foapi-codegen%2Fpull%2F2571
https://github.com/apps/greptile-apps
greptile-apps[bot] https://github.com/apps/greptile-apps
https://github.com/oapi-codegen/oapi-codegen/pull/2571/files/7500383e434203c1526e22774ed39fc0f7e624c2
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2571
bug https://github.com/oapi-codegen/oapi-codegen/issues?q=state%3Aopen%20label%3Abug
Please reload this pagehttps://github.com/oapi-codegen/oapi-codegen/pull/2571
https://github.com/mromaszewicz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.