René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Required inheritance and generated objects when using allOf","articleBody":"Considering the following schema:\r\n\r\n```yaml\r\n    FooProperties:\r\n      type: object\r\n      properties:\r\n        uuid:\r\n          type: string\r\n          format: uuid\r\n          readOnly: true\r\n        firstname:\r\n          type: string\r\n        lastname:\r\n          type: string\r\n\r\n    Foo:\r\n      allOf:\r\n        - $ref: \"#/components/schemas/FooProperties\"\r\n        - type: object\r\n          required:\r\n            - uuid\r\n            - firstname\r\n            - lastname\r\n\r\n    NewFoo:\r\n      allOf:\r\n        - $ref: \"#/components/schemas/FooProperties\"\r\n        - type: object\r\n          required:\r\n            - firstname\r\n```\r\n\r\nAccording to the specs, also confirmed in the https://editor.swagger.io/, and https://github.com/swagger-api/swagger-editor/issues/1212, `NewFoo` should have `firstname` as required, and `Foo` should have all properties as required.\r\n\r\nThe validation works as expected.\r\n\r\nHowever, the resulting objects in Go are:\r\n\r\n```go\r\ntype Foo struct {\r\n\t// Embedded struct due to allOf(#/components/schemas/FooProperties)\r\n\tFooProperties `yaml:\",inline\"`\r\n\t// Embedded fields due to inline allOf schema\r\n}\r\n\r\n// FooProperties defines model for FooProperties.\r\ntype FooProperties struct {\r\n\tFirstname *string `json:\"firstname,omitempty\"`\r\n\tLastname  *string `json:\"lastname,omitempty\"`\r\n\tUuid      *string `json:\"uuid,omitempty\"`\r\n}\r\n\r\n// NewFoo defines model for NewFoo.\r\ntype NewFoo struct {\r\n\t// Embedded struct due to allOf(#/components/schemas/FooProperties)\r\n\tFooProperties `yaml:\",inline\"`\r\n\t// Embedded fields due to inline allOf schema\r\n}\r\n```\r\n\r\nBecause of the struct embedding, the properties are all pointers instead of values (like when using \"required\" directly in objects).\r\n\r\nNow, because the validation works as expected, this might not be an issue at all. I wonder however if in this case, if the generated code should embed `FooProperties` as is, or if a new struct should be generated per \"merge\".\r\n\r\nThis has been discussed, and sometimes fixed, in several other projects:\r\n- https://github.com/OAI/OpenAPI-Specification/issues/1870\r\n- https://github.com/cyclosproject/ng-openapi-gen/issues/108\r\n- https://github.com/sylvainlaurent/swagger-validator-maven-plugin/issues/19\r\n- https://github.com/acacode/swagger-typescript-api/issues/275\r\n- https://github.com/p1c2u/openapi-schema-validator/issues/15\r\n\r\n","author":{"url":"https://github.com/florentchauveau","@type":"Person","name":"florentchauveau"},"datePublished":"2022-02-23T10:25:58Z","url":"https://github.com/oapi-codegen/oapi-codegen/issues/531"}