René's URL Explorer Experiment


Title: Merge properties when combining schemas with `allOf` · Issue #2107 · oapi-codegen/oapi-codegen · GitHub

Open Graph Title: Merge properties when combining schemas with `allOf` · Issue #2107 · oapi-codegen/oapi-codegen

X Title: Merge properties when combining schemas with `allOf` · Issue #2107 · oapi-codegen/oapi-codegen

Description: Currently oapi-codegen doesn't merge property definitions when combining schemas with allOf and instead takes the complete property from the last one it sees: oapi-codegen/pkg/codegen/merge_schemas.go Line 203 in 0d94f2f // TODO: detect ...

Open Graph Description: Currently oapi-codegen doesn't merge property definitions when combining schemas with allOf and instead takes the complete property from the last one it sees: oapi-codegen/pkg/codegen/merge_schemas...

X Description: Currently oapi-codegen doesn't merge property definitions when combining schemas with allOf and instead takes the complete property from the last one it sees: oapi-codegen/pkg/codegen/merge_sch...

Opengraph URL: https://github.com/oapi-codegen/oapi-codegen/issues/2107

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Merge properties when combining schemas with `allOf`","articleBody":"Currently oapi-codegen doesn't merge property definitions when combining schemas with `allOf` and instead takes the complete property from the last one it sees: https://github.com/oapi-codegen/oapi-codegen/blob/0d94f2f2015e5fec2cd66273eeb8eff7d1f86bc1/pkg/codegen/merge_schemas.go#L203\n\nThis means we can't create a schema for a JSON Merge Patch endpoint that inherits types and everything else from a base schema and just makes some of them nullable  (as sending `null` is how one clears a value in RFC 7396). This approach is described here: https://blog.stoplight.io/reuse-openapi-descriptions Instead we have to maintain redundant types/formats/descriptions/etc. for the properties.\n\nFrom this doc in the spec it does seem like properties are expected to be inherited: https://swagger.io/docs/specification/v3_0/data-models/inheritance-and-polymorphism/\n\nAnd other implementations seem to merge them: https://github.com/Redocly/redoc/blob/34623575ce4741280df4c960f926c3751022b026/src/services/OpenAPIParser.ts#L276\n\nUnderstandably a full merge would be an undertaking, reflection is not ideal, and something like [mergo](https://github.com/darccio/mergo) would be a somewhat heavy extra dep. However, even a shallow merge of a subset of `Schema` properties would enable this PATCH use case and presumably many others.","author":{"url":"https://github.com/skomorokh","@type":"Person","name":"skomorokh"},"datePublished":"2025-10-17T20:39:29Z","url":"https://github.com/oapi-codegen/oapi-codegen/issues/2107"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8b309911-6aef-ca7d-925e-aaf6c7520344
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDE42:381FD0:2360ED:30FBEC:6AF9C9E7
html-safe-nonce04997c6625f1831e977e42357dbb7a3e32bc20616bedef6beac99b0a82711f86
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTQyOjM4MUZEMDoyMzYwRUQ6MzBGQkVDOjZBRjlDOUU3IiwidmlzaXRvcl9pZCI6IjI3Mjk3MzczNTk0OTc3NDI4MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfebebeac3cd71956954bbac93032aaf12061c4078601cc94f5db58ec9fba32b3
hovercard-subject-tagissue:3527484183
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/oapi-codegen/oapi-codegen/2107/issue_layout
twitter:imagehttps://opengraph.githubassets.com/fa35251f178e3edc1d8021c99bb56fa2382a98861757617e794cf43b3a45e052/oapi-codegen/oapi-codegen/issues/2107
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fa35251f178e3edc1d8021c99bb56fa2382a98861757617e794cf43b3a45e052/oapi-codegen/oapi-codegen/issues/2107
og:image:altCurrently oapi-codegen doesn't merge property definitions when combining schemas with allOf and instead takes the complete property from the last one it sees: oapi-codegen/pkg/codegen/merge_schemas...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameskomorokh
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-preview
go-importgithub.com/oapi-codegen/oapi-codegen git https://github.com/oapi-codegen/oapi-codegen.git
octolytics-dimension-user_id142752710
octolytics-dimension-user_loginoapi-codegen
octolytics-dimension-repository_id173009358
octolytics-dimension-repository_nwooapi-codegen/oapi-codegen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id173009358
octolytics-dimension-repository_network_root_nwooapi-codegen/oapi-codegen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/oapi-codegen/oapi-codegen/issues/2107#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foapi-codegen%2Foapi-codegen%2Fissues%2F2107
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Foapi-codegen%2Foapi-codegen%2Fissues%2F2107
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=oapi-codegen%2Foapi-codegen
Reloadhttps://github.com/oapi-codegen/oapi-codegen/issues/2107
Reloadhttps://github.com/oapi-codegen/oapi-codegen/issues/2107
Reloadhttps://github.com/oapi-codegen/oapi-codegen/issues/2107
oapi-codegenhttps://github.com/oapi-codegen
oapi-codegenhttps://github.com/oapi-codegen/oapi-codegen
Codehttps://github.com/oapi-codegen/oapi-codegen
Issues228 (228)https://github.com/oapi-codegen/oapi-codegen/issues
Pull requests70 (70)https://github.com/oapi-codegen/oapi-codegen/pulls
Discussionshttps://github.com/oapi-codegen/oapi-codegen/discussions
Actionshttps://github.com/oapi-codegen/oapi-codegen/actions
Projectshttps://github.com/oapi-codegen/oapi-codegen/projects
Security and quality11 (11)https://github.com/oapi-codegen/oapi-codegen/security
Insightshttps://github.com/oapi-codegen/oapi-codegen/pulse
https://github.com/oapi-codegen/oapi-codegen
New issuehttps://github.com/login?return_to=https://github.com/oapi-codegen/oapi-codegen/issues/2107
New issuehttps://github.com/login?return_to=https://github.com/oapi-codegen/oapi-codegen/issues/2107
#2572https://github.com/oapi-codegen/oapi-codegen/pull/2572
Merge properties when combining schemas with allOfhttps://github.com/oapi-codegen/oapi-codegen/issues/2107#top
#2572https://github.com/oapi-codegen/oapi-codegen/pull/2572
https://github.com/skomorokh
skomorokhhttps://github.com/skomorokh
on Oct 17, 2025https://github.com/oapi-codegen/oapi-codegen/issues/2107#issue-3527484183
oapi-codegen/pkg/codegen/merge_schemas.gohttps://github.com/oapi-codegen/oapi-codegen/blob/0d94f2f2015e5fec2cd66273eeb8eff7d1f86bc1/pkg/codegen/merge_schemas.go#L203
0d94f2fhttps://github.com/oapi-codegen/oapi-codegen/commit/0d94f2f2015e5fec2cd66273eeb8eff7d1f86bc1
https://blog.stoplight.io/reuse-openapi-descriptionshttps://blog.stoplight.io/reuse-openapi-descriptions
https://swagger.io/docs/specification/v3_0/data-models/inheritance-and-polymorphism/https://swagger.io/docs/specification/v3_0/data-models/inheritance-and-polymorphism/
https://github.com/Redocly/redoc/blob/34623575ce4741280df4c960f926c3751022b026/src/services/OpenAPIParser.ts#L276https://github.com/Redocly/redoc/blob/34623575ce4741280df4c960f926c3751022b026/src/services/OpenAPIParser.ts#L276
mergohttps://github.com/darccio/mergo
skomorokhhttps://github.com/skomorokh
completedhttps://github.com/oapi-codegen/oapi-codegen/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 21, 2025https://github.com/oapi-codegen/oapi-codegen/issues/2107#event-20391602976
skomorokhhttps://github.com/skomorokh
duplicatehttps://github.com/oapi-codegen/oapi-codegen/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Aduplicate
error merging schemas for AllOf: merging two schemas with different Nullable #1898https://github.com/oapi-codegen/oapi-codegen/issues/1898
on Oct 21, 2025https://github.com/oapi-codegen/oapi-codegen/issues/2107#event-20391607649
skomorokhhttps://github.com/skomorokh
on Oct 21, 2025https://github.com/oapi-codegen/oapi-codegen/issues/2107#event-20391864639
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
on Jun 22, 2026https://github.com/oapi-codegen/oapi-codegen/issues/2107#issuecomment-4773617555
https://github.com/bendrucker
bendruckerhttps://github.com/bendrucker
on Aug 14, 2026https://github.com/oapi-codegen/oapi-codegen/issues/2107#issuecomment-5296019244
6768b63https://github.com/oapi-codegen/oapi-codegen/commit/6768b639b7e66eec3a46bddd232d87e4287912e3
merge_schemas.go:403https://github.com/oapi-codegen/oapi-codegen/blob/main/pkg/codegen/merge_schemas.go
#1883https://github.com/oapi-codegen/oapi-codegen/issues/1883
Honeycomb'shttps://github.com/bendrucker/honeycomb-cli/issues/238
mromaszewiczhttps://github.com/mromaszewicz
on Sep 24, 2026https://github.com/oapi-codegen/oapi-codegen/issues/2107#event-31789128141
feat(v3): merge a property that several allOf members declarehttps://github.com/mromaszewicz/oapi-codegen/commit/2d73a27cc471eafd46bf91beb12b311c459b4a20
2d73a27https://github.com/mromaszewicz/oapi-codegen/commit/2d73a27cc471eafd46bf91beb12b311c459b4a20
mromaszewiczhttps://github.com/mromaszewicz
completedhttps://github.com/oapi-codegen/oapi-codegen/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#2572https://github.com/oapi-codegen/oapi-codegen/pull/2572
on Sep 24, 2026https://github.com/oapi-codegen/oapi-codegen/issues/2107#event-31790423411
https://github.com/mromaszewicz
mromaszewiczhttps://github.com/mromaszewicz
on Sep 26, 2026https://github.com/oapi-codegen/oapi-codegen/issues/2107#issuecomment-5843284131
#2572https://github.com/oapi-codegen/oapi-codegen/pull/2572
docs/schema-merging.mdhttps://github.com/oapi-codegen/oapi-codegen/blob/main/docs/schema-merging.md
mromaszewiczhttps://github.com/mromaszewicz
on Sep 26, 2026https://github.com/oapi-codegen/oapi-codegen/issues/2107#event-31881251780
feat(v3): merge allOf members by what allOf means (oapi-codegen#2572)https://github.com/akashchamp/oapi-codegen/commit/96133d325ca25870309de635f65e929ff990d40f
oapi-codegen#2572https://github.com/oapi-codegen/oapi-codegen/pull/2572
96133d3https://github.com/akashchamp/oapi-codegen/commit/96133d325ca25870309de635f65e929ff990d40f
Sign up for freehttps://github.com/signup?return_to=https://github.com/oapi-codegen/oapi-codegen/issues/2107
Sign in to commenthttps://github.com/login?return_to=https://github.com/oapi-codegen/oapi-codegen/issues/2107
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.