René's URL Explorer Experiment


Title: Throw OperationError if PBKDF2 iterations is zero by tniessen · Pull Request #29 · nodejs/webcrypto · GitHub

Open Graph Title: Throw OperationError if PBKDF2 iterations is zero by tniessen · Pull Request #29 · nodejs/webcrypto

X Title: Throw OperationError if PBKDF2 iterations is zero by tniessen · Pull Request #29 · nodejs/webcrypto

Description: This repository has been archived. The WebCrypto API has been implemented in recent versions of Node.js and does not require additional packages. - Throw OperationError if PBKDF2 iterations is zero by tniessen · Pull Request #29 · nodejs/webcrypto

Open Graph Description: Node.js accepts an iteration count of zero, but WebCrypto requires an OperationError. This fixes 468 WPTs.

X Description: Node.js accepts an iteration count of zero, but WebCrypto requires an OperationError. This fixes 468 WPTs.

Opengraph URL: https://github.com/nodejs/webcrypto/pull/29

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:784755f6-3380-b98a-581b-9f9a0d04975e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6A6:142296:77156E:9B0D77:6AED3339
html-safe-nonce9ad969d1a21031908994f76a1d75645593f732a1e55b07a33b308c3fc98edd79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkE2OjE0MjI5Njo3NzE1NkU6OUIwRDc3OjZBRUQzMzM5IiwidmlzaXRvcl9pZCI6IjM5NDUyOTI1NTY4NjQ5MjY1MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac92bb4785b917f17f0aefee15402d3cf32f9193ff05491bdc59a58e896bad0a50
hovercard-subject-tagpull_request:343883349
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/webcrypto/29/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1761a849b417edf140a536f883b3778ebf2b53f316a4cabd71cfbde7ae85e340/nodejs/webcrypto/pull/29
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1761a849b417edf140a536f883b3778ebf2b53f316a4cabd71cfbde7ae85e340/nodejs/webcrypto/pull/29
og:image:altNode.js accepts an iteration count of zero, but WebCrypto requires an OperationError. This fixes 468 WPTs.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/webcrypto git https://github.com/nodejs/webcrypto.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id190637069
octolytics-dimension-repository_nwonodejs/webcrypto
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id190637069
octolytics-dimension-repository_network_root_nwonodejs/webcrypto
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/webcrypto/pull/29#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fwebcrypto%2Fpull%2F29
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fwebcrypto%2Fpull%2F29
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fwebcrypto
Reloadhttps://github.com/nodejs/webcrypto/pull/29
Reloadhttps://github.com/nodejs/webcrypto/pull/29
Reloadhttps://github.com/nodejs/webcrypto/pull/29
nodejshttps://github.com/nodejs
webcryptohttps://github.com/nodejs/webcrypto
Codehttps://github.com/nodejs/webcrypto
Issues4 (4)https://github.com/nodejs/webcrypto/issues
Pull requests1 (1)https://github.com/nodejs/webcrypto/pulls
Actionshttps://github.com/nodejs/webcrypto/actions
Projectshttps://github.com/nodejs/webcrypto/projects
Security and qualityhttps://github.com/nodejs/webcrypto/security
Insightshttps://github.com/nodejs/webcrypto/pulse
https://github.com/nodejs/webcrypto
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/webcrypto/tree/master
tniessen:pbkdf2-throw-operationerror-zero-iterationshttps://github.com/tniessen/node-webcrypto/tree/pbkdf2-throw-operationerror-zero-iterations
Conversationhttps://github.com/nodejs/webcrypto/pull/29
Commits1 (1)https://github.com/nodejs/webcrypto/pull/29/commits
Checkshttps://github.com/nodejs/webcrypto/pull/29/checks
Files changedhttps://github.com/nodejs/webcrypto/pull/29/files
Throw OperationError if PBKDF2 iterations is zerohttps://github.com/nodejs/webcrypto/pull/29#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/webcrypto/tree/master
tniessen:pbkdf2-throw-operationerror-zero-iterationshttps://github.com/tniessen/node-webcrypto/tree/pbkdf2-throw-operationerror-zero-iterations
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 21, 2019https://github.com/nodejs/webcrypto/pull/29#issue-526413796
Please reload this pagehttps://github.com/nodejs/webcrypto/pull/29
https://github.com/tniessen
Throw OperationError if PBKDF2 iterations is zerohttps://github.com/nodejs/webcrypto/pull/29/commits/a5e290679cc0901d1ccb926d2e00d3fcba6faeac
a5e2906https://github.com/nodejs/webcrypto/pull/29/commits/a5e290679cc0901d1ccb926d2e00d3fcba6faeac
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 21, 2019 https://github.com/nodejs/webcrypto/pull/29#pullrequestreview-320802747
View reviewed changes https://github.com/nodejs/webcrypto/pull/29/files/a5e290679cc0901d1ccb926d2e00d3fcba6faeac
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/webcrypto/pull/29#pullrequestreview-320802747
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/webcrypto/pull/29
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Nov 21, 2019 https://github.com/nodejs/webcrypto/pull/29#pullrequestreview-320869536
View reviewed changes https://github.com/nodejs/webcrypto/pull/29/files/a5e290679cc0901d1ccb926d2e00d3fcba6faeac
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 21, 2019https://github.com/nodejs/webcrypto/pull/29#issuecomment-557111622
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/webcrypto/pull/29
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 21, 2019https://github.com/nodejs/webcrypto/pull/29#issuecomment-557117919
Please reload this pagehttps://github.com/nodejs/webcrypto/pull/29
treat values <= 1 as 1https://github.com/openssl/openssl/blob/f6f371d472262e9525107074d93828b68acdbbdf/crypto/evp/p5_crpt2.c#L91
appears to forbid such inputshttps://github.com/openssl/openssl/blob/ab5c77b4766e0992751d86560193ca42b49cf316/providers/implementations/kdfs/pbkdf2.c#L181-L185
Please reload this pagehttps://github.com/nodejs/webcrypto/pull/29
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 21, 2019 https://github.com/nodejs/webcrypto/pull/29#ref-pullrequest-526653555
crypto: forbid setting the PBKDF2 iter count to 0 nodejs/node#30578 https://github.com/nodejs/node/pull/30578
https://github.com/tniessen
tniessenhttps://github.com/tniessen
f97c0d1https://github.com/nodejs/webcrypto/commit/f97c0d1a8c5a75a9c530b95406403b8ec3cd3dc5
Nov 21, 2019https://github.com/nodejs/webcrypto/pull/29#event-2820021025
https://github.com/tniessen
tniessenhttps://github.com/tniessen
November 21, 2019 15:12https://github.com/nodejs/webcrypto/pull/29#event-2820021358
tniessenhttps://github.com/tniessen
Nov 24, 2019 https://github.com/nodejs/webcrypto/pull/29#ref-commit-a1ba429
https://github.com/tniessen
crypto: forbid setting the PBKDF2 iter count to 0https://github.com/tniessen/node/commit/a1ba429a2fe725abe5e664624fc441c3451005de
a1ba429https://github.com/tniessen/node/commit/a1ba429a2fe725abe5e664624fc441c3451005de
nodejs/webcrypto#29https://github.com/nodejs/webcrypto/pull/29
addaleaxhttps://github.com/addaleax
Nov 27, 2019 https://github.com/nodejs/webcrypto/pull/29#ref-commit-10f5fa7
https://github.com/tniessen
https://github.com/addaleax
crypto: forbid setting the PBKDF2 iter count to 0https://github.com/nodejs/node/commit/10f5fa75136b540487730b5c1852ea6ad795bb96
10f5fa7https://github.com/nodejs/node/commit/10f5fa75136b540487730b5c1852ea6ad795bb96
nodejs/webcrypto#29https://github.com/nodejs/webcrypto/pull/29
#30578https://github.com/nodejs/node/pull/30578
https://github.co/hiddenchars
https://github.com/nodejs/webcrypto/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fwebcrypto%2Fpull%2F29
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/webcrypto/pull/29/files/a5e290679cc0901d1ccb926d2e00d3fcba6faeac
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/webcrypto/pull/29/files/a5e290679cc0901d1ccb926d2e00d3fcba6faeac
Please reload this pagehttps://github.com/nodejs/webcrypto/pull/29
Please reload this pagehttps://github.com/nodejs/webcrypto/pull/29
https://github.com/tniessen
https://github.com/bnoordhuis
https://github.com/cjihrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.