| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c4c38e69-64b3-b594-17c5-be785fd8c918 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E964:24ACB9:711D68:975E53:6B00D5BB |
| html-safe-nonce | 0786c1711acb6d9434244ed20cf03ef020918059a2e33d571cec3ccac399f76a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTY0OjI0QUNCOTo3MTFENjg6OTc1RTUzOjZCMDBENUJCIiwidmlzaXRvcl9pZCI6Ijc3NDQyMDM5MzM0NzU3MjI2ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 05ac5508e6578ef13e1df404cde8c2268deea85b12ca92341b2fd01b6c2c4830 |
| hovercard-subject-tag | pull_request:338211840 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/nodejs.dev/pull/366/files |
| twitter:image | https://avatars.githubusercontent.com/u/849613?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/849613?s=400&v=4 |
| og:image:alt | Description
It refactors out utils/DarkModeController.js as an external dependency.
Note — Attempts to roll this out as a GPR dependency were abandoned.
Progress
Switch to using the external d... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/nodejs.dev git https://github.com/nodejs/nodejs.dev.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 168201675 |
| octolytics-dimension-repository_nwo | nodejs/nodejs.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 168201675 |
| octolytics-dimension-repository_network_root_nwo | nodejs/nodejs.dev |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/nodejs.dev/pull/366/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnodejs.dev%2Fpull%2F366%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnodejs.dev%2Fpull%2F366%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnodejs.dev |
| Reload | https://github.com/nodejs/nodejs.dev/pull/366/files |
| Reload | https://github.com/nodejs/nodejs.dev/pull/366/files |
| Reload | https://github.com/nodejs/nodejs.dev/pull/366/files |
| nodejs | https://github.com/nodejs |
| nodejs.dev | https://github.com/nodejs/nodejs.dev |
| Code | https://github.com/nodejs/nodejs.dev |
| Pull requests | https://github.com/nodejs/nodejs.dev/pulls |
| Actions | https://github.com/nodejs/nodejs.dev/actions |
| Security and quality | https://github.com/nodejs/nodejs.dev/security |
| Insights | https://github.com/nodejs/nodejs.dev/insights |
| SMotaal | https://github.com/SMotaal |
| nodejs:staging | https://github.com/nodejs/nodejs.dev/tree/staging |
| SMotaal:refactor-enhanced-dark-mode | https://github.com/SMotaal/nodejs.dev/tree/refactor-enhanced-dark-mode |
|
Conversation
26
| https://github.com/nodejs/nodejs.dev/pull/366 |
|
Commits
14
| https://github.com/nodejs/nodejs.dev/pull/366/commits |
|
Checks
0
| https://github.com/nodejs/nodejs.dev/pull/366/checks |
|
Files changed
| https://github.com/nodejs/nodejs.dev/pull/366/files |
| Please reload this page | https://github.com/nodejs/nodejs.dev/pull/366/files |
|
refactor: Enhanced Dark Mode as third-party dependency
| https://github.com/nodejs/nodejs.dev/pull/366/files#top |
|
Show all changes
14 commits
| https://github.com/nodejs/nodejs.dev/pull/366/files |
|
1e7c5e0
refactor: Swap to @smotaal.io/dark-mode-controller NPM
Nov 7, 2019
| https://github.com/nodejs/nodejs.dev/pull/366/commits/1e7c5e0dde54cc3bc6e056b4f9c2b86540b7e6b9 |
|
993dbce
build: Upgrade to @smotaal.io/dark-mode-controller@0.0.3
SMotaal Nov 10, 2019
| https://github.com/nodejs/nodejs.dev/pull/366/commits/993dbce16900e74455a0f6b7142baf87ad1616d8 |
|
567ebbc
fix: Delegating to dark-mode-controller not always stable
SMotaal Nov 10, 2019
| https://github.com/nodejs/nodejs.dev/pull/366/commits/567ebbcd04a7e746b1ab46f8d8abbae997919f77 |
|
247d9cb
test: Update snapshots
SMotaal Nov 10, 2019
| https://github.com/nodejs/nodejs.dev/pull/366/commits/247d9cba967247a51110f505e3f98a89d3d9e46d |
|
3a59084
fix: Restore accidentally deleted `.nvmrc`
SMotaal Nov 13, 2019
| https://github.com/nodejs/nodejs.dev/pull/366/commits/3a5908481b5eeae24a3c57da8ad19c3335e70a3d |
|
5b05bb6
build: Upgrade to @smotaal.io/dark-mode-controller@0.0.4
SMotaal Feb 6, 2020
| https://github.com/nodejs/nodejs.dev/pull/366/commits/5b05bb60d97aad829cce935bf1832dfdaef67df0 |
|
a2780e5
Merge branch 'staging' into refactor-enhanced-dark-mode
SMotaal Feb 6, 2020
| https://github.com/nodejs/nodejs.dev/pull/366/commits/a2780e56cb7d23002cd0b73d20af881aaeb990ed |
|
4b5a28a
Merge branch 'staging' of https://github.com/nodejs/nodejs.dev into r…
SMotaal Feb 29, 2020
| https://github.com/nodejs/nodejs.dev/pull/366/commits/4b5a28a361a0e344831310ef984a6fcdb693b5a6 |
|
e7b8768
refactor: Delete controls.tsx
SMotaal Feb 29, 2020
| https://github.com/nodejs/nodejs.dev/pull/366/commits/e7b8768204a5d7c387031d95e2ec720f216e4304 |
|
23401e0
refactor: Optionally cascade darkModeController as a property
SMotaal Feb 29, 2020
| https://github.com/nodejs/nodejs.dev/pull/366/commits/23401e0621312f6dfc0c7aff8c6b067d07bf2ea8 |
|
30f8322
test(snapshot): Updated snapshot for banner.tsx
SMotaal Feb 29, 2020
| https://github.com/nodejs/nodejs.dev/pull/366/commits/30f83227310ca314f6f4d7e49fd5c9c4f4ed3600 |
|
15ad5a3
build: Set explicit version for @smotaal.io/dark-mode-controller
SMotaal Feb 29, 2020
| https://github.com/nodejs/nodejs.dev/pull/366/commits/15ad5a3a37e9f5d0e952fa2464a7e23fa87d96ca |
|
955978c
build: Update yarn.lock
SMotaal Feb 29, 2020
| https://github.com/nodejs/nodejs.dev/pull/366/commits/955978c442ba18c078f07013aca87f26a99bae61 |
|
2aabe27
Merge branch 'staging' into refactor-enhanced-dark-mode
SMotaal Mar 11, 2020
| https://github.com/nodejs/nodejs.dev/pull/366/commits/2aabe274be96f596d9036e75a7d75e7df18327c0 |
|
Clear filters
| https://github.com/nodejs/nodejs.dev/pull/366/files |
| Please reload this page | https://github.com/nodejs/nodejs.dev/pull/366/files |
| Please reload this page | https://github.com/nodejs/nodejs.dev/pull/366/files |
|
.nvmrc
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-2c8effdf840690ccb88c7e21e56148978c6adb2c6926530c58ff0e47a9588b44 |
|
package.json
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
controls.tsx
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-5da631aac8c7d25ddcba8ef413a2bfa73ac40cdd5cc51681dd5a940417face0c |
|
header.tsx
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206 |
|
layout.tsx
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5 |
|
DarkModeController.js
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0991b0ea66d96371c3cef2f4bc2287aed26fedaebec5a3d44a7796c2f8b818a0 |
|
darkModeController.ts
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-5b8f2401bda48f61e9928303b091c1ebe7f605b091ddd27dcaef112b7219ba4d |
|
header.test.tsx.snap
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-ae16bf713631eed74cc9087f9a8e80ee983eac2c652134846ef9ca254f148875 |
|
yarn.lock
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de |
| .nvmrc | https://github.com/nodejs/nodejs.dev/pull/366/files#diff-2c8effdf840690ccb88c7e21e56148978c6adb2c6926530c58ff0e47a9588b44 |
|
View file
| https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/.nvmrc |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }} |
| Please reload this page | https://github.com/nodejs/nodejs.dev/pull/366/files |
| package.json | https://github.com/nodejs/nodejs.dev/pull/366/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
View file
| https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/package.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }} |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
| src/components/controls.tsx | https://github.com/nodejs/nodejs.dev/pull/366/files#diff-5da631aac8c7d25ddcba8ef413a2bfa73ac40cdd5cc51681dd5a940417face0c |
|
View file
| https://github.com/nodejs/nodejs.dev/blob/753ac9095da4f26a166a8a465663dcdb2b757844/src/components/controls.tsx |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/nodejs/nodejs.dev/pull/366/files |
| src/components/header.tsx | https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206 |
|
View file
| https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/src/components/header.tsx |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }} |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206 |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206 |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206 |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206 |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206 |
| src/components/layout.tsx | https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5 |
|
View file
| https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/src/components/layout.tsx |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }} |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5 |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5 |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5 |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5 |
| src/util/DarkModeController.js | https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0991b0ea66d96371c3cef2f4bc2287aed26fedaebec5a3d44a7796c2f8b818a0 |
|
View file
| https://github.com/nodejs/nodejs.dev/blob/753ac9095da4f26a166a8a465663dcdb2b757844/src/util/DarkModeController.js |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/nodejs/nodejs.dev/pull/366/files |
| src/util/darkModeController.ts | https://github.com/nodejs/nodejs.dev/pull/366/files#diff-5b8f2401bda48f61e9928303b091c1ebe7f605b091ddd27dcaef112b7219ba4d |
|
View file
| https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/src/util/darkModeController.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }} |
| test/components/__snapshots__/header.test.tsx.snap | https://github.com/nodejs/nodejs.dev/pull/366/files#diff-ae16bf713631eed74cc9087f9a8e80ee983eac2c652134846ef9ca254f148875 |
|
View file
| https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/test/components/__snapshots__/header.test.tsx.snap |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }} |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-ae16bf713631eed74cc9087f9a8e80ee983eac2c652134846ef9ca254f148875 |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-ae16bf713631eed74cc9087f9a8e80ee983eac2c652134846ef9ca254f148875 |
| yarn.lock | https://github.com/nodejs/nodejs.dev/pull/366/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de |
|
View file
| https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/yarn.lock |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }} |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de |
|
| https://github.com/nodejs/nodejs.dev/pull/366/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |