René's URL Explorer Experiment


Title: refactor: Enhanced Dark Mode as third-party dependency by SMotaal · Pull Request #366 · nodejs/nodejs.dev · GitHub

Open Graph Title: refactor: Enhanced Dark Mode as third-party dependency by SMotaal · Pull Request #366 · nodejs/nodejs.dev

X Title: refactor: Enhanced Dark Mode as third-party dependency by SMotaal · Pull Request #366 · nodejs/nodejs.dev

Description: Description It refactors out utils/DarkModeController.js as an external dependency. Note — Attempts to roll this out as a GPR dependency were abandoned. Progress Switch to using the external dependency Identify/Address upstream regressions Identify/Address local optimizations Restore accidentally removed .nvmrc Future Work Help Wanted Fix HMR bug — see @SMotaal/meta#7 Live Build Mar11 https://storage.googleapis.com/staging.nodejs.dev/2aabe27/index.html Feb29 https://storage.googleapis.com/staging.nodejs.dev/955978c/index.html Feb29 https://storage.googleapis.com/staging.nodejs.dev/30f8322/index.html Feb06 https://storage.googleapis.com/staging.nodejs.dev/a2780e5/index.html Feb06 https://storage.googleapis.com/staging.nodejs.dev/5b05bb6/index.html Nov13 https://storage.googleapis.com/staging.nodejs.dev/2ac2cf8/index.html Nov10 https://storage.googleapis.com/staging.nodejs.dev/2341fba/index.html Assets Mar11 https://storage.googleapis.com/staging.nodejs.dev/?prefix=2aabe27 Feb29 https://storage.googleapis.com/staging.nodejs.dev/?prefix=955978c Feb29 https://storage.googleapis.com/staging.nodejs.dev/?prefix=30f8322 Feb06 https://storage.googleapis.com/staging.nodejs.dev/?prefix=a2780e5 Feb06 https://storage.googleapis.com/staging.nodejs.dev/?prefix=5b05bb6 Nov13 https://storage.googleapis.com/staging.nodejs.dev/?prefix=2ac2cf8 Nov10 https://storage.googleapis.com/staging.nodejs.dev/?prefix=2341fba Related Issues Related to #352

Open Graph Description: Description It refactors out utils/DarkModeController.js as an external dependency. Note — Attempts to roll this out as a GPR dependency were abandoned. Progress Switch to using the external d...

X Description: Description It refactors out utils/DarkModeController.js as an external dependency. Note — Attempts to roll this out as a GPR dependency were abandoned. Progress Switch to using the external d...

Opengraph URL: https://github.com/nodejs/nodejs.dev/pull/366

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c4c38e69-64b3-b594-17c5-be785fd8c918
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE964:24ACB9:711D68:975E53:6B00D5BB
html-safe-nonce0786c1711acb6d9434244ed20cf03ef020918059a2e33d571cec3ccac399f76a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTY0OjI0QUNCOTo3MTFENjg6OTc1RTUzOjZCMDBENUJCIiwidmlzaXRvcl9pZCI6Ijc3NDQyMDM5MzM0NzU3MjI2ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac05ac5508e6578ef13e1df404cde8c2268deea85b12ca92341b2fd01b6c2c4830
hovercard-subject-tagpull_request:338211840
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/nodejs.dev/pull/366/files
twitter:imagehttps://avatars.githubusercontent.com/u/849613?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/849613?s=400&v=4
og:image:altDescription It refactors out utils/DarkModeController.js as an external dependency. Note — Attempts to roll this out as a GPR dependency were abandoned. Progress Switch to using the external d...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/nodejs.dev git https://github.com/nodejs/nodejs.dev.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id168201675
octolytics-dimension-repository_nwonodejs/nodejs.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id168201675
octolytics-dimension-repository_network_root_nwonodejs/nodejs.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/nodejs.dev/pull/366/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnodejs.dev%2Fpull%2F366%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnodejs.dev%2Fpull%2F366%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnodejs.dev
Reloadhttps://github.com/nodejs/nodejs.dev/pull/366/files
Reloadhttps://github.com/nodejs/nodejs.dev/pull/366/files
Reloadhttps://github.com/nodejs/nodejs.dev/pull/366/files
nodejshttps://github.com/nodejs
nodejs.devhttps://github.com/nodejs/nodejs.dev
Codehttps://github.com/nodejs/nodejs.dev
Pull requestshttps://github.com/nodejs/nodejs.dev/pulls
Actionshttps://github.com/nodejs/nodejs.dev/actions
Security and qualityhttps://github.com/nodejs/nodejs.dev/security
Insightshttps://github.com/nodejs/nodejs.dev/insights
SMotaalhttps://github.com/SMotaal
nodejs:staginghttps://github.com/nodejs/nodejs.dev/tree/staging
SMotaal:refactor-enhanced-dark-modehttps://github.com/SMotaal/nodejs.dev/tree/refactor-enhanced-dark-mode
Conversation 26 https://github.com/nodejs/nodejs.dev/pull/366
Commits 14 https://github.com/nodejs/nodejs.dev/pull/366/commits
Checks 0 https://github.com/nodejs/nodejs.dev/pull/366/checks
Files changed https://github.com/nodejs/nodejs.dev/pull/366/files
Please reload this pagehttps://github.com/nodejs/nodejs.dev/pull/366/files
refactor: Enhanced Dark Mode as third-party dependency https://github.com/nodejs/nodejs.dev/pull/366/files#top
Show all changes 14 commits https://github.com/nodejs/nodejs.dev/pull/366/files
1e7c5e0 refactor: Swap to @smotaal.io/dark-mode-controller NPM Nov 7, 2019 https://github.com/nodejs/nodejs.dev/pull/366/commits/1e7c5e0dde54cc3bc6e056b4f9c2b86540b7e6b9
993dbce build: Upgrade to @smotaal.io/dark-mode-controller@0.0.3 SMotaal Nov 10, 2019 https://github.com/nodejs/nodejs.dev/pull/366/commits/993dbce16900e74455a0f6b7142baf87ad1616d8
567ebbc fix: Delegating to dark-mode-controller not always stable SMotaal Nov 10, 2019 https://github.com/nodejs/nodejs.dev/pull/366/commits/567ebbcd04a7e746b1ab46f8d8abbae997919f77
247d9cb test: Update snapshots SMotaal Nov 10, 2019 https://github.com/nodejs/nodejs.dev/pull/366/commits/247d9cba967247a51110f505e3f98a89d3d9e46d
3a59084 fix: Restore accidentally deleted `.nvmrc` SMotaal Nov 13, 2019 https://github.com/nodejs/nodejs.dev/pull/366/commits/3a5908481b5eeae24a3c57da8ad19c3335e70a3d
5b05bb6 build: Upgrade to @smotaal.io/dark-mode-controller@0.0.4 SMotaal Feb 6, 2020 https://github.com/nodejs/nodejs.dev/pull/366/commits/5b05bb60d97aad829cce935bf1832dfdaef67df0
a2780e5 Merge branch 'staging' into refactor-enhanced-dark-mode SMotaal Feb 6, 2020 https://github.com/nodejs/nodejs.dev/pull/366/commits/a2780e56cb7d23002cd0b73d20af881aaeb990ed
4b5a28a Merge branch 'staging' of https://github.com/nodejs/nodejs.dev into r… SMotaal Feb 29, 2020 https://github.com/nodejs/nodejs.dev/pull/366/commits/4b5a28a361a0e344831310ef984a6fcdb693b5a6
e7b8768 refactor: Delete controls.tsx SMotaal Feb 29, 2020 https://github.com/nodejs/nodejs.dev/pull/366/commits/e7b8768204a5d7c387031d95e2ec720f216e4304
23401e0 refactor: Optionally cascade darkModeController as a property SMotaal Feb 29, 2020 https://github.com/nodejs/nodejs.dev/pull/366/commits/23401e0621312f6dfc0c7aff8c6b067d07bf2ea8
30f8322 test(snapshot): Updated snapshot for banner.tsx SMotaal Feb 29, 2020 https://github.com/nodejs/nodejs.dev/pull/366/commits/30f83227310ca314f6f4d7e49fd5c9c4f4ed3600
15ad5a3 build: Set explicit version for @smotaal.io/dark-mode-controller SMotaal Feb 29, 2020 https://github.com/nodejs/nodejs.dev/pull/366/commits/15ad5a3a37e9f5d0e952fa2464a7e23fa87d96ca
955978c build: Update yarn.lock SMotaal Feb 29, 2020 https://github.com/nodejs/nodejs.dev/pull/366/commits/955978c442ba18c078f07013aca87f26a99bae61
2aabe27 Merge branch 'staging' into refactor-enhanced-dark-mode SMotaal Mar 11, 2020 https://github.com/nodejs/nodejs.dev/pull/366/commits/2aabe274be96f596d9036e75a7d75e7df18327c0
Clear filters https://github.com/nodejs/nodejs.dev/pull/366/files
Please reload this pagehttps://github.com/nodejs/nodejs.dev/pull/366/files
Please reload this pagehttps://github.com/nodejs/nodejs.dev/pull/366/files
.nvmrc https://github.com/nodejs/nodejs.dev/pull/366/files#diff-2c8effdf840690ccb88c7e21e56148978c6adb2c6926530c58ff0e47a9588b44
package.json https://github.com/nodejs/nodejs.dev/pull/366/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
controls.tsx https://github.com/nodejs/nodejs.dev/pull/366/files#diff-5da631aac8c7d25ddcba8ef413a2bfa73ac40cdd5cc51681dd5a940417face0c
header.tsx https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206
layout.tsx https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5
DarkModeController.js https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0991b0ea66d96371c3cef2f4bc2287aed26fedaebec5a3d44a7796c2f8b818a0
darkModeController.ts https://github.com/nodejs/nodejs.dev/pull/366/files#diff-5b8f2401bda48f61e9928303b091c1ebe7f605b091ddd27dcaef112b7219ba4d
header.test.tsx.snap https://github.com/nodejs/nodejs.dev/pull/366/files#diff-ae16bf713631eed74cc9087f9a8e80ee983eac2c652134846ef9ca254f148875
yarn.lock https://github.com/nodejs/nodejs.dev/pull/366/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de
.nvmrchttps://github.com/nodejs/nodejs.dev/pull/366/files#diff-2c8effdf840690ccb88c7e21e56148978c6adb2c6926530c58ff0e47a9588b44
View file https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/.nvmrc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/nodejs.dev/pull/366/files
package.jsonhttps://github.com/nodejs/nodejs.dev/pull/366/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }}
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
src/components/controls.tsxhttps://github.com/nodejs/nodejs.dev/pull/366/files#diff-5da631aac8c7d25ddcba8ef413a2bfa73ac40cdd5cc51681dd5a940417face0c
View file https://github.com/nodejs/nodejs.dev/blob/753ac9095da4f26a166a8a465663dcdb2b757844/src/components/controls.tsx
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/nodejs/nodejs.dev/pull/366/files
src/components/header.tsxhttps://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206
View file https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/src/components/header.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }}
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-8387d64f5b5e50e1e386a42e75a377d0d8bf6d40a149697aca42cfeda4c8c206
src/components/layout.tsxhttps://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5
View file https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/src/components/layout.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }}
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-0b75a532e530ce749a966d77dffeea3593e67560e5894213143637ee1d84aef5
src/util/DarkModeController.jshttps://github.com/nodejs/nodejs.dev/pull/366/files#diff-0991b0ea66d96371c3cef2f4bc2287aed26fedaebec5a3d44a7796c2f8b818a0
View file https://github.com/nodejs/nodejs.dev/blob/753ac9095da4f26a166a8a465663dcdb2b757844/src/util/DarkModeController.js
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/nodejs/nodejs.dev/pull/366/files
src/util/darkModeController.tshttps://github.com/nodejs/nodejs.dev/pull/366/files#diff-5b8f2401bda48f61e9928303b091c1ebe7f605b091ddd27dcaef112b7219ba4d
View file https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/src/util/darkModeController.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }}
test/components/__snapshots__/header.test.tsx.snaphttps://github.com/nodejs/nodejs.dev/pull/366/files#diff-ae16bf713631eed74cc9087f9a8e80ee983eac2c652134846ef9ca254f148875
View file https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/test/components/__snapshots__/header.test.tsx.snap
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }}
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-ae16bf713631eed74cc9087f9a8e80ee983eac2c652134846ef9ca254f148875
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-ae16bf713631eed74cc9087f9a8e80ee983eac2c652134846ef9ca254f148875
yarn.lockhttps://github.com/nodejs/nodejs.dev/pull/366/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de
View file https://github.com/SMotaal/nodejs.dev/blob/2aabe274be96f596d9036e75a7d75e7df18327c0/yarn.lock
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/nodejs.dev/pull/366/{{ revealButtonHref }}
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de
https://github.com/nodejs/nodejs.dev/pull/366/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.