| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:26239936-daab-7ed2-875c-c86b1d5f842b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9EE0:C1AA7:4D1B3A:6A6331:6AEDBCBF |
| html-safe-nonce | 494b70d7ca1dd130d072e3365927d2492ab07f4837d7e85da540dd3becae1228 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUUwOkMxQUE3OjREMUIzQTo2QTYzMzE6NkFFREJDQkYiLCJ2aXNpdG9yX2lkIjoiMjk1MjkwODk0MTE0MzQyNDE5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5c0f17beb3572e9eb598e92bfef5f63803db8ec12fe392382959eba57944a0f3 |
| hovercard-subject-tag | pull_request:400033833 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
| twitter:image | https://avatars.githubusercontent.com/u/3759816?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3759816?s=400&v=4 |
| og:image:alt | See https://github.com/gengjiawen/node-v8/blob/f1add0594a838793871fc8d785fc7bf1cdf30441/deps/v8/include/v8.h#L5064
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1eb5f7cedbc707472687eab1a30e6c4619c00791815622ceaba9694eb161930f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node-v8 git https://github.com/nodejs/node-v8.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 90261711 |
| octolytics-dimension-repository_nwo | nodejs/node-v8 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 90261711 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node-v8 |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f31f9c89203c022acdb651c34ae048cf41764208 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-v8%2Fpull%2F154%2Fcommits%2Fd93140b65a85fd34781e9071768b8871999c19ca |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-v8%2Fpull%2F154%2Fcommits%2Fd93140b65a85fd34781e9071768b8871999c19ca |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode-v8 |
| Reload | https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
| Reload | https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
| Reload | https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
| nodejs | https://github.com/nodejs |
| node-v8 | https://github.com/nodejs/node-v8 |
| Code | https://github.com/nodejs/node-v8 |
| Issues11 (11) | https://github.com/nodejs/node-v8/issues |
| Pull requests | https://github.com/nodejs/node-v8/pulls |
| Actions | https://github.com/nodejs/node-v8/actions |
| Projects | https://github.com/nodejs/node-v8/projects |
| Security and quality | https://github.com/nodejs/node-v8/security |
| Insights | https://github.com/nodejs/node-v8/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode-v8%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode-v8%2Fissues%2Fnew%2Fchoose |
| gengjiawen | https://github.com/gengjiawen |
| nodejs:canary | https://github.com/nodejs/node-v8/tree/canary |
| gengjiawen:bugfix/buffer | https://github.com/gengjiawen/node-v8/tree/bugfix/buffer |
|
Conversation
4
| https://github.com/nodejs/node-v8/pull/154 |
|
Commits
2
| https://github.com/nodejs/node-v8/pull/154/commits |
|
Checks
0
| https://github.com/nodejs/node-v8/pull/154/checks |
|
Files changed
| https://github.com/nodejs/node-v8/pull/154/files |
| Please reload this page | https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
|
src: remove Reallocate since it introduced in upstream v8
| https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca#top |
|
Show all changes
2 commits
| https://github.com/nodejs/node-v8/pull/154/files |
|
413f9fd
deps: update V8 to 8.4.0
nodejs-ci Apr 5, 2020
| https://github.com/nodejs/node-v8/pull/154/commits/413f9fd4ccb65ad66efea88fe50f50c51b35b6b2 |
|
d93140b
src: remove Reallocate since it introduced in upstream v8
gengjiawen Apr 7, 2020
| https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
|
Clear filters
| https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
| Please reload this page | https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
| Please reload this page | https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
|
Prev
| https://github.com/nodejs/node-v8/pull/154/commits/413f9fd4ccb65ad66efea88fe50f50c51b35b6b2 |
| Please reload this page | https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
|
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/nodejs/node-v8/commits?author=gengjiawen |
| src/node_internals.h | https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d |
|
View file
| https://github.com/gengjiawen/node-v8/blob/d93140b65a85fd34781e9071768b8871999c19ca/src/node_internals.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node-v8/pull/154/commits/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d |
|
| https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca#diff-6648b37276e20be36473a32445be879f73cedc8d557c06a8a8dfc9adb013a42d |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |