| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:39687998-d697-0f6b-becd-d79a2fd44984 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BB38:21A83E:B4CE40:EBBDF3:6AED4809 |
| html-safe-nonce | c9125c3ff9a6e0f9083a0d74f278a74d73d5fe0a7f95d2d15da55b9645105163 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjM4OjIxQTgzRTpCNENFNDA6RUJCREYzOjZBRUQ0ODA5IiwidmlzaXRvcl9pZCI6IjI3ODgyOTU0ODkwNzE0MzM3MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 01097ee13cdaaa4b5897262e3ae0bce1c9c5ac2ca5649f0987455d4f58c6c889 |
| hovercard-subject-tag | pull_request:400033833 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-v8/154/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ba5d0d446854c1f70286d92fe426fe680e60f36afb0843df3a18899b83eef179/nodejs/node-v8/pull/154 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ba5d0d446854c1f70286d92fe426fe680e60f36afb0843df3a18899b83eef179/nodejs/node-v8/pull/154 |
| og:image:alt | See https://github.com/gengjiawen/node-v8/blob/f1add0594a838793871fc8d785fc7bf1cdf30441/deps/v8/include/v8.h#L5064
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gengjiawen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node-v8 git https://github.com/nodejs/node-v8.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 90261711 |
| octolytics-dimension-repository_nwo | nodejs/node-v8 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 90261711 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node-v8 |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/nodejs/node-v8/pull/154#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-v8%2Fpull%2F154 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-v8%2Fpull%2F154 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode-v8 |
| Reload | https://github.com/nodejs/node-v8/pull/154 |
| Reload | https://github.com/nodejs/node-v8/pull/154 |
| Reload | https://github.com/nodejs/node-v8/pull/154 |
| nodejs | https://github.com/nodejs |
| node-v8 | https://github.com/nodejs/node-v8 |
| Code | https://github.com/nodejs/node-v8 |
| Issues11 (11) | https://github.com/nodejs/node-v8/issues |
| Pull requests | https://github.com/nodejs/node-v8/pulls |
| Actions | https://github.com/nodejs/node-v8/actions |
| Projects | https://github.com/nodejs/node-v8/projects |
| Security and quality | https://github.com/nodejs/node-v8/security |
| Insights | https://github.com/nodejs/node-v8/pulse |
| https://github.com/nodejs/node-v8 |
| gengjiawen | https://github.com/gengjiawen |
| nodejs:canary | https://github.com/nodejs/node-v8/tree/canary |
| gengjiawen:bugfix/buffer | https://github.com/gengjiawen/node-v8/tree/bugfix/buffer |
| Conversation | https://github.com/nodejs/node-v8/pull/154 |
| Commits2 (2) | https://github.com/nodejs/node-v8/pull/154/commits |
| Checks | https://github.com/nodejs/node-v8/pull/154/checks |
| Files changed | https://github.com/nodejs/node-v8/pull/154/files |
| src: remove Reallocate since it introduced in upstream v8 | https://github.com/nodejs/node-v8/pull/154#top |
| gengjiawen | https://github.com/gengjiawen |
| nodejs:canary | https://github.com/nodejs/node-v8/tree/canary |
| gengjiawen:bugfix/buffer | https://github.com/gengjiawen/node-v8/tree/bugfix/buffer |
|
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 7, 2020 | https://github.com/nodejs/node-v8/pull/154#issue-595585803 |
| https://github.com/gengjiawen/node-v8/blob/f1add0594a838793871fc8d785fc7bf1cdf30441/deps/v8/include/v8.h#L5064 | https://github.com/gengjiawen/node-v8/blob/f1add0594a838793871fc8d785fc7bf1cdf30441/deps/v8/include/v8.h#L5064 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node-v8/pull/154 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| addaleax | https://github.com/addaleax |
| April 7, 2020 04:42 | https://github.com/nodejs/node-v8/pull/154#event-3208156963 |
| https://github.com/nodejs-ci |
| nodejs-ci | https://github.com/nodejs-ci |
| force-pushed | https://github.com/nodejs/node-v8/compare/a0ba79f8ed0a47377472f36ba278dc99e4e4f33b..ca0d7f295bc50209976cb35bc63a78d56e2cffd2 |
| a0ba79f | https://github.com/nodejs/node-v8/commit/a0ba79f8ed0a47377472f36ba278dc99e4e4f33b |
| ca0d7f2 | https://github.com/nodejs/node-v8/commit/ca0d7f295bc50209976cb35bc63a78d56e2cffd2 |
|
Compare
| https://github.com/nodejs/node-v8/compare/a0ba79f8ed0a47377472f36ba278dc99e4e4f33b..ca0d7f295bc50209976cb35bc63a78d56e2cffd2 |
| April 7, 2020 06:57 | https://github.com/nodejs/node-v8/pull/154#event-3208451115 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Apr 7, 2020 | https://github.com/nodejs/node-v8/pull/154#issuecomment-610366681 |
| @gengjiawen | https://github.com/gengjiawen |
| Please reload this page | https://github.com/nodejs/node-v8/pull/154 |
|
| https://github.com/nodejs-ci |
|
| https://github.com/gengjiawen |
| deps: update V8 to 8.4.0 | https://github.com/nodejs/node-v8/pull/154/commits/413f9fd4ccb65ad66efea88fe50f50c51b35b6b2 |
| 413f9fd | https://github.com/nodejs/node-v8/pull/154/commits/413f9fd4ccb65ad66efea88fe50f50c51b35b6b2 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 7, 2020 | https://github.com/nodejs/node-v8/pull/154#issuecomment-610381628 |
| @gengjiawen | https://github.com/gengjiawen |
| Please reload this page | https://github.com/nodejs/node-v8/pull/154 |
|
| https://github.com/gengjiawen |
| src: remove Reallocate since it introduced in upstream v8 | https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
| d93140b | https://github.com/nodejs/node-v8/pull/154/commits/d93140b65a85fd34781e9071768b8871999c19ca |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| force-pushed | https://github.com/nodejs/node-v8/compare/650d6280a942acd5b5e9e2a3e71797da687ed5b6..d93140b65a85fd34781e9071768b8871999c19ca |
| 650d628 | https://github.com/nodejs/node-v8/commit/650d6280a942acd5b5e9e2a3e71797da687ed5b6 |
| d93140b | https://github.com/nodejs/node-v8/commit/d93140b65a85fd34781e9071768b8871999c19ca |
|
Compare
| https://github.com/nodejs/node-v8/compare/650d6280a942acd5b5e9e2a3e71797da687ed5b6..d93140b65a85fd34781e9071768b8871999c19ca |
| April 7, 2020 13:22 | https://github.com/nodejs/node-v8/pull/154#event-3209831882 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Apr 7, 2020 | https://github.com/nodejs/node-v8/pull/154#issuecomment-610535409 |
| @gengjiawen | https://github.com/gengjiawen |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node-v8/pull/154 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 8, 2020 | https://github.com/nodejs/node-v8/pull/154#issuecomment-610698907 |
| @gengjiawen | https://github.com/gengjiawen |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node-v8/pull/154 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 8, 2020 | https://github.com/nodejs/node-v8/pull/154#event-3212163872 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| April 8, 2020 01:19 | https://github.com/nodejs/node-v8/pull/154#event-3212164193 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Apr 8, 2020
| https://github.com/nodejs/node-v8/pull/154#ref-pullrequest-596517429 |
|
src: refactor Reallocate since it introduced in upstream v8
nodejs/node#32716
| https://github.com/nodejs/node/pull/32716 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node-v8/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-v8%2Fpull%2F154 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node-v8/pull/154 |
| Please reload this page | https://github.com/nodejs/node-v8/pull/154 |
|
| https://github.com/gengjiawen |
|
| https://github.com/addaleax |
|
| https://github.com/mmarchini |
|
| https://github.com/nodejs-ci |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |