René's URL Explorer Experiment


Title: Force push does not invalidate existing approved reviews · Issue #677 · nodejs/node-core-utils · GitHub

Open Graph Title: Force push does not invalidate existing approved reviews · Issue #677 · nodejs/node-core-utils

X Title: Force push does not invalidate existing approved reviews · Issue #677 · nodejs/node-core-utils

Description: If the author force pushes to their branch after a reviewer approved it, I assumed that it would invalidate existing approved reviews, since the code that was reviewed is changed. But right now approved reviews count as valid ones, and m...

Open Graph Description: If the author force pushes to their branch after a reviewer approved it, I assumed that it would invalidate existing approved reviews, since the code that was reviewed is changed. But right now app...

X Description: If the author force pushes to their branch after a reviewer approved it, I assumed that it would invalidate existing approved reviews, since the code that was reviewed is changed. But right now app...

Opengraph URL: https://github.com/nodejs/node-core-utils/issues/677

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Force push does not invalidate existing approved reviews","articleBody":"If the author force pushes to their branch after a reviewer approved it, I assumed that it would invalidate existing approved reviews, since the code that was reviewed is changed. But right now approved reviews count as valid ones, and might lead to unwanted code to be merged to main.\r\n\r\nExample https://github.com/nodejs/node/pull/46904\r\n\r\n```\r\n➜  node git:(main) ✗ git node metadata 46904\r\n✔  Done loading data for nodejs/node/pull/46904\r\n----------------------------------- PR info ------------------------------------\r\nTitle      url: use private properties for brand check (#46904)\r\nAuthor     Yagiz Nizipli \u003cyagiz@nizipli.com\u003e (@anonrig)\r\nBranch     anonrig:url-context -\u003e nodejs:main\r\nLabels     semver-major, performance, whatwg-url, esm, author ready, worker, needs-ci\r\nCommits    1\r\n - url: use private properties for brand check\r\nCommitters 1\r\n - Yagiz Nizipli \u003cyagiz@nizipli.com\u003e\r\n------------------------------ Generated metadata ------------------------------\r\nPR-URL: https://github.com/nodejs/node/pull/46904\r\nReviewed-By: Antoine du Hamel \u003cduhamelantoine1995@gmail.com\u003e\r\nReviewed-By: Ruben Bridgewater \u003cruben@bridgewater.de\u003e\r\nReviewed-By: Benjamin Gruenbaum \u003cbenjamingr@gmail.com\u003e\r\n--------------------------------------------------------------------------------\r\n   ℹ  This PR was created on Wed, 01 Mar 2023 21:28:43 GMT\r\n   ✔  Approvals: 3\r\n   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46904#pullrequestreview-1320667498\r\n   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/46904#pullrequestreview-1320668469\r\n   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/46904#pullrequestreview-1321281126\r\n   ✖  This PR needs to wait 21 more hours to land\r\n   ✖  GitHub CI is still running\r\n   ℹ  Last Full PR CI on 2023-03-02T23:13:10Z: https://ci.nodejs.org/job/node-test-pull-request/50175/\r\n✔  Build data downloaded\r\n   ✖  Last Jenkins CI still running\r\n```","author":{"url":"https://github.com/anonrig","@type":"Person","name":"anonrig"},"datePublished":"2023-03-02T23:42:32.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":11},"url":"https://github.com/677/node-core-utils/issues/677"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:93ef9aae-4a10-26f6-d6a0-4f27fc7d1101
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA47C:A7ECB:232BAD:2F7EE1:6A4D33FB
html-safe-noncebe58a48d99f85ac28c140e1ba3df4852d649de4af27a9856ae3ad54f8a3d0352
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDdDOkE3RUNCOjIzMkJBRDoyRjdFRTE6NkE0RDMzRkIiLCJ2aXNpdG9yX2lkIjoiODkxMjY4OTM2ODc1OTM1MDI2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2042a881b311c55d084aaf8b779163524ccd3dfa82706f04ba71a3c669bf2724
hovercard-subject-tagissue:1607703177
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node-core-utils/677/issue_layout
twitter:imagehttps://opengraph.githubassets.com/19733639eddc12f7289da4a78d75662e9ec643ad3e5f8a8d10fae7f4f09e7d7b/nodejs/node-core-utils/issues/677
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/19733639eddc12f7289da4a78d75662e9ec643ad3e5f8a8d10fae7f4f09e7d7b/nodejs/node-core-utils/issues/677
og:image:altIf the author force pushes to their branch after a reviewer approved it, I assumed that it would invalidate existing approved reviews, since the code that was reviewed is changed. But right now app...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanonrig
hostnamegithub.com
expected-hostnamegithub.com
None92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node-core-utils git https://github.com/nodejs/node-core-utils.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id107863796
octolytics-dimension-repository_nwonodejs/node-core-utils
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id107863796
octolytics-dimension-repository_network_root_nwonodejs/node-core-utils
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56fc8347865a14e2ec811533d68f929cf4e0ec19
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node-core-utils/issues/677#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-core-utils%2Fissues%2F677
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-core-utils%2Fissues%2F677
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=nodejs%2Fnode-core-utils
Reloadhttps://github.com/nodejs/node-core-utils/issues/677
Reloadhttps://github.com/nodejs/node-core-utils/issues/677
Reloadhttps://github.com/nodejs/node-core-utils/issues/677
Please reload this pagehttps://github.com/nodejs/node-core-utils/issues/677
nodejs https://github.com/nodejs
node-core-utilshttps://github.com/nodejs/node-core-utils
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode-core-utils
Fork 131 https://github.com/login?return_to=%2Fnodejs%2Fnode-core-utils
Star 311 https://github.com/login?return_to=%2Fnodejs%2Fnode-core-utils
Code https://github.com/nodejs/node-core-utils
Issues 63 https://github.com/nodejs/node-core-utils/issues
Pull requests 27 https://github.com/nodejs/node-core-utils/pulls
Actions https://github.com/nodejs/node-core-utils/actions
Projects https://github.com/nodejs/node-core-utils/projects
Security and quality 0 https://github.com/nodejs/node-core-utils/security
Insights https://github.com/nodejs/node-core-utils/pulse
Code https://github.com/nodejs/node-core-utils
Issues https://github.com/nodejs/node-core-utils/issues
Pull requests https://github.com/nodejs/node-core-utils/pulls
Actions https://github.com/nodejs/node-core-utils/actions
Projects https://github.com/nodejs/node-core-utils/projects
Security and quality https://github.com/nodejs/node-core-utils/security
Insights https://github.com/nodejs/node-core-utils/pulse
Force push does not invalidate existing approved reviewshttps://github.com/nodejs/node-core-utils/issues/677#top
bughttps://github.com/nodejs/node-core-utils/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/anonrig
anonrighttps://github.com/anonrig
on Mar 2, 2023https://github.com/nodejs/node-core-utils/issues/677#issue-1607703177
nodejs/node#46904https://github.com/nodejs/node/pull/46904
bughttps://github.com/nodejs/node-core-utils/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.