Title: Force push does not invalidate existing approved reviews · Issue #677 · nodejs/node-core-utils · GitHub
Open Graph Title: Force push does not invalidate existing approved reviews · Issue #677 · nodejs/node-core-utils
X Title: Force push does not invalidate existing approved reviews · Issue #677 · nodejs/node-core-utils
Description: If the author force pushes to their branch after a reviewer approved it, I assumed that it would invalidate existing approved reviews, since the code that was reviewed is changed. But right now approved reviews count as valid ones, and m...
Open Graph Description: If the author force pushes to their branch after a reviewer approved it, I assumed that it would invalidate existing approved reviews, since the code that was reviewed is changed. But right now app...
X Description: If the author force pushes to their branch after a reviewer approved it, I assumed that it would invalidate existing approved reviews, since the code that was reviewed is changed. But right now app...
Opengraph URL: https://github.com/nodejs/node-core-utils/issues/677
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Force push does not invalidate existing approved reviews","articleBody":"If the author force pushes to their branch after a reviewer approved it, I assumed that it would invalidate existing approved reviews, since the code that was reviewed is changed. But right now approved reviews count as valid ones, and might lead to unwanted code to be merged to main.\r\n\r\nExample https://github.com/nodejs/node/pull/46904\r\n\r\n```\r\n➜ node git:(main) ✗ git node metadata 46904\r\n✔ Done loading data for nodejs/node/pull/46904\r\n----------------------------------- PR info ------------------------------------\r\nTitle url: use private properties for brand check (#46904)\r\nAuthor Yagiz Nizipli \u003cyagiz@nizipli.com\u003e (@anonrig)\r\nBranch anonrig:url-context -\u003e nodejs:main\r\nLabels semver-major, performance, whatwg-url, esm, author ready, worker, needs-ci\r\nCommits 1\r\n - url: use private properties for brand check\r\nCommitters 1\r\n - Yagiz Nizipli \u003cyagiz@nizipli.com\u003e\r\n------------------------------ Generated metadata ------------------------------\r\nPR-URL: https://github.com/nodejs/node/pull/46904\r\nReviewed-By: Antoine du Hamel \u003cduhamelantoine1995@gmail.com\u003e\r\nReviewed-By: Ruben Bridgewater \u003cruben@bridgewater.de\u003e\r\nReviewed-By: Benjamin Gruenbaum \u003cbenjamingr@gmail.com\u003e\r\n--------------------------------------------------------------------------------\r\n ℹ This PR was created on Wed, 01 Mar 2023 21:28:43 GMT\r\n ✔ Approvals: 3\r\n ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46904#pullrequestreview-1320667498\r\n ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/46904#pullrequestreview-1320668469\r\n ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/46904#pullrequestreview-1321281126\r\n ✖ This PR needs to wait 21 more hours to land\r\n ✖ GitHub CI is still running\r\n ℹ Last Full PR CI on 2023-03-02T23:13:10Z: https://ci.nodejs.org/job/node-test-pull-request/50175/\r\n✔ Build data downloaded\r\n ✖ Last Jenkins CI still running\r\n```","author":{"url":"https://github.com/anonrig","@type":"Person","name":"anonrig"},"datePublished":"2023-03-02T23:42:32.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":11},"url":"https://github.com/677/node-core-utils/issues/677"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:93ef9aae-4a10-26f6-d6a0-4f27fc7d1101 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A47C:A7ECB:232BAD:2F7EE1:6A4D33FB |
| html-safe-nonce | be58a48d99f85ac28c140e1ba3df4852d649de4af27a9856ae3ad54f8a3d0352 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDdDOkE3RUNCOjIzMkJBRDoyRjdFRTE6NkE0RDMzRkIiLCJ2aXNpdG9yX2lkIjoiODkxMjY4OTM2ODc1OTM1MDI2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2042a881b311c55d084aaf8b779163524ccd3dfa82706f04ba71a3c669bf2724 |
| hovercard-subject-tag | issue:1607703177 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/nodejs/node-core-utils/677/issue_layout |
| twitter:image | https://opengraph.githubassets.com/19733639eddc12f7289da4a78d75662e9ec643ad3e5f8a8d10fae7f4f09e7d7b/nodejs/node-core-utils/issues/677 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/19733639eddc12f7289da4a78d75662e9ec643ad3e5f8a8d10fae7f4f09e7d7b/nodejs/node-core-utils/issues/677 |
| og:image:alt | If the author force pushes to their branch after a reviewer approved it, I assumed that it would invalidate existing approved reviews, since the code that was reviewed is changed. But right now app... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | anonrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node-core-utils git https://github.com/nodejs/node-core-utils.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 107863796 |
| octolytics-dimension-repository_nwo | nodejs/node-core-utils |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 107863796 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node-core-utils |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56fc8347865a14e2ec811533d68f929cf4e0ec19 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width