René's URL Explorer Experiment


Title: fixes v8 GC access violation for zombie objects by blagoev · Pull Request #638 · nodejs/node-addon-api · GitHub

Open Graph Title: fixes v8 GC access violation for zombie objects by blagoev · Pull Request #638 · nodejs/node-addon-api

X Title: fixes v8 GC access violation for zombie objects by blagoev · Pull Request #638 · nodejs/node-addon-api

Description: Module for using Node-API from C++. Contribute to nodejs/node-addon-api development by creating an account on GitHub.

Open Graph Description: fix v8 GC access violation after napi ObjectWrap instance is left in zombie state by an exception in its constructor closes this #635

X Description: fix v8 GC access violation after napi ObjectWrap instance is left in zombie state by an exception in its constructor closes this #635

Opengraph URL: https://github.com/nodejs/node-addon-api/pull/638

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6791c047-759c-10d0-149e-8d192bfa0b07
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD36:16CCCC:27C3808:374B5C3:6A4F568F
html-safe-nonce30112efeb92dce8d72060401fce89adadfb4bee57498d92accb78c1fa33502e1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDM2OjE2Q0NDQzoyN0MzODA4OjM3NEI1QzM6NkE0RjU2OEYiLCJ2aXNpdG9yX2lkIjoiNDE1MTM5NDYzNzA5MTY1NzM1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace37cfabd9585cdeef68c07dd42e168eb2fc4908a48bb7b36df92a488e0129b90
hovercard-subject-tagpull_request:355626620
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-addon-api/638/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6717d5885df9c82d5acc388d8082a733a9b5cf8a50eb1d17874f721b9abbe00b/nodejs/node-addon-api/pull/638
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6717d5885df9c82d5acc388d8082a733a9b5cf8a50eb1d17874f721b9abbe00b/nodejs/node-addon-api/pull/638
og:image:altfix v8 GC access violation after napi ObjectWrap instance is left in zombie state by an exception in its constructor closes this #635
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameblagoev
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node-addon-api git https://github.com/nodejs/node-addon-api.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id81384578
octolytics-dimension-repository_nwonodejs/node-addon-api
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81384578
octolytics-dimension-repository_network_root_nwonodejs/node-addon-api
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node-addon-api/pull/638#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F638
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F638
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode-addon-api
Reloadhttps://github.com/nodejs/node-addon-api/pull/638
Reloadhttps://github.com/nodejs/node-addon-api/pull/638
Reloadhttps://github.com/nodejs/node-addon-api/pull/638
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
nodejs https://github.com/nodejs
node-addon-apihttps://github.com/nodejs/node-addon-api
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Fork 500 https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Star 2.4k https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Code https://github.com/nodejs/node-addon-api
Issues 10 https://github.com/nodejs/node-addon-api/issues
Pull requests 4 https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security and quality 0 https://github.com/nodejs/node-addon-api/security
Insights https://github.com/nodejs/node-addon-api/pulse
Code https://github.com/nodejs/node-addon-api
Issues https://github.com/nodejs/node-addon-api/issues
Pull requests https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security and quality https://github.com/nodejs/node-addon-api/security
Insights https://github.com/nodejs/node-addon-api/pulse
blagoevhttps://github.com/blagoev
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
blagoev:fix-zombie-objects-finalizationhttps://github.com/blagoev/node-addon-api/tree/fix-zombie-objects-finalization
Conversationhttps://github.com/nodejs/node-addon-api/pull/638
Commits5 (5)https://github.com/nodejs/node-addon-api/pull/638/commits
Checkshttps://github.com/nodejs/node-addon-api/pull/638/checks
Files changedhttps://github.com/nodejs/node-addon-api/pull/638/files
fixes v8 GC access violation for zombie objectshttps://github.com/nodejs/node-addon-api/pull/638#top
blagoevhttps://github.com/blagoev
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
blagoev:fix-zombie-objects-finalizationhttps://github.com/blagoev/node-addon-api/tree/fix-zombie-objects-finalization
https://github.com/blagoev
blagoevhttps://github.com/blagoev
Dec 20, 2019https://github.com/nodejs/node-addon-api/pull/638#issue-540873023
#635https://github.com/nodejs/node-addon-api/issues/635
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/blagoev
fix v8 GC access violation after napi ObjectWrap instance is left in …https://github.com/nodejs/node-addon-api/pull/638/commits/7c59fab1bca576212836c465da8e9ef4d3dba896
7c59fabhttps://github.com/nodejs/node-addon-api/pull/638/commits/7c59fab1bca576212836c465da8e9ef4d3dba896
https://github.com/blagoev
blagoevhttps://github.com/blagoev
Dec 20, 2019https://github.com/nodejs/node-addon-api/pull/638#issuecomment-567851070
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
blagoevhttps://github.com/blagoev
December 24, 2019 10:15https://github.com/nodejs/node-addon-api/pull/638#commits-pushed-beb4920
https://github.com/blagoev
handle exceptions disabled casehttps://github.com/nodejs/node-addon-api/pull/638/commits/beb4920e723a14ca91b1ea3611e7a561ffabe4ec
beb4920https://github.com/nodejs/node-addon-api/pull/638/commits/beb4920e723a14ca91b1ea3611e7a561ffabe4ec
https://github.com/blagoev
specify return value typehttps://github.com/nodejs/node-addon-api/pull/638/commits/80d6607e0fa41ad67949566cc2464b60fce4bc08
80d6607https://github.com/nodejs/node-addon-api/pull/638/commits/80d6607e0fa41ad67949566cc2464b60fce4bc08
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 25, 2019https://github.com/nodejs/node-addon-api/pull/638#issuecomment-568833099
@blagoevhttps://github.com/blagoev
#600https://github.com/nodejs/node-addon-api/pull/600
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 25, 2019https://github.com/nodejs/node-addon-api/pull/638#issuecomment-568833501
@blagoevhttps://github.com/blagoev
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/blagoev
blagoevhttps://github.com/blagoev
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#issuecomment-569611916
#600https://github.com/nodejs/node-addon-api/pull/600
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/blagoev
add a test for constructor exceptionshttps://github.com/nodejs/node-addon-api/pull/638/commits/41c7a89b0234fb126c2b87a5d32efd98ea850529
41c7a89https://github.com/nodejs/node-addon-api/pull/638/commits/41c7a89b0234fb126c2b87a5d32efd98ea850529
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019 https://github.com/nodejs/node-addon-api/pull/638#pullrequestreview-337177780
View reviewed changes https://github.com/nodejs/node-addon-api/pull/638/files/41c7a89b0234fb126c2b87a5d32efd98ea850529
gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/nodejs/node-addon-api/pull/638#pullrequestreview-337177780
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi.hhttps://github.com/nodejs/node-addon-api/pull/638/files/41c7a89b0234fb126c2b87a5d32efd98ea850529#diff-6294f8ee1d8cd7e4e94cfc22a083380fb80058e34f53100d895b9b3b295dd801
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#discussion_r362045149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/41c7a89b0234fb126c2b87a5d32efd98ea850529#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#discussion_r362045277
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/41c7a89b0234fb126c2b87a5d32efd98ea850529#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#discussion_r362045449
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/41c7a89b0234fb126c2b87a5d32efd98ea850529#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#discussion_r362050918
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/41c7a89b0234fb126c2b87a5d32efd98ea850529#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#discussion_r362051228
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/41c7a89b0234fb126c2b87a5d32efd98ea850529#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/41c7a89b0234fb126c2b87a5d32efd98ea850529#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#discussion_r362056067
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/41c7a89b0234fb126c2b87a5d32efd98ea850529#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#discussion_r362056208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
test/objectwrap.cchttps://github.com/nodejs/node-addon-api/pull/638/files/41c7a89b0234fb126c2b87a5d32efd98ea850529#diff-7be4d5cb6740acf2d39cbdcf8f3156bcf46370eca854c283c499ccab2cd3ddf1
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#discussion_r362057661
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/41c7a89b0234fb126c2b87a5d32efd98ea850529#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#discussion_r362061538
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#discussion_r362063433
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#issuecomment-569761016
@danandersonhttps://github.com/dananderson
@dmitryashhttps://github.com/dmitryash
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#issuecomment-569761762
@blagoevhttps://github.com/blagoev
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/blagoev
blagoevhttps://github.com/blagoev
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#issuecomment-569769388
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 30, 2019https://github.com/nodejs/node-addon-api/pull/638#issuecomment-569780694
@gabrielschulhofhttps://github.com/gabrielschulhof
#600https://github.com/nodejs/node-addon-api/pull/600
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/blagoev
refactored constructor exceptions fix.https://github.com/nodejs/node-addon-api/pull/638/commits/253a9e1025b75f87002757d2cdbf23b51ee33288
253a9e1https://github.com/nodejs/node-addon-api/pull/638/commits/253a9e1025b75f87002757d2cdbf23b51ee33288
https://github.com/blagoev
blagoevhttps://github.com/blagoev
Dec 31, 2019https://github.com/nodejs/node-addon-api/pull/638#issuecomment-569918229
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 31, 2019 https://github.com/nodejs/node-addon-api/pull/638#pullrequestreview-337411671
View reviewed changes https://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288
gabrielschulhofhttps://github.com/gabrielschulhof
https://github.com/nodejs/node-addon-api/pull/638#pullrequestreview-337411671
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Dec 31, 2019https://github.com/nodejs/node-addon-api/pull/638#issuecomment-569990543
@blagoevhttps://github.com/blagoev
https://github.com/nodehs/node-addon-api/pull/600/fileshttps://github.com/nodehs/node-addon-api/pull/600/files
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 1, 2020 https://github.com/nodejs/node-addon-api/pull/638#pullrequestreview-337468150
View reviewed changes https://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288
napi.hhttps://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288#diff-6294f8ee1d8cd7e4e94cfc22a083380fb80058e34f53100d895b9b3b295dd801
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 1, 2020https://github.com/nodejs/node-addon-api/pull/638#discussion_r362298191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 1, 2020 https://github.com/nodejs/node-addon-api/pull/638#pullrequestreview-337468263
View reviewed changes https://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 1, 2020https://github.com/nodejs/node-addon-api/pull/638#discussion_r362298323
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 1, 2020https://github.com/nodejs/node-addon-api/pull/638#discussion_r362298371
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 1, 2020https://github.com/nodejs/node-addon-api/pull/638#discussion_r362298378
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 1, 2020https://github.com/nodejs/node-addon-api/pull/638#discussion_r362298466
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
test/objectwrap.cchttps://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288#diff-7be4d5cb6740acf2d39cbdcf8f3156bcf46370eca854c283c499ccab2cd3ddf1
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 1, 2020https://github.com/nodejs/node-addon-api/pull/638#discussion_r362298533
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
test/objectwrap.jshttps://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288#diff-5a899ac114bbb0f816675b44a8931db3f503b0a96a984e2b5de282d1a7f0391f
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 1, 2020https://github.com/nodejs/node-addon-api/pull/638#discussion_r362298558
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
test/objectwrap.jshttps://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288#diff-5a899ac114bbb0f816675b44a8931db3f503b0a96a984e2b5de282d1a7f0391f
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 1, 2020https://github.com/nodejs/node-addon-api/pull/638#discussion_r362298630
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/blagoev
blagoevhttps://github.com/blagoev
Jan 2, 2020 https://github.com/nodejs/node-addon-api/pull/638#ref-pullrequest-522024659
objectwrap: gracefully handle constructor exceptions #600 https://github.com/nodejs/node-addon-api/pull/600
https://github.com/blagoev
blagoevhttps://github.com/blagoev
Jan 3, 2020https://github.com/nodejs/node-addon-api/pull/638#issuecomment-570584191
#600https://github.com/nodejs/node-addon-api/pull/600
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/blagoev
blagoevhttps://github.com/blagoev
Jan 3, 2020https://github.com/nodejs/node-addon-api/pull/638#event-2920304160
https://github.co/hiddenchars
https://github.com/nodejs/node-addon-api/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F638
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/nodejs/node-addon-api/pull/638/files/253a9e1025b75f87002757d2cdbf23b51ee33288
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/638
https://github.com/blagoev
https://github.com/gabrielschulhof
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.