| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7368db74-a309-7d63-72c2-472c75793d54 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E65A:38592C:151C945:1EBD9C6:6A4E4B66 |
| html-safe-nonce | abe7da0f3b5f85d7610a0577ebe7d60759634287e050bcca6b206579f11d938d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjVBOjM4NTkyQzoxNTFDOTQ1OjFFQkQ5QzY6NkE0RTRCNjYiLCJ2aXNpdG9yX2lkIjoiNDA0MjkzNjY4ODQxMzkyMDEwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ce44bd4a7095b40d9a05b531d629932661c188eb85559f287bf3b1d709a1d11e |
| hovercard-subject-tag | pull_request:340294012 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-addon-api/600/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c73a7bee53d3c126fac64a4f11fba07e44e9ee7d7677be4afcf736622c76182c/nodejs/node-addon-api/pull/600 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c73a7bee53d3c126fac64a4f11fba07e44e9ee7d7677be4afcf736622c76182c/nodejs/node-addon-api/pull/600 |
| og:image:alt | Move the napi_wrap() step out of the
Napi::ObjectWrap<T>::ObjectWrap() constructor to ensure that no
native instance pointer is associated with the JavaScript object under
construction if the... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabrielschulhof |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node-addon-api git https://github.com/nodejs/node-addon-api.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 81384578 |
| octolytics-dimension-repository_nwo | nodejs/node-addon-api |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81384578 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node-addon-api |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e8506f6d0538364886e3f0153c154c410965e70d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node-addon-api/pull/600#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F600 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F600 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode-addon-api |
| Reload | https://github.com/nodejs/node-addon-api/pull/600 |
| Reload | https://github.com/nodejs/node-addon-api/pull/600 |
| Reload | https://github.com/nodejs/node-addon-api/pull/600 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
|
nodejs
| https://github.com/nodejs |
| node-addon-api | https://github.com/nodejs/node-addon-api |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Fork
500
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Star
2.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Code
| https://github.com/nodejs/node-addon-api |
|
Issues
10
| https://github.com/nodejs/node-addon-api/issues |
|
Pull requests
4
| https://github.com/nodejs/node-addon-api/pulls |
|
Actions
| https://github.com/nodejs/node-addon-api/actions |
|
Projects
| https://github.com/nodejs/node-addon-api/projects |
|
Wiki
| https://github.com/nodejs/node-addon-api/wiki |
|
Security and quality
0
| https://github.com/nodejs/node-addon-api/security |
|
Insights
| https://github.com/nodejs/node-addon-api/pulse |
|
Code
| https://github.com/nodejs/node-addon-api |
|
Issues
| https://github.com/nodejs/node-addon-api/issues |
|
Pull requests
| https://github.com/nodejs/node-addon-api/pulls |
|
Actions
| https://github.com/nodejs/node-addon-api/actions |
|
Projects
| https://github.com/nodejs/node-addon-api/projects |
|
Wiki
| https://github.com/nodejs/node-addon-api/wiki |
|
Security and quality
| https://github.com/nodejs/node-addon-api/security |
|
Insights
| https://github.com/nodejs/node-addon-api/pulse |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node-addon-api/tree/master |
| gabrielschulhof:issue-599 | https://github.com/gabrielschulhof/node-addon-api/tree/issue-599 |
| Conversation | https://github.com/nodejs/node-addon-api/pull/600 |
| Commits4 (4) | https://github.com/nodejs/node-addon-api/pull/600/commits |
| Checks | https://github.com/nodejs/node-addon-api/pull/600/checks |
| Files changed | https://github.com/nodejs/node-addon-api/pull/600/files |
| objectwrap: gracefully handle constructor exceptions | https://github.com/nodejs/node-addon-api/pull/600#top |
| gabrielschulhof | https://github.com/gabrielschulhof |
| nodejs:master | https://github.com/nodejs/node-addon-api/tree/master |
| gabrielschulhof:issue-599 | https://github.com/gabrielschulhof/node-addon-api/tree/issue-599 |
|
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Nov 13, 2019 | https://github.com/nodejs/node-addon-api/pull/600#issue-522024659 |
| #599 | https://github.com/nodejs/node-addon-api/issues/599 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/NickNaso |
| NickNaso | https://github.com/NickNaso |
| Nov 13, 2019 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-553373131 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/dananderson |
| dananderson | https://github.com/dananderson |
| Nov 13, 2019 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-553494695 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Nov 13, 2019 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-553527682 |
| @dananderson | https://github.com/dananderson |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/dananderson |
| dananderson | https://github.com/dananderson |
| Nov 13, 2019 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-553554957 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node-addon-api/compare/bf8519d10a7145bdf90e42d79edb7d3fc732e0b8..9347e10d6ec28ae60aab2ac10148fdf6562245f4 |
| bf8519d | https://github.com/nodejs/node-addon-api/commit/bf8519d10a7145bdf90e42d79edb7d3fc732e0b8 |
| 9347e10 | https://github.com/nodejs/node-addon-api/commit/9347e10d6ec28ae60aab2ac10148fdf6562245f4 |
|
Compare
| https://github.com/nodejs/node-addon-api/compare/bf8519d10a7145bdf90e42d79edb7d3fc732e0b8..9347e10d6ec28ae60aab2ac10148fdf6562245f4 |
| November 14, 2019 03:09 | https://github.com/nodejs/node-addon-api/pull/600#event-2797563866 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Nov 14, 2019 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-554141520 |
| @dananderson | https://github.com/dananderson |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Nov 14, 2019 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-554142005 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node-addon-api/compare/9347e10d6ec28ae60aab2ac10148fdf6562245f4..f9a8178b64f25c81fa8e4afb69d84d443220f2ce |
| 9347e10 | https://github.com/nodejs/node-addon-api/commit/9347e10d6ec28ae60aab2ac10148fdf6562245f4 |
| f9a8178 | https://github.com/nodejs/node-addon-api/commit/f9a8178b64f25c81fa8e4afb69d84d443220f2ce |
|
Compare
| https://github.com/nodejs/node-addon-api/compare/9347e10d6ec28ae60aab2ac10148fdf6562245f4..f9a8178b64f25c81fa8e4afb69d84d443220f2ce |
| November 15, 2019 04:31 | https://github.com/nodejs/node-addon-api/pull/600#event-2801409532 |
| https://github.com/dmitryash |
| dmitryash | https://github.com/dmitryash |
| Nov 16, 2019 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-554627140 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Nov 16, 2019 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-554662485 |
| @dananderson | https://github.com/dananderson |
| pointed out | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-553494695 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/dmitryash |
| dmitryash | https://github.com/dmitryash |
| Nov 16, 2019 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-554674201 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/dmitryash |
| dmitryash | https://github.com/dmitryash |
| Nov 16, 2019 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-554679005 |
| node-addon-api/napi-inl.h | https://github.com/nodejs/node-addon-api/blob/24d75dd82f0206f4298588af063dc740cc297919/napi-inl.h#L2971-L2973 |
| 24d75dd | https://github.com/nodejs/node-addon-api/commit/24d75dd82f0206f4298588af063dc740cc297919 |
| standard | https://en.cppreference.com/w/cpp/language/lifetime |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Dec 25, 2019
| https://github.com/nodejs/node-addon-api/pull/600#ref-pullrequest-540873023 |
|
fixes v8 GC access violation for zombie objects
#638
| https://github.com/nodejs/node-addon-api/pull/638 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Dec 30, 2019
| https://github.com/nodejs/node-addon-api/pull/600#pullrequestreview-337172179 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/600/files |
| napi-inl.h | https://github.com/nodejs/node-addon-api/pull/600/files#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
blocked
| https://github.com/nodejs/node-addon-api/issues?q=state%3Aopen%20label%3Ablocked |
| Dec 30, 2019 | https://github.com/nodejs/node-addon-api/pull/600#event-2914311520 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Dec 31, 2019
| https://github.com/nodejs/node-addon-api/pull/600#ref-commit-683bfcc |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/gabrielschulhof/node-addon-api/commit/683bfcce763dd0bc706c2939f1e0ed9f3f0d48e6 |
| 683bfcc | https://github.com/gabrielschulhof/node-addon-api/commit/683bfcce763dd0bc706c2939f1e0ed9f3f0d48e6 |
| nodejs#599 | https://github.com/nodejs/node-addon-api/issues/599 |
| nodejs#600 | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node-addon-api/compare/f9a8178b64f25c81fa8e4afb69d84d443220f2ce..683bfcce763dd0bc706c2939f1e0ed9f3f0d48e6 |
| f9a8178 | https://github.com/nodejs/node-addon-api/commit/f9a8178b64f25c81fa8e4afb69d84d443220f2ce |
| 683bfcc | https://github.com/nodejs/node-addon-api/commit/683bfcce763dd0bc706c2939f1e0ed9f3f0d48e6 |
|
Compare
| https://github.com/nodejs/node-addon-api/compare/f9a8178b64f25c81fa8e4afb69d84d443220f2ce..683bfcce763dd0bc706c2939f1e0ed9f3f0d48e6 |
| December 31, 2019 20:55 | https://github.com/nodejs/node-addon-api/pull/600#event-2916093470 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
blocked
| https://github.com/nodejs/node-addon-api/issues?q=state%3Aopen%20label%3Ablocked |
| Dec 31, 2019 | https://github.com/nodejs/node-addon-api/pull/600#event-2916093834 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jan 1, 2020
| https://github.com/nodejs/node-addon-api/pull/600#ref-commit-a1acd41 |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/gabrielschulhof/node-addon-api/commit/a1acd41a939275709702da36600eb20f50b6e166 |
| a1acd41 | https://github.com/gabrielschulhof/node-addon-api/commit/a1acd41a939275709702da36600eb20f50b6e166 |
| nodejs#599 | https://github.com/nodejs/node-addon-api/issues/599 |
| nodejs#600 | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node-addon-api/compare/683bfcce763dd0bc706c2939f1e0ed9f3f0d48e6..a1acd41a939275709702da36600eb20f50b6e166 |
| 683bfcc | https://github.com/nodejs/node-addon-api/commit/683bfcce763dd0bc706c2939f1e0ed9f3f0d48e6 |
| a1acd41 | https://github.com/nodejs/node-addon-api/commit/a1acd41a939275709702da36600eb20f50b6e166 |
|
Compare
| https://github.com/nodejs/node-addon-api/compare/683bfcce763dd0bc706c2939f1e0ed9f3f0d48e6..a1acd41a939275709702da36600eb20f50b6e166 |
| January 1, 2020 00:11 | https://github.com/nodejs/node-addon-api/pull/600#event-2916211309 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jan 1, 2020
| https://github.com/nodejs/node-addon-api/pull/600#ref-commit-0cc1985 |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/gabrielschulhof/node-addon-api/commit/0cc1985b6a60a05d5c30c46941d10df6019660e2 |
| 0cc1985 | https://github.com/gabrielschulhof/node-addon-api/commit/0cc1985b6a60a05d5c30c46941d10df6019660e2 |
| nodejs#599 | https://github.com/nodejs/node-addon-api/issues/599 |
| nodejs#600 | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node-addon-api/compare/a1acd41a939275709702da36600eb20f50b6e166..0cc1985b6a60a05d5c30c46941d10df6019660e2 |
| a1acd41 | https://github.com/nodejs/node-addon-api/commit/a1acd41a939275709702da36600eb20f50b6e166 |
| 0cc1985 | https://github.com/nodejs/node-addon-api/commit/0cc1985b6a60a05d5c30c46941d10df6019660e2 |
|
Compare
| https://github.com/nodejs/node-addon-api/compare/a1acd41a939275709702da36600eb20f50b6e166..0cc1985b6a60a05d5c30c46941d10df6019660e2 |
| January 1, 2020 00:27 | https://github.com/nodejs/node-addon-api/pull/600#event-2916218890 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jan 1, 2020
| https://github.com/nodejs/node-addon-api/pull/600#ref-commit-7ee9bfd |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/gabrielschulhof/node-addon-api/commit/7ee9bfd57ab646f7057c3848b24a91ea87ea1a88 |
| 7ee9bfd | https://github.com/gabrielschulhof/node-addon-api/commit/7ee9bfd57ab646f7057c3848b24a91ea87ea1a88 |
| nodejs#599 | https://github.com/nodejs/node-addon-api/issues/599 |
| nodejs#600 | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node-addon-api/compare/0cc1985b6a60a05d5c30c46941d10df6019660e2..7ee9bfd57ab646f7057c3848b24a91ea87ea1a88 |
| 0cc1985 | https://github.com/nodejs/node-addon-api/commit/0cc1985b6a60a05d5c30c46941d10df6019660e2 |
| 7ee9bfd | https://github.com/nodejs/node-addon-api/commit/7ee9bfd57ab646f7057c3848b24a91ea87ea1a88 |
|
Compare
| https://github.com/nodejs/node-addon-api/compare/0cc1985b6a60a05d5c30c46941d10df6019660e2..7ee9bfd57ab646f7057c3848b24a91ea87ea1a88 |
| January 1, 2020 00:29 | https://github.com/nodejs/node-addon-api/pull/600#event-2916219755 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 1, 2020 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-570011804 |
| https://ci.nodejs.org/job/node-test-node-addon-api-new/1507/ | https://ci.nodejs.org/job/node-test-node-addon-api-new/1507/ |
| https://ci.nodejs.org/job/node-test-node-addon-api-new/1508/ | https://ci.nodejs.org/job/node-test-node-addon-api-new/1508/ |
| https://ci.nodejs.org/job/node-test-node-addon-api-new/1509/ | https://ci.nodejs.org/job/node-test-node-addon-api-new/1509/ |
| https://ci.nodejs.org/job/node-test-node-addon-api-new/1510/ | https://ci.nodejs.org/job/node-test-node-addon-api-new/1510/ |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jan 1, 2020
| https://github.com/nodejs/node-addon-api/pull/600#pullrequestreview-337467278 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/600/files |
| napi-inl.h | https://github.com/nodejs/node-addon-api/pull/600/files#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 1, 2020 | https://github.com/nodejs/node-addon-api/pull/600#discussion_r362296963 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @dmitryash | https://github.com/dmitryash |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| addaleax | https://github.com/addaleax |
| Jan 14, 2020 | https://github.com/nodejs/node-addon-api/pull/600#discussion_r366615153 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| #475 | https://github.com/nodejs/node-addon-api/pull/475 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 15, 2020 | https://github.com/nodejs/node-addon-api/pull/600#discussion_r366683768 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| #475 | https://github.com/nodejs/node-addon-api/pull/475 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| KevinEady | https://github.com/KevinEady |
| legendecas | https://github.com/legendecas |
| mhdawson | https://github.com/mhdawson |
| January 1, 2020 01:20 | https://github.com/nodejs/node-addon-api/pull/600#event-2916235766 |
| https://github.com/blagoev |
| blagoev | https://github.com/blagoev |
| Jan 2, 2020 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-570157627 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| #638 | https://github.com/nodejs/node-addon-api/pull/638 |
| #600 | https://github.com/nodejs/node-addon-api/pull/600 |
| #600 | https://github.com/nodejs/node-addon-api/pull/600 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/blagoev |
| blagoev | https://github.com/blagoev |
|
Jan 2, 2020
| https://github.com/nodejs/node-addon-api/pull/600#pullrequestreview-337589863 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/600/files |
| test/objectwrap_constructor_exception.js | https://github.com/nodejs/node-addon-api/pull/600/files#diff-a563eb37669271f941fd94cd6ab23999f3b87dbe39c8b6b73b7484cbea29d088 |
| blagoev | https://github.com/blagoev |
| Jan 2, 2020 | https://github.com/nodejs/node-addon-api/pull/600#discussion_r362418263 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/blagoev |
| blagoev | https://github.com/blagoev |
| Jan 2, 2020 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-570166039 |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 2, 2020 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-570358429 |
| @blagoev | https://github.com/blagoev |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 2, 2020 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-570362568 |
| #643 | https://github.com/nodejs/node-addon-api/pull/643 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
blocked
| https://github.com/nodejs/node-addon-api/issues?q=state%3Aopen%20label%3Ablocked |
| Jan 2, 2020 | https://github.com/nodejs/node-addon-api/pull/600#event-2918874112 |
| https://github.com/blagoev |
| blagoev | https://github.com/blagoev |
|
Jan 3, 2020
| https://github.com/nodejs/node-addon-api/pull/600#pullrequestreview-338087486 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/600/files |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
blocked
| https://github.com/nodejs/node-addon-api/issues?q=state%3Aopen%20label%3Ablocked |
| Jan 7, 2020 | https://github.com/nodejs/node-addon-api/pull/600#event-2926015005 |
| January 6, 2020 16:27 | https://github.com/nodejs/node-addon-api/pull/600#commits-pushed-8cf3755 |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/nodejs/node-addon-api/pull/600/commits/8cf3755bff2f567ebd44e03c83232f6d94c3acd7 |
| 8cf3755 | https://github.com/nodejs/node-addon-api/pull/600/commits/8cf3755bff2f567ebd44e03c83232f6d94c3acd7 |
| nodejs#599 | https://github.com/nodejs/node-addon-api/issues/599 |
| nodejs#600 | https://github.com/nodejs/node-addon-api/pull/600 |
| remove static cast in constructor | https://github.com/nodejs/node-addon-api/pull/600/commits/b00638cf428cd6dd0bea7a4076cb98d3c25e3452 |
| b00638c | https://github.com/nodejs/node-addon-api/pull/600/commits/b00638cf428cd6dd0bea7a4076cb98d3c25e3452 |
| perform some renames to better reflect semantics | https://github.com/nodejs/node-addon-api/pull/600/commits/868b4bd1f003897e9f086a9adb75182041619964 |
| 868b4bd | https://github.com/nodejs/node-addon-api/pull/600/commits/868b4bd1f003897e9f086a9adb75182041619964 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| force-pushed | https://github.com/nodejs/node-addon-api/compare/759800aab6e2cbc95a568e00337bf3e572b5b136..868b4bd1f003897e9f086a9adb75182041619964 |
| 759800a | https://github.com/nodejs/node-addon-api/commit/759800aab6e2cbc95a568e00337bf3e572b5b136 |
| 868b4bd | https://github.com/nodejs/node-addon-api/commit/868b4bd1f003897e9f086a9adb75182041619964 |
|
Compare
| https://github.com/nodejs/node-addon-api/compare/759800aab6e2cbc95a568e00337bf3e572b5b136..868b4bd1f003897e9f086a9adb75182041619964 |
| January 7, 2020 00:27 | https://github.com/nodejs/node-addon-api/pull/600#event-2926015797 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 7, 2020 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-571380152 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| @KevinEady | https://github.com/KevinEady |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jan 9, 2020
| https://github.com/nodejs/node-addon-api/pull/600#pullrequestreview-340867359 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/600/files/868b4bd1f003897e9f086a9adb75182041619964 |
| test/objectwrap_constructor_exception.js | https://github.com/nodejs/node-addon-api/pull/600/files/868b4bd1f003897e9f086a9adb75182041619964#diff-a563eb37669271f941fd94cd6ab23999f3b87dbe39c8b6b73b7484cbea29d088 |
| mhdawson | https://github.com/mhdawson |
| Jan 9, 2020 | https://github.com/nodejs/node-addon-api/pull/600#discussion_r365000578 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 9, 2020 | https://github.com/nodejs/node-addon-api/pull/600#discussion_r365005867 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jan 9, 2020
| https://github.com/nodejs/node-addon-api/pull/600#pullrequestreview-340869846 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/600/files/868b4bd1f003897e9f086a9adb75182041619964 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node-addon-api/pull/600#pullrequestreview-340869846 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| test for a specific exception | https://github.com/nodejs/node-addon-api/pull/600/commits/bd465dea41f2b3c13e832441dfd757f0fc193241 |
| bd465de | https://github.com/nodejs/node-addon-api/pull/600/commits/bd465dea41f2b3c13e832441dfd757f0fc193241 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 9, 2020 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-572805386 |
| https://ci.nodejs.org/job/node-test-node-addon-api-new/1578/ | https://ci.nodejs.org/job/node-test-node-addon-api-new/1578/ |
| https://ci.nodejs.org/job/node-test-node-addon-api-new/1579/ | https://ci.nodejs.org/job/node-test-node-addon-api-new/1579/ |
| https://ci.nodejs.org/job/node-test-node-addon-api-new/1580/ | https://ci.nodejs.org/job/node-test-node-addon-api-new/1580/ |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jan 9, 2020
| https://github.com/nodejs/node-addon-api/pull/600#ref-commit-86384f9 |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/nodejs/node-addon-api/commit/86384f94d31f80e57e0e80fb3187a4abfde2f248 |
| 86384f9 | https://github.com/nodejs/node-addon-api/commit/86384f94d31f80e57e0e80fb3187a4abfde2f248 |
| #599 | https://github.com/nodejs/node-addon-api/issues/599 |
| #600 | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 9, 2020 | https://github.com/nodejs/node-addon-api/pull/600#issuecomment-572811846 |
| 86384f9 | https://github.com/nodejs/node-addon-api/commit/86384f94d31f80e57e0e80fb3187a4abfde2f248 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jan 9, 2020 | https://github.com/nodejs/node-addon-api/pull/600#event-2936866239 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jan 10, 2020
| https://github.com/nodejs/node-addon-api/pull/600#ref-pullrequest-438118456 |
|
src: fix ObjectWrap destruction
#475
| https://github.com/nodejs/node-addon-api/pull/475 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
May 11, 2020
| https://github.com/nodejs/node-addon-api/pull/600#ref-commit-663d627 |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/gabrielschulhof/node-addon-api/commit/663d627cdf0756dfad877f968e1e33840ebf4065 |
| 663d627 | https://github.com/gabrielschulhof/node-addon-api/commit/663d627cdf0756dfad877f968e1e33840ebf4065 |
| nodejs#599 | https://github.com/nodejs/node-addon-api/issues/599 |
| nodejs#600 | https://github.com/nodejs/node-addon-api/pull/600 |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jun 12, 2020
| https://github.com/nodejs/node-addon-api/pull/600#ref-commit-1a51067 |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/gabrielschulhof/node-addon-api/commit/1a5106743822f2ed8f8ae2d6158a8e888cbaf342 |
| 1a51067 | https://github.com/gabrielschulhof/node-addon-api/commit/1a5106743822f2ed8f8ae2d6158a8e888cbaf342 |
| nodejs#599 | https://github.com/nodejs/node-addon-api/issues/599 |
| nodejs#600 | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| February 1, 2021 16:39 | https://github.com/nodejs/node-addon-api/pull/600#event-4274731921 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| February 1, 2021 16:40 | https://github.com/nodejs/node-addon-api/pull/600#event-4274735551 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
| March 7, 2021 18:44 | https://github.com/nodejs/node-addon-api/pull/600#event-4418341501 |
| kevindavies8 | https://github.com/kevindavies8 |
|
Aug 24, 2022
| https://github.com/nodejs/node-addon-api/pull/600#ref-commit-85435af |
|
| https://github.com/kevindavies8 |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/kevindavies8/node-addon-api-Develop/commit/85435af17189515e9fa2dd0ecd7aad82a5428f03 |
| 85435af | https://github.com/kevindavies8/node-addon-api-Develop/commit/85435af17189515e9fa2dd0ecd7aad82a5428f03 |
| nodejs/node-addon-api#599 | https://github.com/nodejs/node-addon-api/issues/599 |
| nodejs/node-addon-api#600 | https://github.com/nodejs/node-addon-api/pull/600 |
| Marlyfleitas | https://github.com/Marlyfleitas |
|
Aug 26, 2022
| https://github.com/nodejs/node-addon-api/pull/600#ref-commit-af19fc1 |
|
| https://github.com/Marlyfleitas |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/Marlyfleitas/node-api-addon-Development/commit/af19fc121cfa8e31a37200139208219e2cc8a93d |
| af19fc1 | https://github.com/Marlyfleitas/node-api-addon-Development/commit/af19fc121cfa8e31a37200139208219e2cc8a93d |
| nodejs/node-addon-api#599 | https://github.com/nodejs/node-addon-api/issues/599 |
| nodejs/node-addon-api#600 | https://github.com/nodejs/node-addon-api/pull/600 |
| wroy7860 | https://github.com/wroy7860 |
|
Sep 19, 2022
| https://github.com/nodejs/node-addon-api/pull/600#ref-commit-59b433e |
|
| https://github.com/wroy7860 |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/wroy7860/addon-api-benchmark-node/commit/59b433e848fd2eaa4e49cdc1b91c8077866dbf95 |
| 59b433e | https://github.com/wroy7860/addon-api-benchmark-node/commit/59b433e848fd2eaa4e49cdc1b91c8077866dbf95 |
| nodejs/node-addon-api#599 | https://github.com/nodejs/node-addon-api/issues/599 |
| nodejs/node-addon-api#600 | https://github.com/nodejs/node-addon-api/pull/600 |
| johnfrench3 | https://github.com/johnfrench3 |
|
Aug 11, 2023
| https://github.com/nodejs/node-addon-api/pull/600#ref-commit-226cbd8 |
|
| https://github.com/blagoev |
| objectwrap: gracefully handle constructor exceptions | https://github.com/johnfrench3/node-addon-api-git/commit/226cbd8ff34b4fb2f621b2c19175533bcf088493 |
| 226cbd8 | https://github.com/johnfrench3/node-addon-api-git/commit/226cbd8ff34b4fb2f621b2c19175533bcf088493 |
| nodejs/node-addon-api#599 | https://github.com/nodejs/node-addon-api/issues/599 |
| nodejs/node-addon-api#600 | https://github.com/nodejs/node-addon-api/pull/600 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node-addon-api/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F600 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node-addon-api/pull/600/files/bd465dea41f2b3c13e832441dfd757f0fc193241 |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
| https://github.com/nodejs/node-addon-api/pull/600/files/c4473ea1dfa70c17804f928072947d27433cc63b |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node-addon-api/pull/600/files/868b4bd1f003897e9f086a9adb75182041619964 |
|
| https://github.com/KevinEady |
|
KevinEady
| https://github.com/KevinEady |
|
| https://github.com/blagoev |
|
blagoev
| https://github.com/blagoev |
|
| https://github.com/nodejs/node-addon-api/pull/600/files/759800aab6e2cbc95a568e00337bf3e572b5b136 |
|
GC Crash With ObjectWrap + Exceptions
| https://github.com/nodejs/node-addon-api/issues/599 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/600 |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/NickNaso |
|
| https://github.com/dananderson |
|
| https://github.com/dmitryash |
|
| https://github.com/blagoev |
|
| https://github.com/addaleax |
|
| https://github.com/legendecas |
|
| https://github.com/mhdawson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |