René's URL Explorer Experiment


Title: src: attach data with napi_add_finalizer by gabrielschulhof · Pull Request #577 · nodejs/node-addon-api · GitHub

Open Graph Title: src: attach data with napi_add_finalizer by gabrielschulhof · Pull Request #577 · nodejs/node-addon-api

X Title: src: attach data with napi_add_finalizer by gabrielschulhof · Pull Request #577 · nodejs/node-addon-api

Description: Module for using Node-API from C++. Contribute to nodejs/node-addon-api development by creating an account on GitHub.

Open Graph Description: Use napi_add_finalizer() to attach data when building against N-API 5 instead of the symbol + external approach that leaves a trace on the target object. Fixes: #557

X Description: Use napi_add_finalizer() to attach data when building against N-API 5 instead of the symbol + external approach that leaves a trace on the target object. Fixes: #557

Opengraph URL: https://github.com/nodejs/node-addon-api/pull/577

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ebd91b5c-d2e2-2183-9659-780ea1fece6f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F82:2213EE:618289:846F6E:6A534946
html-safe-nonce87d297064506b9d0b69975e97d048de203a92998aea3ae4ac9f17576ff5a307a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjgyOjIyMTNFRTo2MTgyODk6ODQ2RjZFOjZBNTM0OTQ2IiwidmlzaXRvcl9pZCI6Ijc4OTE3MTIzNDMyNzI1NDA0ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7dd170fef0fd968547c3cda8d59b5e0dfdcf7aaf942ff368d016dc5ce1b159e5
hovercard-subject-tagpull_request:332914109
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-addon-api/577/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c73a7bee53d3c126fac64a4f11fba07e44e9ee7d7677be4afcf736622c76182c/nodejs/node-addon-api/pull/577
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c73a7bee53d3c126fac64a4f11fba07e44e9ee7d7677be4afcf736622c76182c/nodejs/node-addon-api/pull/577
og:image:altUse napi_add_finalizer() to attach data when building against N-API 5 instead of the symbol + external approach that leaves a trace on the target object. Fixes: #557
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node-addon-api git https://github.com/nodejs/node-addon-api.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id81384578
octolytics-dimension-repository_nwonodejs/node-addon-api
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81384578
octolytics-dimension-repository_network_root_nwonodejs/node-addon-api
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node-addon-api/pull/577#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F577
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F577
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode-addon-api
Reloadhttps://github.com/nodejs/node-addon-api/pull/577
Reloadhttps://github.com/nodejs/node-addon-api/pull/577
Reloadhttps://github.com/nodejs/node-addon-api/pull/577
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/577
nodejs https://github.com/nodejs
node-addon-apihttps://github.com/nodejs/node-addon-api
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/577
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Fork 500 https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Star 2.4k https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Code https://github.com/nodejs/node-addon-api
Issues 10 https://github.com/nodejs/node-addon-api/issues
Pull requests 4 https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security and quality 0 https://github.com/nodejs/node-addon-api/security
Insights https://github.com/nodejs/node-addon-api/pulse
Code https://github.com/nodejs/node-addon-api
Issues https://github.com/nodejs/node-addon-api/issues
Pull requests https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security and quality https://github.com/nodejs/node-addon-api/security
Insights https://github.com/nodejs/node-addon-api/pulse
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
gabrielschulhof:issue-557https://github.com/gabrielschulhof/node-addon-api/tree/issue-557
Conversationhttps://github.com/nodejs/node-addon-api/pull/577
Commits1 (1)https://github.com/nodejs/node-addon-api/pull/577/commits
Checkshttps://github.com/nodejs/node-addon-api/pull/577/checks
Files changedhttps://github.com/nodejs/node-addon-api/pull/577/files
src: attach data with napi_add_finalizerhttps://github.com/nodejs/node-addon-api/pull/577#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
gabrielschulhof:issue-557https://github.com/gabrielschulhof/node-addon-api/tree/issue-557
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 28, 2019https://github.com/nodejs/node-addon-api/pull/577#issue-513049866
#557https://github.com/nodejs/node-addon-api/issues/557
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/577
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 28, 2019https://github.com/nodejs/node-addon-api/pull/577#issuecomment-546754969
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/577
https://ci.nodejs.org/job/node-test-node-addon-api-new/874/https://ci.nodejs.org/job/node-test-node-addon-api-new/874/
https://ci.nodejs.org/job/node-test-node-addon-api-new/875/https://ci.nodejs.org/job/node-test-node-addon-api-new/875/
https://ci.nodejs.org/job/node-test-node-addon-api-new/876/https://ci.nodejs.org/job/node-test-node-addon-api-new/876/
https://ci.nodejs.org/job/node-test-node-addon-api-new/877/https://ci.nodejs.org/job/node-test-node-addon-api-new/877/
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/577
https://github.com/legendecas
legendecashttps://github.com/legendecas
Oct 28, 2019 https://github.com/nodejs/node-addon-api/pull/577#pullrequestreview-307622037
View reviewed changes https://github.com/nodejs/node-addon-api/pull/577/files
https://github.com/legendecas
legendecashttps://github.com/legendecas
Oct 28, 2019https://github.com/nodejs/node-addon-api/pull/577#issuecomment-546769511
#576https://github.com/nodejs/node-addon-api/pull/576
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/577
src: attach data with napi_add_finalizerhttps://github.com/nodejs/node-addon-api/pull/577/commits/301c5bfd9e07c9494a1f791008334b43572dc370
301c5bfhttps://github.com/nodejs/node-addon-api/pull/577/commits/301c5bfd9e07c9494a1f791008334b43572dc370
nodejs#557https://github.com/nodejs/node-addon-api/issues/557
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node-addon-api/compare/d484d034afa65bca24cfeb913f33984b3315b866..301c5bfd9e07c9494a1f791008334b43572dc370
d484d03https://github.com/nodejs/node-addon-api/commit/d484d034afa65bca24cfeb913f33984b3315b866
301c5bfhttps://github.com/nodejs/node-addon-api/commit/301c5bfd9e07c9494a1f791008334b43572dc370
Compare https://github.com/nodejs/node-addon-api/compare/d484d034afa65bca24cfeb913f33984b3315b866..301c5bfd9e07c9494a1f791008334b43572dc370
October 29, 2019 16:26https://github.com/nodejs/node-addon-api/pull/577#event-2752878353
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/577#pullrequestreview-309606480
View reviewed changes https://github.com/nodejs/node-addon-api/pull/577/files/301c5bfd9e07c9494a1f791008334b43572dc370
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node-addon-api/pull/577#pullrequestreview-309606480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/577
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 1, 2019https://github.com/nodejs/node-addon-api/pull/577#issuecomment-548650684
https://ci.nodejs.org/job/node-test-node-addon-api-new/914/https://ci.nodejs.org/job/node-test-node-addon-api-new/914/
https://ci.nodejs.org/job/node-test-node-addon-api-new/915/https://ci.nodejs.org/job/node-test-node-addon-api-new/915/
https://ci.nodejs.org/job/node-test-node-addon-api-new/916/https://ci.nodejs.org/job/node-test-node-addon-api-new/916/
https://ci.nodejs.org/job/node-test-node-addon-api-new/918/https://ci.nodejs.org/job/node-test-node-addon-api-new/918/
https://ci.nodejs.org/job/node-test-node-addon-api-new/917/https://ci.nodejs.org/job/node-test-node-addon-api-new/917/
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/577
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 1, 2019 https://github.com/nodejs/node-addon-api/pull/577#ref-commit-bdfd141
src: attach data with napi_add_finalizerhttps://github.com/nodejs/node-addon-api/commit/bdfd14101f1ab00bc83ab7da942657856d7130e6
bdfd141https://github.com/nodejs/node-addon-api/commit/bdfd14101f1ab00bc83ab7da942657856d7130e6
#557https://github.com/nodejs/node-addon-api/issues/557
#577https://github.com/nodejs/node-addon-api/pull/577
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 1, 2019https://github.com/nodejs/node-addon-api/pull/577#issuecomment-548652657
bdfd141https://github.com/nodejs/node-addon-api/commit/bdfd14101f1ab00bc83ab7da942657856d7130e6
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/577
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 1, 2019https://github.com/nodejs/node-addon-api/pull/577#event-2762069644
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
February 1, 2021 16:39https://github.com/nodejs/node-addon-api/pull/577#event-4274731889
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
February 1, 2021 16:40https://github.com/nodejs/node-addon-api/pull/577#event-4274736743
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
March 7, 2021 18:44https://github.com/nodejs/node-addon-api/pull/577#event-4418341497
kevindavies8https://github.com/kevindavies8
Aug 24, 2022 https://github.com/nodejs/node-addon-api/pull/577#ref-commit-a9dc1be
https://github.com/kevindavies8
src: attach data with napi_add_finalizerhttps://github.com/kevindavies8/node-addon-api-Develop/commit/a9dc1be548090dac68d0fca7b711a11b97346389
a9dc1behttps://github.com/kevindavies8/node-addon-api-Develop/commit/a9dc1be548090dac68d0fca7b711a11b97346389
nodejs/node-addon-api#557https://github.com/nodejs/node-addon-api/issues/557
nodejs/node-addon-api#577https://github.com/nodejs/node-addon-api/pull/577
Marlyfleitashttps://github.com/Marlyfleitas
Aug 26, 2022 https://github.com/nodejs/node-addon-api/pull/577#ref-commit-fbff84f
https://github.com/Marlyfleitas
src: attach data with napi_add_finalizerhttps://github.com/Marlyfleitas/node-api-addon-Development/commit/fbff84f6a35f42e050be49006c7eab0ef2d1706a
fbff84fhttps://github.com/Marlyfleitas/node-api-addon-Development/commit/fbff84f6a35f42e050be49006c7eab0ef2d1706a
nodejs/node-addon-api#557https://github.com/nodejs/node-addon-api/issues/557
nodejs/node-addon-api#577https://github.com/nodejs/node-addon-api/pull/577
wroy7860https://github.com/wroy7860
Sep 19, 2022 https://github.com/nodejs/node-addon-api/pull/577#ref-commit-f5c0ea6
https://github.com/wroy7860
src: attach data with napi_add_finalizerhttps://github.com/wroy7860/addon-api-benchmark-node/commit/f5c0ea625d49c2f1a7ed6f8965210820b89f2454
f5c0ea6https://github.com/wroy7860/addon-api-benchmark-node/commit/f5c0ea625d49c2f1a7ed6f8965210820b89f2454
nodejs/node-addon-api#557https://github.com/nodejs/node-addon-api/issues/557
nodejs/node-addon-api#577https://github.com/nodejs/node-addon-api/pull/577
johnfrench3https://github.com/johnfrench3
Aug 11, 2023 https://github.com/nodejs/node-addon-api/pull/577#ref-commit-c5a920e
src: attach data with napi_add_finalizerhttps://github.com/johnfrench3/node-addon-api-git/commit/c5a920e3fc02a0dafda67edd29ad074ada8f709c
c5a920ehttps://github.com/johnfrench3/node-addon-api-git/commit/c5a920e3fc02a0dafda67edd29ad074ada8f709c
nodejs/node-addon-api#557https://github.com/nodejs/node-addon-api/issues/557
nodejs/node-addon-api#577https://github.com/nodejs/node-addon-api/pull/577
https://github.co/hiddenchars
https://github.com/nodejs/node-addon-api/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F577
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node-addon-api/pull/577/files/d484d034afa65bca24cfeb913f33984b3315b866
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node-addon-api/pull/577/files/301c5bfd9e07c9494a1f791008334b43572dc370
Implement Napi::details::AttachData via napi_add_finalizer https://github.com/nodejs/node-addon-api/issues/557
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/577
https://github.com/gabrielschulhof
https://github.com/legendecas
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.