| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3ad20301-c611-f921-9356-0052ac70bcdb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 82A0:28B9FB:24E2FC6:347CB0A:6A50F681 |
| html-safe-nonce | 69bd1dd4568aa9af165a5304fc59ada8cb8f40174c26f74b6431de072c7e34e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkEwOjI4QjlGQjoyNEUyRkM2OjM0N0NCMEE6NkE1MEY2ODEiLCJ2aXNpdG9yX2lkIjoiMjcwMjgxMzQ4OTQwODMwODg2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6cf7a8356a02cd754763eb665bd5210e11e279c9f16f97fb73b8827519a78bb0 |
| hovercard-subject-tag | pull_request:325109339 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-addon-api/558/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f3823ec3a86c445a5a522e21dc18cb4cfc2c339a0db4d8eb7f9ddd7f74ce5811/nodejs/node-addon-api/pull/558 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f3823ec3a86c445a5a522e21dc18cb4cfc2c339a0db4d8eb7f9ddd7f74ce5811/nodejs/node-addon-api/pull/558 |
| og:image:alt | This PR improves the documentation for CMake.js to accompany to the recent CMake.js example project.
Fixes nodejs/abi-stable-node#381 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jschlight |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5266e58c17a510c403505cc811606465e90a881d2007ee7df1c4800d5c659838 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node-addon-api git https://github.com/nodejs/node-addon-api.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 81384578 |
| octolytics-dimension-repository_nwo | nodejs/node-addon-api |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81384578 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node-addon-api |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8d836581d020676cc0ef4a83cd2fe17e4af02c3d |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node-addon-api/pull/558#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F558 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F558 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode-addon-api |
| Reload | https://github.com/nodejs/node-addon-api/pull/558 |
| Reload | https://github.com/nodejs/node-addon-api/pull/558 |
| Reload | https://github.com/nodejs/node-addon-api/pull/558 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
|
nodejs
| https://github.com/nodejs |
| node-addon-api | https://github.com/nodejs/node-addon-api |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Fork
500
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Star
2.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Code
| https://github.com/nodejs/node-addon-api |
|
Issues
10
| https://github.com/nodejs/node-addon-api/issues |
|
Pull requests
4
| https://github.com/nodejs/node-addon-api/pulls |
|
Actions
| https://github.com/nodejs/node-addon-api/actions |
|
Projects
| https://github.com/nodejs/node-addon-api/projects |
|
Wiki
| https://github.com/nodejs/node-addon-api/wiki |
|
Security and quality
0
| https://github.com/nodejs/node-addon-api/security |
|
Insights
| https://github.com/nodejs/node-addon-api/pulse |
|
Code
| https://github.com/nodejs/node-addon-api |
|
Issues
| https://github.com/nodejs/node-addon-api/issues |
|
Pull requests
| https://github.com/nodejs/node-addon-api/pulls |
|
Actions
| https://github.com/nodejs/node-addon-api/actions |
|
Projects
| https://github.com/nodejs/node-addon-api/projects |
|
Wiki
| https://github.com/nodejs/node-addon-api/wiki |
|
Security and quality
| https://github.com/nodejs/node-addon-api/security |
|
Insights
| https://github.com/nodejs/node-addon-api/pulse |
| jschlight | https://github.com/jschlight |
| nodejs:master | https://github.com/nodejs/node-addon-api/tree/master |
| Conversation | https://github.com/nodejs/node-addon-api/pull/558 |
| Commits2 (2) | https://github.com/nodejs/node-addon-api/pull/558/commits |
| Checks | https://github.com/nodejs/node-addon-api/pull/558/checks |
| Files changed | https://github.com/nodejs/node-addon-api/pull/558/files |
| Update the CMake.js doc to current best practices | https://github.com/nodejs/node-addon-api/pull/558#top |
| jschlight | https://github.com/jschlight |
| nodejs:master | https://github.com/nodejs/node-addon-api/tree/master |
|
| https://github.com/jschlight |
| jschlight | https://github.com/jschlight |
| Oct 7, 2019 | https://github.com/nodejs/node-addon-api/pull/558#issue-503209102 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
| nodejs/abi-stable-node#381 | https://github.com/nodejs/abi-stable-node/issues/381 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
|
| https://github.com/jschlight |
| Updates the CMake.js doc to current best practices | https://github.com/nodejs/node-addon-api/pull/558/commits/7093b49d2b0f0c2a5375698a38a4ca8f954ffc56 |
| 7093b49 | https://github.com/nodejs/node-addon-api/pull/558/commits/7093b49d2b0f0c2a5375698a38a4ca8f954ffc56 |
| https://github.com/jschlight |
| jschlight | https://github.com/jschlight |
| NickNaso | https://github.com/NickNaso |
| gabrielschulhof | https://github.com/gabrielschulhof |
| mhdawson | https://github.com/mhdawson |
| October 7, 2019 02:59 | https://github.com/nodejs/node-addon-api/pull/558#event-2690389864 |
| https://github.com/jschlight |
| jschlight | https://github.com/jschlight |
| Oct 7, 2019 | https://github.com/nodejs/node-addon-api/pull/558#event-2690396652 |
| https://github.com/jschlight |
| jschlight | https://github.com/jschlight |
| Oct 7, 2019 | https://github.com/nodejs/node-addon-api/pull/558#issuecomment-538825716 |
| nodejs/abi-stable-node#381 | https://github.com/nodejs/abi-stable-node/issues/381 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
| https://github.com/NickNaso |
| NickNaso | https://github.com/NickNaso |
|
Oct 7, 2019
| https://github.com/nodejs/node-addon-api/pull/558#pullrequestreview-297981094 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/558/files/7093b49d2b0f0c2a5375698a38a4ca8f954ffc56 |
| NickNaso | https://github.com/NickNaso |
| https://github.com/nodejs/node-addon-api/pull/558#pullrequestreview-297981094 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
| doc/cmake-js.md | https://github.com/nodejs/node-addon-api/pull/558/files/7093b49d2b0f0c2a5375698a38a4ca8f954ffc56#diff-4495251732afe815e786359150e81ee876ffbae2ccd9ea32d3aea0009ff35d48 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
| doc/cmake-js.md | https://github.com/nodejs/node-addon-api/pull/558/files/7093b49d2b0f0c2a5375698a38a4ca8f954ffc56#diff-4495251732afe815e786359150e81ee876ffbae2ccd9ea32d3aea0009ff35d48 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Oct 10, 2019
| https://github.com/nodejs/node-addon-api/pull/558#pullrequestreview-300344495 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/558/files/7093b49d2b0f0c2a5375698a38a4ca8f954ffc56 |
| doc/cmake-js.md | https://github.com/nodejs/node-addon-api/pull/558/files/7093b49d2b0f0c2a5375698a38a4ca8f954ffc56#diff-4495251732afe815e786359150e81ee876ffbae2ccd9ea32d3aea0009ff35d48 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
|
| https://github.com/jschlight |
| Improvements suggested by reviewers | https://github.com/nodejs/node-addon-api/pull/558/commits/decf2e567e2b43ea7d898dd02663aa562b0b108d |
| decf2e5 | https://github.com/nodejs/node-addon-api/pull/558/commits/decf2e567e2b43ea7d898dd02663aa562b0b108d |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Oct 21, 2019
| https://github.com/nodejs/node-addon-api/pull/558#pullrequestreview-304713339 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/558/files/decf2e567e2b43ea7d898dd02663aa562b0b108d |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node-addon-api/pull/558#pullrequestreview-304713339 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
| https://github.com/NickNaso |
| NickNaso | https://github.com/NickNaso |
|
Oct 21, 2019
| https://github.com/nodejs/node-addon-api/pull/558#pullrequestreview-304713936 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/558/files/decf2e567e2b43ea7d898dd02663aa562b0b108d |
| https://github.com/NickNaso |
| NickNaso | https://github.com/NickNaso |
|
Oct 22, 2019
| https://github.com/nodejs/node-addon-api/pull/558#ref-issue-510548688 |
|
Next release 2.0.0
#570
| https://github.com/nodejs/node-addon-api/issues/570 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Oct 23, 2019
| https://github.com/nodejs/node-addon-api/pull/558#pullrequestreview-305592723 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/558/files/decf2e567e2b43ea7d898dd02663aa562b0b108d |
| gabrielschulhof | https://github.com/gabrielschulhof |
| https://github.com/nodejs/node-addon-api/pull/558#pullrequestreview-305592723 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
| mhdawson | https://github.com/mhdawson |
|
Oct 23, 2019
| https://github.com/nodejs/node-addon-api/pull/558#ref-commit-e9a4bcd |
|
| https://github.com/jschlight |
|
| https://github.com/mhdawson |
| doc: updates Make.js doc to current best practices | https://github.com/nodejs/node-addon-api/commit/e9a4bcd52ac5e24ec00d8d9cc7a6375a8ec9d587 |
| e9a4bcd | https://github.com/nodejs/node-addon-api/commit/e9a4bcd52ac5e24ec00d8d9cc7a6375a8ec9d587 |
| #558 | https://github.com/nodejs/node-addon-api/pull/558 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Oct 23, 2019 | https://github.com/nodejs/node-addon-api/pull/558#issuecomment-545666871 |
| e9a4bcd | https://github.com/nodejs/node-addon-api/commit/e9a4bcd52ac5e24ec00d8d9cc7a6375a8ec9d587 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Oct 23, 2019 | https://github.com/nodejs/node-addon-api/pull/558#event-2738799640 |
| https://github.com/jschlight |
| jschlight | https://github.com/jschlight |
| October 24, 2019 19:47 | https://github.com/nodejs/node-addon-api/pull/558#event-2742003207 |
| kevindavies8 | https://github.com/kevindavies8 |
|
Aug 24, 2022
| https://github.com/nodejs/node-addon-api/pull/558#ref-commit-11a1202 |
|
| https://github.com/kevindavies8 |
| doc: updates Make.js doc to current best practices | https://github.com/kevindavies8/node-addon-api-Develop/commit/11a1202ff14312a35d9de0ab9dfece0e6e96b962 |
| 11a1202 | https://github.com/kevindavies8/node-addon-api-Develop/commit/11a1202ff14312a35d9de0ab9dfece0e6e96b962 |
| nodejs/node-addon-api#558 | https://github.com/nodejs/node-addon-api/pull/558 |
| Marlyfleitas | https://github.com/Marlyfleitas |
|
Aug 26, 2022
| https://github.com/nodejs/node-addon-api/pull/558#ref-commit-bfad5c2 |
|
| https://github.com/Marlyfleitas |
| doc: updates Make.js doc to current best practices | https://github.com/Marlyfleitas/node-api-addon-Development/commit/bfad5c23f3cba81fc5ed736ef1db6fa94dfca12e |
| bfad5c2 | https://github.com/Marlyfleitas/node-api-addon-Development/commit/bfad5c23f3cba81fc5ed736ef1db6fa94dfca12e |
| nodejs/node-addon-api#558 | https://github.com/nodejs/node-addon-api/pull/558 |
| wroy7860 | https://github.com/wroy7860 |
|
Sep 19, 2022
| https://github.com/nodejs/node-addon-api/pull/558#ref-commit-356494b |
|
| https://github.com/wroy7860 |
| doc: updates Make.js doc to current best practices | https://github.com/wroy7860/addon-api-benchmark-node/commit/356494ba18017859618a9d83bf9f69562f403fdb |
| 356494b | https://github.com/wroy7860/addon-api-benchmark-node/commit/356494ba18017859618a9d83bf9f69562f403fdb |
| nodejs/node-addon-api#558 | https://github.com/nodejs/node-addon-api/pull/558 |
| johnfrench3 | https://github.com/johnfrench3 |
|
Aug 11, 2023
| https://github.com/nodejs/node-addon-api/pull/558#ref-commit-1c92948 |
| doc: updates Make.js doc to current best practices | https://github.com/johnfrench3/node-addon-api-git/commit/1c929488eef94de1ed54cdaf1acc7576ebfa4d86 |
| 1c92948 | https://github.com/johnfrench3/node-addon-api-git/commit/1c929488eef94de1ed54cdaf1acc7576ebfa4d86 |
| nodejs/node-addon-api#558 | https://github.com/nodejs/node-addon-api/pull/558 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node-addon-api/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F558 |
|
| https://github.com/NickNaso |
|
NickNaso
| https://github.com/NickNaso |
|
| https://github.com/nodejs/node-addon-api/pull/558/files/decf2e567e2b43ea7d898dd02663aa562b0b108d |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs/node-addon-api/pull/558/files/decf2e567e2b43ea7d898dd02663aa562b0b108d |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node-addon-api/pull/558/files/decf2e567e2b43ea7d898dd02663aa562b0b108d |
|
Building addons with cmake
| https://github.com/nodejs/abi-stable-node/issues/381 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/558 |
|
| https://github.com/jschlight |
|
| https://github.com/mhdawson |
|
| https://github.com/NickNaso |
|
| https://github.com/gabrielschulhof |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |