René's URL Explorer Experiment


Title: test: conditional test experimental features with NODE_MAJOR_VERSION by legendecas · Pull Request #545 · nodejs/node-addon-api · GitHub

Open Graph Title: test: conditional test experimental features with NODE_MAJOR_VERSION by legendecas · Pull Request #545 · nodejs/node-addon-api

X Title: test: conditional test experimental features with NODE_MAJOR_VERSION by legendecas · Pull Request #545 · nodejs/node-addon-api

Description: Module for using Node-API from C++. Contribute to nodejs/node-addon-api development by creating an account on GitHub.

Open Graph Description: test: conditionally test experimental features with NODE_MAJOR_VERSION NAPI_EXPERIMENTAL would be expand to NAPI_VERSION=2147483647 if NAPI_VERSION is not defined. It would be not compatible with v...

X Description: test: conditionally test experimental features with NODE_MAJOR_VERSION NAPI_EXPERIMENTAL would be expand to NAPI_VERSION=2147483647 if NAPI_VERSION is not defined. It would be not compatible with v...

Opengraph URL: https://github.com/nodejs/node-addon-api/pull/545

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c892a256-3023-1cf2-b6b0-8ce3d7e03620
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9524:C8AE2:83150FD:B7C1324:6A505647
html-safe-nonceecc48662913d53e715c37720e19cd0b81dd879d18c7c841b81c1fd96b6ad8eb0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTI0OkM4QUUyOjgzMTUwRkQ6QjdDMTMyNDo2QTUwNTY0NyIsInZpc2l0b3JfaWQiOiI1OTg2NDI1NzAyMTM5ODQ0MTY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac554e5870ac03708065dcad13de7921bf349ed5ef32b54b057d854d3408ccf09a
hovercard-subject-tagpull_request:318772496
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-addon-api/545/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/65c299c0b0e3cc7b7b41c3096961bcddb954044066a3f07a0417a7ab5b54d435/nodejs/node-addon-api/pull/545
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/65c299c0b0e3cc7b7b41c3096961bcddb954044066a3f07a0417a7ab5b54d435/nodejs/node-addon-api/pull/545
og:image:alttest: conditionally test experimental features with NODE_MAJOR_VERSION NAPI_EXPERIMENTAL would be expand to NAPI_VERSION=2147483647 if NAPI_VERSION is not defined. It would be not compatible with v...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelegendecas
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node-addon-api git https://github.com/nodejs/node-addon-api.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id81384578
octolytics-dimension-repository_nwonodejs/node-addon-api
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81384578
octolytics-dimension-repository_network_root_nwonodejs/node-addon-api
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node-addon-api/pull/545#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F545
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F545
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode-addon-api
Reloadhttps://github.com/nodejs/node-addon-api/pull/545
Reloadhttps://github.com/nodejs/node-addon-api/pull/545
Reloadhttps://github.com/nodejs/node-addon-api/pull/545
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
nodejs https://github.com/nodejs
node-addon-apihttps://github.com/nodejs/node-addon-api
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Fork 500 https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Star 2.4k https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Code https://github.com/nodejs/node-addon-api
Issues 10 https://github.com/nodejs/node-addon-api/issues
Pull requests 4 https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security and quality 0 https://github.com/nodejs/node-addon-api/security
Insights https://github.com/nodejs/node-addon-api/pulse
Code https://github.com/nodejs/node-addon-api
Issues https://github.com/nodejs/node-addon-api/issues
Pull requests https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security and quality https://github.com/nodejs/node-addon-api/security
Insights https://github.com/nodejs/node-addon-api/pulse
mhdawsonhttps://github.com/mhdawson
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
legendecas:experiment-feature-testhttps://github.com/legendecas/node-addon-api/tree/experiment-feature-test
Conversationhttps://github.com/nodejs/node-addon-api/pull/545
Commits5 (5)https://github.com/nodejs/node-addon-api/pull/545/commits
Checkshttps://github.com/nodejs/node-addon-api/pull/545/checks
Files changedhttps://github.com/nodejs/node-addon-api/pull/545/files
test: conditional test experimental features with NODE_MAJOR_VERSIONhttps://github.com/nodejs/node-addon-api/pull/545#top
mhdawsonhttps://github.com/mhdawson
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
legendecas:experiment-feature-testhttps://github.com/legendecas/node-addon-api/tree/experiment-feature-test
https://github.com/legendecas
legendecashttps://github.com/legendecas
Sep 18, 2019https://github.com/nodejs/node-addon-api/pull/545#issue-495177197
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
#534 (comment)https://github.com/nodejs/node-addon-api/pull/534#discussion_r321590943
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node-addon-api/compare/080913a0183177300c7daea84ffcf80408efc6ed..d098649b5884d45b0c2617eb9c239d3273a5d875
080913ahttps://github.com/nodejs/node-addon-api/commit/080913a0183177300c7daea84ffcf80408efc6ed
d098649https://github.com/nodejs/node-addon-api/commit/d098649b5884d45b0c2617eb9c239d3273a5d875
Compare https://github.com/nodejs/node-addon-api/compare/080913a0183177300c7daea84ffcf80408efc6ed..d098649b5884d45b0c2617eb9c239d3273a5d875
September 18, 2019 12:51https://github.com/nodejs/node-addon-api/pull/545#event-2643387768
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 20, 2019https://github.com/nodejs/node-addon-api/pull/545#issuecomment-533609948
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/legendecas
legendecashttps://github.com/legendecas
Sep 21, 2019https://github.com/nodejs/node-addon-api/pull/545#issuecomment-533767804
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node-addon-api/compare/a9acd9544b1c31bf7e157734125c92b66bff1948..8757704bd4bf17f3bd7de728ffdfdaea4a645517
a9acd95https://github.com/nodejs/node-addon-api/commit/a9acd9544b1c31bf7e157734125c92b66bff1948
8757704https://github.com/nodejs/node-addon-api/commit/8757704bd4bf17f3bd7de728ffdfdaea4a645517
Compare https://github.com/nodejs/node-addon-api/compare/a9acd9544b1c31bf7e157734125c92b66bff1948..8757704bd4bf17f3bd7de728ffdfdaea4a645517
September 22, 2019 02:27https://github.com/nodejs/node-addon-api/pull/545#event-2652419926
https://github.com/legendecas
legendecashttps://github.com/legendecas
Oct 22, 2019 https://github.com/nodejs/node-addon-api/pull/545#ref-issue-510548688
Next release 2.0.0 #570 https://github.com/nodejs/node-addon-api/issues/570
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node-addon-api/compare/8757704bd4bf17f3bd7de728ffdfdaea4a645517..d198d14dfa6bba4dcac8915365b273e2ffb375c0
8757704https://github.com/nodejs/node-addon-api/commit/8757704bd4bf17f3bd7de728ffdfdaea4a645517
d198d14https://github.com/nodejs/node-addon-api/commit/d198d14dfa6bba4dcac8915365b273e2ffb375c0
Compare https://github.com/nodejs/node-addon-api/compare/8757704bd4bf17f3bd7de728ffdfdaea4a645517..d198d14dfa6bba4dcac8915365b273e2ffb375c0
October 22, 2019 16:30https://github.com/nodejs/node-addon-api/pull/545#event-2733990646
https://github.com/legendecas
legendecashttps://github.com/legendecas
Oct 22, 2019 https://github.com/nodejs/node-addon-api/pull/545#ref-pullrequest-496723884
Conditional enabling BigInt API with NAPI_EXPERIMENTAL #547 https://github.com/nodejs/node-addon-api/pull/547
https://github.com/legendecas
legendecashttps://github.com/legendecas
Oct 23, 2019https://github.com/nodejs/node-addon-api/pull/545#issuecomment-545227031
https://travis-ci.com/nodejs/node-addon-api/jobs/248367006#L296https://travis-ci.com/nodejs/node-addon-api/jobs/248367006#L296
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 25, 2019https://github.com/nodejs/node-addon-api/pull/545#issuecomment-546504309
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/legendecas
legendecashttps://github.com/legendecas
Oct 29, 2019https://github.com/nodejs/node-addon-api/pull/545#event-2750857383
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node-addon-api/compare/797d3d565afc1615fd5d729ce547cdd36e559e9d..e7b4eeae4bff53ccb2237d2320569d98cd69d865
797d3d5https://github.com/nodejs/node-addon-api/commit/797d3d565afc1615fd5d729ce547cdd36e559e9d
e7b4eeahttps://github.com/nodejs/node-addon-api/commit/e7b4eeae4bff53ccb2237d2320569d98cd69d865
Compare https://github.com/nodejs/node-addon-api/compare/797d3d565afc1615fd5d729ce547cdd36e559e9d..e7b4eeae4bff53ccb2237d2320569d98cd69d865
October 29, 2019 05:11https://github.com/nodejs/node-addon-api/pull/545#event-2750859253
https://github.com/legendecas
legendecashttps://github.com/legendecas
Oct 29, 2019https://github.com/nodejs/node-addon-api/pull/545#issuecomment-547259447
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/legendecas
legendecashttps://github.com/legendecas
NickNasohttps://github.com/NickNaso
mhdawsonhttps://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
October 29, 2019 05:13https://github.com/nodejs/node-addon-api/pull/545#event-2750861757
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node-addon-api/compare/e7b4eeae4bff53ccb2237d2320569d98cd69d865..a1cb729d5381730990bb2e0a274b0e4a19009409
e7b4eeahttps://github.com/nodejs/node-addon-api/commit/e7b4eeae4bff53ccb2237d2320569d98cd69d865
a1cb729https://github.com/nodejs/node-addon-api/commit/a1cb729d5381730990bb2e0a274b0e4a19009409
Compare https://github.com/nodejs/node-addon-api/compare/e7b4eeae4bff53ccb2237d2320569d98cd69d865..a1cb729d5381730990bb2e0a274b0e4a19009409
October 29, 2019 05:15https://github.com/nodejs/node-addon-api/pull/545#event-2750864426
https://github.com/legendecas
legendecashttps://github.com/legendecas
gabrielschulhofhttps://github.com/gabrielschulhof
October 29, 2019 05:16https://github.com/nodejs/node-addon-api/pull/545#event-2750865854
legendecashttps://github.com/legendecas
October 30, 2019 10:35https://github.com/nodejs/node-addon-api/pull/545#commits-pushed-93348b1
https://github.com/legendecas
test: conditionally test experimental features with NODE_MAJOR_VERSIONhttps://github.com/nodejs/node-addon-api/pull/545/commits/93348b1f347f674d456c4c728dda6606ef939df6
93348b1https://github.com/nodejs/node-addon-api/pull/545/commits/93348b1f347f674d456c4c728dda6606ef939df6
https://github.com/legendecas
build: remove unnecessary NAPI_VERSION pre-definition on travishttps://github.com/nodejs/node-addon-api/pull/545/commits/890d90465e7dc9c6f0521f5b1945ff6f4fd9d567
890d904https://github.com/nodejs/node-addon-api/pull/545/commits/890d90465e7dc9c6f0521f5b1945ff6f4fd9d567
https://github.com/legendecas
src: enabling BigInt API with NAPI_EXPERIMENTALhttps://github.com/nodejs/node-addon-api/pull/545/commits/988e5c21e98b097f7bdc76cf7f1bed497c967d15
988e5c2https://github.com/nodejs/node-addon-api/pull/545/commits/988e5c21e98b097f7bdc76cf7f1bed497c967d15
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node-addon-api/compare/a1cb729d5381730990bb2e0a274b0e4a19009409..988e5c21e98b097f7bdc76cf7f1bed497c967d15
a1cb729https://github.com/nodejs/node-addon-api/commit/a1cb729d5381730990bb2e0a274b0e4a19009409
988e5c2https://github.com/nodejs/node-addon-api/commit/988e5c21e98b097f7bdc76cf7f1bed497c967d15
Compare https://github.com/nodejs/node-addon-api/compare/a1cb729d5381730990bb2e0a274b0e4a19009409..988e5c21e98b097f7bdc76cf7f1bed497c967d15
October 30, 2019 02:35https://github.com/nodejs/node-addon-api/pull/545#event-2754432331
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309604150
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925044
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
legendecashttps://github.com/legendecas
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r341236641
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
mhdawsonhttps://github.com/mhdawson
Nov 1, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r341623273
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309604164
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925058
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309604269
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
napi.hhttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-6294f8ee1d8cd7e4e94cfc22a083380fb80058e34f53100d895b9b3b295dd801
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925138
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309604280
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
napi.hhttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-6294f8ee1d8cd7e4e94cfc22a083380fb80058e34f53100d895b9b3b295dd801
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925147
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309604300
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
napi.hhttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-6294f8ee1d8cd7e4e94cfc22a083380fb80058e34f53100d895b9b3b295dd801
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925160
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309604332
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
napi.hhttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-6294f8ee1d8cd7e4e94cfc22a083380fb80058e34f53100d895b9b3b295dd801
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925190
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309604358
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
napi.hhttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-6294f8ee1d8cd7e4e94cfc22a083380fb80058e34f53100d895b9b3b295dd801
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925213
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309604453
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
test/bigint.cchttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-0001e93eed7d3bc1ff60bb7fea41a595759ee408482567c74f26e30143a89df0
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925288
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
legendecashttps://github.com/legendecas
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r341238208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
mhdawsonhttps://github.com/mhdawson
Nov 1, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r341624169
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309604836
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
test/binding.cchttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-994bd7eb26e23ba70f1d7faa2084e7c57f520e1ba8d8fb09a1cfa3610456d1a4
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309604863
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
test/binding.cchttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-994bd7eb26e23ba70f1d7faa2084e7c57f520e1ba8d8fb09a1cfa3610456d1a4
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925605
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309604981
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
test/typedarray.cchttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-719e4c5b7dbad7b7af73858ac52fc4ac71b92c4c423816a99fdb285b6e920336
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309605014
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
test/typedarray.cchttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-719e4c5b7dbad7b7af73858ac52fc4ac71b92c4c423816a99fdb285b6e920336
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925714
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309605037
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
test/typedarray.cchttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-719e4c5b7dbad7b7af73858ac52fc4ac71b92c4c423816a99fdb285b6e920336
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925735
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309605053
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
test/typedarray.cchttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-719e4c5b7dbad7b7af73858ac52fc4ac71b92c4c423816a99fdb285b6e920336
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925753
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309605070
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
test/typedarray.cchttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-719e4c5b7dbad7b7af73858ac52fc4ac71b92c4c423816a99fdb285b6e920336
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340925774
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309605434
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
test/index.jshttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-5bb8db779819ddef5956a5d9d5949c05ef7445237656ca37bf2f02720271440b
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340926097
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309605483
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
test/index.jshttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-5bb8db779819ddef5956a5d9d5949c05ef7445237656ca37bf2f02720271440b
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340926136
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-309605541
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15
test/index.jshttps://github.com/nodejs/node-addon-api/pull/545/files/988e5c21e98b097f7bdc76cf7f1bed497c967d15#diff-5bb8db779819ddef5956a5d9d5949c05ef7445237656ca37bf2f02720271440b
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#discussion_r340926180
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#issuecomment-548177577
@legendecashttps://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/legendecas
legendecashttps://github.com/legendecas
Oct 31, 2019https://github.com/nodejs/node-addon-api/pull/545#issuecomment-548460280
test: conditional test experimental features with NODE_MAJOR_VERSION #545 (comment)https://github.com/nodejs/node-addon-api/pull/545#discussion_r341236641
test: conditional test experimental features with NODE_MAJOR_VERSION #545 (comment)https://github.com/nodejs/node-addon-api/pull/545#discussion_r341238208
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 1, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-310271543
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files
https://github.com/legendecas
doc: update comments on test conditionshttps://github.com/nodejs/node-addon-api/pull/545/commits/5fae20ac5f6dbb5d806ef5307a7d9e771321a176
5fae20ahttps://github.com/nodejs/node-addon-api/pull/545/commits/5fae20ac5f6dbb5d806ef5307a7d9e771321a176
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node-addon-api/compare/34af5b338304ff785235a09714d9e8008b271de7..5fae20ac5f6dbb5d806ef5307a7d9e771321a176
34af5b3https://github.com/nodejs/node-addon-api/commit/34af5b338304ff785235a09714d9e8008b271de7
5fae20ahttps://github.com/nodejs/node-addon-api/commit/5fae20ac5f6dbb5d806ef5307a7d9e771321a176
Compare https://github.com/nodejs/node-addon-api/compare/34af5b338304ff785235a09714d9e8008b271de7..5fae20ac5f6dbb5d806ef5307a7d9e771321a176
November 1, 2019 16:46https://github.com/nodejs/node-addon-api/pull/545#event-2763801507
https://github.com/legendecas
legendecashttps://github.com/legendecas
Nov 1, 2019https://github.com/nodejs/node-addon-api/pull/545#issuecomment-548860797
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 1, 2019https://github.com/nodejs/node-addon-api/pull/545#issuecomment-548943457
@legendecashttps://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 1, 2019 https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-310686123
View reviewed changes https://github.com/nodejs/node-addon-api/pull/545/files/5fae20ac5f6dbb5d806ef5307a7d9e771321a176
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node-addon-api/pull/545#pullrequestreview-310686123
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/mhdawson
Merge branch 'master' into experiment-feature-testhttps://github.com/nodejs/node-addon-api/pull/545/commits/03d619599e968ff10cfdc3f63fb0f76ba45d9383
03d6195https://github.com/nodejs/node-addon-api/pull/545/commits/03d619599e968ff10cfdc3f63fb0f76ba45d9383
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
295e560https://github.com/nodejs/node-addon-api/commit/295e560f5554c87d0a9dde6b73942ebd85fddb9d
Nov 1, 2019https://github.com/nodejs/node-addon-api/pull/545#event-2764467241
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 1, 2019https://github.com/nodejs/node-addon-api/pull/545#issuecomment-548948584
295e560https://github.com/nodejs/node-addon-api/commit/295e560f5554c87d0a9dde6b73942ebd85fddb9d
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/legendecas
legendecashttps://github.com/legendecas
November 2, 2019 01:51https://github.com/nodejs/node-addon-api/pull/545#event-2764859783
https://github.com/legendecas
legendecashttps://github.com/legendecas
Nov 2, 2019https://github.com/nodejs/node-addon-api/pull/545#issuecomment-548999586
@mhdawsonhttps://github.com/mhdawson
@gabrielschulhofhttps://github.com/gabrielschulhof
https://ci.nodejs.org/job/node-test-node-addon-api-newhttps://ci.nodejs.org/job/node-test-node-addon-api-new
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
kevindavies8https://github.com/kevindavies8
Aug 24, 2022 https://github.com/nodejs/node-addon-api/pull/545#ref-commit-d9dbfae
https://github.com/kevindavies8
test: improve guards for experimental featureshttps://github.com/kevindavies8/node-addon-api-Develop/commit/d9dbfae0c6d6ded80df22e6e256e2a3f036d3d8f
d9dbfaehttps://github.com/kevindavies8/node-addon-api-Develop/commit/d9dbfae0c6d6ded80df22e6e256e2a3f036d3d8f
nodejs/node-addon-api#545https://github.com/nodejs/node-addon-api/pull/545
Marlyfleitashttps://github.com/Marlyfleitas
Aug 26, 2022 https://github.com/nodejs/node-addon-api/pull/545#ref-commit-4481f6f
https://github.com/Marlyfleitas
test: improve guards for experimental featureshttps://github.com/Marlyfleitas/node-api-addon-Development/commit/4481f6f2b9e4c4fd33dd7f27ee1f103b36bbf020
4481f6fhttps://github.com/Marlyfleitas/node-api-addon-Development/commit/4481f6f2b9e4c4fd33dd7f27ee1f103b36bbf020
nodejs/node-addon-api#545https://github.com/nodejs/node-addon-api/pull/545
wroy7860https://github.com/wroy7860
Sep 19, 2022 https://github.com/nodejs/node-addon-api/pull/545#ref-commit-e1b8b62
https://github.com/wroy7860
test: improve guards for experimental featureshttps://github.com/wroy7860/addon-api-benchmark-node/commit/e1b8b62da179aee050c7ccbdf5e0a13ff65e80b7
e1b8b62https://github.com/wroy7860/addon-api-benchmark-node/commit/e1b8b62da179aee050c7ccbdf5e0a13ff65e80b7
nodejs/node-addon-api#545https://github.com/nodejs/node-addon-api/pull/545
johnfrench3https://github.com/johnfrench3
Aug 11, 2023 https://github.com/nodejs/node-addon-api/pull/545#ref-commit-63f9d06
test: improve guards for experimental featureshttps://github.com/johnfrench3/node-addon-api-git/commit/63f9d06cefd50bfdafe25460ccb3bd1fdac2558e
63f9d06https://github.com/johnfrench3/node-addon-api-git/commit/63f9d06cefd50bfdafe25460ccb3bd1fdac2558e
nodejs/node-addon-api#545https://github.com/nodejs/node-addon-api/pull/545
https://github.co/hiddenchars
https://github.com/nodejs/node-addon-api/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F545
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/nodejs/node-addon-api/pull/545/files/34af5b338304ff785235a09714d9e8008b271de7
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node-addon-api/pull/545/files/5fae20ac5f6dbb5d806ef5307a7d9e771321a176
https://github.com/NickNaso
NickNaso https://github.com/NickNaso
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/545
https://github.com/legendecas
https://github.com/mhdawson
https://github.com/gabrielschulhof
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.