René's URL Explorer Experiment


Title: tsfn: fix crash on releasing tsfn by legendecas · Pull Request #532 · nodejs/node-addon-api · GitHub

Open Graph Title: tsfn: fix crash on releasing tsfn by legendecas · Pull Request #532 · nodejs/node-addon-api

X Title: tsfn: fix crash on releasing tsfn by legendecas · Pull Request #532 · nodejs/node-addon-api

Description: Module for using Node-API from C++. Contribute to nodejs/node-addon-api development by creating an account on GitHub.

Open Graph Description: napi_threadsafe_function* returned from out param of napi_create_threadsafe_function should not be deleted outside of node core. Related: #531 npm test passed test added

X Description: napi_threadsafe_function* returned from out param of napi_create_threadsafe_function should not be deleted outside of node core. Related: #531 npm test passed test added

Opengraph URL: https://github.com/nodejs/node-addon-api/pull/532

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:88256e9a-7d2a-6402-0f9a-345a61351fa1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEE00:19A0FC:10EBCB6:1722827:6A520E4B
html-safe-nonce59fc979366eaf3f5a680cec36d001635b4f57f6f47147d8cfaa42eef515e1bfe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRTAwOjE5QTBGQzoxMEVCQ0I2OjE3MjI4Mjc6NkE1MjBFNEIiLCJ2aXNpdG9yX2lkIjoiNzk1NDE1NzAwNTkzMjk5MDAyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac36e38aef0478e05fd0dedd501cfa1b4f26eee3959eb8ef0275fc59127fe53916
hovercard-subject-tagpull_request:312282713
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-addon-api/532/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f47d7d6a3c9bc28c6fddd12a7a96ebf1dcc4df197bf9b7f301b5fa6750472ce7/nodejs/node-addon-api/pull/532
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f47d7d6a3c9bc28c6fddd12a7a96ebf1dcc4df197bf9b7f301b5fa6750472ce7/nodejs/node-addon-api/pull/532
og:image:altnapi_threadsafe_function* returned from out param of napi_create_threadsafe_function should not be deleted outside of node core. Related: #531 npm test passed test added
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelegendecas
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node-addon-api git https://github.com/nodejs/node-addon-api.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id81384578
octolytics-dimension-repository_nwonodejs/node-addon-api
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81384578
octolytics-dimension-repository_network_root_nwonodejs/node-addon-api
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node-addon-api/pull/532#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F532
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F532
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode-addon-api
Reloadhttps://github.com/nodejs/node-addon-api/pull/532
Reloadhttps://github.com/nodejs/node-addon-api/pull/532
Reloadhttps://github.com/nodejs/node-addon-api/pull/532
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
nodejs https://github.com/nodejs
node-addon-apihttps://github.com/nodejs/node-addon-api
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Fork 500 https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Star 2.4k https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Code https://github.com/nodejs/node-addon-api
Issues 10 https://github.com/nodejs/node-addon-api/issues
Pull requests 4 https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security and quality 0 https://github.com/nodejs/node-addon-api/security
Insights https://github.com/nodejs/node-addon-api/pulse
Code https://github.com/nodejs/node-addon-api
Issues https://github.com/nodejs/node-addon-api/issues
Pull requests https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security and quality https://github.com/nodejs/node-addon-api/security
Insights https://github.com/nodejs/node-addon-api/pulse
legendecashttps://github.com/legendecas
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
legendecas:tsfnhttps://github.com/legendecas/node-addon-api/tree/tsfn
Conversationhttps://github.com/nodejs/node-addon-api/pull/532
Commits1 (1)https://github.com/nodejs/node-addon-api/pull/532/commits
Checkshttps://github.com/nodejs/node-addon-api/pull/532/checks
Files changedhttps://github.com/nodejs/node-addon-api/pull/532/files
tsfn: fix crash on releasing tsfnhttps://github.com/nodejs/node-addon-api/pull/532#top
legendecashttps://github.com/legendecas
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
legendecas:tsfnhttps://github.com/legendecas/node-addon-api/tree/tsfn
https://github.com/legendecas
legendecashttps://github.com/legendecas
Aug 29, 2019https://github.com/nodejs/node-addon-api/pull/532#issue-486914787
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
#531https://github.com/nodejs/node-addon-api/issues/531
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node-addon-api/compare/463c6fae59ba97196f21a040954cc759d53320b5..5c5d04c2b8b2742454ff07345e843226a8a81120
463c6fahttps://github.com/nodejs/node-addon-api/commit/463c6fae59ba97196f21a040954cc759d53320b5
5c5d04chttps://github.com/nodejs/node-addon-api/commit/5c5d04c2b8b2742454ff07345e843226a8a81120
Compare https://github.com/nodejs/node-addon-api/compare/463c6fae59ba97196f21a040954cc759d53320b5..5c5d04c2b8b2742454ff07345e843226a8a81120
August 29, 2019 12:00https://github.com/nodejs/node-addon-api/pull/532#event-2593723490
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 29, 2019 https://github.com/nodejs/node-addon-api/pull/532#pullrequestreview-281643933
View reviewed changes https://github.com/nodejs/node-addon-api/pull/532/files
gabrielschulhofhttps://github.com/gabrielschulhof
https://github.com/nodejs/node-addon-api/pull/532#pullrequestreview-281643933
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Aug 29, 2019 https://github.com/nodejs/node-addon-api/pull/532#pullrequestreview-281714687
View reviewed changes https://github.com/nodejs/node-addon-api/pull/532/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node-addon-api/pull/532#pullrequestreview-281714687
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
https://github.com/legendecas
tsfn: fix crash on releasing tsfnhttps://github.com/nodejs/node-addon-api/pull/532/commits/f82b5f14c05d79e0c0f36ebab9d5b32e67509128
f82b5f1https://github.com/nodejs/node-addon-api/pull/532/commits/f82b5f14c05d79e0c0f36ebab9d5b32e67509128
nodejs#531https://github.com/nodejs/node-addon-api/issues/531
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node-addon-api/compare/5c5d04c2b8b2742454ff07345e843226a8a81120..f82b5f14c05d79e0c0f36ebab9d5b32e67509128
5c5d04chttps://github.com/nodejs/node-addon-api/commit/5c5d04c2b8b2742454ff07345e843226a8a81120
f82b5f1https://github.com/nodejs/node-addon-api/commit/f82b5f14c05d79e0c0f36ebab9d5b32e67509128
Compare https://github.com/nodejs/node-addon-api/compare/5c5d04c2b8b2742454ff07345e843226a8a81120..f82b5f14c05d79e0c0f36ebab9d5b32e67509128
September 2, 2019 04:25https://github.com/nodejs/node-addon-api/pull/532#event-2599880310
https://github.com/legendecas
legendecashttps://github.com/legendecas
Sep 3, 2019 https://github.com/nodejs/node-addon-api/pull/532#ref-pullrequest-485804554
Implement AsyncProgressWorker #529 https://github.com/nodejs/node-addon-api/pull/529
https://github.com/legendecas
legendecashttps://github.com/legendecas
Sep 3, 2019https://github.com/nodejs/node-addon-api/pull/532#issuecomment-527427419
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 3, 2019https://github.com/nodejs/node-addon-api/pull/532#issuecomment-527658281
@legendecashttps://github.com/legendecas
https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/
https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-new/https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-new/
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 3, 2019https://github.com/nodejs/node-addon-api/pull/532#issuecomment-527658657
@legendecashttps://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 3, 2019https://github.com/nodejs/node-addon-api/pull/532#issuecomment-527659193
@legendecashttps://github.com/legendecas
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
https://github.com/legendecas
legendecashttps://github.com/legendecas
Sep 4, 2019https://github.com/nodejs/node-addon-api/pull/532#issuecomment-527707089
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
mhdawsonhttps://github.com/mhdawson
Sep 4, 2019 https://github.com/nodejs/node-addon-api/pull/532#ref-commit-0b4f3a5
https://github.com/legendecas
https://github.com/mhdawson
tsfn: fix crash on releasing tsfnhttps://github.com/nodejs/node-addon-api/commit/0b4f3a5b8c441f5380925e4c61606c17868050fb
0b4f3a5https://github.com/nodejs/node-addon-api/commit/0b4f3a5b8c441f5380925e4c61606c17868050fb
#531https://github.com/nodejs/node-addon-api/issues/531
#532https://github.com/nodejs/node-addon-api/pull/532
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 4, 2019https://github.com/nodejs/node-addon-api/pull/532#issuecomment-527943698
0b4f3a5https://github.com/nodejs/node-addon-api/commit/0b4f3a5b8c441f5380925e4c61606c17868050fb
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Sep 4, 2019https://github.com/nodejs/node-addon-api/pull/532#event-2607378179
https://github.com/legendecas
legendecashttps://github.com/legendecas
September 4, 2019 15:28https://github.com/nodejs/node-addon-api/pull/532#event-2607462962
kevindavies8https://github.com/kevindavies8
Aug 24, 2022 https://github.com/nodejs/node-addon-api/pull/532#ref-commit-ca0f5ef
https://github.com/kevindavies8
tsfn: fix crash on releasing tsfnhttps://github.com/kevindavies8/node-addon-api-Develop/commit/ca0f5ef235681043cf2ebe9a85028d6b642e1832
ca0f5efhttps://github.com/kevindavies8/node-addon-api-Develop/commit/ca0f5ef235681043cf2ebe9a85028d6b642e1832
nodejs/node-addon-api#531https://github.com/nodejs/node-addon-api/issues/531
nodejs/node-addon-api#532https://github.com/nodejs/node-addon-api/pull/532
Marlyfleitashttps://github.com/Marlyfleitas
Aug 26, 2022 https://github.com/nodejs/node-addon-api/pull/532#ref-commit-66a53fe
https://github.com/Marlyfleitas
tsfn: fix crash on releasing tsfnhttps://github.com/Marlyfleitas/node-api-addon-Development/commit/66a53febf9c913aa0a1ec9c767a52e06adfd1856
66a53fehttps://github.com/Marlyfleitas/node-api-addon-Development/commit/66a53febf9c913aa0a1ec9c767a52e06adfd1856
nodejs/node-addon-api#531https://github.com/nodejs/node-addon-api/issues/531
nodejs/node-addon-api#532https://github.com/nodejs/node-addon-api/pull/532
wroy7860https://github.com/wroy7860
Sep 19, 2022 https://github.com/nodejs/node-addon-api/pull/532#ref-commit-ca5071f
https://github.com/wroy7860
tsfn: fix crash on releasing tsfnhttps://github.com/wroy7860/addon-api-benchmark-node/commit/ca5071fa441006ffe1d18fe8a5328546d2339a14
ca5071fhttps://github.com/wroy7860/addon-api-benchmark-node/commit/ca5071fa441006ffe1d18fe8a5328546d2339a14
nodejs/node-addon-api#531https://github.com/nodejs/node-addon-api/issues/531
nodejs/node-addon-api#532https://github.com/nodejs/node-addon-api/pull/532
johnfrench3https://github.com/johnfrench3
Aug 11, 2023 https://github.com/nodejs/node-addon-api/pull/532#ref-commit-cc50c36
tsfn: fix crash on releasing tsfnhttps://github.com/johnfrench3/node-addon-api-git/commit/cc50c3659fbf7e3ad2484c5d5b2aeb41d453a50f
cc50c36https://github.com/johnfrench3/node-addon-api-git/commit/cc50c3659fbf7e3ad2484c5d5b2aeb41d453a50f
nodejs/node-addon-api#531https://github.com/nodejs/node-addon-api/issues/531
nodejs/node-addon-api#532https://github.com/nodejs/node-addon-api/pull/532
https://github.co/hiddenchars
https://github.com/nodejs/node-addon-api/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F532
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/nodejs/node-addon-api/pull/532/files/5c5d04c2b8b2742454ff07345e843226a8a81120
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node-addon-api/pull/532/files/5c5d04c2b8b2742454ff07345e843226a8a81120
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/532
https://github.com/legendecas
https://github.com/mhdawson
https://github.com/gabrielschulhof
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.