René's URL Explorer Experiment


Title: src: fix ObjectWrap destruction by addaleax · Pull Request #475 · nodejs/node-addon-api · GitHub

Open Graph Title: src: fix ObjectWrap destruction by addaleax · Pull Request #475 · nodejs/node-addon-api

X Title: src: fix ObjectWrap destruction by addaleax · Pull Request #475 · nodejs/node-addon-api

Description: Module for using Node-API from C++. Contribute to nodejs/node-addon-api development by creating an account on GitHub.

Open Graph Description: src: call napi_remove_wrap() in ObjectWrap dtor Currently, when the ObjectWrap constructor runs, it calls napi_wrap(), adding a finalize callback to the freshly created JS object. However, if the O...

X Description: src: call napi_remove_wrap() in ObjectWrap dtor Currently, when the ObjectWrap constructor runs, it calls napi_wrap(), adding a finalize callback to the freshly created JS object. However, if the O...

Opengraph URL: https://github.com/nodejs/node-addon-api/pull/475

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a6421a68-44e3-9cb0-7291-b7002ec49702
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9878:1971A3:8FE0F3:D34714:6A4E1AE0
html-safe-nonce12980f0454682e619b2358f5c022eb5627be7e8499897c58abd269003c9d9f25
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODc4OjE5NzFBMzo4RkUwRjM6RDM0NzE0OjZBNEUxQUUwIiwidmlzaXRvcl9pZCI6IjEzNDYzNzYyNjk0NDUzMzk4NzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3c2811fc6f8aaa35102e940126cac5c267dd50a2e67c265d6f6b1fdd5f9b2733
hovercard-subject-tagpull_request:274221538
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-addon-api/475/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5ceda9a4df9d12d86e6d53d367ced9cf708748dae670b355ebe10f0f21106f51/nodejs/node-addon-api/pull/475
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5ceda9a4df9d12d86e6d53d367ced9cf708748dae670b355ebe10f0f21106f51/nodejs/node-addon-api/pull/475
og:image:altsrc: call napi_remove_wrap() in ObjectWrap dtor Currently, when the ObjectWrap constructor runs, it calls napi_wrap(), adding a finalize callback to the freshly created JS object. However, if the O...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node-addon-api git https://github.com/nodejs/node-addon-api.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id81384578
octolytics-dimension-repository_nwonodejs/node-addon-api
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81384578
octolytics-dimension-repository_network_root_nwonodejs/node-addon-api
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5fe497b4815fcce3df76c0e246faa739a82c3124
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node-addon-api/pull/475#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F475
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F475
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode-addon-api
Reloadhttps://github.com/nodejs/node-addon-api/pull/475
Reloadhttps://github.com/nodejs/node-addon-api/pull/475
Reloadhttps://github.com/nodejs/node-addon-api/pull/475
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
nodejs https://github.com/nodejs
node-addon-apihttps://github.com/nodejs/node-addon-api
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Fork 500 https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Star 2.4k https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Code https://github.com/nodejs/node-addon-api
Issues 10 https://github.com/nodejs/node-addon-api/issues
Pull requests 4 https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security and quality 0 https://github.com/nodejs/node-addon-api/security
Insights https://github.com/nodejs/node-addon-api/pulse
Code https://github.com/nodejs/node-addon-api
Issues https://github.com/nodejs/node-addon-api/issues
Pull requests https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security and quality https://github.com/nodejs/node-addon-api/security
Insights https://github.com/nodejs/node-addon-api/pulse
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
addaleax:add-napi_remove_wraphttps://github.com/addaleax/node-api/tree/add-napi_remove_wrap
Conversationhttps://github.com/nodejs/node-addon-api/pull/475
Commits1 (1)https://github.com/nodejs/node-addon-api/pull/475/commits
Checkshttps://github.com/nodejs/node-addon-api/pull/475/checks
Files changedhttps://github.com/nodejs/node-addon-api/pull/475/files
src: fix ObjectWrap destructionhttps://github.com/nodejs/node-addon-api/pull/475#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
addaleax:add-napi_remove_wraphttps://github.com/addaleax/node-api/tree/add-napi_remove_wrap
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 29, 2019https://github.com/nodejs/node-addon-api/pull/475#issue-438118456
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
node-ffi-napi/weak-napi#16https://github.com/node-ffi-napi/weak-napi/issues/16
nodejs/node#27470https://github.com/nodejs/node/pull/27470
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Apr 29, 2019 https://github.com/nodejs/node-addon-api/pull/475#ref-issue-436388284
Segfault in node 12 node-ffi-napi/weak-napi#16 https://github.com/node-ffi-napi/weak-napi/issues/16
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node-addon-api/compare/4c7f8ba1870c23d968f84ba0c5eeccedbea77323..f4bfde2a3bd9dafdd5b3542de07f6b040ae10c1a
4c7f8bahttps://github.com/nodejs/node-addon-api/commit/4c7f8ba1870c23d968f84ba0c5eeccedbea77323
f4bfde2https://github.com/nodejs/node-addon-api/commit/f4bfde2a3bd9dafdd5b3542de07f6b040ae10c1a
Compare https://github.com/nodejs/node-addon-api/compare/4c7f8ba1870c23d968f84ba0c5eeccedbea77323..f4bfde2a3bd9dafdd5b3542de07f6b040ae10c1a
April 29, 2019 00:52https://github.com/nodejs/node-addon-api/pull/475#event-2305551978
https://github.com/digitalinfinity
digitalinfinityhttps://github.com/digitalinfinity
Apr 29, 2019 https://github.com/nodejs/node-addon-api/pull/475#pullrequestreview-231552702
View reviewed changes https://github.com/nodejs/node-addon-api/pull/475/files
https://github.com/digitalinfinity
digitalinfinityhttps://github.com/digitalinfinity
Apr 29, 2019 https://github.com/nodejs/node-addon-api/pull/475#pullrequestreview-231553365
View reviewed changes https://github.com/nodejs/node-addon-api/pull/475/files
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/475/files#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
digitalinfinityhttps://github.com/digitalinfinity
Apr 29, 2019https://github.com/nodejs/node-addon-api/pull/475#discussion_r279267604
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
addaleaxhttps://github.com/addaleax
Apr 29, 2019https://github.com/nodejs/node-addon-api/pull/475#discussion_r279352865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@digitalinfinityhttps://github.com/digitalinfinity
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
VoltanaDMGhttps://github.com/VoltanaDMG
Apr 30, 2019 https://github.com/nodejs/node-addon-api/pull/475#ref-commit-cb81e71
https://github.com/VoltanaDMG
[<](Fallback) .travis.ymlhttps://github.com/oss-dmg/weak/commit/cb81e7160f2906356fa99856628f483d647dbc85
cb81e71https://github.com/oss-dmg/weak/commit/cb81e7160f2906356fa99856628f483d647dbc85
nodejs/node-addon-api#475https://github.com/nodejs/node-addon-api/pull/475
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 3, 2019https://github.com/nodejs/node-addon-api/pull/475#issuecomment-489154012
nodejs/node#24494https://github.com/nodejs/node/pull/24494
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
May 6, 2019 https://github.com/nodejs/node-addon-api/pull/475#pullrequestreview-234062824
View reviewed changes https://github.com/nodejs/node-addon-api/pull/475/files
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 9, 2019 https://github.com/nodejs/node-addon-api/pull/475#pullrequestreview-235714716
View reviewed changes https://github.com/nodejs/node-addon-api/pull/475/files
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node-addon-api/pull/475#pullrequestreview-235714716
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
do not land https://github.com/nodejs/node-addon-api/issues?q=state%3Aopen%20label%3A%22do%20not%20land%22
May 17, 2019https://github.com/nodejs/node-addon-api/pull/475#event-2350391025
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
May 17, 2019https://github.com/nodejs/node-addon-api/pull/475#issuecomment-493591228
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/splitice
spliticehttps://github.com/splitice
Jun 5, 2019 https://github.com/nodejs/node-addon-api/pull/475#ref-issue-391375675
Ecosystem Modules that will break in Node 12 nodejs/node#25060 https://github.com/nodejs/node/issues/25060
https://github.com/Veetaha
Veetahahttps://github.com/Veetaha
Aug 28, 2019https://github.com/nodejs/node-addon-api/pull/475#issuecomment-525925092
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/Veetaha
Veetahahttps://github.com/Veetaha
Aug 28, 2019 https://github.com/nodejs/node-addon-api/pull/475#pullrequestreview-281113122
View reviewed changes https://github.com/nodejs/node-addon-api/pull/475/files
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/475/files#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
Veetahahttps://github.com/Veetaha
Aug 28, 2019https://github.com/nodejs/node-addon-api/pull/475#discussion_r318800524
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/475/files#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
Veetahahttps://github.com/Veetaha
Aug 28, 2019https://github.com/nodejs/node-addon-api/pull/475#discussion_r318803538
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/davedoesdev
davedoesdevhttps://github.com/davedoesdev
Oct 10, 2019https://github.com/nodejs/node-addon-api/pull/475#issuecomment-540402194
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/davedoesdev
davedoesdevhttps://github.com/davedoesdev
Oct 10, 2019 https://github.com/nodejs/node-addon-api/pull/475#ref-pullrequest-504522134
updated dependencies as of 9.10.19 davedoesdev/shared-memory-disruptor#1 https://github.com/davedoesdev/shared-memory-disruptor/pull/1
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 10, 2019 https://github.com/nodejs/node-addon-api/pull/475#pullrequestreview-300034368
View reviewed changes https://github.com/nodejs/node-addon-api/pull/475/files
https://github.com/davedoesdev
davedoesdevhttps://github.com/davedoesdev
Oct 10, 2019 https://github.com/nodejs/node-addon-api/pull/475#ref-issue-505554366
Tests fail due to double free bug in node-addon-api davedoesdev/shared-memory-disruptor#4 https://github.com/davedoesdev/shared-memory-disruptor/issues/4
davedoesdevhttps://github.com/davedoesdev
Oct 12, 2019 https://github.com/nodejs/node-addon-api/pull/475#ref-commit-5f75991
https://github.com/davedoesdev
Work around ObjectWrap destruction bughttps://github.com/davedoesdev/shared-memory-disruptor/commit/5f7599175cf3d9c8579f5a6a0a0b14be9f8c87fa
5f75991https://github.com/davedoesdev/shared-memory-disruptor/commit/5f7599175cf3d9c8579f5a6a0a0b14be9f8c87fa
nodejs/node-addon-api#475https://github.com/nodejs/node-addon-api/pull/475
fprenoveauhttps://github.com/fprenoveau
Oct 22, 2019 https://github.com/nodejs/node-addon-api/pull/475#ref-commit-f73d84a
https://github.com/fprenoveau
Merge branch 'add-napi_remove_wrap' of github.com:addaleax/node-apihttps://github.com/fprenoveau/node-addon-api/commit/f73d84aa402995e28a9f3ef28555d510d34b657c
f73d84ahttps://github.com/fprenoveau/node-addon-api/commit/f73d84aa402995e28a9f3ef28555d510d34b657c
nodejs#475https://github.com/nodejs/node-addon-api/pull/475
fritzmhttps://github.com/fritzm
Dec 11, 2019 https://github.com/nodejs/node-addon-api/pull/475#ref-commit-029ad07
https://github.com/fritzm
Fix crashes after throw from ctor of Napi::ObjectWrap subclasseshttps://github.com/fritzm/node-cgal/commit/029ad07c819511ad9293bd956638d1e2b94ffdc4
029ad07https://github.com/fritzm/node-cgal/commit/029ad07c819511ad9293bd956638d1e2b94ffdc4
nodejs/node-addon-api#475https://github.com/nodejs/node-addon-api/pull/475
https://github.com/fritzm
fritzmhttps://github.com/fritzm
Dec 11, 2019 https://github.com/nodejs/node-addon-api/pull/475#ref-pullrequest-536067590
Fix crashes after throw from ctor of Napi::ObjectWrap subclasses fritzm/node-cgal#12 https://github.com/fritzm/node-cgal/pull/12
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 10, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-572814804
#600https://github.com/nodejs/node-addon-api/pull/600
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 10, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-572816763
@addaleaxhttps://github.com/addaleax
#600https://github.com/nodejs/node-addon-api/pull/600
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 10, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-572884648
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2020 https://github.com/nodejs/node-addon-api/pull/475#ref-pullrequest-522024659
objectwrap: gracefully handle constructor exceptions #600 https://github.com/nodejs/node-addon-api/pull/600
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node-addon-api/compare/0fd142bf1738c03b9f4b935dbc17f900a2e77d63..c243f71edc5b14de92ca1aa19c28ff1d7eca4f11
0fd142bhttps://github.com/nodejs/node-addon-api/commit/0fd142bf1738c03b9f4b935dbc17f900a2e77d63
c243f71https://github.com/nodejs/node-addon-api/commit/c243f71edc5b14de92ca1aa19c28ff1d7eca4f11
Compare https://github.com/nodejs/node-addon-api/compare/0fd142bf1738c03b9f4b935dbc17f900a2e77d63..c243f71edc5b14de92ca1aa19c28ff1d7eca4f11
January 14, 2020 22:52https://github.com/nodejs/node-addon-api/pull/475#event-2948908745
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 14, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-574411974
@gabrielschulhofhttps://github.com/gabrielschulhof
#600https://github.com/nodejs/node-addon-api/pull/600
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 15, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-574443897
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 15, 2020https://github.com/nodejs/node-addon-api/pull/475#event-2949129253
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 15, 2020https://github.com/nodejs/node-addon-api/pull/475#event-2949129418
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 15, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-574444020
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 15, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-574450885
@addaleaxhttps://github.com/addaleax
#600https://github.com/nodejs/node-addon-api/pull/600
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node-addon-api/compare/c243f71edc5b14de92ca1aa19c28ff1d7eca4f11..10a26987fea5e9d43dd16c3546b444d175493f2a
c243f71https://github.com/nodejs/node-addon-api/commit/c243f71edc5b14de92ca1aa19c28ff1d7eca4f11
10a2698https://github.com/nodejs/node-addon-api/commit/10a26987fea5e9d43dd16c3546b444d175493f2a
Compare https://github.com/nodejs/node-addon-api/compare/c243f71edc5b14de92ca1aa19c28ff1d7eca4f11..10a26987fea5e9d43dd16c3546b444d175493f2a
January 16, 2020 20:35https://github.com/nodejs/node-addon-api/pull/475#event-2955976951
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 16, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-575334606
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 16, 2020 https://github.com/nodejs/node-addon-api/pull/475#pullrequestreview-344222499
View reviewed changes https://github.com/nodejs/node-addon-api/pull/475/files
gabrielschulhofhttps://github.com/gabrielschulhof
https://github.com/nodejs/node-addon-api/pull/475#pullrequestreview-344222499
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 16, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-575353452
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://ci.nodejs.org/job/node-test-node-addon-api-new/1637/https://ci.nodejs.org/job/node-test-node-addon-api-new/1637/
https://ci.nodejs.org/job/node-test-node-addon-api-new/1638/https://ci.nodejs.org/job/node-test-node-addon-api-new/1638/
https://ci.nodejs.org/job/node-test-node-addon-api-new/1639/https://ci.nodejs.org/job/node-test-node-addon-api-new/1639/
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 16, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-575356693
@addaleaxhttps://github.com/addaleax
#649https://github.com/nodejs/node-addon-api/pull/649
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/addaleax
src: call napi_remove_wrap() in ObjectWrap dtorhttps://github.com/nodejs/node-addon-api/pull/475/commits/257393d1d221badb204e0dafed5d812957af8791
257393dhttps://github.com/nodejs/node-addon-api/pull/475/commits/257393d1d221badb204e0dafed5d812957af8791
node-ffi-napi/weak-napi#16https://github.com/node-ffi-napi/weak-napi/issues/16
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 16, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-575358755
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
force-pushedhttps://github.com/nodejs/node-addon-api/compare/10a26987fea5e9d43dd16c3546b444d175493f2a..257393d1d221badb204e0dafed5d812957af8791
10a2698https://github.com/nodejs/node-addon-api/commit/10a26987fea5e9d43dd16c3546b444d175493f2a
257393dhttps://github.com/nodejs/node-addon-api/commit/257393d1d221badb204e0dafed5d812957af8791
Compare https://github.com/nodejs/node-addon-api/compare/10a26987fea5e9d43dd16c3546b444d175493f2a..257393d1d221badb204e0dafed5d812957af8791
January 16, 2020 21:37https://github.com/nodejs/node-addon-api/pull/475#event-2956156126
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 16, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-575360065
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://ci.nodejs.org/job/node-test-node-addon-api-new/1640/https://ci.nodejs.org/job/node-test-node-addon-api-new/1640/
https://ci.nodejs.org/job/node-test-node-addon-api-new/1641/https://ci.nodejs.org/job/node-test-node-addon-api-new/1641/
https://ci.nodejs.org/job/node-test-node-addon-api-new/1642/https://ci.nodejs.org/job/node-test-node-addon-api-new/1642/
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 17, 2020 https://github.com/nodejs/node-addon-api/pull/475#ref-commit-4e88506
https://github.com/addaleax
src: call napi_remove_wrap() in ObjectWrap dtorhttps://github.com/nodejs/node-addon-api/commit/4e885069f1721dec1705c898383625dd2907f9e6
4e88506https://github.com/nodejs/node-addon-api/commit/4e885069f1721dec1705c898383625dd2907f9e6
node-ffi-napi/weak-napi#16https://github.com/node-ffi-napi/weak-napi/issues/16
#475https://github.com/nodejs/node-addon-api/pull/475
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 17, 2020https://github.com/nodejs/node-addon-api/pull/475#issuecomment-575737900
4e88506https://github.com/nodejs/node-addon-api/commit/4e885069f1721dec1705c898383625dd2907f9e6
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jan 17, 2020https://github.com/nodejs/node-addon-api/pull/475#event-2959059436
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
April 22, 2020 18:45https://github.com/nodejs/node-addon-api/pull/475#event-3261953393
gabrielschulhofhttps://github.com/gabrielschulhof
May 11, 2020 https://github.com/nodejs/node-addon-api/pull/475#ref-commit-d06efa0
https://github.com/addaleax
src: call napi_remove_wrap() in ObjectWrap dtorhttps://github.com/gabrielschulhof/node-addon-api/commit/d06efa0b96b3126740e03e018a58c2569957de92
d06efa0https://github.com/gabrielschulhof/node-addon-api/commit/d06efa0b96b3126740e03e018a58c2569957de92
node-ffi-napi/weak-napi#16https://github.com/node-ffi-napi/weak-napi/issues/16
nodejs#475https://github.com/nodejs/node-addon-api/pull/475
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 12, 2020 https://github.com/nodejs/node-addon-api/pull/475#ref-commit-a552a38
https://github.com/addaleax
src: call napi_remove_wrap() in ObjectWrap dtorhttps://github.com/gabrielschulhof/node-addon-api/commit/a552a384ddbbf2a6574d478cf3dc20cae87f0459
a552a38https://github.com/gabrielschulhof/node-addon-api/commit/a552a384ddbbf2a6574d478cf3dc20cae87f0459
node-ffi-napi/weak-napi#16https://github.com/node-ffi-napi/weak-napi/issues/16
nodejs#475https://github.com/nodejs/node-addon-api/pull/475
kevindavies8https://github.com/kevindavies8
Aug 24, 2022 https://github.com/nodejs/node-addon-api/pull/475#ref-commit-ddf68b7
https://github.com/kevindavies8
src: call napi_remove_wrap() in ObjectWrap dtorhttps://github.com/kevindavies8/node-addon-api-Develop/commit/ddf68b7f078b4afea2d840b9292c953b3717c692
ddf68b7https://github.com/kevindavies8/node-addon-api-Develop/commit/ddf68b7f078b4afea2d840b9292c953b3717c692
node-ffi-napi/weak-napi#16https://github.com/node-ffi-napi/weak-napi/issues/16
nodejs/node-addon-api#475https://github.com/nodejs/node-addon-api/pull/475
Marlyfleitashttps://github.com/Marlyfleitas
Aug 26, 2022 https://github.com/nodejs/node-addon-api/pull/475#ref-commit-4dc2575
https://github.com/Marlyfleitas
src: call napi_remove_wrap() in ObjectWrap dtorhttps://github.com/Marlyfleitas/node-api-addon-Development/commit/4dc2575323d3c89d81913ec9f0f7acbf6f9ff806
4dc2575https://github.com/Marlyfleitas/node-api-addon-Development/commit/4dc2575323d3c89d81913ec9f0f7acbf6f9ff806
node-ffi-napi/weak-napi#16https://github.com/node-ffi-napi/weak-napi/issues/16
nodejs/node-addon-api#475https://github.com/nodejs/node-addon-api/pull/475
wroy7860https://github.com/wroy7860
Sep 19, 2022 https://github.com/nodejs/node-addon-api/pull/475#ref-commit-3bc08e8
https://github.com/wroy7860
src: call napi_remove_wrap() in ObjectWrap dtorhttps://github.com/wroy7860/addon-api-benchmark-node/commit/3bc08e8bb21e5bd83ace713364e4b1459bea3de5
3bc08e8https://github.com/wroy7860/addon-api-benchmark-node/commit/3bc08e8bb21e5bd83ace713364e4b1459bea3de5
node-ffi-napi/weak-napi#16https://github.com/node-ffi-napi/weak-napi/issues/16
nodejs/node-addon-api#475https://github.com/nodejs/node-addon-api/pull/475
johnfrench3https://github.com/johnfrench3
Aug 11, 2023 https://github.com/nodejs/node-addon-api/pull/475#ref-commit-1ad933b
src: call napi_remove_wrap() in ObjectWrap dtorhttps://github.com/johnfrench3/node-addon-api-git/commit/1ad933bcb57c1908cb2df93f8aa73a33ba40b08a
1ad933bhttps://github.com/johnfrench3/node-addon-api-git/commit/1ad933bcb57c1908cb2df93f8aa73a33ba40b08a
node-ffi-napi/weak-napi#16https://github.com/node-ffi-napi/weak-napi/issues/16
nodejs/node-addon-api#475https://github.com/nodejs/node-addon-api/pull/475
https://github.com/drakedevel
drakedevelhttps://github.com/drakedevel
Jul 6, 2025 https://github.com/nodejs/node-addon-api/pull/475#ref-issue-3172778043
Regression: Deno 2.3.7 crash with NAPI-RS denoland/deno#29874 https://github.com/denoland/deno/issues/29874
https://github.co/hiddenchars
https://github.com/nodejs/node-addon-api/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F475
https://github.com/gabrielschulhof
gabrielschulhof https://github.com/gabrielschulhof
https://github.com/nodejs/node-addon-api/pull/475/files/10a26987fea5e9d43dd16c3546b444d175493f2a
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node-addon-api/pull/475/files/0fd142bf1738c03b9f4b935dbc17f900a2e77d63
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node-addon-api/pull/475/files/0fd142bf1738c03b9f4b935dbc17f900a2e77d63
https://github.com/digitalinfinity
digitalinfinity https://github.com/digitalinfinity
https://github.com/nodejs/node-addon-api/pull/475/files/f4bfde2a3bd9dafdd5b3542de07f6b040ae10c1a
https://github.com/Veetaha
Veetaha https://github.com/Veetaha
https://github.com/nodejs/node-addon-api/pull/475/files/f4bfde2a3bd9dafdd5b3542de07f6b040ae10c1a
do not land https://github.com/nodejs/node-addon-api/issues?q=state%3Aopen%20label%3A%22do%20not%20land%22
Segfault in node 12 https://github.com/node-ffi-napi/weak-napi/issues/16
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/475
https://github.com/addaleax
https://github.com/mhdawson
https://github.com/Veetaha
https://github.com/davedoesdev
https://github.com/gabrielschulhof
https://github.com/digitalinfinity
https://github.com/tniessen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.