René's URL Explorer Experiment


Title: Fix reporting of API error messages by jasongin · Pull Request #43 · nodejs/node-addon-api · GitHub

Open Graph Title: Fix reporting of API error messages by jasongin · Pull Request #43 · nodejs/node-addon-api

X Title: Fix reporting of API error messages by jasongin · Pull Request #43 · nodejs/node-addon-api

Description: When a call to an N-API function caused an error for some reason other than a JS exception, the fallback error message "Error in native callback" was always reported because of incorrect logic in N...

Open Graph Description: When a call to an N-API function caused an error for some reason other than a JS exception, the fallback error message "Error in native callback" was always reported because of incorrect ...

X Description: When a call to an N-API function caused an error for some reason other than a JS exception, the fallback error message "Error in native callback" was always reported because of in...

Opengraph URL: https://github.com/nodejs/node-addon-api/pull/43

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ae0e8fae-86a7-0dcc-8741-671409b14414
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2E8:1DECF9:49495E:5F6E51:696AE240
html-safe-nonce47da737b31b88fd17079cb76e8b6d06aa9724cbb7acca3dcdb07fd2a0059fb45
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkU4OjFERUNGOTo0OTQ5NUU6NUY2RTUxOjY5NkFFMjQwIiwidmlzaXRvcl9pZCI6IjkwMDA2ODk1NjM1NTc2MTgyNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4850fce4429971f5254f4a2cc42981f530e1f3da3a144d508a0fef70ed7d6772
hovercard-subject-tagpull_request:121180731
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-addon-api/43/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/94c870966d98bf4e0229624abccd57d960d3b30ad6606235a6c82ecebf51d998/nodejs/node-addon-api/pull/43
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/94c870966d98bf4e0229624abccd57d960d3b30ad6606235a6c82ecebf51d998/nodejs/node-addon-api/pull/43
og:image:altWhen a call to an N-API function caused an error for some reason other than a JS exception, the fallback error message "Error in native callback" was always reported because of incorrect ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasongin
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node-addon-api git https://github.com/nodejs/node-addon-api.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id81384578
octolytics-dimension-repository_nwonodejs/node-addon-api
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81384578
octolytics-dimension-repository_network_root_nwonodejs/node-addon-api
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3d84d50b3c75fa36755c3cf392edbc09e626f979
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node-addon-api/pull/43#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F43
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F43
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode-addon-api
Reloadhttps://github.com/nodejs/node-addon-api/pull/43
Reloadhttps://github.com/nodejs/node-addon-api/pull/43
Reloadhttps://github.com/nodejs/node-addon-api/pull/43
nodejs https://github.com/nodejs
node-addon-apihttps://github.com/nodejs/node-addon-api
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/43
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Fork 493 https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Star 2.4k https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api
Code https://github.com/nodejs/node-addon-api
Issues 9 https://github.com/nodejs/node-addon-api/issues
Pull requests 3 https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects 1 https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node-addon-api/security
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/43
Insights https://github.com/nodejs/node-addon-api/pulse
Code https://github.com/nodejs/node-addon-api
Issues https://github.com/nodejs/node-addon-api/issues
Pull requests https://github.com/nodejs/node-addon-api/pulls
Actions https://github.com/nodejs/node-addon-api/actions
Projects https://github.com/nodejs/node-addon-api/projects
Wiki https://github.com/nodejs/node-addon-api/wiki
Security https://github.com/nodejs/node-addon-api/security
Insights https://github.com/nodejs/node-addon-api/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode-addon-api%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node-addon-api/pull/43#issue-comment-box
jasonginhttps://github.com/jasongin
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
jasongin:errorhttps://github.com/jasongin/node-addon-api/tree/error
Fix reporting of API error messages https://github.com/nodejs/node-addon-api/pull/43#top
jasonginhttps://github.com/jasongin
nodejs:masterhttps://github.com/nodejs/node-addon-api/tree/master
jasongin:errorhttps://github.com/jasongin/node-addon-api/tree/error
Conversation 6 https://github.com/nodejs/node-addon-api/pull/43
Commits 1 https://github.com/nodejs/node-addon-api/pull/43/commits
Checks 0 https://github.com/nodejs/node-addon-api/pull/43/checks
Files changed https://github.com/nodejs/node-addon-api/pull/43/files
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/43
https://github.co/hiddenchars
https://github.com/nodejs/node-addon-api/pull/{{ revealButtonHref }}
https://github.com/jasongin
jasonginhttps://github.com/jasongin
May 18, 2017https://github.com/nodejs/node-addon-api/pull/43#issue-229525560
nodejs/node#13087https://github.com/nodejs/node/pull/13087
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/43
https://github.com/jasongin
Fix reporting of API error messageshttps://github.com/nodejs/node-addon-api/pull/43/commits/fff49908c9267da6b7e5d254b03d3513359d648c
fff4990https://github.com/nodejs/node-addon-api/pull/43/commits/fff49908c9267da6b7e5d254b03d3513359d648c
nodejs/node#13087https://github.com/nodejs/node/pull/13087
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 18, 2017 https://github.com/nodejs/node-addon-api/pull/43#pullrequestreview-38934258
View reviewed changes https://github.com/nodejs/node-addon-api/pull/43/files/fff49908c9267da6b7e5d254b03d3513359d648c
napi-inl.hhttps://github.com/nodejs/node-addon-api/pull/43/files/fff49908c9267da6b7e5d254b03d3513359d648c#diff-cd0b229bcaf532206661e2ee1a603a7f60ac22ecfcb239920f6b42a34d909f34
addaleaxhttps://github.com/addaleax
May 18, 2017https://github.com/nodejs/node-addon-api/pull/43#discussion_r117244977
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/43
jasonginhttps://github.com/jasongin
May 18, 2017https://github.com/nodejs/node-addon-api/pull/43#discussion_r117292553
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
yethttps://github.com/nodejs/abi-stable-node/issues/232
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/43
jasonginhttps://github.com/jasongin
May 30, 2017https://github.com/nodejs/node-addon-api/pull/43#discussion_r119162112
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#32 (comment)https://github.com/nodejs/node-addon-api/pull/32#discussion_r114903602
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/43
jasonginhttps://github.com/jasongin
May 30, 2017https://github.com/nodejs/node-addon-api/pull/43#discussion_r119167236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#48https://github.com/nodejs/node-addon-api/issues/48
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/43
https://github.com/jasongin
jasonginhttps://github.com/jasongin
boingoinghttps://github.com/boingoing
May 30, 2017 17:21https://github.com/nodejs/node-addon-api/pull/43#event-1102754797
https://github.com/jasongin
jasonginhttps://github.com/jasongin
May 30, 2017 https://github.com/nodejs/node-addon-api/pull/43#ref-issue-232328138
Abort with fatal error when error-handling fails #48 https://github.com/nodejs/node-addon-api/issues/48
https://github.com/jasongin
jasonginhttps://github.com/jasongin
Jun 5, 2017https://github.com/nodejs/node-addon-api/pull/43#issuecomment-306340105
@addaleaxhttps://github.com/addaleax
@boingoinghttps://github.com/boingoing
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/43
https://github.com/boingoing
boingoinghttps://github.com/boingoing
Jun 5, 2017 https://github.com/nodejs/node-addon-api/pull/43#pullrequestreview-42182601
View reviewed changes https://github.com/nodejs/node-addon-api/pull/43/files/fff49908c9267da6b7e5d254b03d3513359d648c
boingoinghttps://github.com/boingoing
https://github.com/nodejs/node-addon-api/pull/43#pullrequestreview-42182601
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/43
https://github.com/boingoing
boingoinghttps://github.com/boingoing
Jun 5, 2017 https://github.com/nodejs/node-addon-api/pull/43#pullrequestreview-42182635
View reviewed changes https://github.com/nodejs/node-addon-api/pull/43/files/fff49908c9267da6b7e5d254b03d3513359d648c
https://github.com/jasongin
jasonginhttps://github.com/jasongin
92f362ahttps://github.com/nodejs/node-addon-api/commit/92f362a9b7063c91cb56b315c2a52accceee1a63
Jun 6, 2017https://github.com/nodejs/node-addon-api/pull/43#event-1112203042
https://github.com/jasongin
jasonginhttps://github.com/jasongin
June 6, 2017 17:16https://github.com/nodejs/node-addon-api/pull/43#event-1112203189
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F43
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node-addon-api/pull/43/files/fff49908c9267da6b7e5d254b03d3513359d648c
https://github.com/boingoing
boingoing https://github.com/boingoing
https://github.com/nodejs/node-addon-api/pull/43/files/fff49908c9267da6b7e5d254b03d3513359d648c
Please reload this pagehttps://github.com/nodejs/node-addon-api/pull/43
https://github.com/jasongin
https://github.com/addaleax
https://github.com/boingoing
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.