| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8c3e73e2-c3ae-68d8-9d76-382ee82fd1b5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 80D2:2144F:57C26B:7DB2E0:6A50FDDA |
| html-safe-nonce | 45653be8c09c50343697b287666e38df209c20b89c62c42849910bdb41656571 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEQyOjIxNDRGOjU3QzI2Qjo3REIyRTA6NkE1MEZEREEiLCJ2aXNpdG9yX2lkIjoiMzYwODc0MTkwMDI0NzQzMjY2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c068f1baed2e3857e04eaa052956b8eb45dab4a565287fcdee872bf61fcd1087 |
| hovercard-subject-tag | pull_request:216308873 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-addon-api/345/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4de55c80d4a560f2630ffc7e8c2c45a219eeb952aacffd1ebedceb649ab04d50/nodejs/node-addon-api/pull/345 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4de55c80d4a560f2630ffc7e8c2c45a219eeb952aacffd1ebedceb649ab04d50/nodejs/node-addon-api/pull/345 |
| og:image:alt | Since original submit for
#292 warnings
were tightened through #315
causing the bigint test to fail to compile
Fix the compile failure |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mhdawson |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5266e58c17a510c403505cc811606465e90a881d2007ee7df1c4800d5c659838 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node-addon-api git https://github.com/nodejs/node-addon-api.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 81384578 |
| octolytics-dimension-repository_nwo | nodejs/node-addon-api |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81384578 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node-addon-api |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8d836581d020676cc0ef4a83cd2fe17e4af02c3d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node-addon-api/pull/345#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F345 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F345 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode-addon-api |
| Reload | https://github.com/nodejs/node-addon-api/pull/345 |
| Reload | https://github.com/nodejs/node-addon-api/pull/345 |
| Reload | https://github.com/nodejs/node-addon-api/pull/345 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/345 |
|
nodejs
| https://github.com/nodejs |
| node-addon-api | https://github.com/nodejs/node-addon-api |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/345 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Fork
500
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Star
2.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Code
| https://github.com/nodejs/node-addon-api |
|
Issues
10
| https://github.com/nodejs/node-addon-api/issues |
|
Pull requests
4
| https://github.com/nodejs/node-addon-api/pulls |
|
Actions
| https://github.com/nodejs/node-addon-api/actions |
|
Projects
| https://github.com/nodejs/node-addon-api/projects |
|
Wiki
| https://github.com/nodejs/node-addon-api/wiki |
|
Security and quality
0
| https://github.com/nodejs/node-addon-api/security |
|
Insights
| https://github.com/nodejs/node-addon-api/pulse |
|
Code
| https://github.com/nodejs/node-addon-api |
|
Issues
| https://github.com/nodejs/node-addon-api/issues |
|
Pull requests
| https://github.com/nodejs/node-addon-api/pulls |
|
Actions
| https://github.com/nodejs/node-addon-api/actions |
|
Projects
| https://github.com/nodejs/node-addon-api/projects |
|
Wiki
| https://github.com/nodejs/node-addon-api/wiki |
|
Security and quality
| https://github.com/nodejs/node-addon-api/security |
|
Insights
| https://github.com/nodejs/node-addon-api/pulse |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node-addon-api/tree/master |
| mhdawson:fixci | https://github.com/mhdawson/node-addon-api/tree/fixci |
| Conversation | https://github.com/nodejs/node-addon-api/pull/345 |
| Commits1 (1) | https://github.com/nodejs/node-addon-api/pull/345/commits |
| Checks | https://github.com/nodejs/node-addon-api/pull/345/checks |
| Files changed | https://github.com/nodejs/node-addon-api/pull/345/files |
| src: fix compile failure in test | https://github.com/nodejs/node-addon-api/pull/345#top |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node-addon-api/tree/master |
| mhdawson:fixci | https://github.com/mhdawson/node-addon-api/tree/fixci |
|
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 18, 2018 | https://github.com/nodejs/node-addon-api/pull/345#issue-361306198 |
| #292 | https://github.com/nodejs/node-addon-api/pull/292 |
| #315 | https://github.com/nodejs/node-addon-api/pull/315 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/345 |
|
| https://github.com/mhdawson |
| src: fix compile failure in test | https://github.com/nodejs/node-addon-api/pull/345/commits/61ffacf44bb5e7d669e531297b5cf033fa19a092 |
| 61ffacf | https://github.com/nodejs/node-addon-api/pull/345/commits/61ffacf44bb5e7d669e531297b5cf033fa19a092 |
| nodejs#292 | https://github.com/nodejs/node-addon-api/pull/292 |
| nodejs#315 | https://github.com/nodejs/node-addon-api/pull/315 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Sep 18, 2018
| https://github.com/nodejs/node-addon-api/pull/345#ref-pullrequest-336662833 |
|
bigint support
#292
| https://github.com/nodejs/node-addon-api/pull/292 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 18, 2018 | https://github.com/nodejs/node-addon-api/pull/345#issuecomment-422395305 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/345 |
| mhdawson | https://github.com/mhdawson |
|
Sep 18, 2018
| https://github.com/nodejs/node-addon-api/pull/345#ref-commit-79ee838 |
|
| https://github.com/mhdawson |
| src: fix compile failure in test | https://github.com/nodejs/node-addon-api/commit/79ee8381d2fc49b5bb7c338ceb3559b8a7e6b489 |
| 79ee838 | https://github.com/nodejs/node-addon-api/commit/79ee8381d2fc49b5bb7c338ceb3559b8a7e6b489 |
| #292 | https://github.com/nodejs/node-addon-api/pull/292 |
| #315 | https://github.com/nodejs/node-addon-api/pull/315 |
| #345 | https://github.com/nodejs/node-addon-api/pull/345 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 18, 2018 | https://github.com/nodejs/node-addon-api/pull/345#issuecomment-422396750 |
| 79ee838 | https://github.com/nodejs/node-addon-api/commit/79ee8381d2fc49b5bb7c338ceb3559b8a7e6b489 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/345 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Sep 18, 2018 | https://github.com/nodejs/node-addon-api/pull/345#event-1852414609 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Oct 19, 2018
| https://github.com/nodejs/node-addon-api/pull/345#ref-issue-371825058 |
|
Fatal error with ObjectWrap since 1.5.0
#372
| https://github.com/nodejs/node-addon-api/issues/372 |
| kevindavies8 | https://github.com/kevindavies8 |
|
Aug 24, 2022
| https://github.com/nodejs/node-addon-api/pull/345#ref-commit-7f4abc4 |
|
| https://github.com/kevindavies8 |
| src: fix compile failure in test | https://github.com/kevindavies8/node-addon-api-Develop/commit/7f4abc47a7045c0c5e7e232b2ff4762bc3b9ac7f |
| 7f4abc4 | https://github.com/kevindavies8/node-addon-api-Develop/commit/7f4abc47a7045c0c5e7e232b2ff4762bc3b9ac7f |
| nodejs/node-addon-api#292 | https://github.com/nodejs/node-addon-api/pull/292 |
| nodejs/node-addon-api#315 | https://github.com/nodejs/node-addon-api/pull/315 |
| nodejs/node-addon-api#345 | https://github.com/nodejs/node-addon-api/pull/345 |
| Marlyfleitas | https://github.com/Marlyfleitas |
|
Aug 26, 2022
| https://github.com/nodejs/node-addon-api/pull/345#ref-commit-d8058bd |
|
| https://github.com/Marlyfleitas |
| src: fix compile failure in test | https://github.com/Marlyfleitas/node-api-addon-Development/commit/d8058bd5ef99d9529bbeacdc7a3afce648f128bf |
| d8058bd | https://github.com/Marlyfleitas/node-api-addon-Development/commit/d8058bd5ef99d9529bbeacdc7a3afce648f128bf |
| nodejs/node-addon-api#292 | https://github.com/nodejs/node-addon-api/pull/292 |
| nodejs/node-addon-api#315 | https://github.com/nodejs/node-addon-api/pull/315 |
| nodejs/node-addon-api#345 | https://github.com/nodejs/node-addon-api/pull/345 |
| wroy7860 | https://github.com/wroy7860 |
|
Sep 19, 2022
| https://github.com/nodejs/node-addon-api/pull/345#ref-commit-87f86da |
|
| https://github.com/wroy7860 |
| src: fix compile failure in test | https://github.com/wroy7860/addon-api-benchmark-node/commit/87f86da63d37fdacb64eff1ba421df8f5c9cbb48 |
| 87f86da | https://github.com/wroy7860/addon-api-benchmark-node/commit/87f86da63d37fdacb64eff1ba421df8f5c9cbb48 |
| nodejs/node-addon-api#292 | https://github.com/nodejs/node-addon-api/pull/292 |
| nodejs/node-addon-api#315 | https://github.com/nodejs/node-addon-api/pull/315 |
| nodejs/node-addon-api#345 | https://github.com/nodejs/node-addon-api/pull/345 |
| johnfrench3 | https://github.com/johnfrench3 |
|
Aug 11, 2023
| https://github.com/nodejs/node-addon-api/pull/345#ref-commit-156055b |
| src: fix compile failure in test | https://github.com/johnfrench3/node-addon-api-git/commit/156055b8d15d102fa99bd20c9ab10637f4665a5d |
| 156055b | https://github.com/johnfrench3/node-addon-api-git/commit/156055b8d15d102fa99bd20c9ab10637f4665a5d |
| nodejs/node-addon-api#292 | https://github.com/nodejs/node-addon-api/pull/292 |
| nodejs/node-addon-api#315 | https://github.com/nodejs/node-addon-api/pull/315 |
| nodejs/node-addon-api#345 | https://github.com/nodejs/node-addon-api/pull/345 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node-addon-api/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F345 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/345 |
|
| https://github.com/mhdawson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |