| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:62e966d2-4a26-6572-05cf-be647a2a68ce |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8DF0:3A3FB3:DB2FF:13C4AB:6A4E63E6 |
| html-safe-nonce | 7386dd38a7067efe9669dc42da4501d2a6702991fad1cb80604ea4ad9846edcc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REYwOjNBM0ZCMzpEQjJGRjoxM0M0QUI6NkE0RTYzRTYiLCJ2aXNpdG9yX2lkIjoiMTE2ODk5NDI4NzYyNDI4MzExMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 808c36c56162a0255a676250a4dbb2f85eb4100dcbdaa73bce2f63306c44123d |
| hovercard-subject-tag | pull_request:2107333595 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-addon-api/1585/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ebbd4cc59b4675165ad7ad76195ff5806dcefd2fc3250011af2867ab08fd0413/nodejs/node-addon-api/pull/1585 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ebbd4cc59b4675165ad7ad76195ff5806dcefd2fc3250011af2867ab08fd0413/nodejs/node-addon-api/pull/1585 |
| og:image:alt | Fixes: #1584
Add GitHub Actions for node-api-headers compatibility test, covering old Node.js versions. node-api-headers strips experimental apis so only test with stable NAPI_VERSION.
As there was... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | legendecas |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node-addon-api git https://github.com/nodejs/node-addon-api.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 81384578 |
| octolytics-dimension-repository_nwo | nodejs/node-addon-api |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81384578 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node-addon-api |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node-addon-api/pull/1585#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F1585 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F1585 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode-addon-api |
| Reload | https://github.com/nodejs/node-addon-api/pull/1585 |
| Reload | https://github.com/nodejs/node-addon-api/pull/1585 |
| Reload | https://github.com/nodejs/node-addon-api/pull/1585 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
|
nodejs
| https://github.com/nodejs |
| node-addon-api | https://github.com/nodejs/node-addon-api |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Fork
500
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Star
2.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode-addon-api |
|
Code
| https://github.com/nodejs/node-addon-api |
|
Issues
10
| https://github.com/nodejs/node-addon-api/issues |
|
Pull requests
4
| https://github.com/nodejs/node-addon-api/pulls |
|
Actions
| https://github.com/nodejs/node-addon-api/actions |
|
Projects
| https://github.com/nodejs/node-addon-api/projects |
|
Wiki
| https://github.com/nodejs/node-addon-api/wiki |
|
Security and quality
0
| https://github.com/nodejs/node-addon-api/security |
|
Insights
| https://github.com/nodejs/node-addon-api/pulse |
|
Code
| https://github.com/nodejs/node-addon-api |
|
Issues
| https://github.com/nodejs/node-addon-api/issues |
|
Pull requests
| https://github.com/nodejs/node-addon-api/pulls |
|
Actions
| https://github.com/nodejs/node-addon-api/actions |
|
Projects
| https://github.com/nodejs/node-addon-api/projects |
|
Wiki
| https://github.com/nodejs/node-addon-api/wiki |
|
Security and quality
| https://github.com/nodejs/node-addon-api/security |
|
Insights
| https://github.com/nodejs/node-addon-api/pulse |
| legendecas | https://github.com/legendecas |
| nodejs:main | https://github.com/nodejs/node-addon-api/tree/main |
| legendecas:compat | https://github.com/legendecas/node-addon-api/tree/compat |
| Conversation | https://github.com/nodejs/node-addon-api/pull/1585 |
| Commits2 (2) | https://github.com/nodejs/node-addon-api/pull/1585/commits |
| Checks | https://github.com/nodejs/node-addon-api/pull/1585/checks |
| Files changed | https://github.com/nodejs/node-addon-api/pull/1585/files |
| fix: missing node_api_nogc_env definition | https://github.com/nodejs/node-addon-api/pull/1585#top |
| legendecas | https://github.com/legendecas |
| nodejs:main | https://github.com/nodejs/node-addon-api/tree/main |
| legendecas:compat | https://github.com/legendecas/node-addon-api/tree/compat |
|
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| Oct 4, 2024 | https://github.com/nodejs/node-addon-api/pull/1585#issue-2566088843 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
| #1584 | https://github.com/nodejs/node-addon-api/issues/1584 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
| https://github.com/codecov-commenter |
| codecov-commenter | https://github.com/codecov-commenter |
| Oct 4, 2024 | https://github.com/nodejs/node-addon-api/pull/1585#issuecomment-2393448730 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
| Codecov | https://app.codecov.io/gh/nodejs/node-addon-api/pull/1585?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (d8523a7) | https://app.codecov.io/gh/nodejs/node-addon-api/commit/d8523a708030a0a3abb9d7832051c70e2dafac3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (0f1f7e6) | https://app.codecov.io/gh/nodejs/node-addon-api/commit/0f1f7e699ebf81624ec9fb6a61b848fdaa6fcd12?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| ☔ View full report in Codecov by Sentry | https://app.codecov.io/gh/nodejs/node-addon-api/pull/1585?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Share it here | https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
| https://github.com/NickNaso |
| NickNaso | https://github.com/NickNaso |
|
Oct 4, 2024
| https://github.com/nodejs/node-addon-api/pull/1585#pullrequestreview-2347891363 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/1585/files |
| .github/workflows/node-api-headers.yml | https://github.com/nodejs/node-addon-api/pull/1585/files#diff-359fe4ea1c561a47ab250e9ba7c2fa935b537042065fef67d60676b1979bda7f |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
|
| https://github.com/legendecas |
| fix: node-api-headers compat | https://github.com/nodejs/node-addon-api/pull/1585/commits/8e5eb0bbac3ecf654a90fa0e44a2c12bbc3fdee9 |
| 8e5eb0b | https://github.com/nodejs/node-addon-api/pull/1585/commits/8e5eb0bbac3ecf654a90fa0e44a2c12bbc3fdee9 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| force-pushed | https://github.com/nodejs/node-addon-api/compare/b04fb6350dd4c77989a9a520533510ee92969f61..8e5eb0bbac3ecf654a90fa0e44a2c12bbc3fdee9 |
| b04fb63 | https://github.com/nodejs/node-addon-api/commit/b04fb6350dd4c77989a9a520533510ee92969f61 |
| 8e5eb0b | https://github.com/nodejs/node-addon-api/commit/8e5eb0bbac3ecf654a90fa0e44a2c12bbc3fdee9 |
|
Compare
| https://github.com/nodejs/node-addon-api/compare/b04fb6350dd4c77989a9a520533510ee92969f61..8e5eb0bbac3ecf654a90fa0e44a2c12bbc3fdee9 |
| October 4, 2024 13:24 | https://github.com/nodejs/node-addon-api/pull/1585#event-14519234704 |
| https://github.com/KevinEady |
| KevinEady | https://github.com/KevinEady |
|
Oct 4, 2024
| https://github.com/nodejs/node-addon-api/pull/1585#pullrequestreview-2348381785 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/1585/files/8e5eb0bbac3ecf654a90fa0e44a2c12bbc3fdee9 |
| napi.h | https://github.com/nodejs/node-addon-api/pull/1585/files/8e5eb0bbac3ecf654a90fa0e44a2c12bbc3fdee9#diff-6294f8ee1d8cd7e4e94cfc22a083380fb80058e34f53100d895b9b3b295dd801 |
| KevinEady | https://github.com/KevinEady |
| Oct 4, 2024 | https://github.com/nodejs/node-addon-api/pull/1585#discussion_r1787906281 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
| legendecas | https://github.com/legendecas |
| Oct 8, 2024 | https://github.com/nodejs/node-addon-api/pull/1585#discussion_r1791146635 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
|
| https://github.com/legendecas |
| fixup! | https://github.com/nodejs/node-addon-api/pull/1585/commits/0f1f7e699ebf81624ec9fb6a61b848fdaa6fcd12 |
| 0f1f7e6 | https://github.com/nodejs/node-addon-api/pull/1585/commits/0f1f7e699ebf81624ec9fb6a61b848fdaa6fcd12 |
| https://github.com/NickNaso |
| NickNaso | https://github.com/NickNaso |
|
Oct 8, 2024
| https://github.com/nodejs/node-addon-api/pull/1585#pullrequestreview-2353939831 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/1585/files/0f1f7e699ebf81624ec9fb6a61b848fdaa6fcd12 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Oct 8, 2024
| https://github.com/nodejs/node-addon-api/pull/1585#ref-issue-2557111232 |
|
Upgrading from v8.1.0 to v8.2.0 breaks compilation
#1584
| https://github.com/nodejs/node-addon-api/issues/1584 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Oct 8, 2024
| https://github.com/nodejs/node-addon-api/pull/1585#pullrequestreview-2354911271 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/1585/files/0f1f7e699ebf81624ec9fb6a61b848fdaa6fcd12 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node-addon-api/pull/1585#pullrequestreview-2354911271 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
| https://github.com/KevinEady |
| KevinEady | https://github.com/KevinEady |
|
Oct 8, 2024
| https://github.com/nodejs/node-addon-api/pull/1585#pullrequestreview-2355314875 |
|
View reviewed changes
| https://github.com/nodejs/node-addon-api/pull/1585/files/0f1f7e699ebf81624ec9fb6a61b848fdaa6fcd12 |
| KevinEady | https://github.com/KevinEady |
| https://github.com/nodejs/node-addon-api/pull/1585#pullrequestreview-2355314875 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| 6ba3891 | https://github.com/nodejs/node-addon-api/commit/6ba3891954d8b56215d133e54a86cb621e476b9e |
| Oct 8, 2024 | https://github.com/nodejs/node-addon-api/pull/1585#event-14563865041 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| October 8, 2024 23:20 | https://github.com/nodejs/node-addon-api/pull/1585#event-14563865279 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Oct 8, 2024
| https://github.com/nodejs/node-addon-api/pull/1585#ref-pullrequest-2574398539 |
|
chore: release v8.2.1
#1589
| https://github.com/nodejs/node-addon-api/pull/1589 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Oct 15, 2024
| https://github.com/nodejs/node-addon-api/pull/1585#ref-issue-2566077709 |
|
Experimental node_api_nogc_env is not stripped
nodejs/node-api-headers#51
| https://github.com/nodejs/node-api-headers/issues/51 |
| https://github.com/apps/snyk-io |
| snyk-io | https://github.com/apps/snyk-io |
|
Nov 10, 2024
| https://github.com/nodejs/node-addon-api/pull/1585#ref-pullrequest-2646789774 |
|
[Snyk] Upgrade node-addon-api from 3.2.1 to 8.2.1
doperiddle/bch-rpc-explorer#9
| https://github.com/doperiddle/bch-rpc-explorer/pull/9 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node-addon-api/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode-addon-api%2Fpull%2F1585 |
|
| https://github.com/NickNaso |
|
NickNaso
| https://github.com/NickNaso |
|
| https://github.com/nodejs/node-addon-api/pull/1585/files/0f1f7e699ebf81624ec9fb6a61b848fdaa6fcd12 |
|
| https://github.com/KevinEady |
|
KevinEady
| https://github.com/KevinEady |
|
| https://github.com/nodejs/node-addon-api/pull/1585/files/0f1f7e699ebf81624ec9fb6a61b848fdaa6fcd12 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node-addon-api/pull/1585/files/0f1f7e699ebf81624ec9fb6a61b848fdaa6fcd12 |
|
Node-API Team Project
| https://github.com/orgs/nodejs/projects/11 |
|
Upgrading from v8.1.0 to v8.2.0 breaks compilation
| https://github.com/nodejs/node-addon-api/issues/1584 |
| Please reload this page | https://github.com/nodejs/node-addon-api/pull/1585 |
|
| https://github.com/legendecas |
|
| https://github.com/codecov-commenter |
|
| https://github.com/NickNaso |
|
| https://github.com/KevinEady |
|
| https://github.com/mhdawson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |