René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"GC Crash With ObjectWrap + Exceptions","articleBody":"I am seeing crashes in the V8 GC when I have ObjectWraps that throw in subclass constructors. Example:\r\n\r\n`class MyObject : public ObjectWrap\u003cMyObject\u003e {\r\n  MyObject(const CallbackInfo\u0026 info) : ObjectWrap\u003cMyObject\u003e(info) {\r\n    throw Error::New(info.Env(), \"something exceptional happened!\");\r\n  }\r\n}`\r\n\r\nThe ObjectWrap constructor will create a napi_ref for the object, associate this pointer and register a finalizer. If the subclass throws, the C++ runtime invalidates the this pointer. However, the pointer is still registered with the napi_ref. When the GC gets to the object, the finalizer tries to delete the invalid this and the system may crash.","author":{"url":"https://github.com/dananderson","@type":"Person","name":"dananderson"},"datePublished":"2019-11-12T20:43:07.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/599/node-addon-api/issues/599"}