Title: fix: add missing const to ObjectReference::Set string parameter by umuoy1 · Pull Request #1713 · nodejs/node-addon-api · GitHub
Open Graph Title: fix: add missing const to ObjectReference::Set string parameter by umuoy1 · Pull Request #1713 · nodejs/node-addon-api
X Title: fix: add missing const to ObjectReference::Set string parameter by umuoy1 · Pull Request #1713 · nodejs/node-addon-api
Description: Module for using Node-API from C++. Contribute to nodejs/node-addon-api development by creating an account on GitHub.
Open Graph Description: The ObjectReference::Set(const std::string&, std::string&) overload was missing a const qualifier on the value parameter, making it inconsistent with other Set overloads. This prevented pas...
X Description: The ObjectReference::Set(const std::string&, std::string&) overload was missing a const qualifier on the value parameter, making it inconsistent with other Set overloads. This preve...
Opengraph URL: https://github.com/nodejs/node-addon-api/pull/1713
X: @github
Domain: github.com
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0d788c80-56be-c256-1b95-282db395e8c1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 94D8:3092B8:A140F0:A4C6AE:6A4DB2ED |
| html-safe-nonce | 22f77b66646694a3c8be96ba15a2d60ac11501544a63ce0a1a654e9774176a25 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEQ4OjMwOTJCODpBMTQwRjA6QTRDNkFFOjZBNERCMkVEIiwidmlzaXRvcl9pZCI6IjY4NDM1MTg5MjE3NzkwMzI4MTMiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ== |
| visitor-hmac | e3ef72362ed2b47d524eb3e0501b4b09d775a4d1e23994307c685bf79ff4b316 |
| hovercard-subject-tag | pull_request:3349678349 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node-addon-api/1713/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ab019e149c52694f96c055f3e9ea94cf7d5143974359afcfe011f1cf84ead8a7/nodejs/node-addon-api/pull/1713 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ab019e149c52694f96c055f3e9ea94cf7d5143974359afcfe011f1cf84ead8a7/nodejs/node-addon-api/pull/1713 |
| og:image:alt | The ObjectReference::Set(const std::string&, std::string&) overload was missing a const qualifier on the value parameter, making it inconsistent with other Set overloads. This prevented pas... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | umuoy1 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node-addon-api git https://github.com/nodejs/node-addon-api.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 81384578 |
| octolytics-dimension-repository_nwo | nodejs/node-addon-api |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81384578 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node-addon-api |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 32f7b614aca06e6bbd89842b1370df1328264f68 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width