| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0363e3ad-18c6-33cc-3d27-b628458e9fe4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D3B4:C2480:18DAE4:22A662:696A6418 |
| html-safe-nonce | 153a669f7b6e68ffc32c3e0ce879280dc22b228b1ef4e6dfd19bdbf3fcce4b9c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0I0OkMyNDgwOjE4REFFNDoyMkE2NjI6Njk2QTY0MTgiLCJ2aXNpdG9yX2lkIjoiODIzNDkxODMyNTMwNDk0NDg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1b65a6bb6bec227b90e6b4e3b86350b977fbd0c332296bee6a28fa6ea039eb35 |
| hovercard-subject-tag | pull_request:96132793 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9995/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/cb074fe82a2e4746d86ef877d4e535fe04b274f5e1af628b09acae0c2d4f5b5c/nodejs/node/pull/9995 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cb074fe82a2e4746d86ef877d4e535fe04b274f5e1af628b09acae0c2d4f5b5c/nodejs/node/pull/9995 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines
Affected core subsystem(s)
test
Description of change
addressed nits |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kmccmk9 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9995#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9995 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9995 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9995 |
| Reload | https://github.com/nodejs/node/pull/9995 |
| Reload | https://github.com/nodejs/node/pull/9995 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9995 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9995 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9995#issue-comment-box |
| kmccmk9 | https://github.com/kmccmk9 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Test net keepalive
| https://github.com/nodejs/node/pull/9995#top |
| kmccmk9 | https://github.com/kmccmk9 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
4
| https://github.com/nodejs/node/pull/9995 |
|
Commits
2
| https://github.com/nodejs/node/pull/9995/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9995/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9995/files |
| Please reload this page | https://github.com/nodejs/node/pull/9995 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/kmccmk9 |
| kmccmk9 | https://github.com/kmccmk9 |
| Dec 1, 2016 | https://github.com/nodejs/node/pull/9995#issue-192909462 |
| Please reload this page | https://github.com/nodejs/node/pull/9995 |
| kmccmk9 | https://github.com/kmccmk9 |
| December 1, 2016 11:57 | https://github.com/nodejs/node/pull/9995#commits-pushed-0c55efd |
|
| https://github.com/kmccmk9 |
| test: add mustCall to setTimeout | https://github.com/nodejs/node/pull/9995/commits/0c55efdd3b0bd418bce11a1637629b502e6f6d0e |
| 0c55efd | https://github.com/nodejs/node/pull/9995/commits/0c55efdd3b0bd418bce11a1637629b502e6f6d0e |
|
| https://github.com/kmccmk9 |
| addresses nits | https://github.com/nodejs/node/pull/9995/commits/7b09ff31e22a4cca63034c6f1502281c188ec5d8 |
| 7b09ff3 | https://github.com/nodejs/node/pull/9995/commits/7b09ff31e22a4cca63034c6f1502281c188ec5d8 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Dec 1, 2016 | https://github.com/nodejs/node/pull/9995#event-878814153 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Dec 1, 2016 | https://github.com/nodejs/node/pull/9995#event-878814348 |
| https://github.com/imyller |
| imyller | https://github.com/imyller |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Dec 1, 2016 | https://github.com/nodejs/node/pull/9995#event-878814425 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Dec 1, 2016 | https://github.com/nodejs/node/pull/9995#event-878814555 |
| https://github.com/kmccmk9 |
| kmccmk9 | https://github.com/kmccmk9 |
|
Dec 1, 2016
| https://github.com/nodejs/node/pull/9995#ref-pullrequest-192906688 |
|
test: add mustCall to setTimeout
#9984
| https://github.com/nodejs/node/pull/9984 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 1, 2016 | https://github.com/nodejs/node/pull/9995#issuecomment-264280826 |
| @kmccmk9 | https://github.com/kmccmk9 |
| Please reload this page | https://github.com/nodejs/node/pull/9995 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 5, 2016
| https://github.com/nodejs/node/pull/9995#pullrequestreview-11473780 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9995/files/7b09ff31e22a4cca63034c6f1502281c188ec5d8 |
| test/parallel/test-net-keepalive.js | https://github.com/nodejs/node/pull/9995/files/7b09ff31e22a4cca63034c6f1502281c188ec5d8#diff-53121f5f5c714596cd1385c2936ce5e117d0f7c34c0dc20716f7b722b0a3e444 |
| jasnell | https://github.com/jasnell |
| Dec 5, 2016 | https://github.com/nodejs/node/pull/9995#discussion_r90960310 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9995 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 5, 2016
| https://github.com/nodejs/node/pull/9995#pullrequestreview-11473799 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9995/files/7b09ff31e22a4cca63034c6f1502281c188ec5d8 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Dec 8, 2016
| https://github.com/nodejs/node/pull/9995#pullrequestreview-11928385 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9995/files/7b09ff31e22a4cca63034c6f1502281c188ec5d8 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Dec 8, 2016 | https://github.com/nodejs/node/pull/9995#issuecomment-265658516 |
| https://ci.nodejs.org/job/node-test-pull-request/5305/ | https://ci.nodejs.org/job/node-test-pull-request/5305/ |
| Please reload this page | https://github.com/nodejs/node/pull/9995 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 8, 2016 | https://github.com/nodejs/node/pull/9995#issuecomment-265757378 |
| 6967ed4 | https://github.com/nodejs/node/commit/6967ed45acad1e421f50df426c2454031701267a |
| Please reload this page | https://github.com/nodejs/node/pull/9995 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 8, 2016 | https://github.com/nodejs/node/pull/9995#event-886952247 |
| cjihrig | https://github.com/cjihrig |
|
Dec 8, 2016
| https://github.com/nodejs/node/pull/9995#ref-commit-6967ed4 |
|
| https://github.com/kmccmk9 |
|
| https://github.com/cjihrig |
| test: refactor test-net-keepalive.js | https://github.com/nodejs/node/commit/6967ed45acad1e421f50df426c2454031701267a |
| 6967ed4 | https://github.com/nodejs/node/commit/6967ed45acad1e421f50df426c2454031701267a |
| #9995 | https://github.com/nodejs/node/pull/9995 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Dec 13, 2016
| https://github.com/nodejs/node/pull/9995#ref-commit-ca38f70 |
|
| https://github.com/kmccmk9 |
|
| https://github.com/Fishrock123 |
| test: refactor test-net-keepalive.js | https://github.com/nodejs/node/commit/ca38f70dea6ea29a9c03ee42342a7eeddfe19445 |
| ca38f70 | https://github.com/nodejs/node/commit/ca38f70dea6ea29a9c03ee42342a7eeddfe19445 |
| #9995 | https://github.com/nodejs/node/pull/9995 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Dec 15, 2016
| https://github.com/nodejs/node/pull/9995#ref-pullrequest-195698085 |
|
v7.3.0 proposal
#10277
| https://github.com/nodejs/node/pull/10277 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Jan 16, 2017 | https://github.com/nodejs/node/pull/9995#event-924540920 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 16, 2017
| https://github.com/nodejs/node/pull/9995#ref-commit-a12fae8 |
|
| https://github.com/kmccmk9 |
|
| https://github.com/MylesBorins |
| test: refactor test-net-keepalive.js | https://github.com/nodejs/node/commit/a12fae81191142030152d0294ea05400a51c20d7 |
| a12fae8 | https://github.com/nodejs/node/commit/a12fae81191142030152d0294ea05400a51c20d7 |
| #9995 | https://github.com/nodejs/node/pull/9995 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 16, 2017
| https://github.com/nodejs/node/pull/9995#ref-commit-6b66647 |
|
| https://github.com/kmccmk9 |
|
| https://github.com/MylesBorins |
| test: refactor test-net-keepalive.js | https://github.com/nodejs/node/commit/6b6664780550d8edd1e4b62ebdf7a0e46f50dc96 |
| 6b66647 | https://github.com/nodejs/node/commit/6b6664780550d8edd1e4b62ebdf7a0e46f50dc96 |
| #9995 | https://github.com/nodejs/node/pull/9995 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/9995#ref-commit-29e7de9 |
|
| https://github.com/kmccmk9 |
|
| https://github.com/MylesBorins |
| test: refactor test-net-keepalive.js | https://github.com/nodejs/node/commit/29e7de96eb6370193419d1ccb49824a1589cc0a7 |
| 29e7de9 | https://github.com/nodejs/node/commit/29e7de96eb6370193419d1ccb49824a1589cc0a7 |
| #9995 | https://github.com/nodejs/node/pull/9995 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/9995#ref-commit-6df13ce |
|
| https://github.com/kmccmk9 |
|
| https://github.com/MylesBorins |
| test: refactor test-net-keepalive.js | https://github.com/nodejs/node/commit/6df13ce96df68bcfd69431f1edfd7480bcd6822e |
| 6df13ce | https://github.com/nodejs/node/commit/6df13ce96df68bcfd69431f1edfd7480bcd6822e |
| #9995 | https://github.com/nodejs/node/pull/9995 |
|
v4.8.0 proposal
#10973
| https://github.com/nodejs/node/pull/10973 |
|
v6.10.0 proposal
#10974
| https://github.com/nodejs/node/pull/10974 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 31, 2017
| https://github.com/nodejs/node/pull/9995#ref-commit-58c5bdc |
|
| https://github.com/kmccmk9 |
|
| https://github.com/MylesBorins |
| test: refactor test-net-keepalive.js | https://github.com/nodejs/node/commit/58c5bdc57ca44d8b116bb254f16c025859886ff7 |
| 58c5bdc | https://github.com/nodejs/node/commit/58c5bdc57ca44d8b116bb254f16c025859886ff7 |
| #9995 | https://github.com/nodejs/node/pull/9995 |
| MylesBorins | https://github.com/MylesBorins |
|
Feb 1, 2017
| https://github.com/nodejs/node/pull/9995#ref-commit-4f5f0e4 |
|
| https://github.com/kmccmk9 |
|
| https://github.com/MylesBorins |
| test: refactor test-net-keepalive.js | https://github.com/nodejs/node/commit/4f5f0e4975ee4f867c518778a7232cb17561b19b |
| 4f5f0e4 | https://github.com/nodejs/node/commit/4f5f0e4975ee4f867c518778a7232cb17561b19b |
| #9995 | https://github.com/nodejs/node/pull/9995 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9995 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/9995/files/7b09ff31e22a4cca63034c6f1502281c188ec5d8 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/9995/files/7b09ff31e22a4cca63034c6f1502281c188ec5d8 |
|
code-and-learn
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acode-and-learn |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/9995 |
|
| https://github.com/kmccmk9 |
|
| https://github.com/MylesBorins |
|
| https://github.com/Trott |
|
| https://github.com/cjihrig |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/mscdex |
|
| https://github.com/imyller |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |