| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6f013f8b-b559-271f-0e6d-4a0289ebda91 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B7AE:367397:28070E:38D40B:696A06F8 |
| html-safe-nonce | 7fef089d99e05f7e2ea8bdb2992f39e26da5dee6ae067e21cb06057a828a9d8b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0FFOjM2NzM5NzoyODA3MEU6MzhENDBCOjY5NkEwNkY4IiwidmlzaXRvcl9pZCI6IjM4ODI5NDgwMDk4NjY2OTIzNDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | aadd139ce569c63255713426015ea5927a096b4235649fc9f0eedb9f535e0054 |
| hovercard-subject-tag | pull_request:95671507 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/9837/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6143894b2f9960e3707ec36279b4d6a6898d99f0906877e1c91d7d3400bac453/nodejs/node/pull/9837 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6143894b2f9960e3707ec36279b4d6a6898d99f0906877e1c91d7d3400bac453/nodejs/node/pull/9837 |
| og:image:alt | Checklist
make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines
Affected core subsystem(s)
buffer
Descript... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/9837#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9837 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9837 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/9837 |
| Reload | https://github.com/nodejs/node/pull/9837 |
| Reload | https://github.com/nodejs/node/pull/9837 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/9837#issue-comment-box |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:buffer-fix-single-byte-fill | https://github.com/addaleax/node/tree/buffer-fix-single-byte-fill |
|
buffer: fix single-character string filling
| https://github.com/nodejs/node/pull/9837#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:buffer-fix-single-byte-fill | https://github.com/addaleax/node/tree/buffer-fix-single-byte-fill |
|
Conversation
22
| https://github.com/nodejs/node/pull/9837 |
|
Commits
2
| https://github.com/nodejs/node/pull/9837/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/9837/checks |
|
Files changed
| https://github.com/nodejs/node/pull/9837/files |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 29, 2016 | https://github.com/nodejs/node/pull/9837#issue-192253327 |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| #9836 | https://github.com/nodejs/node/issues/9836 |
| https://ci.nodejs.org/job/node-test-commit/6222/ | https://ci.nodejs.org/job/node-test-commit/6222/ |
| https://ci.nodejs.org/job/node-test-commit/6224/ | https://ci.nodejs.org/job/node-test-commit/6224/ |
| https://ci.nodejs.org/job/node-test-commit/6600/ | https://ci.nodejs.org/job/node-test-commit/6600/ |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
| Nov 29, 2016 | https://github.com/nodejs/node/pull/9837#event-875061227 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Nov 29, 2016 | https://github.com/nodejs/node/pull/9837#event-875061447 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Nov 29, 2016
| https://github.com/nodejs/node/pull/9837#pullrequestreview-10515467 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9837/files |
| lib/buffer.js | https://github.com/nodejs/node/pull/9837/files#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630 |
| bnoordhuis | https://github.com/bnoordhuis |
| Nov 29, 2016 | https://github.com/nodejs/node/pull/9837#discussion_r89990633 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| addaleax | https://github.com/addaleax |
| Nov 29, 2016 | https://github.com/nodejs/node/pull/9837#discussion_r89991488 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/0690d5f0b4e28eda46171d64ad298c640059f445..641cfa2be3c5462c14e7d6d211e42d1efa79e0f3 |
| 0690d5f | https://github.com/nodejs/node/commit/0690d5f0b4e28eda46171d64ad298c640059f445 |
| 641cfa2 | https://github.com/nodejs/node/commit/641cfa2be3c5462c14e7d6d211e42d1efa79e0f3 |
|
Compare
| https://github.com/nodejs/node/compare/0690d5f0b4e28eda46171d64ad298c640059f445..641cfa2be3c5462c14e7d6d211e42d1efa79e0f3 |
| November 29, 2016 11:31 | https://github.com/nodejs/node/pull/9837#event-875083369 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Nov 29, 2016 | https://github.com/nodejs/node/pull/9837#issuecomment-263549839 |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/c7c27c99b34fe9840b57755793c799cc594d48be..63e0a5e522c3b79fb2f2cb605fc8e1cd7a353c6f |
| c7c27c9 | https://github.com/nodejs/node/commit/c7c27c99b34fe9840b57755793c799cc594d48be |
| 63e0a5e | https://github.com/nodejs/node/commit/63e0a5e522c3b79fb2f2cb605fc8e1cd7a353c6f |
|
Compare
| https://github.com/nodejs/node/compare/c7c27c99b34fe9840b57755793c799cc594d48be..63e0a5e522c3b79fb2f2cb605fc8e1cd7a353c6f |
| November 29, 2016 13:14 | https://github.com/nodejs/node/pull/9837#event-875201397 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Nov 29, 2016 | https://github.com/nodejs/node/pull/9837#issuecomment-263567647 |
| example ci run | https://ci.nodejs.org/job/node-test-commit-linuxone/2334/nodes=rhel72-s390x/console |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/fb755ba302a881aa1e690d94f9a028c59639a94f..6790a6f712eb84a5ebabbd679623f68b8f30e3d7 |
| fb755ba | https://github.com/nodejs/node/commit/fb755ba302a881aa1e690d94f9a028c59639a94f |
| 6790a6f | https://github.com/nodejs/node/commit/6790a6f712eb84a5ebabbd679623f68b8f30e3d7 |
|
Compare
| https://github.com/nodejs/node/compare/fb755ba302a881aa1e690d94f9a028c59639a94f..6790a6f712eb84a5ebabbd679623f68b8f30e3d7 |
| December 6, 2016 02:28 | https://github.com/nodejs/node/pull/9837#event-883042226 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 6, 2016 | https://github.com/nodejs/node/pull/9837#issuecomment-265045337 |
| https://ci.nodejs.org/job/node-test-commit/6451/ | https://ci.nodejs.org/job/node-test-commit/6451/ |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
|
Dec 6, 2016
| https://github.com/nodejs/node/pull/9837#pullrequestreview-11525019 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9837/files |
| trevnorris | https://github.com/trevnorris |
| https://github.com/nodejs/node/pull/9837#pullrequestreview-11525019 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| lib/buffer.js | https://github.com/nodejs/node/pull/9837/files#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630 |
| trevnorris | https://github.com/trevnorris |
| Dec 6, 2016 | https://github.com/nodejs/node/pull/9837#discussion_r91014128 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| addaleax | https://github.com/addaleax |
| Dec 6, 2016 | https://github.com/nodejs/node/pull/9837#discussion_r91068709 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| trevnorris | https://github.com/trevnorris |
| Dec 9, 2016 | https://github.com/nodejs/node/pull/9837#discussion_r91808474 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| src/node_buffer.cc | https://github.com/nodejs/node/pull/9837/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b |
| trevnorris | https://github.com/trevnorris |
| Dec 6, 2016 | https://github.com/nodejs/node/pull/9837#discussion_r91014159 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| addaleax | https://github.com/addaleax |
| Dec 6, 2016 | https://github.com/nodejs/node/pull/9837#discussion_r91068871 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Dec 6, 2016
| https://github.com/nodejs/node/pull/9837#pullrequestreview-11578239 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9837/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/9837#pullrequestreview-11578239 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://ci.nodejs.org/job/node-test-commit/6469/ | https://ci.nodejs.org/job/node-test-commit/6469/ |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| lib/buffer.js | https://github.com/nodejs/node/pull/9837/files#diff-3c2cd5c512dd026a7765b6b2ae3f85785d3b7ea3795e11949892b7b73beee630 |
| addaleax | https://github.com/addaleax |
| Dec 6, 2016 | https://github.com/nodejs/node/pull/9837#discussion_r91068709 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| src/node_buffer.cc | https://github.com/nodejs/node/pull/9837/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b |
| addaleax | https://github.com/addaleax |
| Dec 6, 2016 | https://github.com/nodejs/node/pull/9837#discussion_r91068871 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Dec 6, 2016
| https://github.com/nodejs/node/pull/9837#pullrequestreview-11635121 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9837/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/9837#pullrequestreview-11635121 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Dec 9, 2016 | https://github.com/nodejs/node/pull/9837#issuecomment-266141376 |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 11, 2016 | https://github.com/nodejs/node/pull/9837#issuecomment-266313620 |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Dec 11, 2016
| https://github.com/nodejs/node/pull/9837#pullrequestreview-12378345 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/9837/files |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/9837#pullrequestreview-12378345 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| test/parallel/test-buffer-fill.js | https://github.com/nodejs/node/pull/9837/files#diff-0cde8c435c6e93186699b49b8fa4df620f6d6159e5f6d8c4b20d42088cb483a9 |
| bnoordhuis | https://github.com/bnoordhuis |
| Dec 11, 2016 | https://github.com/nodejs/node/pull/9837#discussion_r91869073 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| addaleax | https://github.com/addaleax |
| Dec 12, 2016 | https://github.com/nodejs/node/pull/9837#discussion_r91957263 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| addaleax | https://github.com/addaleax |
| December 12, 2016 15:33 | https://github.com/nodejs/node/pull/9837#commits-pushed-cea2194 |
|
| https://github.com/addaleax |
| buffer: handle UCS2 .fill() properly on BE | https://github.com/nodejs/node/pull/9837/commits/cea2194528058009a49fb664af00746eb22ed60c |
| cea2194 | https://github.com/nodejs/node/pull/9837/commits/cea2194528058009a49fb664af00746eb22ed60c |
|
| https://github.com/addaleax |
| buffer: fix single-character string filling | https://github.com/nodejs/node/pull/9837/commits/b0a80b70488b03f258f58e4577ba0488dd240f30 |
| b0a80b7 | https://github.com/nodejs/node/pull/9837/commits/b0a80b70488b03f258f58e4577ba0488dd240f30 |
| nodejs#9836 | https://github.com/nodejs/node/issues/9836 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/6790a6f712eb84a5ebabbd679623f68b8f30e3d7..b0a80b70488b03f258f58e4577ba0488dd240f30 |
| 6790a6f | https://github.com/nodejs/node/commit/6790a6f712eb84a5ebabbd679623f68b8f30e3d7 |
| b0a80b7 | https://github.com/nodejs/node/commit/b0a80b70488b03f258f58e4577ba0488dd240f30 |
|
Compare
| https://github.com/nodejs/node/compare/6790a6f712eb84a5ebabbd679623f68b8f30e3d7..b0a80b70488b03f258f58e4577ba0488dd240f30 |
| December 12, 2016 14:33 | https://github.com/nodejs/node/pull/9837#event-890436283 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 12, 2016 | https://github.com/nodejs/node/pull/9837#issuecomment-266445590 |
| https://ci.nodejs.org/job/node-test-commit/6600/ | https://ci.nodejs.org/job/node-test-commit/6600/ |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 12, 2016 | https://github.com/nodejs/node/pull/9837#issuecomment-266468620 |
| 9ee915b | https://github.com/nodejs/node/commit/9ee915be76f9e4cc8bc43020a721a03257f9b984 |
| d4f00fe | https://github.com/nodejs/node/commit/d4f00fe1098b0d7b8444565e741d8b457fd9c091 |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Dec 12, 2016 | https://github.com/nodejs/node/pull/9837#event-890572235 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| December 12, 2016 15:59 | https://github.com/nodejs/node/pull/9837#event-890572459 |
| addaleax | https://github.com/addaleax |
|
Dec 12, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-9ee915b |
|
| https://github.com/addaleax |
| buffer: handle UCS2 .fill() properly on BE | https://github.com/nodejs/node/commit/9ee915be76f9e4cc8bc43020a721a03257f9b984 |
| 9ee915b | https://github.com/nodejs/node/commit/9ee915be76f9e4cc8bc43020a721a03257f9b984 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| addaleax | https://github.com/addaleax |
|
Dec 12, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-d4f00fe |
|
| https://github.com/addaleax |
| buffer: fix single-character string filling | https://github.com/nodejs/node/commit/d4f00fe1098b0d7b8444565e741d8b457fd9c091 |
| d4f00fe | https://github.com/nodejs/node/commit/d4f00fe1098b0d7b8444565e741d8b457fd9c091 |
| #9836 | https://github.com/nodejs/node/issues/9836 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Dec 13, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-d8b6723 |
|
| https://github.com/addaleax |
|
| https://github.com/Fishrock123 |
| buffer: handle UCS2 .fill() properly on BE | https://github.com/nodejs/node/commit/d8b67230964c0fbdc13796d6bdae47eb1ca4d489 |
| d8b6723 | https://github.com/nodejs/node/commit/d8b67230964c0fbdc13796d6bdae47eb1ca4d489 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Dec 13, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-b99a372 |
|
| https://github.com/addaleax |
|
| https://github.com/Fishrock123 |
| buffer: fix single-character string filling | https://github.com/nodejs/node/commit/b99a372e911efefa9a092b694b3db936cdc9e432 |
| b99a372 | https://github.com/nodejs/node/commit/b99a372e911efefa9a092b694b3db936cdc9e432 |
| #9836 | https://github.com/nodejs/node/issues/9836 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| https://github.com/italoacasas |
| italoacasas | https://github.com/italoacasas |
|
Dec 15, 2016
| https://github.com/nodejs/node/pull/9837#ref-pullrequest-195698085 |
|
v7.3.0 proposal
#10277
| https://github.com/nodejs/node/pull/10277 |
| italoacasas | https://github.com/italoacasas |
|
Dec 15, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-38ecfe0 |
| 2016-12-20, Version 7.3.0 (Current) | https://github.com/nodejs/node/commit/38ecfe01f02466a535439180e821f38acf0ad449 |
| 38ecfe0 | https://github.com/nodejs/node/commit/38ecfe01f02466a535439180e821f38acf0ad449 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| #10021 | https://github.com/nodejs/node/pull/10021 |
| #9484 | https://github.com/nodejs/node/pull/9484 |
| #9440 | https://github.com/nodejs/node/pull/9440 |
| #10153 | https://github.com/nodejs/node/pull/10153 |
| #10277 | https://github.com/nodejs/node/pull/10277 |
| italoacasas | https://github.com/italoacasas |
|
Dec 15, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-617dbf7 |
| 2016-12-20, Version 7.3.0 (Current) | https://github.com/nodejs/node/commit/617dbf75c00498c4372a8367310a338b9cb09c81 |
| 617dbf7 | https://github.com/nodejs/node/commit/617dbf75c00498c4372a8367310a338b9cb09c81 |
| #10039 | https://github.com/nodejs/node/pull/10039 |
| #9139 | https://github.com/nodejs/node/pull/9139 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| #10021 | https://github.com/nodejs/node/pull/10021 |
| #9484 | https://github.com/nodejs/node/pull/9484 |
| #9440 | https://github.com/nodejs/node/pull/9440 |
| #10153 | https://github.com/nodejs/node/pull/10153 |
| #10041 | https://github.com/nodejs/node/pull/10041 |
| #9759 | https://github.com/nodejs/node/pull/9759 |
| #10277 | https://github.com/nodejs/node/pull/10277 |
| italoacasas | https://github.com/italoacasas |
|
Dec 17, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-0afa836 |
| 2016-12-20, Version 7.3.0 (Current) | https://github.com/nodejs/node/commit/0afa836dd3a1b94557f865602ada39428d71b500 |
| 0afa836 | https://github.com/nodejs/node/commit/0afa836dd3a1b94557f865602ada39428d71b500 |
| #9139 | https://github.com/nodejs/node/pull/9139 |
| #9139 | https://github.com/nodejs/node/pull/9139 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| #10039 | https://github.com/nodejs/node/pull/10039 |
| #10039 | https://github.com/nodejs/node/pull/10039 |
| #10021 | https://github.com/nodejs/node/pull/10021 |
| #10021 | https://github.com/nodejs/node/pull/10021 |
| #9484 | https://github.com/nodejs/node/pull/9484 |
| #9484 | https://github.com/nodejs/node/pull/9484 |
| #9440 | https://github.com/nodejs/node/pull/9440 |
| #9440 | https://github.com/nodejs/node/pull/9440 |
| #10153 | https://github.com/nodejs/node/pull/10153 |
| #10153 | https://github.com/nodejs/node/pull/10153 |
| #10041 | https://github.com/nodejs/node/pull/10041 |
| #10041 | https://github.com/nodejs/node/pull/10041 |
| #9759 | https://github.com/nodejs/node/pull/9759 |
| #9759 | https://github.com/nodejs/node/pull/9759 |
| #9139 | https://github.com/nodejs/node/pull/9139 |
| #9139 | https://github.com/nodejs/node/pull/9139 |
| #10082 | https://github.com/nodejs/node/pull/10082 |
| #10082 | https://github.com/nodejs/node/pull/10082 |
| italoacasas | https://github.com/italoacasas |
|
Dec 19, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-e46e078 |
| 2016-12-20, Version 7.3.0 (Current) | https://github.com/nodejs/node/commit/e46e0783d235e32cffd25984de87c31474c53cae |
| e46e078 | https://github.com/nodejs/node/commit/e46e0783d235e32cffd25984de87c31474c53cae |
| #9139 | https://github.com/nodejs/node/pull/9139 |
| #9139 | https://github.com/nodejs/node/pull/9139 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| #10021 | https://github.com/nodejs/node/pull/10021 |
| #10021 | https://github.com/nodejs/node/pull/10021 |
| #9484 | https://github.com/nodejs/node/pull/9484 |
| #9484 | https://github.com/nodejs/node/pull/9484 |
| #9440 | https://github.com/nodejs/node/pull/9440 |
| #9440 | https://github.com/nodejs/node/pull/9440 |
| cjihrig | https://github.com/cjihrig |
|
Dec 20, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-24a3d0e |
|
| https://github.com/cjihrig |
| 2016-12-20, Version 7.3.0 (Current) | https://github.com/cjihrig/node/commit/24a3d0e71b46bdf79041eb71e46662c891ab7694 |
| 24a3d0e | https://github.com/cjihrig/node/commit/24a3d0e71b46bdf79041eb71e46662c891ab7694 |
| nodejs#9837 | https://github.com/nodejs/node/pull/9837 |
| nodejs#10019 | https://github.com/nodejs/node/pull/10019 |
| nodejs#9139 | https://github.com/nodejs/node/pull/9139 |
| nodejs#9440 | https://github.com/nodejs/node/pull/9440 |
| nodejs#10294 | https://github.com/nodejs/node/pull/10294 |
| nodejs#10021 | https://github.com/nodejs/node/pull/10021 |
| nodejs#9484 | https://github.com/nodejs/node/pull/9484 |
| nodejs#10277 | https://github.com/nodejs/node/pull/10277 |
| cjihrig | https://github.com/cjihrig |
|
Dec 20, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-ffd01da |
|
| https://github.com/cjihrig |
| 2016-12-20, Version 7.3.0 (Current) | https://github.com/cjihrig/node/commit/ffd01da0f298f982071f0442f3b54e34f14bea74 |
| ffd01da | https://github.com/cjihrig/node/commit/ffd01da0f298f982071f0442f3b54e34f14bea74 |
| nodejs#9837 | https://github.com/nodejs/node/pull/9837 |
| nodejs#10019 | https://github.com/nodejs/node/pull/10019 |
| nodejs#9139 | https://github.com/nodejs/node/pull/9139 |
| nodejs#9440 | https://github.com/nodejs/node/pull/9440 |
| nodejs#10294 | https://github.com/nodejs/node/pull/10294 |
| nodejs#10021 | https://github.com/nodejs/node/pull/10021 |
| nodejs#9484 | https://github.com/nodejs/node/pull/9484 |
| nodejs#10277 | https://github.com/nodejs/node/pull/10277 |
| cjihrig | https://github.com/cjihrig |
|
Dec 20, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-728b61f |
|
| https://github.com/cjihrig |
| 2016-12-20, Version 7.3.0 (Current) | https://github.com/nodejs/node/commit/728b61f5bb9c14493ac0638ecdb5de528d92677f |
| 728b61f | https://github.com/nodejs/node/commit/728b61f5bb9c14493ac0638ecdb5de528d92677f |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| #10019 | https://github.com/nodejs/node/pull/10019 |
| #9139 | https://github.com/nodejs/node/pull/9139 |
| #9440 | https://github.com/nodejs/node/pull/9440 |
| #10294 | https://github.com/nodejs/node/pull/10294 |
| #10021 | https://github.com/nodejs/node/pull/10021 |
| #9484 | https://github.com/nodejs/node/pull/9484 |
| #10277 | https://github.com/nodejs/node/pull/10277 |
| imyller | https://github.com/imyller |
|
Dec 21, 2016
| https://github.com/nodejs/node/pull/9837#ref-commit-dc0cd98 |
|
| https://github.com/imyller |
| 2016-12-20, Version 7.3.0 (Current) | https://github.com/imyller/meta-nodejs/commit/dc0cd98198b52c73ffe7c184f68d81c953b77290 |
| dc0cd98 | https://github.com/imyller/meta-nodejs/commit/dc0cd98198b52c73ffe7c184f68d81c953b77290 |
| nodejs/node#9837 | https://github.com/nodejs/node/pull/9837 |
| nodejs/node#10019 | https://github.com/nodejs/node/pull/10019 |
| nodejs/node#9139 | https://github.com/nodejs/node/pull/9139 |
| nodejs/node#9440 | https://github.com/nodejs/node/pull/9440 |
| nodejs/node#10294 | https://github.com/nodejs/node/pull/10294 |
| nodejs/node#10021 | https://github.com/nodejs/node/pull/10021 |
| nodejs/node#9484 | https://github.com/nodejs/node/pull/9484 |
| nodejs/node#10277 | https://github.com/nodejs/node/pull/10277 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v6.x |
|
lts-watch-v6.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v6.x |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/9837#event-932213378 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jan 23, 2017 | https://github.com/nodejs/node/pull/9837#issuecomment-274381210 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/9837#ref-commit-d20c875 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| buffer: handle UCS2 .fill() properly on BE | https://github.com/nodejs/node/commit/d20c875dd647a9742b5693b69203e5c8e0833877 |
| d20c875 | https://github.com/nodejs/node/commit/d20c875dd647a9742b5693b69203e5c8e0833877 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 23, 2017
| https://github.com/nodejs/node/pull/9837#ref-commit-e76a7e0 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| buffer: fix single-character string filling | https://github.com/nodejs/node/commit/e76a7e04556f3ac6d28b36106e1a3474d694b8bc |
| e76a7e0 | https://github.com/nodejs/node/commit/e76a7e04556f3ac6d28b36106e1a3474d694b8bc |
| #9836 | https://github.com/nodejs/node/issues/9836 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/9837#ref-commit-60d5f6b |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| buffer: handle UCS2 .fill() properly on BE | https://github.com/nodejs/node/commit/60d5f6b64f15a1232e34be59a3a6823b0862985b |
| 60d5f6b | https://github.com/nodejs/node/commit/60d5f6b64f15a1232e34be59a3a6823b0862985b |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/9837#ref-commit-9eaa721 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| buffer: fix single-character string filling | https://github.com/nodejs/node/commit/9eaa721fb18d13cdb5e22ffcc03624e78f92671e |
| 9eaa721 | https://github.com/nodejs/node/commit/9eaa721fb18d13cdb5e22ffcc03624e78f92671e |
| #9836 | https://github.com/nodejs/node/issues/9836 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 24, 2017
| https://github.com/nodejs/node/pull/9837#ref-pullrequest-202753839 |
|
v6.10.0 proposal
#10974
| https://github.com/nodejs/node/pull/10974 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 26, 2017 | https://github.com/nodejs/node/pull/9837#issuecomment-275525651 |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jan 26, 2017 | https://github.com/nodejs/node/pull/9837#event-938508008 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 31, 2017
| https://github.com/nodejs/node/pull/9837#ref-commit-03f0d2a |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| buffer: handle UCS2 .fill() properly on BE | https://github.com/nodejs/node/commit/03f0d2ac21b169a7dfcd16b3dcc51f173e16ddf5 |
| 03f0d2a | https://github.com/nodejs/node/commit/03f0d2ac21b169a7dfcd16b3dcc51f173e16ddf5 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 31, 2017
| https://github.com/nodejs/node/pull/9837#ref-commit-40c7ec6 |
|
| https://github.com/addaleax |
|
| https://github.com/MylesBorins |
| buffer: fix single-character string filling | https://github.com/nodejs/node/commit/40c7ec62e01f7ebbeafbe5d94af6462afacbaab0 |
| 40c7ec6 | https://github.com/nodejs/node/commit/40c7ec62e01f7ebbeafbe5d94af6462afacbaab0 |
| #9836 | https://github.com/nodejs/node/issues/9836 |
| #9837 | https://github.com/nodejs/node/pull/9837 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F9837 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/9837/files/6790a6f712eb84a5ebabbd679623f68b8f30e3d7 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/9837/files/6790a6f712eb84a5ebabbd679623f68b8f30e3d7 |
|
| https://github.com/trevnorris |
|
trevnorris
| https://github.com/trevnorris |
|
| https://github.com/nodejs/node/pull/9837/files/6790a6f712eb84a5ebabbd679623f68b8f30e3d7 |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
[buffer] fill() for utf16le is broken
| https://github.com/nodejs/node/issues/9836 |
| Please reload this page | https://github.com/nodejs/node/pull/9837 |
|
| https://github.com/addaleax |
|
| https://github.com/bnoordhuis |
|
| https://github.com/trevnorris |
|
| https://github.com/MylesBorins |
|
| https://github.com/jasnell |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |